From ef21c830370f89f4f51b3bdfb6c5f6071eefde9b Mon Sep 17 00:00:00 2001
From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Sun, 21 Jun 2020 16:33:18 -0400
Subject: [PATCH] [twitter] Fix return value of twitter_user_to_contact()

- Simplify check in twitter_fetch_own_contact()
---
 twitter/twitter.php | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/twitter/twitter.php b/twitter/twitter.php
index ff773c0a..15ad9b57 100644
--- a/twitter/twitter.php
+++ b/twitter/twitter.php
@@ -1079,10 +1079,14 @@ function twitter_get_relation($uid, $target, $contact = [])
 	return $relation;
 }
 
+/**
+ * @param $data
+ * @return array
+ */
 function twitter_user_to_contact($data)
 {
 	if (empty($data->id_str)) {
-		return -1;
+		return [];
 	}
 
 	$baseurl = 'https://twitter.com';
@@ -1924,7 +1928,7 @@ function twitter_fetch_own_contact(App $a, $uid)
 		// Fetching user data
 		// get() may throw TwitterOAuthException, but we will catch it later
 		$user = $connection->get('account/verify_credentials');
-		if (empty($user) || empty($user->id_str)) {
+		if (empty($user->id_str)) {
 			return false;
 		}