[Suggestion] Move New User Tip Link (#5342)

* Move new member tips to navigation bar.

The link looks so forlorn when its just somewhere in there. Put it in the nav bar.

* Style new member hints link propery.

* Make changes requested by @MrPetovan.

mod/profile.php

@@ -191,10 +191,6 @@ function profile_content(App $a, $update = 0)
 
 		$o .= Widget::commonFriendsVisitor($a->profile['profile_uid']);
 
-		if (x($_SESSION, 'new_member') && $is_owner) {
-			$o .= '<div id="newmember-tips"><a href="newmember"><b>' . L10n::t('Tips for New Members') . '</b></a></div>';
-		}
-
 		$commpage = $a->profile['page-flags'] == PAGE_COMMUNITY;
 		$commvisitor = $commpage && $remote_contact;
 

src/Model/Profile.php

@@ -947,6 +947,16 @@ class Profile
 			];
 		}
 
+		if (!empty($_SESSION['new_member']) && $is_owner) {
+			$tabs[] = [
+				'label' => L10n::t('Tips for New Members'),
+				'url'   => System::baseUrl() . '/newmember',
+				'sel'   => false,
+				'title' => L10n::t('Tips for New Members'),
+				'id'    => 'newmember-tab',
+			];
+		}
+
 		if (!$is_owner && empty($a->profile['hide-friends'])) {
 			$tabs[] = [
 				'label' => L10n::t('Contacts'),

view/global.css

@@ -207,10 +207,8 @@ blockquote.shared_content {
 }
 
 #newmember-tips {
+  margin-top: -3px;
   font-size: 1.2em;
-  float: right;
-  margin-top: -32px;
-  padding-right: 10px;
 }
 
 /* headers */

view/theme/frio/css/style.css

@@ -972,6 +972,10 @@ nav.navbar a, nav.navbar .btn-link {
     padding: 2px 10px;
 }
 
+#newmember-tab > a {
+  font-size: 1.2em;
+  font-weight: 800;
+}
 
 /*
  * Aside

view/theme/vier/style.css

@@ -2340,6 +2340,11 @@ ul.tabs li .active, span.pager_current a {
   text-decoration: none;
 }
 
+#newmember-tab > a {
+  font-size: 1.2em;
+  font-weight: 800;
+}
+
 /**
  * Form fields
  */