Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2024-11-10 13:02:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Only add user contacts, alternate way to fetch public contact id

Browse source
This commit is contained in:
Michael 2021-09-11 12:43:46 +00:00
parent 5113987031
commit 10cb52bc00
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/Model/Contact/User.php
View file

@ -45,7 +45,12 @@ class User
*/ */
public static function insertForContactArray(array $contact) public static function insertForContactArray(array $contact)
{ {
if (!isset($contact['uid']) || (empty($contact['uri-id']) && empty($contact['url']))) { if (empty($contact['uid'])) {
// We don't create entries for the public user - by now
return false;
}
if (empty($contact['uri-id']) && empty($contact['url'])) {
Logger::info('Missing contact details', ['contact' => $contact, 'callstack' => System::callstack(20)]); Logger::info('Missing contact details', ['contact' => $contact, 'callstack' => System::callstack(20)]);
return false; return false;
} }
@ -55,7 +60,9 @@ class User
} }
$pcontact = Contact::selectFirst(['id'], ['uri-id' => $contact['uri-id'], 'uid' => 0]); $pcontact = Contact::selectFirst(['id'], ['uri-id' => $contact['uri-id'], 'uid' => 0]);
if (!DBA::isResult($pcontact)) { if (!empty($contact['uri-id']) && DBA::isResult($pcontact)) {
$pcid = $pcontact['id'];
} elseif (empty($contact['url']) || !($pcid = Contact::getIdForURL($contact['url']))) {
Logger::info('Public contact for user not found', ['uri-id' => $contact['uri-id'], 'uid' => $contact['uid']]); Logger::info('Public contact for user not found', ['uri-id' => $contact['uri-id'], 'uid' => $contact['uid']]);
return false; return false;
} }
@ -67,13 +74,13 @@ class User
} }
$fields = DBStructure::getFieldsForTable('user-contact', $fields); $fields = DBStructure::getFieldsForTable('user-contact', $fields);
$fields['cid'] = $pcontact['id']; $fields['cid'] = $pcid;
$fields['uid'] = $contact['uid']; $fields['uid'] = $contact['uid'];
$fields['uri-id'] = $contact['uri-id']; $fields['uri-id'] = $contact['uri-id'];
$ret = DBA::insert('user-contact', $fields, Database::INSERT_IGNORE); $ret = DBA::insert('user-contact', $fields, Database::INSERT_UPDATE);
Logger::info('Inserted user contact', ['uid' => $contact['uid'], 'cid' => $pcontact['id'], 'uri-id' => $contact['uri-id'], 'ret' => $ret]); Logger::info('Inserted user contact', ['uid' => $contact['uid'], 'cid' => $pcid, 'uri-id' => $contact['uri-id'], 'ret' => $ret]);
return $ret; return $ret;
} }
@ -103,7 +110,7 @@ class User
if (!empty($update_fields)) { if (!empty($update_fields)) {
$contacts = DBA::select('contact', ['uri-id', 'uid'], $condition); $contacts = DBA::select('contact', ['uri-id', 'uid'], $condition);
while ($row = DBA::fetch($contacts)) { while ($row = DBA::fetch($contacts)) {
if (empty($row['uri-id'])) { if (empty($row['uri-id']) || empty($contact['uid'])) {
continue; continue;
} }
$ret = DBA::update('user-contact', $update_fields, ['uri-id' => $row['uri-id'], 'uid' => $row['uid']]); $ret = DBA::update('user-contact', $update_fields, ['uri-id' => $row['uri-id'], 'uid' => $row['uid']]);