mirror of
https://github.com/friendica/friendica
synced 2024-11-10 02:22:55 +00:00
Ensure Post::toArray returns an array
- We don't handle query errors anyway - Remove unused parameter do_close - Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314245581
This commit is contained in:
parent
0eaa2eae84
commit
10e48a34f2
1 changed files with 8 additions and 9 deletions
|
@ -102,26 +102,25 @@ class Post
|
|||
}
|
||||
|
||||
/**
|
||||
* Fills an array with data from an post query
|
||||
* Fills an array with data from a post query
|
||||
*
|
||||
* @param object $stmt statement object
|
||||
* @param bool $do_close
|
||||
* @param object|bool $stmt Return value from Database->select
|
||||
* @return array Data array
|
||||
* @todo Find proper type-hint for $stmt and maybe avoid boolean
|
||||
* @throws \Exception
|
||||
*/
|
||||
public static function toArray($stmt, bool $do_close = true)
|
||||
public static function toArray($stmt): array
|
||||
{
|
||||
if (is_bool($stmt)) {
|
||||
return $stmt;
|
||||
return [];
|
||||
}
|
||||
|
||||
$data = [];
|
||||
while ($row = self::fetch($stmt)) {
|
||||
$data[] = $row;
|
||||
}
|
||||
if ($do_close) {
|
||||
|
||||
DBA::close($stmt);
|
||||
}
|
||||
|
||||
return $data;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue