Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2024-11-19 02:23:41 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #8005 from MrPetovan/bug/7992-empty-in-clause

Browse source 
Add support for empty values array in Database\DBA
This commit is contained in:
Michael Vogel 2019-12-25 09:34:01 +01:00 committed by GitHub
commit 221746bff3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/Database/DBA.php
View file

@ -543,6 +543,7 @@ class DBA extends BaseObject
$condition_string .= " AND ";
}
if (is_array($value)) {
if (count($value)) {
/* Workaround for MySQL Bug #64791.
* Never mix data types inside any IN() condition.
* In case of mixed types, cast all as string.
@ -570,6 +571,10 @@ class DBA extends BaseObject
$new_values = array_merge($new_values, array_values($value));
$placeholders = substr(str_repeat("?, ", count($value)), 0, -2);
$condition_string .= self::quoteIdentifier($field) . " IN (" . $placeholders . ")";
} else {
// Empty value array isn't supported by IN and is logically equivalent to no match
$condition_string .= "FALSE";
}
} elseif (is_null($value)) {
$condition_string .= self::quoteIdentifier($field) . " IS NULL";
} else {