mirror of
https://github.com/friendica/friendica
synced 2025-04-25 23:50:11 +00:00
Merge remote-tracking branch 'upstream/develop' into blocked-server
This commit is contained in:
commit
259fe7fcf2
30 changed files with 530 additions and 391 deletions
|
@ -357,8 +357,6 @@ class App
|
|||
$this->profiler->reset();
|
||||
|
||||
if ($this->mode->has(App\Mode::DBAVAILABLE)) {
|
||||
$this->profiler->update($this->config);
|
||||
|
||||
Core\Hook::loadHooks();
|
||||
$loader = (new Config())->createConfigFileManager($this->getBasePath(), $_SERVER);
|
||||
Core\Hook::callAll('load_config', $loader);
|
||||
|
|
|
@ -22,9 +22,8 @@
|
|||
namespace Friendica\App;
|
||||
|
||||
use Detection\MobileDetect;
|
||||
use Friendica\Core\Config\ValueObject\Cache;
|
||||
use Friendica\Core\Config\Capability\IManageConfigValues;
|
||||
use Friendica\Database\Database;
|
||||
use Friendica\Util\BasePath;
|
||||
|
||||
/**
|
||||
* Mode of the current Friendica Node
|
||||
|
@ -129,15 +128,13 @@ class Mode
|
|||
*
|
||||
* @throws \Exception
|
||||
*/
|
||||
public function determine(BasePath $basepath, Database $database, Cache $configCache): Mode
|
||||
public function determine(string $basePath, Database $database, IManageConfigValues $config): Mode
|
||||
{
|
||||
$mode = 0;
|
||||
|
||||
$basepathName = $basepath->getPath();
|
||||
|
||||
if (!file_exists($basepathName . '/config/local.config.php')
|
||||
&& !file_exists($basepathName . '/config/local.ini.php')
|
||||
&& !file_exists($basepathName . '/.htconfig.php')) {
|
||||
if (!file_exists($basePath . '/config/local.config.php') &&
|
||||
!file_exists($basePath . '/config/local.ini.php') &&
|
||||
!file_exists($basePath . '/.htconfig.php')) {
|
||||
return new Mode($mode);
|
||||
}
|
||||
|
||||
|
@ -149,7 +146,7 @@ class Mode
|
|||
|
||||
$mode |= Mode::DBAVAILABLE;
|
||||
|
||||
if (!empty($configCache->get('system', 'maintenance'))) {
|
||||
if (!empty($config->get('system', 'maintenance'))) {
|
||||
return new Mode($mode);
|
||||
}
|
||||
|
||||
|
|
|
@ -21,7 +21,7 @@
|
|||
|
||||
namespace Friendica\Console;
|
||||
|
||||
use Friendica\Core\Config\ValueObject\Cache;
|
||||
use Friendica\Core\Config\Capability\IManageConfigValues;
|
||||
use Friendica\Core\Update;
|
||||
use Friendica\Database\Database;
|
||||
use Friendica\Database\DBStructure;
|
||||
|
@ -43,8 +43,8 @@ class DatabaseStructure extends \Asika\SimpleConsole\Console
|
|||
/** @var Database */
|
||||
private $dba;
|
||||
|
||||
/** @var Cache */
|
||||
private $configCache;
|
||||
/** @var IManageConfigValues */
|
||||
private $config;
|
||||
|
||||
/** @var DbaDefinition */
|
||||
private $dbaDefinition;
|
||||
|
@ -83,14 +83,14 @@ HELP;
|
|||
return $help;
|
||||
}
|
||||
|
||||
public function __construct(Database $dba, DbaDefinition $dbaDefinition, ViewDefinition $viewDefinition, BasePath $basePath, Cache $configCache, $argv = null)
|
||||
public function __construct(Database $dba, DbaDefinition $dbaDefinition, ViewDefinition $viewDefinition, BasePath $basePath, IManageConfigValues $config, $argv = null)
|
||||
{
|
||||
parent::__construct($argv);
|
||||
|
||||
$this->dba = $dba;
|
||||
$this->dbaDefinition = $dbaDefinition;
|
||||
$this->viewDefinition = $viewDefinition;
|
||||
$this->configCache = $configCache;
|
||||
$this->config = $config;
|
||||
$this->basePath = $basePath->getPath();
|
||||
}
|
||||
|
||||
|
@ -117,7 +117,7 @@ HELP;
|
|||
throw new RuntimeException('Unable to connect to database');
|
||||
}
|
||||
|
||||
$basePath = $this->configCache->get('system', 'basepath');
|
||||
$basePath = $this->config->get('system', 'basepath');
|
||||
|
||||
switch ($this->getArgument(0)) {
|
||||
case "dryrun":
|
||||
|
|
|
@ -26,67 +26,201 @@ namespace Friendica\Core\Config\Util;
|
|||
*/
|
||||
class ConfigFileTransformer
|
||||
{
|
||||
/**
|
||||
* This method takes an array of config values and applies some standard rules for formatting on it
|
||||
*
|
||||
* Beware that the applied rules follow some basic formatting principles for node.config.php
|
||||
* and doesn't support any custom formatting rules.
|
||||
*
|
||||
* f.e. associative array and list formatting are very complex with newlines and indentations, thus there are
|
||||
* three hardcoded types of formatting for them.
|
||||
*
|
||||
* a negative example, what's NOT working:
|
||||
* key => [ value1, [inner_value1, inner_value2], value2]
|
||||
* Since this isn't necessary for config values, there's no further logic handling such complex-list-in-list scenarios
|
||||
*
|
||||
* @param array $data A full config array
|
||||
*
|
||||
* @return string The config stream, which can be saved
|
||||
*/
|
||||
public static function encode(array $data): string
|
||||
{
|
||||
// Add the typical header values
|
||||
$dataString = '<?php' . PHP_EOL . PHP_EOL;
|
||||
$dataString .= 'return [' . PHP_EOL;
|
||||
$dataString .= 'return ';
|
||||
|
||||
$categories = array_keys($data);
|
||||
$dataString .= static::extractArray($data);
|
||||
|
||||
foreach ($categories as $category) {
|
||||
if (is_null($data[$category])) {
|
||||
$dataString .= "\t'$category' => null," . PHP_EOL;
|
||||
continue;
|
||||
}
|
||||
|
||||
$dataString .= "\t'$category' => [" . PHP_EOL;
|
||||
|
||||
if (is_array($data[$category])) {
|
||||
$keys = array_keys($data[$category]);
|
||||
|
||||
foreach ($keys as $key) {
|
||||
$dataString .= static::mapConfigValue($key, $data[$category][$key]);
|
||||
}
|
||||
}
|
||||
$dataString .= "\t]," . PHP_EOL;
|
||||
}
|
||||
|
||||
$dataString .= "];" . PHP_EOL;
|
||||
// the last array line, close it with a semicolon
|
||||
$dataString .= ";" . PHP_EOL;
|
||||
|
||||
return $dataString;
|
||||
}
|
||||
|
||||
protected static function extractArray(array $config, int $level = 0): string
|
||||
/**
|
||||
* Extracts an inner config array.
|
||||
* Either as an associative array or as a list
|
||||
*
|
||||
* @param array $config The config array which should get extracted
|
||||
* @param int $level The current level of recursion (necessary for tab-indentation calculation)
|
||||
* @param bool $inList If true, the current array resides inside another list. Different rules may be applicable
|
||||
*
|
||||
* @return string The config string
|
||||
*/
|
||||
protected static function extractArray(array $config, int $level = 0, bool $inList = false): string
|
||||
{
|
||||
if (array_values($config) === $config) {
|
||||
return self::extractList($config, $level, $inList);
|
||||
} else {
|
||||
return self::extractAssociativeArray($config, $level, $inList);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Extracts a key-value array and save it into a string
|
||||
* output:
|
||||
* [
|
||||
* 'key' => value,
|
||||
* 'key' => value,
|
||||
* ...
|
||||
* ]
|
||||
*
|
||||
* @param array $config The associative/key-value array
|
||||
* @param int $level The current level of recursion (necessary for tab-indentation calculation)
|
||||
* @param bool $inList If true, the current array resides inside another list. Different rules may be applicable
|
||||
*
|
||||
* @return string The config string
|
||||
*/
|
||||
protected static function extractAssociativeArray(array $config, int $level = 0, bool $inList = false): string
|
||||
{
|
||||
$string = '';
|
||||
|
||||
foreach ($config as $configKey => $configValue) {
|
||||
$string .= static::mapConfigValue($configKey, $configValue, $level);
|
||||
// Because we're in a list, we have to add a line-break first
|
||||
if ($inList) {
|
||||
$string .= PHP_EOL . str_repeat("\t", $level);
|
||||
}
|
||||
|
||||
// Add a typical Line break for a taxative list of key-value pairs
|
||||
$string .= '[' . PHP_EOL;
|
||||
|
||||
foreach ($config as $configKey => $configValue) {
|
||||
$string .= str_repeat("\t", $level + 1) .
|
||||
"'$configKey' => " .
|
||||
static::transformConfigValue($configValue, $level) .
|
||||
',' . PHP_EOL;
|
||||
}
|
||||
|
||||
$string .= str_repeat("\t", $level) . ']';
|
||||
|
||||
return $string;
|
||||
}
|
||||
|
||||
protected static function mapConfigValue(string $key, $value, $level = 0): string
|
||||
/**
|
||||
* Extracts a list and save it into a string
|
||||
* output1 - simple:
|
||||
* [ value, value, value ]
|
||||
*
|
||||
* output2 - complex:
|
||||
* [
|
||||
* [ value, value, value ],
|
||||
* value,
|
||||
* [
|
||||
* key => value,
|
||||
* key => value,
|
||||
* ],
|
||||
* ]
|
||||
*
|
||||
* @param array $config The list
|
||||
* @param int $level The current level of recursion (necessary for tab-indentation calculation)
|
||||
* @param bool $inList If true, the current array resides inside another list. Different rules may be applicable
|
||||
*
|
||||
* @return string The config string
|
||||
*/
|
||||
protected static function extractList(array $config, int $level = 0, bool $inList = false): string
|
||||
{
|
||||
$string = str_repeat("\t", $level + 2) . "'$key' => ";
|
||||
$string = '[';
|
||||
|
||||
if (is_null($value)) {
|
||||
$string .= "null,";
|
||||
} elseif (is_array($value)) {
|
||||
$string .= "[" . PHP_EOL;
|
||||
$string .= static::extractArray($value, ++$level);
|
||||
$string .= str_repeat("\t", $level + 1) . '],';
|
||||
} elseif (is_bool($value)) {
|
||||
$string .= ($value ? 'true' : 'false') . ",";
|
||||
} elseif (is_numeric($value)) {
|
||||
$string .= $value . ",";
|
||||
} else {
|
||||
$string .= sprintf('\'%s\',', addcslashes($value, '\'\\'));
|
||||
$countConfigValues = count($config);
|
||||
// multiline defines, if each entry uses a new line
|
||||
$multiline = false;
|
||||
|
||||
// Search if any value is an array, because then other formatting rules are applicable
|
||||
foreach ($config as $item) {
|
||||
if (is_array($item)) {
|
||||
$multiline = true;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
$string .= PHP_EOL;
|
||||
for ($i = 0; $i < $countConfigValues; $i++) {
|
||||
$isArray = is_array($config[$i]);
|
||||
|
||||
/**
|
||||
* In case this is an array in an array, directly extract this array again and continue
|
||||
* Skip any other logic since this isn't applicable for an array in an array
|
||||
*/
|
||||
if ($isArray) {
|
||||
$string .= PHP_EOL . str_repeat("\t", $level + 1);
|
||||
$string .= static::extractArray($config[$i], $level + 1, $inList) . ',';
|
||||
continue;
|
||||
}
|
||||
|
||||
if ($multiline) {
|
||||
$string .= PHP_EOL . str_repeat("\t", $level + 1);
|
||||
}
|
||||
|
||||
$string .= static::transformConfigValue($config[$i], $level, true);
|
||||
|
||||
// add trailing commas or whitespaces for certain config entries
|
||||
if (($i < ($countConfigValues - 1))) {
|
||||
$string .= ',';
|
||||
if (!$multiline) {
|
||||
$string .= ' ';
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Add a new line for the last bracket as well
|
||||
if ($multiline) {
|
||||
$string .= PHP_EOL . str_repeat("\t", $level);
|
||||
}
|
||||
|
||||
$string .= ']';
|
||||
|
||||
return $string;
|
||||
}
|
||||
|
||||
/**
|
||||
* Transforms one config value and returns the corresponding text-representation
|
||||
*
|
||||
* @param mixed $value Any value to transform
|
||||
* @param int $level The current level of recursion (necessary for tab-indentation calculation)
|
||||
* @param bool $inList If true, the current array resides inside another list. Different rules may be applicable
|
||||
*
|
||||
* @return string
|
||||
*/
|
||||
protected static function transformConfigValue($value, int $level = 0, bool $inList = false): string
|
||||
{
|
||||
switch (gettype($value)) {
|
||||
case "boolean":
|
||||
return ($value ? 'true' : 'false');
|
||||
case "integer":
|
||||
case "double":
|
||||
return $value;
|
||||
case "string":
|
||||
return sprintf('\'%s\'', addcslashes($value, '\'\\'));
|
||||
case "array":
|
||||
return static::extractArray($value, ++$level, $inList);
|
||||
case "NULL":
|
||||
return "null";
|
||||
case "object":
|
||||
case "resource":
|
||||
case "resource (closed)":
|
||||
throw new \InvalidArgumentException(sprintf('%s in configs are not supported yet.', gettype($value)));
|
||||
case "unknown type":
|
||||
throw new \InvalidArgumentException(sprintf('%s is an unknown value', $value));
|
||||
default:
|
||||
throw new \InvalidArgumentException(sprintf('%s is currently unsupported', $value));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
@ -21,7 +21,7 @@
|
|||
|
||||
namespace Friendica\Core\PConfig\Factory;
|
||||
|
||||
use Friendica\Core\Config\ValueObject\Cache;
|
||||
use Friendica\Core\Config\Capability\IManageConfigValues;
|
||||
use Friendica\Core\PConfig\Capability\IManagePersonalConfigValues;
|
||||
use Friendica\Core\PConfig\Repository;
|
||||
use Friendica\Core\PConfig\Type;
|
||||
|
@ -30,15 +30,15 @@ use Friendica\Core\PConfig\ValueObject;
|
|||
class PConfig
|
||||
{
|
||||
/**
|
||||
* @param Cache $configCache The config cache
|
||||
* @param ValueObject\Cache $pConfigCache The personal config cache
|
||||
* @param Repository\PConfig $configRepo The configuration model
|
||||
* @param IManageConfigValues $config The config
|
||||
* @param ValueObject\Cache $pConfigCache The personal config cache
|
||||
* @param Repository\PConfig $configRepo The configuration model
|
||||
*
|
||||
* @return IManagePersonalConfigValues
|
||||
*/
|
||||
public function create(Cache $configCache, ValueObject\Cache $pConfigCache, Repository\PConfig $configRepo): IManagePersonalConfigValues
|
||||
public function create(IManageConfigValues $config, ValueObject\Cache $pConfigCache, Repository\PConfig $configRepo): IManagePersonalConfigValues
|
||||
{
|
||||
if ($configCache->get('system', 'config_adapter') === 'preload') {
|
||||
if ($config->get('system', 'config_adapter') === 'preload') {
|
||||
$configuration = new Type\PreloadPConfig($pConfigCache, $configRepo);
|
||||
} else {
|
||||
$configuration = new Type\JitPConfig($pConfigCache, $configRepo);
|
||||
|
|
|
@ -21,7 +21,7 @@
|
|||
|
||||
namespace Friendica\Database;
|
||||
|
||||
use Friendica\Core\Config\ValueObject\Cache;
|
||||
use Friendica\Core\Config\Capability\IManageConfigValues;
|
||||
use Friendica\Core\System;
|
||||
use Friendica\Database\Definition\DbaDefinition;
|
||||
use Friendica\Database\Definition\ViewDefinition;
|
||||
|
@ -53,9 +53,9 @@ class Database
|
|||
protected $connected = false;
|
||||
|
||||
/**
|
||||
* @var \Friendica\Core\Config\ValueObject\Cache
|
||||
* @var IManageConfigValues
|
||||
*/
|
||||
protected $configCache;
|
||||
protected $config;
|
||||
/**
|
||||
* @var Profiler
|
||||
*/
|
||||
|
@ -81,11 +81,11 @@ class Database
|
|||
/** @var ViewDefinition */
|
||||
protected $viewDefinition;
|
||||
|
||||
public function __construct(Cache $configCache, Profiler $profiler, DbaDefinition $dbaDefinition, ViewDefinition $viewDefinition)
|
||||
public function __construct(IManageConfigValues $config, Profiler $profiler, DbaDefinition $dbaDefinition, ViewDefinition $viewDefinition)
|
||||
{
|
||||
// We are storing these values for being able to perform a reconnect
|
||||
$this->configCache = $configCache;
|
||||
$this->profiler = $profiler;
|
||||
$this->config = $config;
|
||||
$this->profiler = $profiler;
|
||||
$this->dbaDefinition = $dbaDefinition;
|
||||
$this->viewDefinition = $viewDefinition;
|
||||
|
||||
|
@ -110,32 +110,32 @@ class Database
|
|||
$this->connected = false;
|
||||
|
||||
$port = 0;
|
||||
$serveraddr = trim($this->configCache->get('database', 'hostname') ?? '');
|
||||
$serveraddr = trim($this->config->get('database', 'hostname') ?? '');
|
||||
$serverdata = explode(':', $serveraddr);
|
||||
$host = trim($serverdata[0]);
|
||||
if (count($serverdata) > 1) {
|
||||
$port = trim($serverdata[1]);
|
||||
}
|
||||
|
||||
if (trim($this->configCache->get('database', 'port') ?? 0)) {
|
||||
$port = trim($this->configCache->get('database', 'port') ?? 0);
|
||||
if (trim($this->config->get('database', 'port') ?? 0)) {
|
||||
$port = trim($this->config->get('database', 'port') ?? 0);
|
||||
}
|
||||
|
||||
$user = trim($this->configCache->get('database', 'username'));
|
||||
$pass = trim($this->configCache->get('database', 'password'));
|
||||
$database = trim($this->configCache->get('database', 'database'));
|
||||
$charset = trim($this->configCache->get('database', 'charset'));
|
||||
$socket = trim($this->configCache->get('database', 'socket'));
|
||||
$user = trim($this->config->get('database', 'username'));
|
||||
$pass = trim($this->config->get('database', 'password'));
|
||||
$database = trim($this->config->get('database', 'database'));
|
||||
$charset = trim($this->config->get('database', 'charset'));
|
||||
$socket = trim($this->config->get('database', 'socket'));
|
||||
|
||||
if (!$host && !$socket || !$user) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$persistent = (bool)$this->configCache->get('database', 'persistent');
|
||||
$persistent = (bool)$this->config->get('database', 'persistent');
|
||||
|
||||
$this->pdo_emulate_prepares = (bool)$this->configCache->get('database', 'pdo_emulate_prepares');
|
||||
$this->pdo_emulate_prepares = (bool)$this->config->get('database', 'pdo_emulate_prepares');
|
||||
|
||||
if (!$this->configCache->get('database', 'disable_pdo') && class_exists('\PDO') && in_array('mysql', PDO::getAvailableDrivers())) {
|
||||
if (!$this->config->get('database', 'disable_pdo') && class_exists('\PDO') && in_array('mysql', PDO::getAvailableDrivers())) {
|
||||
$this->driver = self::PDO;
|
||||
if ($socket) {
|
||||
$connect = 'mysql:unix_socket=' . $socket;
|
||||
|
@ -317,7 +317,7 @@ class Database
|
|||
private function logIndex(string $query)
|
||||
{
|
||||
|
||||
if (!$this->configCache->get('system', 'db_log_index')) {
|
||||
if (!$this->config->get('system', 'db_log_index')) {
|
||||
return;
|
||||
}
|
||||
|
||||
|
@ -336,18 +336,18 @@ class Database
|
|||
return;
|
||||
}
|
||||
|
||||
$watchlist = explode(',', $this->configCache->get('system', 'db_log_index_watch'));
|
||||
$denylist = explode(',', $this->configCache->get('system', 'db_log_index_denylist'));
|
||||
$watchlist = explode(',', $this->config->get('system', 'db_log_index_watch'));
|
||||
$denylist = explode(',', $this->config->get('system', 'db_log_index_denylist'));
|
||||
|
||||
while ($row = $this->fetch($r)) {
|
||||
if ((intval($this->configCache->get('system', 'db_loglimit_index')) > 0)) {
|
||||
if ((intval($this->config->get('system', 'db_loglimit_index')) > 0)) {
|
||||
$log = (in_array($row['key'], $watchlist) &&
|
||||
($row['rows'] >= intval($this->configCache->get('system', 'db_loglimit_index'))));
|
||||
($row['rows'] >= intval($this->config->get('system', 'db_loglimit_index'))));
|
||||
} else {
|
||||
$log = false;
|
||||
}
|
||||
|
||||
if ((intval($this->configCache->get('system', 'db_loglimit_index_high')) > 0) && ($row['rows'] >= intval($this->configCache->get('system', 'db_loglimit_index_high')))) {
|
||||
if ((intval($this->config->get('system', 'db_loglimit_index_high')) > 0) && ($row['rows'] >= intval($this->config->get('system', 'db_loglimit_index_high')))) {
|
||||
$log = true;
|
||||
}
|
||||
|
||||
|
@ -358,7 +358,7 @@ class Database
|
|||
if ($log) {
|
||||
$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
|
||||
@file_put_contents(
|
||||
$this->configCache->get('system', 'db_log_index'),
|
||||
$this->config->get('system', 'db_log_index'),
|
||||
DateTimeFormat::utcNow() . "\t" .
|
||||
$row['key'] . "\t" . $row['rows'] . "\t" . $row['Extra'] . "\t" .
|
||||
basename($backtrace[1]["file"]) . "\t" .
|
||||
|
@ -533,7 +533,7 @@ class Database
|
|||
|
||||
$orig_sql = $sql;
|
||||
|
||||
if ($this->configCache->get('system', 'db_callstack') !== null) {
|
||||
if ($this->config->get('system', 'db_callstack') !== null) {
|
||||
$sql = "/*" . System::callstack() . " */ " . $sql;
|
||||
}
|
||||
|
||||
|
@ -738,16 +738,16 @@ class Database
|
|||
|
||||
$this->profiler->stopRecording();
|
||||
|
||||
if ($this->configCache->get('system', 'db_log')) {
|
||||
if ($this->config->get('system', 'db_log')) {
|
||||
$stamp2 = microtime(true);
|
||||
$duration = (float)($stamp2 - $stamp1);
|
||||
|
||||
if (($duration > $this->configCache->get('system', 'db_loglimit'))) {
|
||||
if (($duration > $this->config->get('system', 'db_loglimit'))) {
|
||||
$duration = round($duration, 3);
|
||||
$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
|
||||
|
||||
@file_put_contents(
|
||||
$this->configCache->get('system', 'db_log'),
|
||||
$this->config->get('system', 'db_log'),
|
||||
DateTimeFormat::utcNow() . "\t" . $duration . "\t" .
|
||||
basename($backtrace[1]["file"]) . "\t" .
|
||||
$backtrace[1]["line"] . "\t" . $backtrace[2]["function"] . "\t" .
|
||||
|
|
|
@ -102,7 +102,7 @@ class Details extends BaseAdmin
|
|||
if (array_key_exists($addon, $addons_admin)) {
|
||||
require_once "addon/$addon/$addon.php";
|
||||
$func = $addon . '_addon_admin';
|
||||
$func($a, $admin_form);
|
||||
$func($admin_form);
|
||||
}
|
||||
|
||||
$t = Renderer::getMarkupTemplate('admin/addons/details.tpl');
|
||||
|
|
|
@ -25,14 +25,12 @@ use Friendica\App;
|
|||
use Friendica\Core\Addon;
|
||||
use Friendica\Core\Config\Util\ConfigFileManager;
|
||||
use Friendica\Core\Config\ValueObject\Cache;
|
||||
use Friendica\Core\Logger;
|
||||
use Friendica\Core\Renderer;
|
||||
use Friendica\Core\Update;
|
||||
use Friendica\Database\DBA;
|
||||
use Friendica\Database\DBStructure;
|
||||
use Friendica\DI;
|
||||
use Friendica\Core\Config\Factory\Config;
|
||||
use Friendica\Model\Register;
|
||||
use Friendica\Module\BaseAdmin;
|
||||
use Friendica\Network\HTTPClient\Client\HttpClientAccept;
|
||||
use Friendica\Network\HTTPException\ServiceUnavailableException;
|
||||
|
|
|
@ -376,11 +376,11 @@ class Feed
|
|||
}
|
||||
|
||||
if ($published != '') {
|
||||
$item['created'] = $published;
|
||||
$item['created'] = trim($published);
|
||||
}
|
||||
|
||||
if ($updated != '') {
|
||||
$item['edited'] = $updated;
|
||||
$item['edited'] = trim($updated);
|
||||
}
|
||||
|
||||
if (!$dryRun) {
|
||||
|
|
|
@ -21,7 +21,6 @@
|
|||
|
||||
namespace Friendica\Util;
|
||||
|
||||
use Friendica\Core\Config\ValueObject\Cache;
|
||||
use Friendica\Core\Config\Capability\IManageConfigValues;
|
||||
use Friendica\Core\System;
|
||||
use Psr\Container\ContainerExceptionInterface;
|
||||
|
@ -66,30 +65,10 @@ class Profiler implements ContainerInterface
|
|||
return $this->rendertime;
|
||||
}
|
||||
|
||||
/**
|
||||
* Updates the enabling of the current profiler
|
||||
*
|
||||
* Note: The reason there are two different ways of updating the configuration of this class is because it can
|
||||
* be used even with no available database connection which IManageConfigValues doesn't ensure.
|
||||
*
|
||||
* @param IManageConfigValues $config
|
||||
*/
|
||||
public function update(IManageConfigValues $config)
|
||||
public function __construct(IManageConfigValues $config)
|
||||
{
|
||||
$this->enabled = (bool) $config->get('system', 'profiler') ?? false;
|
||||
$this->rendertime = (bool) $config->get('rendertime', 'callstack') ?? false;
|
||||
}
|
||||
|
||||
/**
|
||||
* Note: The reason we are using a Config Cache object to initialize this class is to ensure it'll work even with no
|
||||
* available database connection.
|
||||
*
|
||||
* @param \Friendica\Core\Config\ValueObject\Cache $configCache The configuration cache
|
||||
*/
|
||||
public function __construct(Cache $configCache)
|
||||
{
|
||||
$this->enabled = (bool) $configCache->get('system', 'profiler') ?? false;
|
||||
$this->rendertime = (bool) $configCache->get('rendertime', 'callstack') ?? false;
|
||||
$this->enabled = (bool)$config->get('system', 'profiler') ?? false;
|
||||
$this->rendertime = (bool)$config->get('rendertime', 'callstack') ?? false;
|
||||
$this->reset();
|
||||
}
|
||||
|
||||
|
@ -125,7 +104,7 @@ class Profiler implements ContainerInterface
|
|||
$timestamp = array_pop($this->timestamps);
|
||||
|
||||
$duration = floatval(microtime(true) - $timestamp['stamp'] - $timestamp['credit']);
|
||||
$value = $timestamp['value'];
|
||||
$value = $timestamp['value'];
|
||||
|
||||
foreach ($this->timestamps as $key => $stamp) {
|
||||
$this->timestamps[$key]['credit'] += $duration;
|
||||
|
@ -137,15 +116,15 @@ class Profiler implements ContainerInterface
|
|||
$this->performance[$value] = 0;
|
||||
}
|
||||
|
||||
$this->performance[$value] += (float) $duration;
|
||||
$this->performance['marktime'] += (float) $duration;
|
||||
$this->performance[$value] += (float)$duration;
|
||||
$this->performance['marktime'] += (float)$duration;
|
||||
|
||||
if (!isset($this->callstack[$value][$callstack])) {
|
||||
// Prevent ugly E_NOTICE
|
||||
$this->callstack[$value][$callstack] = 0;
|
||||
}
|
||||
|
||||
$this->callstack[$value][$callstack] += (float) $duration;
|
||||
$this->callstack[$value][$callstack] += (float)$duration;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -173,15 +152,15 @@ class Profiler implements ContainerInterface
|
|||
$this->performance[$value] = 0;
|
||||
}
|
||||
|
||||
$this->performance[$value] += (float) $duration;
|
||||
$this->performance['marktime'] += (float) $duration;
|
||||
$this->performance[$value] += (float)$duration;
|
||||
$this->performance['marktime'] += (float)$duration;
|
||||
|
||||
if (!isset($this->callstack[$value][$callstack])) {
|
||||
// Prevent ugly E_NOTICE
|
||||
$this->callstack[$value][$callstack] = 0;
|
||||
}
|
||||
|
||||
$this->callstack[$value][$callstack] += (float) $duration;
|
||||
$this->callstack[$value][$callstack] += (float)$duration;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -202,23 +181,22 @@ class Profiler implements ContainerInterface
|
|||
*/
|
||||
public function resetPerformance()
|
||||
{
|
||||
$this->performance = [];
|
||||
$this->performance['start'] = microtime(true);
|
||||
$this->performance['ready'] = 0;
|
||||
$this->performance['database'] = 0;
|
||||
$this->performance = [];
|
||||
$this->performance['start'] = microtime(true);
|
||||
$this->performance['ready'] = 0;
|
||||
$this->performance['database'] = 0;
|
||||
$this->performance['database_write'] = 0;
|
||||
$this->performance['cache'] = 0;
|
||||
$this->performance['cache_write'] = 0;
|
||||
$this->performance['network'] = 0;
|
||||
$this->performance['file'] = 0;
|
||||
$this->performance['rendering'] = 0;
|
||||
$this->performance['session'] = 0;
|
||||
$this->performance['marktime'] = 0;
|
||||
$this->performance['marktime'] = microtime(true);
|
||||
$this->performance['classcreate'] = 0;
|
||||
$this->performance['classinit'] = 0;
|
||||
$this->performance['init'] = 0;
|
||||
$this->performance['content'] = 0;
|
||||
$this->performance['cache'] = 0;
|
||||
$this->performance['cache_write'] = 0;
|
||||
$this->performance['network'] = 0;
|
||||
$this->performance['file'] = 0;
|
||||
$this->performance['rendering'] = 0;
|
||||
$this->performance['session'] = 0;
|
||||
$this->performance['marktime'] = microtime(true);
|
||||
$this->performance['classcreate'] = 0;
|
||||
$this->performance['classinit'] = 0;
|
||||
$this->performance['init'] = 0;
|
||||
$this->performance['content'] = 0;
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -228,19 +206,20 @@ class Profiler implements ContainerInterface
|
|||
*/
|
||||
public function resetCallstack()
|
||||
{
|
||||
$this->callstack = [];
|
||||
$this->callstack['database'] = [];
|
||||
$this->callstack = [];
|
||||
$this->callstack['database'] = [];
|
||||
$this->callstack['database_write'] = [];
|
||||
$this->callstack['cache'] = [];
|
||||
$this->callstack['cache_write'] = [];
|
||||
$this->callstack['network'] = [];
|
||||
$this->callstack['file'] = [];
|
||||
$this->callstack['rendering'] = [];
|
||||
$this->callstack['session'] = [];
|
||||
$this->callstack['cache'] = [];
|
||||
$this->callstack['cache_write'] = [];
|
||||
$this->callstack['network'] = [];
|
||||
$this->callstack['file'] = [];
|
||||
$this->callstack['rendering'] = [];
|
||||
$this->callstack['session'] = [];
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the rendertime string
|
||||
*
|
||||
* @param float $limit Minimal limit for displaying the execution duration
|
||||
*
|
||||
* @return string the rendertime
|
||||
|
@ -330,17 +309,17 @@ class Profiler implements ContainerInterface
|
|||
$logger->info(
|
||||
$message,
|
||||
[
|
||||
'action' => 'profiling',
|
||||
'database_read' => round($this->get('database') - $this->get('database_write'), 3),
|
||||
'action' => 'profiling',
|
||||
'database_read' => round($this->get('database') - $this->get('database_write'), 3),
|
||||
'database_write' => round($this->get('database_write'), 3),
|
||||
'cache_read' => round($this->get('cache'), 3),
|
||||
'cache_write' => round($this->get('cache_write'), 3),
|
||||
'network_io' => round($this->get('network'), 2),
|
||||
'file_io' => round($this->get('file'), 2),
|
||||
'other_io' => round($duration - ($this->get('database')
|
||||
+ $this->get('cache') + $this->get('cache_write')
|
||||
+ $this->get('network') + $this->get('file')), 2),
|
||||
'total' => round($duration, 2)
|
||||
'cache_read' => round($this->get('cache'), 3),
|
||||
'cache_write' => round($this->get('cache_write'), 3),
|
||||
'network_io' => round($this->get('network'), 2),
|
||||
'file_io' => round($this->get('file'), 2),
|
||||
'other_io' => round($duration - ($this->get('database')
|
||||
+ $this->get('cache') + $this->get('cache_write')
|
||||
+ $this->get('network') + $this->get('file')), 2),
|
||||
'total' => round($duration, 2)
|
||||
]
|
||||
);
|
||||
|
||||
|
@ -355,10 +334,10 @@ class Profiler implements ContainerInterface
|
|||
*
|
||||
* @param string $id Identifier of the entry to look for.
|
||||
*
|
||||
* @throws NotFoundExceptionInterface No entry was found for **this** identifier.
|
||||
* @return float Entry.
|
||||
* @throws ContainerExceptionInterface Error while retrieving the entry.
|
||||
*
|
||||
* @return float Entry.
|
||||
* @throws NotFoundExceptionInterface No entry was found for **this** identifier.
|
||||
*/
|
||||
public function get(string $id): float
|
||||
{
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue