IHTTPResult::getContentType is now a string again

src/Model/Photo.php

@@ -495,7 +495,7 @@ class Photo
 			$contType = $ret->getContentType();
 		} else {
 			$img_str = '';
-			$contType = [];
+			$contType = '';
 		}
 
 		if ($quit_on_error && ($img_str == "")) {

src/Model/User.php

@@ -1098,7 +1098,7 @@ class User
 				$contType = $curlResult->getContentType();
 			} else {
 				$img_str = '';
-				$contType = [];
+				$contType = '';
 			}
 
 			$type = Images::getMimeTypeByData($img_str, $photo, $contType);

src/Network/CurlResult.php

@@ -37,7 +37,7 @@ class CurlResult implements IHTTPResult
 	private $returnCode;
 
 	/**
-	 * @var string[] the content type of the Curl call
+	 * @var string the content type of the Curl call
 	 */
 	private $contentType;
 
@@ -223,9 +223,9 @@ class CurlResult implements IHTTPResult
 	private function checkInfo()
 	{
 		if (isset($this->info['content_type'])) {
-			$this->contentType = [$this->info['content_type']];
+			$this->contentType = $this->info['content_type'];
 		} else {
-			$this->contentType = [];
+			$this->contentType = '';
 		}
 	}
 

src/Network/GuzzleResponse.php

@@ -88,7 +88,7 @@ class GuzzleResponse extends Response implements IHTTPResult, ResponseInterface
 	/** {@inheritDoc} */
 	public function getContentType()
 	{
-		return $this->getHeader('Content-Type');
+		return implode($this->getHeader('Content-Type'));
 	}
 
 	/** {@inheritDoc} */

src/Network/IHTTPResult.php

@@ -19,7 +19,7 @@ interface IHTTPResult
 	/**
 	 * Returns the Content Type
 	 *
-	 * @return string[] the Content Types
+	 * @return string the Content Type
 	 */
 	public function getContentType();
 

src/Network/Probe.php

@@ -430,7 +430,7 @@ class Probe
 		}
 
 		// If it isn't a HTML file then exit
-		if (!in_array('html', $curlResult->getContentType())) {
+		if (($curlResult->getContentType() != '') && !strstr(strtolower($curlResult->getContentType()), 'html')) {
 			return false;
 		}
 

src/Util/Images.php

@@ -75,25 +75,23 @@ class Images
 	/**
 	 * Fetch image mimetype from the image data or guessing from the file name
 	 *
-	 * @param string   $image_data Image data
+	 * @param string $image_data Image data
-	 * @param string   $filename   File name (for guessing the type via the extension)
+	 * @param string $filename   File name (for guessing the type via the extension)
-	 * @param string[] $mimeTypes  possible mime types
+	 * @param string $mimeType   possible mime type
 	 *
 	 * @return string
 	 * @throws \Exception
 	 */
-	public static function getMimeTypeByData(string $image_data, string $filename = '', array $mimeTypes = [])
+	public static function getMimeTypeByData(string $image_data, string $filename = '', string $mimeType = '')
 	{
-		foreach ($mimeTypes as $mimeType) {
+		if (substr($mimeType, 0, 6) == 'image/') {
-			if (substr($mimeType, 0, 6) == 'image/') {
+			Logger::info('Using default mime type', ['filename' => $filename, 'mime' => $mimeType]);
-				Logger::info('Using default mime type', ['filename' => $filename, 'mime' => $mimeTypes]);
+			return $mimeType;
-				return $mimeType;
-			}
 		}
 
 		$image = @getimagesizefromstring($image_data);
 		if (!empty($image['mime'])) {
-			Logger::info('Mime type detected via data', ['filename' => $filename, 'default' => $mimeTypes, 'mime' => $image['mime']]);
+			Logger::info('Mime type detected via data', ['filename' => $filename, 'default' => $mimeType, 'mime' => $image['mime']]);
 			return $image['mime'];
 		}
 

src/Util/ParseUrl.php

@@ -272,10 +272,8 @@ class ParseUrl
 		$charset = '';
 		// Look for a charset, first in headers
 		// Expected form: Content-Type: text/html; charset=ISO-8859-4
-		foreach ($curlResult->getContentType() as $type) {
+		if (preg_match('/charset=([a-z0-9-_.\/]+)/i', $curlResult->getContentType(), $matches)) {
-			if (preg_match('/charset=([a-z0-9-_.\/]+)/i', $type, $matches)) {
+			$charset = trim(trim(trim(array_pop($matches)), ';,'));
-				$charset = trim(trim(trim(array_pop($matches)), ';,'));
-			}
 		}
 
 		// Then in body that gets precedence

tests/src/Network/CurlResultTest.php

@@ -68,7 +68,7 @@ class CurlResultTest extends TestCase
 		self::assertFalse($curlResult->isRedirectUrl());
 		self::assertSame($headerArray, $curlResult->getHeaders());
 		self::assertSame($body, $curlResult->getBody());
-		self::assertSame(['text/html; charset=utf-8'], $curlResult->getContentType());
+		self::assertSame('text/html; charset=utf-8', $curlResult->getContentType());
 		self::assertSame('https://test.local', $curlResult->getUrl());
 		self::assertSame('https://test.local', $curlResult->getRedirectUrl());
 	}
@@ -97,7 +97,7 @@ class CurlResultTest extends TestCase
 		self::assertTrue($curlResult->isRedirectUrl());
 		self::assertSame($headerArray, $curlResult->getHeaders());
 		self::assertSame($body, $curlResult->getBody());
-		self::assertSame(['text/html; charset=utf-8'], $curlResult->getContentType());
+		self::assertSame('text/html; charset=utf-8', $curlResult->getContentType());
 		self::assertSame('https://test.local/test/it', $curlResult->getUrl());
 		self::assertSame('https://test.other/test/it', $curlResult->getRedirectUrl());
 	}
@@ -124,7 +124,7 @@ class CurlResultTest extends TestCase
 		self::assertFalse($curlResult->isRedirectUrl());
 		self::assertSame($headerArray, $curlResult->getHeaders());
 		self::assertSame($body, $curlResult->getBody());
-		self::assertSame(['text/html; charset=utf-8'], $curlResult->getContentType());
+		self::assertSame('text/html; charset=utf-8', $curlResult->getContentType());
 		self::assertSame('https://test.local/test/it', $curlResult->getRedirectUrl());
 		self::assertSame('Tested error', $curlResult->getError());
 	}
@@ -152,7 +152,7 @@ class CurlResultTest extends TestCase
 		self::assertTrue($curlResult->isRedirectUrl());
 		self::assertSame($headerArray, $curlResult->getHeaders());
 		self::assertSame($body, $curlResult->getBody());
-		self::assertSame(['text/html; charset=utf-8'], $curlResult->getContentType());
+		self::assertSame('text/html; charset=utf-8', $curlResult->getContentType());
 		self::assertSame('https://test.local/test/it?key=value', $curlResult->getUrl());
 		self::assertSame('https://test.other/some/?key=value', $curlResult->getRedirectUrl());
 	}