Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2025-04-22 17:50:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add feedback - avoid intermediate variables

Browse source
This commit is contained in:
Philipp 2022-01-02 01:04:04 +01:00
parent adf0d7bc95
commit 301ac83ebf
No known key found for this signature in database
GPG key ID: 24A7501396EB5432
42 changed files with 367 additions and 272 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/src/Factory/Api/Twitter/UserTest.php
View file

@ -31,9 +31,9 @@ class UserTest extends FixtureTest
*/
public function testApiGetUser()
{
$userFactory = new User(DI::logger(), DI::twitterStatus());
$userObj = $userFactory->createFromUserId(ApiTest::SELF_USER['id']);
$user = $userObj->toArray();
$user = (new User(DI::logger(), DI::twitterStatus()))
->createFromUserId(ApiTest::SELF_USER['id'])
->toArray();
$this->assertSelfUser($user);
}
@ -114,9 +114,9 @@ class UserTest extends FixtureTest
*/
public function testApiGetUserWithWrongGetId()
{
$userFactory = new User(DI::logger(), DI::twitterStatus());
$userObj = $userFactory->createFromUserId(-1);
$user = $userObj->toArray();
$user = (new User(DI::logger(), DI::twitterStatus()))
->createFromUserId(-1)
->toArray();
self::assertEquals(0, $user['id']);
self::assertEquals(0, $user['uid']);