From 33ea5dfe3567c39a78cd18e638fc746a19992c68 Mon Sep 17 00:00:00 2001 From: Hypolite Petovan Date: Thu, 19 Dec 2019 07:48:08 -0500 Subject: [PATCH] Add check for $_REQUEST key existence in Module\Item\Compose - Addresses https://github.com/friendica/friendica/issues/7677#issuecomment-566254464 --- src/Module/Item/Compose.php | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/Module/Item/Compose.php b/src/Module/Item/Compose.php index db44ee3d14..b9cda4863e 100644 --- a/src/Module/Item/Compose.php +++ b/src/Module/Item/Compose.php @@ -85,15 +85,20 @@ class Compose extends BaseModule $type = 'post'; $doesFederate = true; - if ($_REQUEST['contact_allow'] - . $_REQUEST['group_allow'] - . $_REQUEST['contact_deny'] - . $_REQUEST['group_deny']) + $contact_allow = $_REQUEST['contact_allow'] ?? ''; + $group_allow = $_REQUEST['group_allow'] ?? ''; + $contact_deny = $_REQUEST['contact_deny'] ?? ''; + $group_deny = $_REQUEST['group_deny'] ?? ''; + + if ($contact_allow + . $group_allow + . $contact_deny + . $group_deny) { - $contact_allow_list = $_REQUEST['contact_allow'] ? explode(',', $_REQUEST['contact_allow']) : []; - $group_allow_list = $_REQUEST['group_allow'] ? explode(',', $_REQUEST['group_allow']) : []; - $contact_deny_list = $_REQUEST['contact_deny'] ? explode(',', $_REQUEST['contact_deny']) : []; - $group_deny_list = $_REQUEST['group_deny'] ? explode(',', $_REQUEST['group_deny']) : []; + $contact_allow_list = $contact_allow ? explode(',', $contact_allow) : []; + $group_allow_list = $group_allow ? explode(',', $group_allow) : []; + $contact_deny_list = $contact_deny ? explode(',', $contact_deny) : []; + $group_deny_list = $group_deny ? explode(',', $group_deny) : []; } break;