Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2025-04-19 08:30:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Replace BaseObject class with DI::* calls

Browse source
This commit is contained in:
nupplaPhil 2019-12-15 23:28:01 +01:00
parent 1de3f186d7
commit 388b963714
No known key found for this signature in database
GPG key ID: D8365C3D36B77D90
98 changed files with 321 additions and 440 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/Module/Admin/Summary.php
View file

@ -81,8 +81,7 @@ class Summary extends BaseAdminModule
if (Config::get('system', 'debugging')) {
$file = Config::get('system', 'logfile');
/** @var FileSystem $fileSystem */
$fileSystem = self::getClass(FileSystem::class);
$fileSystem = DI::fs();
try {
$stream = $fileSystem->createStream($file);

5
src/Module/Api/Mastodon/FollowRequests.php
View file

@ -3,10 +3,10 @@
namespace Friendica\Module\Api\Mastodon;
use Friendica\Api\Mastodon;
use Friendica\App\BaseURL;
use Friendica\Core\System;
use Friendica\Database\DBA;
use Friendica\Model\APContact;
use Friendica\DI;
use Friendica\Model\Contact;
use Friendica\Model\Introduction;
use Friendica\Module\Base\Api;
@ -104,8 +104,7 @@ class FollowRequests extends Api
$base_query['limit'] = $limit;
}
/** @var BaseURL $BaseURL */
$BaseURL = self::getClass(BaseURL::class);
$BaseURL = DI::baseUrl();
$links = [];
if ($count > $limit) {

8
src/Module/Base/Api.php
View file

@ -23,15 +23,15 @@ class Api extends BaseModule
public static function init(array $parameters = [])
{
$Arguments = self::getClass(Arguments::class);
$arguments = DI::args();
if (substr($Arguments->getQueryString(), -4) === '.xml') {
if (substr($arguments->getQueryString(), -4) === '.xml') {
self::$format = 'xml';
}
if (substr($Arguments->getQueryString(), -4) === '.rss') {
if (substr($arguments->getQueryString(), -4) === '.rss') {
self::$format = 'rss';
}
if (substr($Arguments->getQueryString(), -4) === '.atom') {
if (substr($arguments->getQueryString(), -4) === '.atom') {
self::$format = 'atom';
}
}

3
src/Module/BaseSearchModule.php
View file

@ -65,8 +65,7 @@ class BaseSearchModule extends BaseModule
$header = L10n::t('Forum Search - %s', $search);
}
/** @var Arguments $args */
$args = self::getClass(Arguments::class);
$args = DI::args();
$pager = new Pager($args->getQueryString());
if ($localSearch && empty($results)) {

5
src/Module/Delegation.php
View file

@ -3,7 +3,6 @@
namespace Friendica\Module;
use Friendica\BaseModule;
use Friendica\App\Authentication;
use Friendica\Core\Hook;
use Friendica\Core\L10n;
use Friendica\Core\Renderer;
@ -81,9 +80,7 @@ class Delegation extends BaseModule
Session::clear();
/** @var Authentication $authentication */
$authentication = self::getClass(Authentication::class);
$authentication->setForUser(DI::app(), $user, true, true);
DI::auth()->setForUser(DI::app(), $user, true, true);
if ($limited_id) {
Session::set('submanage', $original_id);

15
src/Module/Diaspora/Receive.php
View file

@ -6,6 +6,7 @@ use Friendica\App;
use Friendica\BaseModule;
use Friendica\Core\Config\Configuration;
use Friendica\Core\L10n\L10n;
use Friendica\DI;
use Friendica\Model\User;
use Friendica\Network\HTTPException;
use Friendica\Protocol\Diaspora;
@ -23,24 +24,18 @@ class Receive extends BaseModule
public static function init(array $parameters = [])
{
/** @var LoggerInterface $logger */
self::$logger = self::getClass(LoggerInterface::class);
self::$logger = DI::logger();
}
public static function post(array $parameters = [])
{
/** @var Configuration $config */
$config = self::getClass(Configuration::class);
$enabled = $config->get('system', 'diaspora_enabled', false);
$enabled = DI::config()->get('system', 'diaspora_enabled', false);
if (!$enabled) {
self::$logger->info('Diaspora disabled.');
$l10n = self::getClass(L10n::class);
throw new HTTPException\ForbiddenException($l10n->t('Access denied.'));
throw new HTTPException\ForbiddenException(DI::l10n()->t('Access denied.'));
}
/** @var App\Arguments $args */
$args = self::getClass(App\Arguments::class);
$args = DI::args();
$type = $args->get(1);

3
src/Module/Item/Compose.php
View file

@ -63,8 +63,7 @@ class Compose extends BaseModule
$user = User::getById(local_user(), ['allow_cid', 'allow_gid', 'deny_cid', 'deny_gid', 'hidewall', 'default-location']);
/** @var ACLFormatter $aclFormatter */
$aclFormatter = self::getClass(ACLFormatter::class);
$aclFormatter = DI::aclFormatter();
$contact_allow_list = $aclFormatter->expand($user['allow_cid']);
$group_allow_list = $aclFormatter->expand($user['allow_gid']);

9
src/Module/Item/Ignore.php
View file

@ -19,17 +19,14 @@ class Ignore extends BaseModule
{
public static function rawContent(array $parameters = [])
{
/** @var L10n $l10n */
$l10n = self::getClass(L10n::class);
$l10n = DI::l10n();
if (!Session::isAuthenticated()) {
throw new HttpException\ForbiddenException($l10n->t('Access denied.'));
}
/** @var App\Arguments $args */
$args = self::getClass(App\Arguments::class);
/** @var Database $dba */
$dba = self::getClass(Database::class);
$args = DI::args();
$dba = DI::dba();
$message_id = intval($args->get(2));

9
src/Module/Notifications/Notify.php
View file

@ -3,11 +3,9 @@
namespace Friendica\Module\Notifications;
use Friendica\BaseModule;
use Friendica\BaseObject;
use Friendica\Core\L10n;
use Friendica\Core\System;
use Friendica\DI;
use Friendica\Model\Notify as ModelNotify;
use Friendica\Network\HTTPException;
/**
@ -28,9 +26,7 @@ class Notify extends BaseModule
// @TODO: Replace with parameter from router
if ($a->argc > 2 && $a->argv[1] === 'mark' && $a->argv[2] === 'all') {
/** @var ModelNotify $notificationsManager */
$notificationsManager = self::getClass(ModelNotify::class);
$success = $notificationsManager->setAllSeen();
$success = DI::notify()->setAllSeen();
header('Content-type: application/json; charset=utf-8');
echo json_encode([
@ -52,8 +48,7 @@ class Notify extends BaseModule
// @TODO: Replace with parameter from router
if ($a->argc > 2 && $a->argv[1] === 'view' && intval($a->argv[2])) {
/** @var ModelNotify $notificationsManager */
$notificationsManager = BaseObject::getClass(ModelNotify::class);
$notificationsManager = DI::notify();
// @TODO: Replace with parameter from router
$note = $notificationsManager->getByID($a->argv[2]);
if (!empty($note)) {

5
src/Module/Profile.php
View file

@ -133,12 +133,9 @@ class Profile extends BaseModule
$category = $datequery = $datequery2 = '';
/** @var DateTimeFormat $dtFormat */
$dtFormat = self::getClass(DateTimeFormat::class);
if ($a->argc > 2) {
for ($x = 2; $x < $a->argc; $x ++) {
if ($dtFormat->isYearMonth($a->argv[$x])) {
if (DI::dtFormat()->isYearMonth($a->argv[$x])) {
if ($datequery) {
$datequery2 = Strings::escapeHtml($a->argv[$x]);
} else {

2
src/Module/Register.php
View file

@ -209,7 +209,7 @@ class Register extends BaseModule
$user = $result['user'];
$base_url = self::getClass(BaseURL::class)->get();
$base_url = DI::baseUrl()->get();
if ($netpublish && intval(Config::get('config', 'register_policy')) !== self::APPROVE) {
$url = $base_url . '/profile/' . $user['nickname'];

4
src/Module/Search/Index.php
View file

@ -126,9 +126,7 @@ class Index extends BaseSearchModule
// OR your own posts if you are a logged in member
// No items will be shown if the member has a blocked profile wall.
/** @var Arguments $args */
$args = self::getClass(Arguments::class);
$pager = new Pager($args->getQueryString());
$pager = new Pager(DI::args()->getQueryString());
if ($tag) {
Logger::info('Start tag search.', ['q' => $search]);

6
src/Module/Search/Saved.php
View file

@ -2,7 +2,6 @@
namespace Friendica\Module\Search;
use Friendica\App\Arguments;
use Friendica\BaseModule;
use Friendica\Core\L10n;
use Friendica\Database\DBA;
@ -13,10 +12,7 @@ class Saved extends BaseModule
{
public static function init(array $parameters = [])
{
/** @var Arguments $args */
$args = self::getClass(Arguments::class);
$action = $args->get(2, 'none');
$action = DI::args()->get(2, 'none');
$search = Strings::escapeTags(trim(rawurldecode($_GET['term'] ?? '')));
$return_url = $_GET['return_url'] ?? 'search?q=' . urlencode($search);

9
src/Module/Security/Login.php
View file

@ -7,7 +7,6 @@
namespace Friendica\Module\Security;
use Friendica\BaseModule;
use Friendica\App\Authentication;
use Friendica\Core\Config;
use Friendica\Core\Hook;
use Friendica\Core\L10n;
@ -49,15 +48,11 @@ class Login extends BaseModule
) {
$openid_url = trim(($_POST['openid_url'] ?? '') ?: $_POST['username']);
/** @var Authentication $authentication */
$authentication = self::getClass(Authentication::class);
$authentication->withOpenId($openid_url, !empty($_POST['remember']));
DI::auth()->withOpenId($openid_url, !empty($_POST['remember']));
}
if (!empty($_POST['auth-params']) && $_POST['auth-params'] === 'login') {
/** @var Authentication $authentication */
$authentication = self::getClass(Authentication::class);
$authentication->withPassword(
DI::auth()->withPassword(
DI::app(),
trim($_POST['username']),
trim($_POST['password']),

5
src/Module/Security/TwoFactor/Recovery.php
View file

@ -42,10 +42,7 @@ class Recovery extends BaseModule
Session::set('2fa', true);
notice(L10n::t('Remaining recovery codes: %d', RecoveryCode::countValidForUser(local_user())));
// Resume normal login workflow
/** @var Authentication $authentication */
$authentication = self::getClass(Authentication::class);
$authentication->setForUser($a, $a->user, true, true);
DI::auth()->setForUser($a, $a->user, true, true);
} else {
notice(L10n::t('Invalid code, please retry.'));
}

4
src/Module/Security/TwoFactor/Verify.php
View file

@ -40,9 +40,7 @@ class Verify extends BaseModule
Session::set('2fa', $code);
// Resume normal login workflow
/** @var Authentication $authentication */
$authentication = self::getClass(Authentication::class);
$authentication->setForUser($a, $a->user, true, true);
DI::auth()->setForUser($a, $a->user, true, true);
} else {
self::$errors[] = L10n::t('Invalid code, please retry.');
}

3
src/Module/Settings/Delegation.php
View file

@ -55,8 +55,7 @@ class Delegation extends BaseSettingsModule
throw new HTTPException\ForbiddenException(L10n::t('Permission denied.'));
}
/** @var Arguments $args */
$args = self::getClass(Arguments::class);
$args = DI::args();
// @TODO Replace with router-provided arguments
$action = $args->get(2);

2
src/Module/Settings/UserExport.php
View file

@ -62,7 +62,7 @@ class UserExport extends BaseSettingsModule
**/
public static function rawContent(array $parameters = [])
{
$args = self::getClass(Arguments::class);
$args = DI::args();
if ($args->getArgc() == 3) {
// @TODO Replace with router-provided arguments
$action = $args->get(2);