mirror of
https://github.com/friendica/friendica
synced 2025-04-22 15:10:12 +00:00
Refactoring DBA-mocking tests
- Reducing DB-dependencies - Creating DB-cache mocks - Creating DB-lock mocks - Switching to mocked dependencies for Cache/Lock/App
This commit is contained in:
Philipp Holzer
parent
f7e95f65b1
commit
433d6abe8c
21 changed files with 848 additions and 193 deletions
|
|
@ -3,12 +3,23 @@
|
|||
namespace Friendica\Test\src\Core\Cache;
|
||||
|
||||
use Friendica\Core\Cache\MemcachedCacheDriver;
|
||||
use Friendica\Core\Config;
|
||||
use Friendica\Test\DatabaseTest;
|
||||
use Friendica\Util\DateTimeFormat;
|
||||
use Friendica\Test\MockedTest;
|
||||
use Friendica\Test\Util\AppMockTrait;
|
||||
use Friendica\Test\Util\DateTimeFormatMockTrait;
|
||||
use Friendica\Test\Util\VFSTrait;
|
||||
use Friendica\Util\PidFile;
|
||||
|
||||
abstract class CacheTest extends DatabaseTest
|
||||
abstract class CacheTest extends MockedTest
|
||||
{
|
||||
use VFSTrait;
|
||||
use AppMockTrait;
|
||||
use DateTimeFormatMockTrait;
|
||||
|
||||
/**
|
||||
* @var int Start time of the mock (used for time operations)
|
||||
*/
|
||||
protected $startTime = 1417011228;
|
||||
|
||||
/**
|
||||
* @var \Friendica\Core\Cache\ICacheDriver
|
||||
*/
|
||||
|
|
@ -19,48 +30,87 @@ abstract class CacheTest extends DatabaseTest
|
|||
*/
|
||||
protected $cache;
|
||||
|
||||
/**
|
||||
* Dataset for test setting different types in the cache
|
||||
* @return array
|
||||
*/
|
||||
public function dataTypesInCache()
|
||||
{
|
||||
return [
|
||||
'string' => ['data' => 'foobar'],
|
||||
'integer' => ['data' => 1],
|
||||
'boolTrue' => ['data' => true],
|
||||
'boolFalse' => ['data' => false],
|
||||
'float' => ['data' => 4.6634234],
|
||||
'array' => ['data' => ['1', '2', '3', '4', '5']],
|
||||
'object' => ['data' => new PidFile()],
|
||||
'null' => ['data' => null],
|
||||
];
|
||||
}
|
||||
|
||||
/**
|
||||
* Dataset for simple value sets/gets
|
||||
* @return array
|
||||
*/
|
||||
public function dataSimple()
|
||||
{
|
||||
return [
|
||||
'string' => [
|
||||
'value1' => 'foobar',
|
||||
'value2' => 'ipsum lorum',
|
||||
'value3' => 'test',
|
||||
'value4' => 'lasttest',
|
||||
],
|
||||
];
|
||||
}
|
||||
|
||||
abstract protected function getInstance();
|
||||
|
||||
protected function setUp()
|
||||
{
|
||||
$this->setUpVfsDir();
|
||||
$this->mockApp($this->root);
|
||||
$this->app
|
||||
->shouldReceive('getHostname')
|
||||
->andReturn('friendica.local');
|
||||
|
||||
$this->mockUtcNow($this->startTime);
|
||||
|
||||
parent::setUp();
|
||||
|
||||
$this->instance = $this->getInstance();
|
||||
|
||||
// Reusable App object
|
||||
$this->app = \Friendica\BaseObject::getApp();
|
||||
|
||||
// Default config
|
||||
Config::set('config', 'hostname', 'localhost');
|
||||
Config::set('system', 'throttle_limit_day', 100);
|
||||
Config::set('system', 'throttle_limit_week', 100);
|
||||
Config::set('system', 'throttle_limit_month', 100);
|
||||
Config::set('system', 'theme', 'system_theme');
|
||||
$this->mockConfigGet('config', 'hostname', 'localhost');
|
||||
$this->mockConfigGet('system', 'throttle_limit_day', 100);
|
||||
$this->mockConfigGet('system', 'throttle_limit_week', 100);
|
||||
$this->mockConfigGet('system', 'throttle_limit_month', 100);
|
||||
$this->mockConfigGet('system', 'theme', 'system_theme');
|
||||
|
||||
$this->instance->clear(false);
|
||||
}
|
||||
|
||||
/**
|
||||
* @small
|
||||
* @dataProvider dataSimple
|
||||
* @param mixed $value1 a first
|
||||
* @param mixed $value2 a second
|
||||
*/
|
||||
function testSimple() {
|
||||
function testSimple($value1, $value2) {
|
||||
$this->assertNull($this->instance->get('value1'));
|
||||
|
||||
$value = 'foobar';
|
||||
$this->instance->set('value1', $value);
|
||||
$this->instance->set('value1', $value1);
|
||||
$received = $this->instance->get('value1');
|
||||
$this->assertEquals($value, $received, 'Value received from cache not equal to the original');
|
||||
$this->assertEquals($value1, $received, 'Value received from cache not equal to the original');
|
||||
|
||||
$value = 'ipsum lorum';
|
||||
$this->instance->set('value1', $value);
|
||||
$this->instance->set('value1', $value2);
|
||||
$received = $this->instance->get('value1');
|
||||
$this->assertEquals($value, $received, 'Value not overwritten by second set');
|
||||
$this->assertEquals($value2, $received, 'Value not overwritten by second set');
|
||||
|
||||
$value2 = 'foobar';
|
||||
$this->instance->set('value2', $value2);
|
||||
$this->instance->set('value2', $value1);
|
||||
$received2 = $this->instance->get('value2');
|
||||
$this->assertEquals($value, $received, 'Value changed while setting other variable');
|
||||
$this->assertEquals($value2, $received2, 'Second value not equal to original');
|
||||
$this->assertEquals($value2, $received, 'Value changed while setting other variable');
|
||||
$this->assertEquals($value1, $received2, 'Second value not equal to original');
|
||||
|
||||
$this->assertNull($this->instance->get('not_set'), 'Unset value not equal to null');
|
||||
|
||||
|
|
@ -70,19 +120,24 @@ abstract class CacheTest extends DatabaseTest
|
|||
|
||||
/**
|
||||
* @small
|
||||
* @dataProvider dataSimple
|
||||
* @param mixed $value1 a first
|
||||
* @param mixed $value2 a second
|
||||
* @param mixed $value3 a third
|
||||
* @param mixed $value4 a fourth
|
||||
*/
|
||||
function testClear() {
|
||||
function testClear($value1, $value2, $value3, $value4) {
|
||||
$value = 'ipsum lorum';
|
||||
$this->instance->set('1_value1', $value . '1');
|
||||
$this->instance->set('1_value2', $value . '2');
|
||||
$this->instance->set('2_value1', $value . '3');
|
||||
$this->instance->set('3_value1', $value . '4');
|
||||
$this->instance->set('1_value1', $value1);
|
||||
$this->instance->set('1_value2', $value2);
|
||||
$this->instance->set('2_value1', $value3);
|
||||
$this->instance->set('3_value1', $value4);
|
||||
|
||||
$this->assertEquals([
|
||||
'1_value1' => 'ipsum lorum1',
|
||||
'1_value2' => 'ipsum lorum2',
|
||||
'2_value1' => 'ipsum lorum3',
|
||||
'3_value1' => 'ipsum lorum4',
|
||||
'1_value1' => $value1,
|
||||
'1_value2' => $value2,
|
||||
'2_value1' => $value3,
|
||||
'3_value1' => $value4,
|
||||
], [
|
||||
'1_value1' => $this->instance->get('1_value1'),
|
||||
'1_value2' => $this->instance->get('1_value2'),
|
||||
|
|
@ -93,10 +148,10 @@ abstract class CacheTest extends DatabaseTest
|
|||
$this->assertTrue($this->instance->clear());
|
||||
|
||||
$this->assertEquals([
|
||||
'1_value1' => 'ipsum lorum1',
|
||||
'1_value2' => 'ipsum lorum2',
|
||||
'2_value1' => 'ipsum lorum3',
|
||||
'3_value1' => 'ipsum lorum4',
|
||||
'1_value1' => $value1,
|
||||
'1_value2' => $value2,
|
||||
'2_value1' => $value3,
|
||||
'3_value1' => $value4,
|
||||
], [
|
||||
'1_value1' => $this->instance->get('1_value1'),
|
||||
'1_value2' => $this->instance->get('1_value2'),
|
||||
|
|
@ -139,67 +194,30 @@ abstract class CacheTest extends DatabaseTest
|
|||
|
||||
/**
|
||||
* @small
|
||||
* @param $data mixed the data to store in the cache
|
||||
* @dataProvider dataTypesInCache
|
||||
*/
|
||||
function testDifferentTypesInCache() {
|
||||
// String test
|
||||
$value = "foobar";
|
||||
$this->instance->set('stringVal', $value);
|
||||
$received = $this->instance->get('stringVal');
|
||||
$this->assertEquals($value, $received, 'Value type changed from ' . gettype($value) . ' to ' . gettype($received));
|
||||
|
||||
// Integer test
|
||||
$value = 1;
|
||||
$this->instance->set('intVal', $value);
|
||||
$received = $this->instance->get('intVal');
|
||||
$this->assertEquals($value, $received, 'Value type changed from ' . gettype($value) . ' to ' . gettype($received));
|
||||
|
||||
// Boolean test
|
||||
$value = true;
|
||||
$this->instance->set('boolValTrue', $value);
|
||||
$received = $this->instance->get('boolValTrue');
|
||||
$this->assertEquals($value, $received, 'Value type changed from ' . gettype($value) . ' to ' . gettype($received));
|
||||
|
||||
$value = false;
|
||||
$this->instance->set('boolValFalse', $value);
|
||||
$received = $this->instance->get('boolValFalse');
|
||||
$this->assertEquals($value, $received, 'Value type changed from ' . gettype($value) . ' to ' . gettype($received));
|
||||
|
||||
// float
|
||||
$value = 4.6634234;
|
||||
$this->instance->set('decVal', $value);
|
||||
$received = $this->instance->get('decVal');
|
||||
$this->assertEquals($value, $received, 'Value type changed from ' . gettype($value) . ' to ' . gettype($received));
|
||||
|
||||
// array
|
||||
$value = array('1', '2', '3', '4', '5');
|
||||
$this->instance->set('arrayVal', $value);
|
||||
$received = $this->instance->get('arrayVal');
|
||||
$this->assertEquals($value, $received, 'Value type changed from ' . gettype($value) . ' to ' . gettype($received));
|
||||
|
||||
// object
|
||||
$value = new DateTimeFormat();
|
||||
$this->instance->set('objVal', $value);
|
||||
$received = $this->instance->get('objVal');
|
||||
$this->assertEquals($value, $received, 'Value type changed from ' . gettype($value) . ' to ' . gettype($received));
|
||||
|
||||
// null
|
||||
$value = null;
|
||||
$this->instance->set('objVal', $value);
|
||||
$received = $this->instance->get('objVal');
|
||||
$this->assertEquals($value, $received, 'Value type changed from ' . gettype($value) . ' to ' . gettype($received));
|
||||
function testDifferentTypesInCache($data) {
|
||||
$this->instance->set('val', $data);
|
||||
$received = $this->instance->get('val');
|
||||
$this->assertEquals($data, $received, 'Value type changed from ' . gettype($data) . ' to ' . gettype($received));
|
||||
}
|
||||
|
||||
/**
|
||||
* @small
|
||||
* @param mixed $value1 a first
|
||||
* @param mixed $value2 a second
|
||||
* @param mixed $value3 a third
|
||||
* @dataProvider dataSimple
|
||||
*/
|
||||
public function testGetAllKeys() {
|
||||
public function testGetAllKeys($value1, $value2, $value3) {
|
||||
if ($this->cache instanceof MemcachedCacheDriver) {
|
||||
$this->markTestSkipped('Memcached doesn\'t support getAllKeys anymore');
|
||||
}
|
||||
|
||||
$this->assertTrue($this->instance->set('value1', 'test'));
|
||||
$this->assertTrue($this->instance->set('value2', 'test'));
|
||||
$this->assertTrue($this->instance->set('test_value3', 'test'));
|
||||
$this->assertTrue($this->instance->set('value1', $value1));
|
||||
$this->assertTrue($this->instance->set('value2', $value2));
|
||||
$this->assertTrue($this->instance->set('test_value3', $value3));
|
||||
|
||||
$list = $this->instance->getAllKeys();
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue