Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2025-04-21 13:50:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix PHP notices in various modules

Browse source 
Fixes #14375

Add error handling for undefined variables and replace deprecated functions.

* **mod/photos.php**
  - Add loading message to the photo comment form.

* **mod/update_contact.php**
  - Handle undefined `$_GET['item']` variable.

* **mod/update_notes.php**
  - Handle undefined `$_GET['p']` variable.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/friendica/friendica/issues/14375?shareId=XXXX-XXXX-XXXX-XXXX).
This commit is contained in:
Mustafacco 2024-10-18 00:36:24 +03:00
parent 65fe8fcf41
commit 4342e79f15
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
mod/photos.php
View file

@ -1151,6 +1151,7 @@ function photos_content()
'$comment' => DI::l10n()->t('Comment'), '$comment' => DI::l10n()->t('Comment'),
'$submit' => DI::l10n()->t('Submit'), '$submit' => DI::l10n()->t('Submit'),
'$preview' => DI::l10n()->t('Preview'), '$preview' => DI::l10n()->t('Preview'),
'$loading' => DI::l10n()->t('Loading...'),
'$qcomment' => $qcomment, '$qcomment' => $qcomment,
'$rand_num' => Crypto::randomDigits(12), '$rand_num' => Crypto::randomDigits(12),
]); ]);

4
mod/update_contact.php
View file

@ -23,9 +23,7 @@ function update_contact_content(App $a)
if (DBA::isResult($contact) && empty($contact['deleted'])) { if (DBA::isResult($contact) && empty($contact['deleted'])) {
DI::page()['aside'] = ''; DI::page()['aside'] = '';
if (!empty($_GET['item'])) { $item = Post::selectFirst(['parent'], ['id' => $_GET['item'] ?? 0]);
$item = Post::selectFirst(['parent'], ['id' => $_GET['item']]);
}
$text = Contact::getThreadsFromId($contact['pid'], DI::userSession()->getLocalUserId(), true, $item['parent'] ?? 0, $_GET['last_received'] ?? ''); $text = Contact::getThreadsFromId($contact['pid'], DI::userSession()->getLocalUserId(), true, $item['parent'] ?? 0, $_GET['last_received'] ?? '');
} }

2
mod/update_notes.php
View file

@ -16,7 +16,7 @@ require_once 'mod/notes.php';
function update_notes_content(App $a) function update_notes_content(App $a)
{ {
$profile_uid = intval($_GET['p']); $profile_uid = intval($_GET['p'] ?? 0);
/** /**
* *