Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2025-04-26 15:10:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Add exception when message is empty in FormatteNavNotification::createFromNotification

Browse source 
- Filter out message less notifications in Ping
This commit is contained in:
Hypolite Petovan 2022-03-14 21:53:33 -04:00
parent ee60c96269
commit 73c7b88fb2
4 changed files with 54 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/Navigation/Notifications/Factory/FormattedNavNotification.php
View file

@ -25,6 +25,7 @@ use Friendica\BaseFactory;
use Friendica\Core\Renderer;
use Friendica\Model\Contact;
use Friendica\Navigation\Notifications\Entity;
use Friendica\Navigation\Notifications\Exception\NoMessageException;
use Friendica\Navigation\Notifications\ValueObject;
use Friendica\Util\DateTimeFormat;
use Friendica\Util\Proxy;
@ -94,10 +95,22 @@ class FormattedNavNotification extends BaseFactory
);
}
/**
* @param Entity\Notification $notification
* @return ValueObject\FormattedNavNotification
* @throws NoMessageException
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
* @throws \Friendica\Network\HTTPException\NotFoundException
* @throws \Friendica\Network\HTTPException\ServiceUnavailableException
*/
public function createFromNotification(Entity\Notification $notification): ValueObject\FormattedNavNotification
{
$message = $this->notification->getMessageFromNotification($notification);
if (empty($message)) {
throw new NoMessageException();
}
if (!isset(self::$contacts[$notification->actorId])) {
self::$contacts[$notification->actorId] = Contact::getById($notification->actorId, ['name', 'url']);
}