made exceptions from the db optional

set address for updae mails correctly

boot.php

@@ -515,7 +515,8 @@ class App {
 	}
 
 
-}}
+}
+}
 
 // retrieve the App structure
 // useful in functions which require it but don't get it passed to them
@@ -524,7 +525,8 @@ if(! function_exists('get_app')) {
 	function get_app() {
 		global $a;
 		return $a;
-}};
+	}
+};
 
 
 // Multi-purpose function to check variable state.
@@ -552,7 +554,8 @@ function x($s,$k = NULL) {
 			}
 			return false;
 		}
-}}
+	}
+}
 
 // called from db initialisation if db is dead.
 
@@ -561,7 +564,8 @@ function system_unavailable() {
 		include('system_unavailable.php');
 		system_down();
 		killme();
-}}
+	}
+}
 
 
 
@@ -654,6 +658,7 @@ function check_config(&$a) {
 							// call the specific update
 
 							global $db;
+							$db->excep(TRUE);
 							try {
 								$db->beginTransaction();
 								$func = 'update_' . $x;
@@ -670,14 +675,14 @@ function check_config(&$a) {
 										'$error' => $ex->getMessage());
 								$subject=sprintf(t('Update Error at %s'), $a->get_baseurl());
 									
-							mail($email, $subject, $text, 
+								mail($a->config['admin_email'], $subject, $text,
 										'From: ' . t('Administrator') . '@' . $_SERVER['SERVER_NAME'] . "\n"
 										. 'Content-type: text/plain; charset=UTF-8' . "\n"
 										. 'Content-transfer-encoding: 8bit' );
 								//try the logger
 								logger('update failed: '.$ex->getMessage().EOL);
 							}
-						
+							$db->excep(FALSE);
 						}
 					}
 					set_config('system','build', DB_UPDATE_VERSION);
@@ -737,7 +742,8 @@ function check_config(&$a) {
 		load_hooks();
 
 		return;
-}}
+	}
+}
 
 
 function get_guid($size=16) {
@@ -805,7 +811,8 @@ function login($register = false, $hiddens=false) {
 		call_hooks('login_hook',$o);
 
 		return $o;
-}}
+	}
+}
 
 // Used to end the current process, after saving session state.
 
@@ -813,7 +820,8 @@ if(! function_exists('killme')) {
 	function killme() {
 		session_write_close();
 		exit;
-}}
+	}
+}
 
 // redirect to another URL and terminate this process.
 
@@ -821,7 +829,8 @@ if(! function_exists('goaway')) {
 	function goaway($s) {
 		header("Location: $s");
 		killme();
-}}
+	}
+}
 
 
 // Returns the uid of locally logged in user or false.
@@ -831,7 +840,8 @@ function local_user() {
 		if((x($_SESSION,'authenticated')) && (x($_SESSION,'uid')))
 			return intval($_SESSION['uid']);
 		return false;
-}}
+	}
+}
 
 // Returns contact id of authenticated site visitor or false
 
@@ -840,7 +850,8 @@ function remote_user() {
 		if((x($_SESSION,'authenticated')) && (x($_SESSION,'visitor_id')))
 			return intval($_SESSION['visitor_id']);
 		return false;
-}}
+	}
+}
 
 // contents of $s are displayed prominently on the page the next time
 // a page is loaded. Usually used for errors or alerts.
@@ -851,14 +862,16 @@ function notice($s) {
 		if(! x($_SESSION,'sysmsg'))	$_SESSION['sysmsg'] = array();
 		if($a->interactive)
 			$_SESSION['sysmsg'][] = $s;
-}}
+	}
+}
 if(! function_exists('info')) {
 	function info($s) {
 		$a = get_app();
 		if(! x($_SESSION,'sysmsg_info')) $_SESSION['sysmsg_info'] = array();
 		if($a->interactive)
 			$_SESSION['sysmsg_info'][] = $s;
-}}
+	}
+}
 
 
 // wrapper around config to limit the text length of an incoming message
@@ -867,7 +880,8 @@ if(! function_exists('get_max_import_size')) {
 	function get_max_import_size() {
 		global $a;
 		return ((x($a->config,'max_import_size')) ? $a->config['max_import_size'] : 0 );
-}}
+	}
+}
 
 
 
@@ -969,7 +983,8 @@ function profile_load(&$a, $nickname, $profile = 0) {
 		 $a->page['aside'] .= contact_block();*/
 
 		return;
-}}
+	}
+}
 
 
 /**
@@ -1118,7 +1133,8 @@ function profile_sidebar($profile, $block = 0) {
 		call_hooks('profile_sidebar', $arr);
 
 		return $o;
-}}
+	}
+}
 
 
 if(! function_exists('get_birthdays')) {
@@ -1187,7 +1203,8 @@ function get_birthdays() {
 			}
 		}
 		return $o;
-}}
+	}
+}
 
 
 if(! function_exists('get_events')) {
@@ -1251,7 +1268,8 @@ function get_events() {
 		}
 
 		return $o;
-}}
+	}
+}
 
 
 /**
@@ -1287,7 +1305,8 @@ function proc_run($cmd){
 		}
 		$cmdline = implode($args," ");
 		proc_close(proc_open($cmdline." &",array(),$foo));
-}}
+	}
+}
 
 if(! function_exists('current_theme')) {
 	function current_theme(){
@@ -1313,7 +1332,8 @@ function current_theme(){
 		if(count($fallback))
 			return (str_replace('view/theme/','', substr($fallback[0],0,-10)));
 
-}}
+	}
+}
 
 /*
  * Return full URL to theme which is currently in effect.
@@ -1326,7 +1346,8 @@ function current_theme_url() {
 		if (file_exists('view/theme/' . $t . '/style.php'))
 			return($a->get_baseurl() . '/view/theme/' . $t . '/style.pcss');
 		return($a->get_baseurl() . '/view/theme/' . $t . '/style.css');
-}}
+	}
+}
 
 if(! function_exists('feed_birthday')) {
 	function feed_birthday($uid,$tz) {
@@ -1374,7 +1395,8 @@ function feed_birthday($uid,$tz) {
 		}
 
 		return $birthday;
-}}
+	}
+}
 
 if(! function_exists('is_site_admin')) {
 	function is_site_admin() {
@@ -1382,7 +1404,8 @@ function is_site_admin() {
 		if(local_user() && x($a->user,'email') && x($a->config,'admin_email') && ($a->user['email'] === $a->config['admin_email']))
 			return true;
 		return false;
-}}
+	}
+}
 
 
 if(! function_exists('load_contact_links')) {
@@ -1408,7 +1431,8 @@ function load_contact_links($uid) {
 			$ret['empty'] = true;
 		$a->contacts = $ret;
 		return;
-}}
+	}
+}
 
 if(! function_exists('profile_tabs')){
 	function profile_tabs($a, $is_owner=False, $nickname=Null){
@@ -1460,7 +1484,8 @@ function profile_tabs($a, $is_owner=False, $nickname=Null){
 		$tpl = get_markup_template('common_tabs.tpl');
 
 		return replace_macros($tpl,array('$tabs' => $arr['tabs']));
-}}	
+	}
+}
 
 function get_my_url() {
 	if(x($_SESSION,'my_url'))

include/dba.php

@@ -21,6 +21,8 @@ if(! class_exists('dba')) {
 
 		private $debug = 0;
 		private $db;
+		private $exceptions; 
+		
 		public  $mysqli = true;
 		public  $connected = false;
 		public  $error = false;
@@ -68,6 +70,10 @@ if(! class_exists('dba')) {
 			}
 		}
 
+		public function excep($excep) {
+			$this->exceptions=$excep; 
+		}
+		
 		public function getdb() {
 			return $this->db;
 		}
@@ -75,7 +81,8 @@ if(! class_exists('dba')) {
 		public function q($sql) {
 
 			if((! $this->db) || (! $this->connected)) {
-				throw new RuntimeException(t("There is no db connection. "));
+				throwOrLog(new RuntimeException(t("There is no db connection. ")));
+				return;
 			}
 
 			if($this->mysqli) {
@@ -114,7 +121,8 @@ if(! class_exists('dba')) {
 				}
 				logger('dba: ' . $str );
 				if(FALSE===$result) {
-					throw new RuntimeException('dba: ' . $str);
+					throwOrLog(new RuntimeException('dba: ' . $str));
+					return; 
 				}
 			}
 				
@@ -155,6 +163,19 @@ if(! class_exists('dba')) {
 			}
 		}
 		
+		private function throwOrLog(Exception $ex) {
+			if($this->exceptions) {
+				throw $ex; 
+			} else {
+				logger('dba: '.$ex->getMessage()); 
+			}
+		}
+		
+		/**
+		 * starts a transaction. Transactions need to be finished with 
+		 * commit() or rollback(). Please mind that the db table engine may
+		 * not support this. 
+		 */
 		public function beginTransaction() {
 			if($this->mysqli) {
 				return $this->db->autocommit(false);
@@ -164,6 +185,10 @@ if(! class_exists('dba')) {
 			}
 		}
 		
+		/**
+		 * rollback a transaction. So, rollback anything that was done since the last call 
+		 * to beginTransaction(). 
+		 */
 		public function rollback() {
 			if($this->mysqli) {
 				return $this->db->rollback();
@@ -174,6 +199,9 @@ if(! class_exists('dba')) {
 			$this->stopTransaction(); 
 		}
 
+		/**
+		 * commit a transaction. So, write any query to the database. 
+		 */
 		public function commit() {
 			if($this->mysqli) {
 				return $this->db->commit();

index.php

@@ -11,7 +11,6 @@
  * bootstrap the application
  *
  */
-try {
 
 require_once('boot.php');
 
@@ -371,9 +370,3 @@ else
 
 session_write_close();
 exit;
-} catch(Exception $ex) {
-// it may fail because logger uses the db, 
-// but give it a try: 
-logger('exception caught at index.php: '.$ex->getMessage()); 
-system_unavailable(); 
-}