Make BaseModule a real entity

- Add all dependencies, necessary to run the content (baseUrl, Arguments)
- Encapsulate all POST/GET/DELETE/PATCH/PUT methods as protected methods inside the BaseModule
- Return Module content ONLY per `BaseModule::run()` (including the Hook logic there as well)
This commit is contained in:
Philipp 2021-11-20 15:38:03 +01:00
parent 238613fd01
commit 8bdd90066f
No known key found for this signature in database
GPG key ID: 24A7501396EB5432
252 changed files with 615 additions and 623 deletions

View file

@ -33,7 +33,7 @@ use Friendica\Util\XML;
*/
class RemoveTag extends BaseModule
{
public function content(): string
protected function content(array $request = []): string
{
if (!local_user()) {
throw new HTTPException\ForbiddenException();

View file

@ -21,13 +21,14 @@
namespace Friendica\Module\Filer;
use Friendica\App\BaseURL;
use Friendica\App;
use Friendica\BaseModule;
use Friendica\Core\L10n;
use Friendica\Core\Renderer;
use Friendica\Database\DBA;
use Friendica\Model;
use Friendica\Network\HTTPException;
use Friendica\Util\Profiler;
use Friendica\Util\XML;
use Psr\Log\LoggerInterface;
@ -36,22 +37,17 @@ use Psr\Log\LoggerInterface;
*/
class SaveTag extends BaseModule
{
/** @var LoggerInterface */
protected $logger;
public function __construct(LoggerInterface $logger, BaseURL $baseUrl, L10n $l10n, array $parameters = [])
public function __construct(L10n $l10n, App\BaseURL $baseUrl, App\Arguments $args, LoggerInterface $logger, Profiler $profiler, array $server, array $parameters = [])
{
parent::__construct($l10n, $parameters);
$this->logger = $logger;
parent::__construct($l10n, $baseUrl, $args, $logger, $profiler, $server, $parameters);
if (!local_user()) {
notice($this->t('You must be logged in to use this module'));
$baseUrl->redirect();
}
}
public function rawContent()
protected function rawContent(array $request = [])
{
$term = XML::unescape(trim($_GET['term'] ?? ''));