Changes after review

This commit is contained in:
Michael 2022-12-31 16:20:18 +00:00
parent f022a49f9e
commit 8e397b5849
9 changed files with 38 additions and 38 deletions

View file

@ -43,7 +43,7 @@ class BulkDelivery
$delivery_failure = true;
if (!$server_failure) {
$server_failure = !GServer::reachableById($gsid);
$server_failure = !GServer::isReachableById($gsid);
}
Logger::debug('Delivery failed', ['server_failure' => $server_failure, 'post' => $post]);
}

View file

@ -568,9 +568,9 @@ class Notifier
if (empty($contact['gsid'])) {
$reachable = !GServer::reachable($contact);
} elseif (!DI::config()->get('system', 'bulk_delivery')) {
$reachable = !GServer::reachableById($contact['gsid']);
$reachable = !GServer::isReachableById($contact['gsid']);
} else {
$reachable = !GServer::defunct($contact['gsid']);
$reachable = !GServer::isDefunctById($contact['gsid']);
}
if (!$reachable) {

View file

@ -43,18 +43,18 @@ class UpdateGServer
$filtered = filter_var($server_url, FILTER_SANITIZE_URL);
if (substr(Strings::normaliseLink($filtered), 0, 7) != 'http://') {
GServer::setFailure($server_url);
GServer::setFailureByUrl($server_url);
return;
}
if (($filtered != $server_url) && DBA::exists('gserver', ['nurl' => Strings::normaliseLink($server_url)])) {
GServer::setFailure($server_url);
GServer::setFailureByUrl($server_url);
return;
}
$cleaned = GServer::cleanURL($server_url);
if (($cleaned != $server_url) && DBA::exists('gserver', ['nurl' => Strings::normaliseLink($server_url)])) {
GServer::setFailure($server_url);
GServer::setFailureByUrl($server_url);
return;
}