Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2025-04-25 14:30:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
This commit is contained in:
Philipp 2022-12-29 22:12:02 +01:00 • committed by GitHub
parent 965caf98a5
commit 925c30280c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Core/KeyValueStorage/Type/DBKeyValueStorage.php
View file

@ -104,9 +104,7 @@ class DBKeyValueStorage extends AbstractKeyValueStorage
public function offsetUnset($offset) public function offsetUnset($offset)
{ {
try { try {
$return = $this->database->delete(self::DB_KEY_VALUE_TABLE, ['k' => $offset]); if (!$this->database->delete(self::DB_KEY_VALUE_TABLE, ['k' => $offset])) {
if (!$return) {
throw new \Exception(sprintf('database deletion failed: %s', $this->database->errorMessage())); throw new \Exception(sprintf('database deletion failed: %s', $this->database->errorMessage()));
} }
} catch (\Exception $exception) { } catch (\Exception $exception) {

2
src/Module/Admin/Summary.php
View file

@ -98,7 +98,7 @@ class Summary extends BaseAdmin
$warningtext[] = DI::l10n()->t('The last update failed. Please run "php bin/console.php dbstructure update" from the command line and have a look at the errors that might appear. (Some of the errors are possibly inside the logfile.)'); $warningtext[] = DI::l10n()->t('The last update failed. Please run "php bin/console.php dbstructure update" from the command line and have a look at the errors that might appear. (Some of the errors are possibly inside the logfile.)');
} }
$last_worker_call = DI::keyValue()->get('last_worker_execution') ?? false; $last_worker_call = DI::keyValue()->get('last_worker_execution');
if (!$last_worker_call) { if (!$last_worker_call) {
$warningtext[] = DI::l10n()->t('The worker was never executed. Please check your database structure!'); $warningtext[] = DI::l10n()->t('The worker was never executed. Please check your database structure!');
} elseif ((strtotime(DateTimeFormat::utcNow()) - strtotime($last_worker_call)) > 60 * 60) { } elseif ((strtotime(DateTimeFormat::utcNow()) - strtotime($last_worker_call)) > 60 * 60) {