New class for external resources

src/Model/Storage/ExternalResource.php

@@ -0,0 +1,99 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2021, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Model\Storage;
+
+use \BadMethodCallException;
+use Friendica\DI;
+
+/**
+ * External resource storage class
+ *
+ * This class is used to load external resources, like images.
+ * Is not intended to be selectable by admins as default storage class.
+ */
+class ExternalResource implements IStorage
+{
+	const NAME = 'ExternalResource';
+
+	/**
+	 * @inheritDoc
+	 */
+	public function get(string $filename)
+	{
+		$parts = parse_url($filename);
+		if (empty($parts['scheme']) || empty($parts['host'])) {
+			return "";
+		}
+
+		$curlResult = DI::httpRequest()->get($filename);
+		if ($curlResult->isSuccess()) {
+			return $curlResult->getBody();
+		} else {
+			return "";
+		}
+	}
+
+	/**
+	 * @inheritDoc
+	 */
+	public function put(string $data, string $filename = '')
+	{
+		throw new BadMethodCallException();
+	}
+
+	public function delete(string $filename)
+	{
+		throw new BadMethodCallException();
+	}
+
+	/**
+	 * @inheritDoc
+	 */
+	public function getOptions()
+	{
+		return [];
+	}
+
+	/**
+	 * @inheritDoc
+	 */
+	public function saveOptions(array $data)
+	{
+		return [];
+	}
+
+	/**
+	 * @inheritDoc
+	 */
+	public function __toString()
+	{
+		return self::NAME;
+	}
+
+	/**
+	 * @inheritDoc
+	 */
+	public static function getName()
+	{
+		return self::NAME;
+	}
+}

src/Model/Storage/SystemResource.php

@@ -22,7 +22,6 @@
 namespace Friendica\Model\Storage;
 
 use \BadMethodCallException;
-use Friendica\DI;
 
 /**
  * System resource storage class
@@ -42,16 +41,6 @@ class SystemResource implements IStorage
 	 */
 	public function get(string $filename)
 	{
-		$parts = parse_url($filename);
-		if (!empty($parts['scheme']) && !empty($parts['host'])) {
-			$curlResult = DI::httpRequest()->get($filename);
-			if ($curlResult->isSuccess()) {
-				return $curlResult->getBody();
-			} else {
-				return "";
-			}
-		}
-
 		$folder = dirname($filename);
 		if (!in_array($folder, self::VALID_FOLDERS)) {
 			return "";