Merge pull request #14581 from Art4/phpstan-level-1-in-addons

PHPStan level 1 in addons
This commit is contained in:
Hypolite Petovan 2024-12-13 07:46:21 -05:00 committed by GitHub
commit 955c8a18f0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 247 additions and 244 deletions

View file

@ -3,7 +3,7 @@
# SPDX-License-Identifier: CC0-1.0 # SPDX-License-Identifier: CC0-1.0
parameters: parameters:
level: 0 level: 1
paths: paths:
- addon/ - addon/
@ -13,6 +13,7 @@ parameters:
analyse: analyse:
- addon/*/lang/* - addon/*/lang/*
- addon/*/vendor/* - addon/*/vendor/*
- addon/pumpio/oauth/*
scanDirectories: scanDirectories:
- mod - mod

View file

@ -174,27 +174,24 @@ class Actor
return $contact; return $contact;
} }
if (empty($contact)) { $fields = [
$fields = [ 'uid' => $contact_uid,
'uid' => $contact_uid, 'network' => Protocol::BLUESKY,
'network' => Protocol::BLUESKY, 'priority' => 1,
'priority' => 1, 'writable' => true,
'writable' => true, 'blocked' => false,
'blocked' => false, 'readonly' => false,
'readonly' => false, 'pending' => false,
'pending' => false, 'url' => $did,
'url' => $did, 'nurl' => $did,
'nurl' => $did, 'alias' => ATProtocol::WEB . '/profile/' . $did,
'alias' => ATProtocol::WEB . '/profile/' . $did, 'name' => $did,
'name' => $did, 'nick' => $did,
'nick' => $did, 'addr' => $did,
'addr' => $did, 'rel' => Contact::NOTHING,
'rel' => Contact::NOTHING, ];
];
$cid = Contact::insert($fields); $cid = Contact::insert($fields);
} else {
$cid = $contact['id'];
}
$this->updateContactByDID($did); $this->updateContactByDID($did);

View file

@ -125,6 +125,8 @@ class Processor
public function createPost(stdClass $data, array $uids, bool $dont_fetch) public function createPost(stdClass $data, array $uids, bool $dont_fetch)
{ {
$parent = '';
if (!empty($data->commit->record->reply)) { if (!empty($data->commit->record->reply)) {
$root = $this->getUri($data->commit->record->reply->root); $root = $this->getUri($data->commit->record->reply->root);
$parent = $this->getUri($data->commit->record->reply->parent); $parent = $this->getUri($data->commit->record->reply->parent);
@ -166,7 +168,7 @@ class Processor
return; return;
} }
} }
$item = $this->addMedia($post->thread->post->embed, $item, 0, 0, 0); $item = $this->addMedia($post->thread->post->embed, $item, 0);
} }
$id = Item::insert($item); $id = Item::insert($item);
@ -295,7 +297,7 @@ class Processor
} }
if (!empty($post->embed)) { if (!empty($post->embed)) {
$item = $this->addMedia($post->embed, $item, $uid, $level); $item = $this->addMedia($post->embed, $item, $level);
} }
$item['restrictions'] = $this->getRestrictionsForUser($post, $item, $post_reason); $item['restrictions'] = $this->getRestrictionsForUser($post, $item, $post_reason);
@ -819,7 +821,7 @@ class Processor
} }
$elements = explode(':', $uri); $elements = explode(':', $uri);
if (empty($elements) || ($elements[0] != 'at')) { if ($elements[0] !== 'at') {
$post = Post::selectFirstPost(['extid'], ['uri' => $uri]); $post = Post::selectFirstPost(['extid'], ['uri' => $uri]);
return $this->getUriClass($post['extid'] ?? ''); return $this->getUriClass($post['extid'] ?? '');
} }

File diff suppressed because it is too large Load diff