API: The legacy API finally moved

src/Content/Text/BBCode.php

@@ -1134,7 +1134,7 @@ class BBCode
 		switch ($simplehtml) {
 			case self::API:
 				$text = ($is_quote_share? '<br>' : '') .
-				'<b><a href="' . $attributes['link'] . '">' . html_entity_decode('&#x2672; ', ENT_QUOTES, 'UTF-8') . ' ' . $author_contact['addr'] . "</a>:</b><br>\n" .
+				'<b><a href="' . $attributes['link'] . '">' . html_entity_decode('&#x2672;', ENT_QUOTES, 'UTF-8') . ' ' . $author_contact['addr'] . "</a>:</b><br>\n" .
 				'<blockquote class="shared_content">' . $content . '</blockquote>';
 				break;
 			case self::DIASPORA:

src/DI.php

@@ -270,6 +270,22 @@ abstract class DI
 		return self::$dice->create(Factory\Api\Friendica\Activities::class);
 	}
 
+	/**
+	 * @return Factory\Api\Friendica\Group
+	 */
+	public static function friendicaGroup()
+	{
+		return self::$dice->create(Factory\Api\Friendica\Group::class);
+	}
+
+	/**
+	 * @return Factory\Api\Friendica\Photo
+	 */
+	public static function friendicaPhoto()
+	{
+		return self::$dice->create(Factory\Api\Friendica\Photo::class);
+	}
+
 	/**
 	 * @return Factory\Api\Mastodon\Account
 	 */

src/Factory/Api/Friendica/Group.php

@@ -0,0 +1,59 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Factory\Api\Friendica;
+
+use Friendica\BaseFactory;
+use Friendica\Database\DBA;
+use Friendica\Network\HTTPException;
+use Psr\Log\LoggerInterface;
+use Friendica\Factory\Api\Twitter\User as TwitterUser;
+
+class Group extends BaseFactory
+{
+	/** @var twitterUser entity */
+	private $twitterUser;
+
+	public function __construct(LoggerInterface $logger, TwitterUser $twitteruser)
+	{
+		parent::__construct($logger);
+
+		$this->twitterUser = $twitteruser;
+	}
+
+	/**
+	 * @param int $id id of the group
+	 * @return array
+	 * @throws HTTPException\InternalServerErrorException
+	 */
+	public function createFromId(int $id): array
+	{
+		$group = DBA::selectFirst('group', [], ['id' => $id, 'deleted' => false]);
+		if (empty($group)) {
+			return [];
+		}
+
+		$user   = $this->twitterUser->createFromUserId($group['uid'])->toArray();
+		$object = new \Friendica\Object\Api\Friendica\Group($group, $user);
+
+		return $object->toArray();
+	}
+}

src/Factory/Api/Friendica/Photo.php

@@ -0,0 +1,154 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Factory\Api\Friendica;
+
+use Friendica\App\BaseURL;
+use Friendica\BaseFactory;
+use Friendica\Database\DBA;
+use Friendica\Factory\Api\Twitter\Status;
+use Friendica\Model\Photo as ModelPhoto;
+use Friendica\Model\Post;
+use Friendica\Network\HTTPException;
+use Psr\Log\LoggerInterface;
+use Friendica\Util\Images;
+
+class Photo extends BaseFactory
+{
+	/** @var BaseURL */
+	private $baseUrl;
+	/** @var Status */
+	private $status;
+	/** @var Activities */
+	private $activities;
+
+	public function __construct(LoggerInterface $logger, BaseURL $baseURL, Status $status, Activities $activities)
+	{
+		parent::__construct($logger);
+
+		$this->activities = $activities;
+		$this->status     = $status;
+		$this->baseUrl    = $baseURL;
+	}
+
+	/**
+	 * @param string $photo_id
+	 * @param int    $scale
+	 * @param int    $uid
+	 * @param string $type
+	 * @return Array
+	 */
+	public function createFromId(string $photo_id, int $scale = null, int $uid, string $type = 'json', bool $with_posts = true): array
+	{
+		$fields = ['resource-id', 'created', 'edited', 'title', 'desc', 'album', 'filename','type',
+		'height', 'width', 'datasize', 'profile', 'allow_cid', 'deny_cid', 'allow_gid', 'deny_gid',
+		'backend-class', 'backend-ref', 'id', 'scale'];
+
+		$condition = ['uid' => $uid, 'resource-id' => $photo_id];
+		if (is_int($scale)) {
+			$fields = array_merge(['data'], $fields);
+			$condition['scale'] = $scale;
+		}
+
+		$photos = ModelPhoto::selectToArray($fields, $condition);
+		if (empty($photos)) {
+			throw new HTTPException\NotFoundException();
+		}
+		$data = $photos[0];
+		$data['id'] = $data['resource-id'];
+		if (is_int($scale)) {
+			$data['data'] = base64_encode(ModelPhoto::getImageDataForPhoto($data));
+		} else {
+			unset($data['datasize']); //needed only with scale param
+		}
+
+		if ($type == 'xml') {
+			$data['links'] = [];
+		} else {
+			$data['link'] = [];
+		}
+
+		foreach ($photos as $id => $photo) {
+			$link = $this->baseUrl->get() . '/photo/' . $data['resource-id'] . '-' . $photo['scale'] . Images::getExtensionByMimeType($data['type']);
+			if ($type == 'xml') {
+				$data['links'][$photo['scale'] . ':link']['@attributes'] = [
+					'type' => $data['type'],
+					'scale' => $photo['scale'],
+					'href' => $link
+				];
+			} else {
+				$data['link'][$id] = $link;
+			}
+		}
+
+		unset($data['backend-class']);
+		unset($data['backend-ref']);
+		unset($data['resource-id']);
+		unset($data['scale']);
+	
+		if ($with_posts) {
+			// retrieve item element for getting activities (like, dislike etc.) related to photo
+			$condition = ['uid' => $uid, 'resource-id' => $photo_id];
+			$item = Post::selectFirst(['id', 'uid', 'uri', 'uri-id', 'parent', 'allow_cid', 'deny_cid', 'allow_gid', 'deny_gid'], $condition);
+		}
+		if (!empty($item)) {
+			$data['friendica_activities'] = $this->activities->createFromUriId($item['uri-id'], $item['uid'], $type);
+	
+			// retrieve comments on photo
+			$condition = ["`parent` = ? AND `uid` = ? AND `gravity` IN (?, ?)",
+				$item['parent'], $uid, GRAVITY_PARENT, GRAVITY_COMMENT];
+		
+			$statuses = Post::selectForUser($uid, [], $condition);
+		
+			// prepare output of comments
+			$commentData = [];
+			while ($status = DBA::fetch($statuses)) {
+				$commentData[] = $this->status->createFromUriId($status['uri-id'], $status['uid'])->toArray();
+			}
+			DBA::close($statuses);
+		
+			$comments = [];
+			if ($type == 'xml') {
+				$k = 0;
+				foreach ($commentData as $comment) {
+					$comments[$k++ . ':comment'] = $comment;
+				}
+			} else {
+				foreach ($commentData as $comment) {
+					$comments[] = $comment;
+				}
+			}
+			$data['friendica_comments'] = $comments;
+		
+			// include info if rights on photo and rights on item are mismatching
+			$data['rights_mismatch'] = $data['allow_cid'] != $item['allow_cid'] ||
+				$data['deny_cid'] != $item['deny_cid'] ||
+				$data['allow_gid'] != $item['allow_gid'] ||
+				$data['deny_gid'] != $item['deny_gid'];
+		} elseif ($with_posts) {
+			$data['friendica_activities'] = [];
+			$data['friendica_comments']   = [];
+			$data['rights_mismatch'] = false;
+		}
+	
+		return $data;
+	}
+}

src/Module/Api/Friendica/Group/Create.php

@@ -0,0 +1,87 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Friendica\Group;
+
+use Friendica\Database\DBA;
+use Friendica\Model\Group;
+use Friendica\Module\BaseApi;
+use Friendica\Network\HTTPException;
+
+/**
+ * API endpoint: /api/friendica/group_create
+ */
+class Create extends BaseApi
+{
+	protected function post(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_WRITE);
+		$uid = BaseApi::getCurrentUserID();
+	
+		// params
+		$name = $_REQUEST['name'] ?? '';
+		$json = json_decode($_POST['json'], true);
+		$users = $json['user'];
+	
+		// error if no name specified
+		if ($name == '') {
+			throw new HTTPException\BadRequestException('group name not specified');
+		}
+	
+		// error message if specified group name already exists
+		if (DBA::exists('group', ['uid' => $uid, 'name' => $name, 'deleted' => false])) {
+			throw new HTTPException\BadRequestException('group name already exists');
+		}
+	
+		// Check if the group needs to be reactivated
+		if (DBA::exists('group', ['uid' => $uid, 'name' => $name, 'deleted' => true])) {
+			$reactivate_group = true;
+		}
+	
+		// create group
+		$ret = Group::create($uid, $name);
+		if ($ret) {
+			$gid = Group::getIdByName($uid, $name);
+		} else {
+			throw new HTTPException\BadRequestException('other API error');
+		}
+	
+		// add members
+		$erroraddinguser = false;
+		$errorusers = [];
+		foreach ($users as $user) {
+			$cid = $user['cid'];
+			if (DBA::exists('contact', ['id' => $cid, 'uid' => $uid])) {
+				Group::addMember($gid, $cid);
+			} else {
+				$erroraddinguser = true;
+				$errorusers[] = $cid;
+			}
+		}
+	
+		// return success message incl. missing users in array
+		$status = ($erroraddinguser ? 'missing user' : ((isset($reactivate_group) && $reactivate_group) ? 'reactivated' : 'ok'));
+	
+		$result = ['success' => true, 'gid' => $gid, 'name' => $name, 'status' => $status, 'wrong users' => $errorusers];
+		
+		$this->response->exit('group_create', ['$result' => $result], $this->parameters['extension'] ?? null);
+	}
+}

src/Module/Api/Friendica/Group/Show.php

@@ -0,0 +1,81 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Friendica\Group;
+
+use Friendica\Database\DBA;
+use Friendica\DI;
+use Friendica\Model\Contact;
+use Friendica\Module\BaseApi;
+use Friendica\Network\HTTPException;
+
+/**
+ * API endpoint: /api/friendica/group_show
+ */
+class Show extends BaseApi
+{
+	protected function post(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_READ);
+		$uid  = BaseApi::getCurrentUserID();
+		$type = $this->parameters['extension'] ?? '';
+	
+		// params
+		$gid = $_REQUEST['gid'] ?? 0;
+	
+		// get data of the specified group id or all groups if not specified
+		if ($gid != 0) {
+			$groups = DBA::selectToArray('group', [], ['deleted' => false, 'uid' => $uid, 'id' => $gid]);
+	
+			// error message if specified gid is not in database
+			if (!DBA::isResult($groups)) {
+				throw new HTTPException\BadRequestException('gid not available');
+			}
+		} else {
+			$groups = DBA::selectToArray('group', [], ['deleted' => false, 'uid' => $uid]);
+		}
+	
+		// loop through all groups and retrieve all members for adding data in the user array
+		$grps = [];
+		foreach ($groups as $rr) {
+			$members = Contact\Group::getById($rr['id']);
+			$users = [];
+	
+			if ($type == 'xml') {
+				$user_element = 'users';
+				$k = 0;
+				foreach ($members as $member) {
+					$user = DI::twitterUser()->createFromContactId($member['contact-id'], $uid, true)->toArray();
+					$users[$k++.':user'] = $user;
+				}
+			} else {
+				$user_element = 'user';
+				foreach ($members as $member) {
+					$user = DI::twitterUser()->createFromContactId($member['contact-id'], $uid, true)->toArray();
+					$users[] = $user;
+				}
+			}
+			$grps[] = ['name' => $rr['name'], 'gid' => $rr['id'], $user_element => $users];
+		}
+
+		$this->response->exit('group_update', ['group' => $grps], $this->parameters['extension'] ?? null);
+	}
+}

src/Module/Api/Friendica/Photo.php

@@ -0,0 +1,49 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Friendica;
+
+use Friendica\DI;
+use Friendica\Model\Contact;
+use Friendica\Module\BaseApi;
+use Friendica\Network\HTTPException;
+
+class Activity extends BaseApi
+{
+	protected function post(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_READ);
+		$uid  = BaseApi::getCurrentUserID();
+		$type = $this->parameters['extension'] ?? '';
+
+		if (empty($_REQUEST['photo_id'])) {
+			throw new HTTPException\BadRequestException('No photo id.');
+		}
+	
+		$scale = (!empty($_REQUEST['scale']) ? intval($_REQUEST['scale']) : false);
+		$photo_id = $_REQUEST['photo_id'];
+	
+		// prepare json/xml output with data from database for the requested photo
+		$data = ['photo' => DI::friendicaPhoto()->createFromId($photo_id, $scale, $uid, $type)];
+	
+		$this->response->exit('statuses', $data, $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
+	}
+}

src/Module/Api/Friendica/Photo/Create.php

@@ -0,0 +1,82 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Friendica\Photo;
+
+use Friendica\Core\ACL;
+use Friendica\DI;
+use Friendica\Model\Photo;
+use Friendica\Module\BaseApi;
+use Friendica\Network\HTTPException;
+
+/**
+ * API endpoint: /api/friendica/photo/create
+ */
+class Create extends BaseApi
+{
+	protected function post(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_WRITE);
+		$uid  = BaseApi::getCurrentUserID();
+		$type = $this->parameters['extension'] ?? '';
+
+		// input params
+		$desc      = $_REQUEST['desc']      ?? null;
+		$album     = $_REQUEST['album']     ?? null;
+		$allow_cid = $_REQUEST['allow_cid'] ?? null;
+		$deny_cid  = $_REQUEST['deny_cid' ] ?? null;
+		$allow_gid = $_REQUEST['allow_gid'] ?? null;
+		$deny_gid  = $_REQUEST['deny_gid' ] ?? null;
+	
+		// do several checks on input parameters
+		// we do not allow calls without album string
+		if ($album == null) {
+			throw new HTTPException\BadRequestException('no albumname specified');
+		}
+	
+		// error if no media posted in create-mode
+		if (empty($_FILES['media'])) {
+			// Output error
+			throw new HTTPException\BadRequestException('no media data submitted');
+		}
+	
+		// checks on acl strings provided by clients
+		$acl_input_error = false;
+		$acl_input_error |= !ACL::isValidContact($allow_cid, $uid);
+		$acl_input_error |= !ACL::isValidContact($deny_cid, $uid);
+		$acl_input_error |= !ACL::isValidGroup($allow_gid, $uid);
+		$acl_input_error |= !ACL::isValidGroup($deny_gid, $uid);
+		if ($acl_input_error) {
+			throw new HTTPException\BadRequestException('acl data invalid');
+		}
+		// now let's upload the new media in create-mode
+		$photo = Photo::upload($uid, $_FILES['media'], $album, trim($allow_cid), trim($allow_gid), trim($deny_cid), trim($deny_gid), $desc);
+
+		// return success of updating or error message
+		if (!empty($photo)) {
+			$data = ['photo' => DI::friendicaPhoto()->createFromId($photo['resource_id'], null, $uid, $type)];
+			$this->response->exit('photo_create', $data, $this->parameters['extension'] ?? null);
+			return;
+		} else {
+			throw new HTTPException\InternalServerErrorException('unknown error - uploading photo failed, see Friendica log for more information');
+		}
+	}
+}

src/Module/Api/Friendica/Photo/Lists.php

@@ -0,0 +1,66 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Friendica\Photo;
+
+use Friendica\Database\DBA;
+use Friendica\DI;
+use Friendica\Module\BaseApi;
+use Friendica\Model\Contact;
+use Friendica\Model\Photo;
+
+/**
+ * Returns all lists the user subscribes to.
+ *
+ * @see https://developer.twitter.com/en/docs/accounts-and-users/create-manage-lists/api-reference/get-lists-list
+ */
+class Lists extends BaseApi
+{
+	protected function rawContent(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_READ);
+		$uid  = BaseApi::getCurrentUserID();
+		$type = $this->parameters['extension'] ?? '';
+
+		$photos = Photo::selectToArray(['resource-id'], ["`uid` = ? AND NOT `photo-type` IN (?, ?)", $uid, Photo::CONTACT_AVATAR, Photo::CONTACT_BANNER],
+			['order' => ['id'], 'group_by' => ['resource-id']]);
+	
+		$data = ['photo' => []];
+		if (DBA::isResult($photos)) {
+			foreach ($photos as $photo) {
+				$element = DI::friendicaPhoto()->createFromId($photo['resource-id'], null, $uid, 'json', false);
+	
+				$element['thumb'] = end($element['link']);
+				unset($element['link']);
+	
+				if ($type == 'xml') {
+					$thumb = $element['thumb'];
+					unset($element['thumb']);
+					$data['photo'][] = ['@attributes' => $element, '1' => $thumb];
+				} else {
+					$data['photo'][] = $element;
+				}
+			}
+		}
+
+		$this->response->exit('statuses', $data, $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
+	}
+}

src/Module/Api/Friendica/Photo/Update.php

@@ -0,0 +1,136 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Friendica\Photo;
+
+use Friendica\Core\ACL;
+use Friendica\DI;
+use Friendica\Model\Photo;
+use Friendica\Module\BaseApi;
+use Friendica\Network\HTTPException;
+
+/**
+ * API endpoint: /api/friendica/photo/update
+ */
+class Update extends BaseApi
+{
+	protected function post(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_WRITE);
+		$uid  = BaseApi::getCurrentUserID();
+		$type = $this->parameters['extension'] ?? '';
+	
+		// input params
+		$photo_id  = $_REQUEST['photo_id']  ?? null;
+		$desc      = $_REQUEST['desc']      ?? null;
+		$album     = $_REQUEST['album']     ?? null;
+		$album_new = $_REQUEST['album_new'] ?? null;
+		$allow_cid = $_REQUEST['allow_cid'] ?? null;
+		$deny_cid  = $_REQUEST['deny_cid' ] ?? null;
+		$allow_gid = $_REQUEST['allow_gid'] ?? null;
+		$deny_gid  = $_REQUEST['deny_gid' ] ?? null;
+	
+		// do several checks on input parameters
+		// we do not allow calls without album string
+		if ($album == null) {
+			throw new HTTPException\BadRequestException('no albumname specified');
+		}
+
+		// check if photo is existing in databasei
+		if (!Photo::exists(['resource-id' => $photo_id, 'uid' => $uid, 'album' => $album])) {
+			throw new HTTPException\BadRequestException('photo not available');
+		}
+	
+		// checks on acl strings provided by clients
+		$acl_input_error = false;
+		$acl_input_error |= !ACL::isValidContact($allow_cid, $uid);
+		$acl_input_error |= !ACL::isValidContact($deny_cid, $uid);
+		$acl_input_error |= !ACL::isValidGroup($allow_gid, $uid);
+		$acl_input_error |= !ACL::isValidGroup($deny_gid, $uid);
+		if ($acl_input_error) {
+			throw new HTTPException\BadRequestException('acl data invalid');
+		}
+	
+		$updated_fields = [];
+
+		if (!is_null($desc)) {
+			$updated_fields['desc'] = $desc;
+		}
+
+		if (!is_null($album_new)) {
+			$updated_fields['album'] = $album_new;
+		}
+
+		if (!is_null($allow_cid)) {
+			$allow_cid = trim($allow_cid);
+			$updated_fields['allow_cid'] = $allow_cid;
+		}
+
+		if (!is_null($deny_cid)) {
+			$deny_cid = trim($deny_cid);
+			$updated_fields['deny_cid'] = $deny_cid;
+		}
+
+		if (!is_null($allow_gid)) {
+			$allow_gid = trim($allow_gid);
+			$updated_fields['allow_gid'] = $allow_gid;
+		}
+
+		if (!is_null($deny_gid)) {
+			$deny_gid = trim($deny_gid);
+			$updated_fields['deny_gid'] = $deny_gid;
+		}
+
+		$result = false;
+		if (count($updated_fields) > 0) {
+			$nothingtodo = false;
+			$result = Photo::update($updated_fields, ['uid' => $uid, 'resource-id' => $photo_id, 'album' => $album]);
+		} else {
+			$nothingtodo = true;
+		}
+
+		if (!empty($_FILES['media'])) {
+			$nothingtodo = false;
+			$photo = Photo::upload($uid, $_FILES['media'], $album, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc, $photo_id);
+			if (!empty($photo)) {
+				$data = ['photo' => DI::friendicaPhoto()->createFromId($photo['resource_id'], null, $uid, $type)];
+				$this->response->exit('photo_update', $data, $this->parameters['extension'] ?? null);
+				return;
+			}
+		}
+
+		// return success of updating or error message
+		if ($result) {
+			$answer = ['result' => 'updated', 'message' => 'Image id `' . $photo_id . '` has been updated.'];
+			$this->response->exit('photo_update', ['$result' => $answer], $this->parameters['extension'] ?? null);
+			return;
+		} else {
+			if ($nothingtodo) {
+				$answer = ['result' => 'cancelled', 'message' => 'Nothing to update for image id `' . $photo_id . '`.'];
+				$this->response->exit('photo_update', ['$result' => $answer], $this->parameters['extension'] ?? null);
+				return;
+			}
+			throw new HTTPException\InternalServerErrorException('unknown error - update photo entry in database failed');
+		}
+
+		throw new HTTPException\InternalServerErrorException('unknown error - this error on uploading or updating a photo should never happen');
+	}
+}

src/Module/Api/Twitter/Account/UpdateProfileImage.php

@@ -0,0 +1,72 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Twitter\Account;
+
+use Friendica\Module\BaseApi;
+use Friendica\DI;
+use Friendica\Model\Photo;
+use Friendica\Network\HTTPException;
+
+/**
+ * updates the profile image for the user (either a specified profile or the default profile)
+ *
+ * @see https://developer.twitter.com/en/docs/accounts-and-users/manage-account-settings/api-reference/post-account-update_profile_image
+ */
+class UpdateProfileImage extends BaseApi
+{
+	protected function post(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_WRITE);
+		$uid = BaseApi::getCurrentUserID();
+	
+		// get mediadata from image or media (Twitter call api/account/update_profile_image provides image)
+		if (!empty($_FILES['image'])) {
+			$media = $_FILES['image'];
+		} elseif (!empty($_FILES['media'])) {
+			$media = $_FILES['media'];
+		}
+	
+		// error if image data is missing
+		if (empty($media)) {
+			throw new HTTPException\BadRequestException('no media data submitted');
+		}
+		
+		// save new profile image
+		$resource_id = Photo::uploadAvatar($uid, $media);
+		if (empty($resource_id)) {
+			throw new HTTPException\InternalServerErrorException('image upload failed');
+		}
+	
+		// output for client
+		$skip_status = $_REQUEST['skip_status'] ?? false;
+	
+		$user_info = DI::twitterUser()->createFromUserId($uid, $skip_status)->toArray();
+	
+		// "verified" isn't used here in the standard
+		unset($user_info['verified']);
+	
+		// "uid" is only needed for some internal stuff, so remove it from here
+		unset($user_info['uid']);
+	
+		$this->response->exit('user', ['user' => $user_info], $this->parameters['extension'] ?? null);
+	}
+}

src/Module/Api/Twitter/Lists/Create.php

@@ -0,0 +1,66 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Twitter\Lists;
+
+use Friendica\Database\DBA;
+use Friendica\DI;
+use Friendica\Module\BaseApi;
+use Friendica\Model\Contact;
+use Friendica\Model\Group;
+use Friendica\Network\HTTPException;
+
+/**
+ * Update information about a group.
+ *
+ * @see https://developer.twitter.com/en/docs/accounts-and-users/create-manage-lists/api-reference/post-lists-update
+ */
+class Create extends BaseApi
+{
+	protected function rawContent(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_WRITE);
+		$uid = BaseApi::getCurrentUserID();
+	
+		// params
+		$name = $_REQUEST['name'] ?? '';
+	
+		if ($name == '') {
+			throw new HTTPException\BadRequestException('group name not specified');
+		}
+	
+		// error message if specified group name already exists
+		if (DBA::exists('group', ['uid' => $uid, 'name' => $name, 'deleted' => false])) {
+			throw new HTTPException\BadRequestException('group name already exists');
+		}
+	
+		$ret = Group::create($uid, $name);
+		if ($ret) {
+			$gid = Group::getIdByName($uid, $name);
+		} else {
+			throw new HTTPException\BadRequestException('other API error');
+		}
+	
+		$grp = DI::friendicaGroup()->createFromId($gid);
+	
+		$this->response->exit('statuses', ['lists' => ['lists' => $grp]], $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
+	}
+}

src/Module/Api/Twitter/Lists/Destroy.php

@@ -0,0 +1,64 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Twitter\Lists;
+
+use Friendica\Database\DBA;
+use Friendica\DI;
+use Friendica\Module\BaseApi;
+use Friendica\Model\Contact;
+use Friendica\Model\Group;
+use Friendica\Network\HTTPException;
+
+/**
+ * Delete a group.
+ *
+ * @see https://developer.twitter.com/en/docs/accounts-and-users/create-manage-lists/api-reference/post-lists-destroy
+ */
+class Destroy extends BaseApi
+{
+	protected function rawContent(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_WRITE);
+		$uid = BaseApi::getCurrentUserID();
+	
+		// params
+		$gid = $_REQUEST['list_id'] ?? 0;
+	
+		// error if no gid specified
+		if ($gid == 0) {
+			throw new HTTPException\BadRequestException('gid not specified');
+		}
+	
+		// get data of the specified group id
+		$group = DBA::selectFirst('group', [], ['uid' => $uid, 'id' => $gid]);
+		// error message if specified gid is not in database
+		if (!$group) {
+			throw new HTTPException\BadRequestException('gid not available');
+		}
+	
+		$list = DI::friendicaGroup()->createFromId($gid);
+	
+		if (Group::remove($gid)) {
+			$this->response->exit('statuses', ['lists' => ['lists' => $list]], $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
+		}
+	}
+}

src/Module/Api/Twitter/Lists/Lists.php

@@ -19,32 +19,25 @@
  *
  */
 
-namespace Friendica\Module\Api\Friendica;
+namespace Friendica\Module\Api\Twitter\Lists;
 
-use Friendica\DI;
 use Friendica\Module\BaseApi;
-require_once __DIR__ . '/../../../../include/api.php';
+use Friendica\Model\Contact;
 
 /**
- * api/friendica
+ * Returns all lists the user subscribes to.
  *
- * @package Friendica\Module\Api\Friendica
+ * @see https://developer.twitter.com/en/docs/accounts-and-users/create-manage-lists/api-reference/get-lists-list
  */
-class Index extends BaseApi
+class Lists extends BaseApi
 {
-	protected function post(array $request = [])
-	{
-		self::checkAllowedScope(self::SCOPE_WRITE);		
-	}
-
-	protected function delete(array $request = [])
-	{
-		self::checkAllowedScope(self::SCOPE_WRITE);
-	}
-
 	protected function rawContent(array $request = [])
 	{
-		echo api_call(DI::args()->getCommand(), $this->parameters['extension'] ?? 'json');
-		exit();
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_READ);
+		$uid = BaseApi::getCurrentUserID();
+
+		// This is a dummy endpoint
+		$ret = [];
+		$this->response->exit('statuses', ["lists_list" => $ret], $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
 	}
 }

src/Module/Api/Twitter/Lists/Ownership.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Twitter\Lists;
+
+use Friendica\Database\DBA;
+use Friendica\DI;
+use Friendica\Module\BaseApi;
+use Friendica\Model\Contact;
+
+/**
+ * Returns all groups the user owns.
+ *
+ * @see https://developer.twitter.com/en/docs/accounts-and-users/create-manage-lists/api-reference/get-lists-ownerships
+ */
+class Ownership extends BaseApi
+{
+	protected function rawContent(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_READ);
+		$uid = BaseApi::getCurrentUserID();
+	
+		$groups = DBA::select('group', [], ['deleted' => false, 'uid' => $uid]);
+	
+		// loop through all groups
+		$lists = [];
+		foreach ($groups as $group) {
+			$lists[] = DI::friendicaGroup()->createFromId($group['id']);
+		}
+
+		$this->response->exit('statuses', ['lists' => ['lists' => $lists]], $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
+	}
+}

src/Module/Api/Twitter/Lists/Update.php

@@ -0,0 +1,65 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Module\Api\Twitter\Lists;
+
+use Friendica\Database\DBA;
+use Friendica\DI;
+use Friendica\Module\BaseApi;
+use Friendica\Model\Contact;
+use Friendica\Model\Group;
+use Friendica\Network\HTTPException;
+
+/**
+ * Update information about a group.
+ *
+ * @see https://developer.twitter.com/en/docs/accounts-and-users/create-manage-lists/api-reference/post-lists-update
+ */
+class Update extends BaseApi
+{
+	protected function rawContent(array $request = [])
+	{
+		BaseApi::checkAllowedScope(BaseApi::SCOPE_WRITE);
+		$uid = BaseApi::getCurrentUserID();
+	
+		// params
+		$gid  = $_REQUEST['list_id'] ?? 0;
+		$name = $_REQUEST['name'] ?? '';
+	
+		// error if no gid specified
+		if ($gid == 0) {
+			throw new HTTPException\BadRequestException('gid not specified');
+		}
+	
+		// get data of the specified group id
+		$group = DBA::selectFirst('group', [], ['uid' => $uid, 'id' => $gid]);
+		// error message if specified gid is not in database
+		if (!$group) {
+			throw new HTTPException\BadRequestException('gid not available');
+		}
+	
+		if (Group::update($gid, $name)) {
+			$list = DI::friendicaGroup()->createFromId($gid);
+	
+			$this->response->exit('statuses', ['lists' => ['lists' => $list]], $this->parameters['extension'] ?? null, Contact::getPublicIdByUserId($uid));
+		}
+	}
+}

src/Object/Api/Friendica/Group.php

@@ -0,0 +1,59 @@
+<?php
+/**
+ * @copyright Copyright (C) 2010-2022, the Friendica project
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+namespace Friendica\Object\Api\Friendica;
+
+use Friendica\BaseDataTransferObject;
+
+/**
+ * Class Group
+ *
+ *
+ */
+class Group extends BaseDataTransferObject
+{
+	/** @var string */
+	protected $name;
+	/** @var int */
+	protected $id;
+	/** @var string */
+	protected $id_str;
+	/** @var array */
+	protected $user;
+	/** @var string */
+	protected $mode;
+
+	/**
+	 * Creates an Group entity array
+	 *
+	 * @param array $group
+	 * @param array $user
+	 * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+	 */
+	public function __construct(array $group, array $user)
+	{
+		$this->name   = $group['name'];
+		$this->id     = $group['id'];
+		$this->id_str = (string)$group['id'];
+		$this->user   = $user;
+		$this->mode   = $group['visible'] ? 'public' : 'private';
+	}
+}

src/Util/Images.php

@@ -46,6 +46,30 @@ class Images
 		return $m;
 	}
 
+	/**
+	 * Return file extension for mime type
+	 * @param string $mimetype
+	 * @return string
+	 */
+	public static function getExtensionByMimeType(string $mimetype): string
+	{
+		switch ($mimetype) {
+			case 'image/png':
+				$imagetype = IMAGETYPE_PNG;
+				break;
+
+			case 'image/gif':
+				$imagetype = IMAGETYPE_GIF;
+				break;
+
+			default:
+				$imagetype = IMAGETYPE_JPEG;
+				break;
+		}
+
+		return image_type_to_extension($imagetype);
+	}
+
 	/**
 	 * Returns supported image mimetypes and corresponding file extensions
 	 *

src/Util/ParseUrl.php

@@ -216,6 +216,7 @@ class ParseUrl
 
 		$curlResult = DI::httpClient()->get($url, [HttpClientOptions::CONTENT_LENGTH => 1000000]);
 		if (!$curlResult->isSuccess() || empty($curlResult->getBody())) {
+			Logger::info('Empty body or error when fetching', ['url' => $url, 'success' => $curlResult->isSuccess(), 'code' => $curlResult->getReturnCode()]);
 			return $siteinfo;
 		}