Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2024-11-12 23:42:54 +00:00
Code Issues Projects Releases Packages Wiki Activity

Move unicity check after array initilization in builtin_activity_puller()

Browse source 
- Address https://github.com/friendica/friendica/pull/9569#issuecomment-731613088
- Address https://github.com/friendica/friendica/issues/9251#issuecomment-731615844
This commit is contained in:
Hypolite Petovan 2020-11-21 15:56:07 -05:00
parent 4370d0b967
commit a16d46b0d7
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
include/conversation.php
View file

@ -1034,11 +1034,6 @@ function builtin_activity_puller(array $activity, array &$conv_responses)
$activity['thr-parent'] = $activity['parent-uri']; $activity['thr-parent'] = $activity['parent-uri'];
} }
// only list each unique author once
if (in_array($link, $conv_responses[$mode][$activity['thr-parent']]['links'])) {
continue;
}
// Skip when the causer of the parent is the same than the author of the announce // Skip when the causer of the parent is the same than the author of the announce
if (($verb == Activity::ANNOUNCE) && Item::exists(['uri' => $activity['thr-parent'], if (($verb == Activity::ANNOUNCE) && Item::exists(['uri' => $activity['thr-parent'],
'uid' => $activity['uid'], 'causer-id' => $activity['author-id'], 'gravity' => GRAVITY_PARENT])) { 'uid' => $activity['uid'], 'causer-id' => $activity['author-id'], 'gravity' => GRAVITY_PARENT])) {
@ -1050,6 +1045,9 @@ function builtin_activity_puller(array $activity, array &$conv_responses)
'links' => [], 'links' => [],
'self' => 0, 'self' => 0,
]; ];
} elseif (in_array($link, $conv_responses[$mode][$activity['thr-parent']]['links'])) {
// only list each unique author once
continue;
} }
if (public_contact() == $activity['author-id']) { if (public_contact() == $activity['author-id']) {