Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2024-12-24 13:20:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2709 from annando/1608-push-splitted

Browse source 
pubsubpublish is now split into separate calls per entry
This commit is contained in:
Tobias Diekershoff 2016-08-04 21:31:36 +02:00 committed by GitHub
commit b7ec844429
3 changed files with 67 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
include/notifier.php
View file

@ -642,8 +642,8 @@ function notifier_run(&$argv, &$argc){
if ($h === '[internal]') { if ($h === '[internal]') {
// Set push flag for PuSH subscribers to this topic, // Set push flag for PuSH subscribers to this topic,
// they will be notified in queue.php // they will be notified in queue.php
q("UPDATE `push_subscriber` SET `push` = 1 " . q("UPDATE `push_subscriber` SET `push` = 1 ".
"WHERE `nickname` = '%s'", dbesc($owner['nickname'])); "WHERE `nickname` = '%s' AND `push` = 0", dbesc($owner['nickname']));
logger('Activating internal PuSH for item '.$item_id, LOGGER_DEBUG); logger('Activating internal PuSH for item '.$item_id, LOGGER_DEBUG);

10
include/poller.php
View file

@ -235,9 +235,13 @@ function poller_kill_stale_workers() {
logger("Worker process ".$pid["pid"]." took more than 3 hours. It will be killed now."); logger("Worker process ".$pid["pid"]." took more than 3 hours. It will be killed now.");
posix_kill($pid["pid"], SIGTERM); posix_kill($pid["pid"], SIGTERM);
// Question: If a process is stale: Should we remove it or should we reschedule it? // We killed the stale process.
// By now we rescheduling it. It's maybe not the wisest decision? // To avoid a blocking situation we reschedule the process at the beginning of the queue.
q("UPDATE `workerqueue` SET `executed` = '0000-00-00 00:00:00', `pid` = 0 WHERE `pid` = %d", // Additionally we are lowering the priority.
q("UPDATE `workerqueue` SET `executed` = '0000-00-00 00:00:00', `created` = '%s',
`priority` = %d, `pid` = 0 WHERE `pid` = %d",
dbesc(datetime_convert()),
intval(PRIORITY_LOW),
intval($pid["pid"])); intval($pid["pid"]));
} else } else
logger("Worker process ".$pid["pid"]." now runs for ".round($duration)." minutes. That's okay.", LOGGER_DEBUG); logger("Worker process ".$pid["pid"]." now runs for ".round($duration)." minutes. That's okay.", LOGGER_DEBUG);

47
include/pubsubpublish.php
View file

@ -2,19 +2,19 @@
require_once("boot.php"); require_once("boot.php");
require_once("include/ostatus.php"); require_once("include/ostatus.php");
function handle_pubsubhubbub() { use \Friendica\Core\Config;
use \Friendica\Core\PConfig;
function handle_pubsubhubbub($id) {
global $a, $db; global $a, $db;
logger('start'); $r = q("SELECT * FROM `push_subscriber` WHERE `id` = %d", intval($id));
if (!$r)
return;
else
$rr = $r[0];
// We'll push to each subscriber that has push > 0, logger("Generate feed of user ".$rr['nickname']." to ".$rr['callback_url']." - last updated ".$rr['last_update'], LOGGER_DEBUG);
// i.e. there has been an update (set in notifier.php).
$r = q("SELECT * FROM `push_subscriber` WHERE `push` > 0");
foreach($r as $rr) {
logger("Generate feed for user ".$rr['nickname']." - last updated ".$rr['last_update'], LOGGER_DEBUG);
$params = ostatus::feed($a, $rr['nickname'], $rr['last_update']); $params = ostatus::feed($a, $rr['nickname'], $rr['last_update']);
$hmac_sig = hash_hmac("sha1", $params, $rr['secret']); $hmac_sig = hash_hmac("sha1", $params, $rr['secret']);
@ -53,9 +53,6 @@ function handle_pubsubhubbub() {
$new_push, $new_push,
intval($rr['id'])); intval($rr['id']));
} }
}
logger('done');
} }
@ -89,10 +86,28 @@ function pubsubpublish_run(&$argv, &$argc){
if($argc > 1) if($argc > 1)
$pubsubpublish_id = intval($argv[1]); $pubsubpublish_id = intval($argv[1]);
else else {
$pubsubpublish_id = 0; // We'll push to each subscriber that has push > 0,
// i.e. there has been an update (set in notifier.php).
$r = q("SELECT `id`, `callback_url` FROM `push_subscriber` WHERE `push` > 0");
handle_pubsubhubbub(); // Use the delivery interval that is also used for the notifier
$interval = Config::get("system", "delivery_interval", 2);
// If we are using the worker we don't need a delivery interval
if (get_config("system", "worker"))
$interval = false;
foreach($r as $rr) {
logger("Publish feed to ".$rr["callback_url"], LOGGER_DEBUG);
proc_run(PRIORITY_HIGH, 'include/pubsubpublish.php', $rr["id"]);
if($interval)
@time_sleep_until(microtime(true) + (float) $interval);
}
}
handle_pubsubhubbub($pubsubpublish_id);
return; return;