From c0723e3d486f0f7e3fc4ea5be9dbdb61f16d668d Mon Sep 17 00:00:00 2001 From: Michael Date: Sun, 26 Jan 2025 12:59:59 +0000 Subject: [PATCH] Fix codestyle --- src/Module/BaseProfile.php | 90 +++++----- src/Module/Calendar/Show.php | 1 - src/Module/Conversation/Channel.php | 2 +- src/Module/Conversation/Community.php | 8 +- src/Module/Conversation/Network.php | 23 +-- tests/src/Content/Text/BBCodeTest.php | 246 +++++++++++++------------- view/lang/C/messages.po | 135 +++++++------- view/theme/frio/php/default.php | 81 +++++---- view/theme/frio/php/minimal.php | 12 +- view/theme/frio/php/standard.php | 44 +++-- 10 files changed, 339 insertions(+), 303 deletions(-) diff --git a/src/Module/BaseProfile.php b/src/Module/BaseProfile.php index c034287469..4a73408bc9 100644 --- a/src/Module/BaseProfile.php +++ b/src/Module/BaseProfile.php @@ -31,35 +31,35 @@ class BaseProfile extends BaseModule $tabs = [ [ - 'label' => DI::l10n()->t('Profile'), - 'url' => $baseProfileUrl . '/profile', - 'sel' => $current == 'profile' ? 'active' : '', - 'title' => DI::l10n()->t('Profile Details'), - 'id' => 'profile-tab', + 'label' => DI::l10n()->t('Profile'), + 'url' => $baseProfileUrl . '/profile', + 'sel' => $current == 'profile' ? 'active' : '', + 'title' => DI::l10n()->t('Profile Details'), + 'id' => 'profile-tab', 'accesskey' => 'r', ], [ - 'label' => DI::l10n()->t('Conversations'), - 'url' => $baseProfileUrl . '/conversations', - 'sel' => $current == 'status' ? 'active' : '', - 'title' => DI::l10n()->t('Conversations started'), - 'id' => 'status-tab', + 'label' => DI::l10n()->t('Conversations'), + 'url' => $baseProfileUrl . '/conversations', + 'sel' => $current == 'status' ? 'active' : '', + 'title' => DI::l10n()->t('Conversations started'), + 'id' => 'status-tab', 'accesskey' => 'm', ], [ - 'label' => DI::l10n()->t('Photos'), - 'url' => $baseProfileUrl . '/photos', - 'sel' => $current == 'photos' ? 'active' : '', - 'title' => DI::l10n()->t('Photo Albums'), - 'id' => 'photo-tab', + 'label' => DI::l10n()->t('Photos'), + 'url' => $baseProfileUrl . '/photos', + 'sel' => $current == 'photos' ? 'active' : '', + 'title' => DI::l10n()->t('Photo Albums'), + 'id' => 'photo-tab', 'accesskey' => 'h', ], [ - 'label' => DI::l10n()->t('Media'), - 'url' => $baseProfileUrl . '/media', - 'sel' => $current == 'media' ? 'active' : '', - 'title' => DI::l10n()->t('Media'), - 'id' => 'media-tab', + 'label' => DI::l10n()->t('Media'), + 'url' => $baseProfileUrl . '/media', + 'sel' => $current == 'media' ? 'active' : '', + 'title' => DI::l10n()->t('Media'), + 'id' => 'media-tab', 'accesskey' => 'd', ], ]; @@ -67,22 +67,22 @@ class BaseProfile extends BaseModule // the calendar link for the full-featured events calendar if ($is_owner) { $tabs[] = [ - 'label' => DI::l10n()->t('Calendar'), - 'url' => DI::baseUrl() . '/calendar', - 'sel' => $current == 'calendar' ? 'active' : '', - 'title' => DI::l10n()->t('Calendar'), - 'id' => 'calendar-tab', + 'label' => DI::l10n()->t('Calendar'), + 'url' => DI::baseUrl() . '/calendar', + 'sel' => $current == 'calendar' ? 'active' : '', + 'title' => DI::l10n()->t('Calendar'), + 'id' => 'calendar-tab', 'accesskey' => 'c', ]; } else { $owner = User::getByNickname($nickname, ['uid']); if(DI::userSession()->isAuthenticated() || $owner && Feature::isEnabled($owner['uid'], Feature::PUBLIC_CALENDAR)) { $tabs[] = [ - 'label' => DI::l10n()->t('Calendar'), - 'url' => DI::baseUrl() . '/calendar/show/' . $nickname, - 'sel' => $current == 'calendar' ? 'active' : '', - 'title' => DI::l10n()->t('Calendar'), - 'id' => 'calendar-tab', + 'label' => DI::l10n()->t('Calendar'), + 'url' => DI::baseUrl() . '/calendar/show/' . $nickname, + 'sel' => $current == 'calendar' ? 'active' : '', + 'title' => DI::l10n()->t('Calendar'), + 'id' => 'calendar-tab', 'accesskey' => 'c', ]; } @@ -90,30 +90,30 @@ class BaseProfile extends BaseModule if ($is_owner) { $tabs[] = [ - 'label' => DI::l10n()->t('Personal Notes'), - 'url' => DI::baseUrl() . '/notes', - 'sel' => $current == 'notes' ? 'active' : '', - 'title' => DI::l10n()->t('Only You Can See This'), - 'id' => 'notes-tab', + 'label' => DI::l10n()->t('Personal Notes'), + 'url' => DI::baseUrl() . '/notes', + 'sel' => $current == 'notes' ? 'active' : '', + 'title' => DI::l10n()->t('Only You Can See This'), + 'id' => 'notes-tab', 'accesskey' => 't', ]; $tabs[] = [ - 'label' => DI::l10n()->t('Scheduled Posts'), - 'url' => $baseProfileUrl . '/schedule', - 'sel' => $current == 'schedule' ? 'active' : '', - 'title' => DI::l10n()->t('Posts that are scheduled for publishing'), - 'id' => 'schedule-tab', + 'label' => DI::l10n()->t('Scheduled Posts'), + 'url' => $baseProfileUrl . '/schedule', + 'sel' => $current == 'schedule' ? 'active' : '', + 'title' => DI::l10n()->t('Posts that are scheduled for publishing'), + 'id' => 'schedule-tab', 'accesskey' => 'o', ]; } if (!$hide_friends) { $tabs[] = [ - 'label' => DI::l10n()->t('Contacts'), - 'url' => $baseProfileUrl . '/contacts', - 'sel' => $current == 'contacts' ? 'active' : '', - 'title' => DI::l10n()->t('Contacts'), - 'id' => 'viewcontacts-tab', + 'label' => DI::l10n()->t('Contacts'), + 'url' => $baseProfileUrl . '/contacts', + 'sel' => $current == 'contacts' ? 'active' : '', + 'title' => DI::l10n()->t('Contacts'), + 'id' => 'viewcontacts-tab', 'accesskey' => 'k', ]; } diff --git a/src/Module/Calendar/Show.php b/src/Module/Calendar/Show.php index f808c9d50a..9e9376d8bf 100644 --- a/src/Module/Calendar/Show.php +++ b/src/Module/Calendar/Show.php @@ -21,7 +21,6 @@ use Friendica\Core\Session\Capability\IHandleUserSessions; use Friendica\Core\Theme; use Friendica\Model\Event; use Friendica\Model\Profile; -use Friendica\Model\User; use Friendica\Module\BaseProfile; use Friendica\Module\Response; use Friendica\Module\Security\Login; diff --git a/src/Module/Conversation/Channel.php b/src/Module/Conversation/Channel.php index 4c060b65d7..37d9b18985 100644 --- a/src/Module/Conversation/Channel.php +++ b/src/Module/Conversation/Channel.php @@ -163,7 +163,7 @@ class Channel extends Timeline throw new HTTPException\BadRequestException($this->l10n->t('Channel not available.')); } - $this->maxId = $request['last_created'] ?? $this->maxId; + $this->maxId = $request['last_created'] ?? $this->maxId; $this->minId = $request['first_created'] ?? $this->minId; } } diff --git a/src/Module/Conversation/Community.php b/src/Module/Conversation/Community.php index e3f75ddeaf..84e2179fe3 100644 --- a/src/Module/Conversation/Community.php +++ b/src/Module/Conversation/Community.php @@ -74,10 +74,10 @@ class Community extends Timeline $t = Renderer::getMarkupTemplate("community.tpl"); $o = Renderer::replaceMacros($t, [ - '$content' => '', - '$header' => '', + '$content' => '', + '$header' => '', '$show_global_community_hint' => ($this->selectedTab == CommunityEntity::GLOBAL) && $this->config->get('system', 'show_global_community_hint'), - '$global_community_hint' => $this->l10n->t("This community stream shows all public posts received by this node. They may not reflect the opinions of this node’s users.") + '$global_community_hint' => $this->l10n->t("This community stream shows all public posts received by this node. They may not reflect the opinions of this node’s users.") ]); if ($this->pConfig->get($this->session->getLocalUserId(), 'system', 'infinite_scroll')) { @@ -185,7 +185,7 @@ class Community extends Timeline } } - $this->maxId = $request['last_received'] ?? $this->maxId; + $this->maxId = $request['last_received'] ?? $this->maxId; $this->minId = $request['first_received'] ?? $this->minId; } } diff --git a/src/Module/Conversation/Network.php b/src/Module/Conversation/Network.php index d94aeb6cde..86c2fcf736 100644 --- a/src/Module/Conversation/Network.php +++ b/src/Module/Conversation/Network.php @@ -192,9 +192,9 @@ class Network extends Timeline $x = [ 'lockstate' => $this->circleId || $this->network || ACL::getLockstateForUserId($this->session->getLocalUserId()) ? 'lock' : 'unlock', - 'acl' => ACL::getFullSelectorHTML($this->page, $this->session->getLocalUserId(), true, $default_permissions), - 'bang' => (($this->circleId || $this->network) ? '!' : ''), - 'content' => '', + 'acl' => ACL::getFullSelectorHTML($this->page, $this->session->getLocalUserId(), true, $default_permissions), + 'bang' => (($this->circleId || $this->network) ? '!' : ''), + 'content' => '', ]; $o .= $this->conversation->statusEditor($x); @@ -236,7 +236,7 @@ class Network extends Timeline $pager = new BoundariesPager( $this->l10n, $this->args->getQueryString(), - $items[0][$this->order] ?? null, + $items[0][$this->order] ?? null, $items[count($items) - 1][$this->order] ?? null, $this->itemsPerPage ); @@ -313,23 +313,23 @@ class Network extends Timeline if (!empty($request['star'])) { $this->selectedTab = NetworkEntity::STAR; - $this->star = true; + $this->star = true; } else { $this->star = $this->selectedTab == NetworkEntity::STAR; } if (!empty($request['mention'])) { $this->selectedTab = NetworkEntity::MENTION; - $this->mention = true; + $this->mention = true; } else { $this->mention = $this->selectedTab == NetworkEntity::MENTION; } if (!empty($request['order'])) { $this->selectedTab = $request['order']; - $this->order = $request['order']; - $this->star = false; - $this->mention = false; + $this->order = $request['order']; + $this->star = false; + $this->mention = false; } elseif (in_array($this->selectedTab, [NetworkEntity::RECEIVED, NetworkEntity::STAR]) || $this->community->isTimeline($this->selectedTab)) { $this->order = 'received'; } elseif (($this->selectedTab == NetworkEntity::CREATED) || $this->channel->isTimeline($this->selectedTab) || $this->userDefinedChannel->isTimeline($this->selectedTab, $this->session->getLocalUserId())) { @@ -344,7 +344,8 @@ class Network extends Timeline // since otherwise the feed will optically jump, when some already visible thread has been updated. if ($this->update && ($this->selectedTab == NetworkEntity::COMMENTED)) { $this->order = 'received'; - $request['last_received'] = $request['last_commented'] ?? null; + + $request['last_received'] = $request['last_commented'] ?? null; $request['first_received'] = $request['first_commented'] ?? null; } @@ -361,7 +362,7 @@ class Network extends Timeline $this->network = $request['nets'] ?? ''; $this->dateFrom = $this->parameters['from'] ?? ''; - $this->dateTo = $this->parameters['to'] ?? ''; + $this->dateTo = $this->parameters['to'] ?? ''; $this->setMaxMinByOrder($request); diff --git a/tests/src/Content/Text/BBCodeTest.php b/tests/src/Content/Text/BBCodeTest.php index 4757200000..9c61e10887 100644 --- a/tests/src/Content/Text/BBCodeTest.php +++ b/tests/src/Content/Text/BBCodeTest.php @@ -32,7 +32,7 @@ class BBCodeTest extends FixtureTestCase $config->set('HTML.Doctype', 'HTML5'); $config->set('Attr.AllowedRel', [ 'noreferrer' => true, - 'noopener' => true, + 'noopener' => true, ]); $config->set('Attr.AllowedFrameTargets', [ '_blank' => true, @@ -46,77 +46,77 @@ class BBCodeTest extends FixtureTestCase return [ /** @see https://github.com/friendica/friendica/issues/2487 */ 'bug-2487-1' => [ - 'data' => 'https://de.wikipedia.org/wiki/Juha_Sipilä', + 'data' => 'https://de.wikipedia.org/wiki/Juha_Sipilä', 'assertHTML' => true, ], 'bug-2487-2' => [ - 'data' => 'https://de.wikipedia.org/wiki/Dnepr_(Motorradmarke)', + 'data' => 'https://de.wikipedia.org/wiki/Dnepr_(Motorradmarke)', 'assertHTML' => true, ], 'bug-2487-3' => [ - 'data' => 'https://friendica.wäckerlin.ch/friendica', + 'data' => 'https://friendica.wäckerlin.ch/friendica', 'assertHTML' => true, ], 'bug-2487-4' => [ - 'data' => 'https://mastodon.social/@morevnaproject', + 'data' => 'https://mastodon.social/@morevnaproject', 'assertHTML' => true, ], /** @see https://github.com/friendica/friendica/issues/5795 */ 'bug-5795' => [ - 'data' => 'https://social.nasqueron.org/@liw/100798039015010628', + 'data' => 'https://social.nasqueron.org/@liw/100798039015010628', 'assertHTML' => true, ], /** @see https://github.com/friendica/friendica/issues/6095 */ 'bug-6095' => [ - 'data' => 'https://en.wikipedia.org/wiki/Solid_(web_decentralization_project)', + 'data' => 'https://en.wikipedia.org/wiki/Solid_(web_decentralization_project)', 'assertHTML' => true, ], 'no-protocol' => [ - 'data' => 'example.com/path', + 'data' => 'example.com/path', 'assertHTML' => false ], 'wrong-protocol' => [ - 'data' => 'ftp://example.com', + 'data' => 'ftp://example.com', 'assertHTML' => false ], 'wrong-domain-without-path' => [ - 'data' => 'http://example', + 'data' => 'http://example', 'assertHTML' => false ], 'wrong-domain-with-path' => [ - 'data' => 'http://example/path', + 'data' => 'http://example/path', 'assertHTML' => false ], 'bug-6857-domain-start' => [ - 'data' => "http://\nexample.com", + 'data' => "http://\nexample.com", 'assertHTML' => false ], 'bug-6857-domain-end' => [ - 'data' => "http://example\n.com", + 'data' => "http://example\n.com", 'assertHTML' => false ], 'bug-6857-tld' => [ - 'data' => "http://example.\ncom", + 'data' => "http://example.\ncom", 'assertHTML' => false ], 'bug-6857-end' => [ - 'data' => "http://example.com\ntest", + 'data' => "http://example.com\ntest", 'assertHTML' => false ], 'bug-6901' => [ - 'data' => "http://example.com