From c762c62029295928d2dbb781edcb88d91affb843 Mon Sep 17 00:00:00 2001 From: Art4 Date: Wed, 8 Jan 2025 23:00:38 +0000 Subject: [PATCH] Remove DiceContainer::fromDice() --- src/Core/DiceContainer.php | 14 +------------ tests/Unit/Core/DiceContainerTest.php | 29 --------------------------- 2 files changed, 1 insertion(+), 42 deletions(-) diff --git a/src/Core/DiceContainer.php b/src/Core/DiceContainer.php index 7d8b57b14d..8e0a95b472 100644 --- a/src/Core/DiceContainer.php +++ b/src/Core/DiceContainer.php @@ -27,7 +27,7 @@ final class DiceContainer implements Container $dice = (new Dice())->addRules(require($path)); - return static::fromDice($dice); + return new self($dice); } private Dice $container; @@ -37,18 +37,6 @@ final class DiceContainer implements Container $this->container = $container; } - /** - * Creates an instance with Dice - * - * @param Dice $container - * - * @return self - */ - public static function fromDice(Dice $container): self - { - return new self($container); - } - /** * Initialize the container with the given parameters * diff --git a/tests/Unit/Core/DiceContainerTest.php b/tests/Unit/Core/DiceContainerTest.php index d18c551da1..0b6040029e 100644 --- a/tests/Unit/Core/DiceContainerTest.php +++ b/tests/Unit/Core/DiceContainerTest.php @@ -50,33 +50,4 @@ class DiceContainerTest extends TestCase $this->assertInstanceOf(NullLogger::class, $container->create(LoggerInterface::class)); } - - public function testFromDiceReturnsContainer(): void - { - $dice = $this->createMock(Dice::class); - $dice->expects($this->never())->method('create'); - - $container = DiceContainer::fromDice($dice); - - $this->assertInstanceOf(Container::class, $container); - } - - public function testCreateFromContainer(): void - { - $dice = $this->createMock(Dice::class); - $dice->expects($this->once())->method('create')->with(LoggerInterface::class)->willReturn(new NullLogger()); - - $container = DiceContainer::fromDice($dice); - - $this->assertInstanceOf(NullLogger::class, $container->create(LoggerInterface::class)); - } - - public function testAddRuleFromContainer(): void - { - $dice = $this->createMock(Dice::class); - $dice->expects($this->once())->method('addRule')->with(LoggerInterface::class, ['constructParams' => ['console']])->willReturn($dice); - - $container = DiceContainer::fromDice($dice); - $container->addRule(LoggerInterface::class, ['constructParams' => ['console']]); - } }