Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2025-04-22 21:10:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Just commit config transactions if something changed

Browse source
This commit is contained in:
Philipp 2023-01-04 19:55:22 +01:00
parent aabe39220d
commit dce86be58e
No known key found for this signature in database
GPG key ID: 24A7501396EB5432
3 changed files with 34 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/src/Core/Config/ConfigTransactionTest.php
View file

@ -9,6 +9,7 @@ use Friendica\Core\Config\Util\ConfigFileManager;
use Friendica\Core\Config\ValueObject\Cache;
use Friendica\Test\MockedTest;
use Friendica\Test\Util\VFSTrait;
use Mockery\Exception\InvalidCountException;
class ConfigTransactionTest extends MockedTest
{
@ -108,4 +109,27 @@ class ConfigTransactionTest extends MockedTest
// the whole category should be gone
self::assertNull($tempData['delete'] ?? null);
}
/**
* This test asserts that in empty transactions, no saveData is called, thus no config file writing was performed
*/
public function testNothingToDo()
{
$this->configFileManager = \Mockery::spy(ConfigFileManager::class);
$config = new Config($this->configFileManager, new Cache());
$configTransaction = new ConfigTransaction($config);
// commit empty transaction
$configTransaction->commit();
try {
$this->configFileManager->shouldNotHaveReceived('saveData');
} catch (InvalidCountException $exception) {
self::fail($exception);
}
// If not failed, the test ends successfully :)
self::assertTrue(true);
}
}