- Strings::isHex() should not be misused for checking on NULL
This commit is contained in:
Roland Häder 2022-06-20 08:25:17 +02:00
parent 6743de63f5
commit e5cc7a5ab1
No known key found for this signature in database
GPG key ID: C82EDE5DDFA0BA77
2 changed files with 6 additions and 10 deletions

View file

@ -113,22 +113,18 @@ class StringsTest extends TestCase
'input' => '',
'valid' => false,
],
'nullHex' => [
'input' => null,
'valid' => false,
],
];
}
/**
* Tests if the string is a valid hexadecimal value
*
* @param string|null $input
* @param bool $valid
* @param string $input
* @param bool $valid
*
* @dataProvider dataIsHex
*/
public function testIsHex(string $input = null, bool $valid = false)
public function testIsHex(string $input = '', bool $valid = false)
{
self::assertEquals($valid, Strings::isHex($input));
}