Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2025-04-25 13:10:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

Changed:

Browse source 
- used `$this->getRequestValue($request, 'foo', <bar>)` instead of `$request['foo'] ?? <bar>`
- fixed wrong variable naming
- changed double-quotes to single
- see https://github.com/friendica/friendica/issues/11631#issuecomment-1196410497
This commit is contained in:
Roland Häder 2022-07-29 00:36:07 +02:00
parent 5ec407699b
commit eaed3945d1
No known key found for this signature in database
GPG key ID: C82EDE5DDFA0BA77
21 changed files with 28 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Module/Api/Twitter/DirectMessages/Conversation.php
View file

@ -34,6 +34,6 @@ class Conversation extends DirectMessagesEndpoint
BaseApi::checkAllowedScope(BaseApi::SCOPE_READ);
$uid = BaseApi::getCurrentUserID();
$this->getMessages($request, $uid, ["`parent-uri` = ?", $request['uri'] ?? '']);
$this->getMessages($request, $uid, ["`parent-uri` = ?", $this->getRequestValue($request, 'uri', '')]);
}
}

5
src/Module/Api/Twitter/DirectMessages/Destroy.php
View file

@ -55,9 +55,8 @@ class Destroy extends BaseApi
$id = $this->getRequestValue($request, 'id', 0);
$id = $this->getRequestValue($this->parameters, 'id', $id);
$verbose = $this->getRequestValue($request, 'friendica_verbose', false);
$parenturi = $request['friendica_parenturi'] ?? '';
$verbose = $this->getRequestValue($request, 'friendica_verbose', false);
$parenturi = $this->getRequestValue($request, 'friendica_parenturi', '');
// error if no id or parenturi specified (for clients posting parent-uri as well)
if ($verbose && $id == 0 && $parenturi == "") {

4
src/Module/Api/Twitter/DirectMessages/NewDM.php
View file

@ -63,7 +63,7 @@ class NewDM extends BaseApi
return;
}
$cid = BaseApi::getContactIDForSearchterm($request['screen_name'] ?? '', $request['profileurl'] ?? '', $request['user_id'] ?? 0, 0);
$cid = BaseApi::getContactIDForSearchterm($this->getRequestValue($request, 'screen_name', ''), $this->getRequestValue($request, 'profileurl', ''), $this->getRequestValue($request, 'user_id', 0), 0);
if (empty($cid)) {
throw new NotFoundException('Recipient not found');
}
@ -86,7 +86,7 @@ class NewDM extends BaseApi
$id = Mail::send($cdata['user'], $request['text'], $sub, $replyto);
if ($id > -1) {
$ret = $this->directMessage->createFromMailId($id, $uid, $request['getText'] ?? '');
$ret = $this->directMessage->createFromMailId($id, $uid, $this->getRequestValue($request, 'getText', ''));
} else {
$ret = ['error' => $id];
}