Commit graph

337 commits

Author SHA1 Message Date
Hypolite Petovan
b6e1571b1e Fix various notices 2018-12-15 04:32:47 -05:00
Michael
cced018825 Possibly fix a memory issue with large posts 2018-12-11 18:48:33 +00:00
Michael
491fc5f78a Issue 6168: "redir" now mostly use OWA 2018-12-04 07:12:55 +00:00
Hypolite Petovan
458981f75c Replace x() by isset(), !empty() or defaults()
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Adam Magness
218f0734be Rename removeTags to escapeTags
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
063f0e9cb0 Rename escapeTags to escapeHtml
rename function and update calls.
2018-11-09 13:27:58 -05:00
Adam Magness
b5a97c1abe Move getTags to BBCode
move getTags function to BBCode class and update calls.
2018-11-09 13:24:19 -05:00
Adam Magness
e4354a0d7b Update and Remove isValidEmail
change function calls, and remove unneeded function.
2018-11-09 13:18:42 -05:00
Adam Magness
087f50d820 Missing Use statements
missing use
2018-11-08 11:58:42 -05:00
Adam Magness
ffc406d819 normalise_link calls
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
5276c28a78 link_compare calls
implement compareLink function.
2018-11-08 10:46:50 -05:00
Adam Magness
6fc9c6de3b base64url calls
implement base64UrlEncode and base64UrlDecode functions
2018-11-08 10:37:08 -05:00
Adam Magness
916b3e551e format_network_name calls
implement formatNetworkName function
2018-11-08 10:24:47 -05:00
Adam Magness
b99925060a autoname calls
implement getRandomName function
2018-11-08 10:22:20 -05:00
Adam Magness
0e01568ccd escape_tags calls
implement escapeTags function
2018-11-08 10:20:03 -05:00
Adam Magness
a0f65ca7a1 notags calls
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb random_string calls
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness
fd597472f1 Split text.php to Strings class
move functions to new strings class
Split text.php to Strings class

move functions to new Strings class
2018-11-08 08:33:28 -05:00
Michael
cd2c7f782f We now directly support the custom emojis from Mastodon 2018-11-07 20:34:03 +00:00
Adam Magness
352da9bcf3 Update function calls
update function calls for moved functions
2018-11-06 09:52:58 -05:00
Philipp Holzer
049cd963f3
Using random_int directly 2018-11-05 21:15:30 +01:00
Philipp Holzer
6e10bdf361
Move random Digits to Crypto class 2018-11-05 21:02:54 +01:00
Adam Magness
186cd1d415 Revert "Move methods to new Util/Strings class"
This reverts commit 97fcf23371.
2018-11-05 13:07:15 -05:00
Adam Magness
9e51be7554 Revert "Update function calls"
This reverts commit 748fb8b946.
2018-11-05 13:07:07 -05:00
Adam Magness
748fb8b946 Update function calls
update function calls to new class
2018-11-05 07:40:18 -05:00
Adam Magness
97fcf23371 Move methods to new Util/Strings class
move string methods from xml to strings class.
2018-11-05 07:31:45 -05:00
Adam Magness
6cc339031a Rename functions
rename functions
2018-11-05 07:24:14 -05:00
Adam Magness
ae4aab872f forgotten self
forgotten self references
2018-11-05 07:24:14 -05:00
Adam Magness
84e900d96f Move to XML
move functions from text to xml
2018-11-05 07:24:14 -05:00
Michael
8f27e3aeb1 Support for fetching non-public content / preparations for forum posts 2018-11-03 21:37:08 +00:00
Michael
1395bdc188 Preparations for a relocation message / fix for notice 2018-11-02 21:57:06 +00:00
Adam Magness
35abc4bb64 get markup template
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness
91facd2d0a replace macros
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
Adam Magness
50da89d861 Logger Levels
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
14fde5dc9b Log function
implement log() function.
2018-10-30 09:57:14 -04:00
Michael
58f82e084d Preparations to work with BCC 2018-10-24 19:19:51 +00:00
vinzv
cb75c40f4e adapted profile pic resize to 300px for whole system 2018-10-23 16:36:57 +02:00
Tobias Diekershoff
dbe49a0c1a
Merge pull request #5998 from annando/ap-queue
Unsuccessful ActivitiyPub transmission are now deferred
2018-10-23 06:54:11 +02:00
Michael
e3e714a45f Unsuccessful ActivitiyPub transmission are now deferred 2018-10-23 03:54:18 +00:00
Hypolite Petovan
e511790d62 Move NULL_DATE from boot.php to DBA::NULL_DATETIME
- Add DBA::NULL_DATE constant
2018-10-22 16:50:55 -04:00
Hypolite Petovan
c6f0bea51d Move $strings from App to Core\L10n
- Add L10n::init() call in App constructor
- Improve pushLang/popLang
- Remove no longer needed references to App
2018-10-22 15:58:42 -04:00
Michael
5c13ecdf6e Improved parsing of AP profiles 2018-10-22 07:24:47 +00:00
Philipp Holzer
4392858662
Move Global Functions - Part 3
- Replaced every CACHE definition
- Moved check_url to App->checkURL()
- Removed unused definition "ZCURL_TIMEOUT"
2018-10-20 18:19:55 +02:00
Hypolite Petovan
ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security
Move and Split include/security
2018-10-19 08:55:08 -04:00
Jonny Tischbein
f3fc1f36ca Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments 2018-10-17 21:30:41 +02:00
Jonny Tischbein
45e5a7f59f remove unsed require_onces of security.php 2018-10-17 18:39:27 +02:00
Jonny Tischbein
05be2db725 Move include/security tp /src/Core/Authentication and /src/Util/Security 2018-10-17 14:19:58 +02:00
Hypolite Petovan
c4318fe05e Fix notices in Parse URL feature 2018-10-16 18:27:13 -04:00
Jonny Tischbein
3a95644848 Add Support for relativeDateTime in future + update Admin user waiting for deleting table header 2018-10-14 22:57:44 +02:00
Michael
d23386f9b2 Catching error when compacting doesn't work 2018-10-13 13:17:10 +00:00
Hypolite Petovan
a066befba5
Merge pull request #5878 from nupplaphil/curl_response_refactoring
Curl response refactoring
2018-10-10 18:31:49 -04:00
Philipp Holzer
b2e7ce47b3
Renaming Curl to CurlResult 2018-10-10 22:08:13 +02:00
Philipp Holzer
ffbc688797
Curl Response Refactoring
- refactored Network::getCurl()
- replaced every Network::getCur() execution with a Curl Response
2018-10-10 21:50:13 +02:00
Hypolite Petovan
67afa069ab
Merge pull request #5877 from annando/issue-5859
Issue 5859: Avoid returning empty arrays
2018-10-10 15:23:39 -04:00
Philipp Holzer
7c73e8634c
Curl Response Refactoring
- refactored Network::post()
- replaced every Network::post() execution with the new Curl container
2018-10-10 21:15:26 +02:00
Michael
c4da138eee Issue 5859: Avoid returning empty arrays 2018-10-10 19:15:16 +00:00
Philipp Holzer
2dec8895a9
Curl Response Refactoring
- extended Curl to parse Curl Response
- refactored Network::curl()
- replaced every Network::curl() execution with the new Curl container
2018-10-10 21:08:43 +02:00
Philipp Holzer
e6b1f9ef09
friendica-5875 Uncaught Error: Call to undefined method Friendica\App::getCurlCode() fixed 2018-10-10 18:10:38 +02:00
Philipp Holzer
3d04562c87
some more renamings & doku 2018-10-10 08:54:18 +02:00
Philipp Holzer
5a02e39a65
Rename App Methods
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
Michael
30ad6d60fd Duplicated line removed 2018-10-07 20:51:39 +00:00
Michael
3a74f3364d Switch to parsing compacted JSON data 2018-10-07 13:37:05 +00:00
Michael
d4f6261b81 Avoid notice 2018-10-02 08:31:58 +00:00
Michael
e71f497295 Renamed 2018-09-30 08:14:05 +00:00
Michael
30f67d6e14 removed unneded line 2018-09-27 21:14:01 +00:00
Michael
c4994626e9 Corrected function names 2018-09-27 13:31:32 +00:00
Michael
de8787dd5b Changed comment 2018-09-27 12:01:16 +00:00
Michael
897929ad40 Avoid warnings, added documentation 2018-09-26 22:45:13 +00:00
Michael
9c62727e1d Added doxygen data 2018-09-26 22:02:14 +00:00
Michael
9ec30010c5 APContact stuff is moved to an own class 2018-09-26 17:24:29 +00:00
Michael
e91a1dfa8e Cleaned code 2018-09-25 21:18:37 +00:00
Michael
feeec908d3 We can delete notes / changed credits 2018-09-23 09:20:25 +00:00
Michael
c083ae047c Merge remote-tracking branch 'upstream/2018.08-rc' into ap1 2018-09-22 15:18:53 +00:00
Michael
b44fc62708 Improvements to signature check, private posts do work now again 2018-09-21 22:31:33 +00:00
Michael
355346298b LD signatures will now be checked when receiving messages 2018-09-21 03:39:32 +00:00
Michael
752b5fe284 Outgoing posts are now signed 2018-09-20 21:45:23 +00:00
Michael
11310f4cf0 Relocated AP signature functions, reduced magic auth functions 2018-09-20 18:16:14 +00:00
Michael
0866fbaf8c Code cleaning / wrong table for flags 2018-09-20 09:50:03 +00:00
Michael
0d51474e73 Relocated function 2018-09-20 05:37:01 +00:00
Michael
34cb0aa406 JSON-LD stuff is now in a separate file 2018-09-20 05:30:07 +00:00
Michael Vogel
e68c48e88f
Merge pull request #5763 from MrPetovan/task/improve-getsiteinfo
Use OEmbed data when available no matter the type
2018-09-17 06:40:04 +00:00
Hypolite Petovan
102adf86ae Restore partial condition in OEmbed block of ParseUrl::getSiteInfo 2018-09-16 09:18:31 -04:00
Hypolite Petovan
5b5e5ef4db Use OEmbed data when available no matter the type 2018-09-13 21:50:52 -04:00
Michael
8c00e88f79 The endless saga of the fight against notices continues 2018-09-13 21:11:52 +00:00
Michael
99244d33f5 Fix for #5732 - too much links had been detected as photos 2018-09-07 06:10:33 +00:00
Michael
2592c3891c forgotten $ 2018-09-06 21:10:48 +00:00
Michael
1d4a5402ff Picture posts do work again - everything else should work as well 2018-09-06 20:30:16 +00:00
Michael
04fb885857 Fix: Posts with pictures will now look good again on connector networks 2018-09-06 04:24:34 +00:00
Hypolite Petovan
59d06b6c78
Merge pull request #5719 from annando/notices-yeah
Good news, everyone - again somce notices removed
2018-09-04 19:09:11 -04:00
Michael
821429fdf1 Good news, everyone - again somce notices removed 2018-09-04 17:48:09 +00:00
Hypolite Petovan
9744f0e780 Update ParseUrl::getSiteinfo type recognition
- Added obsolete twitter card type provision
2018-09-02 17:50:27 -04:00
Hypolite Petovan
8bcc3c6860 Fix formatting in Util/ParseUrl
- Remove commented out code
- Replace double quotes with simple quotes
- Remove parentheses for language construct
- Add spaces around operators
- Rename variables
2018-09-02 17:46:28 -04:00
Michael
fd7e45042a The days are getting shorter, like the list of removed notices ... 2018-09-02 07:47:48 +00:00
Michael
2079caea14 Issue 3501: Mail contacts can be added again 2018-08-26 19:49:39 +00:00
Michael Vogel
20127a77b3 Removing a small notice in the network.php (#5652) 2018-08-22 18:46:44 -04:00
Hypolite Petovan
c0e728e7e5 Fix query string parsing border case in Util\Proxy 2018-08-05 15:57:04 +02:00
Michael Vogel
2c8c803d64 Avid notices and warnings (#5546) 2018-08-02 19:07:20 +02:00
Roland Häder
4d39164c1e [WIP] Rewrite to Proxy class: (#5507)
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
2018-07-30 22:06:22 -04:00
Roland Häder
bf87ad4fcf Fixed E_NOTICE in listing worker queue and new utilities class added (#5521)
* Fixes for E_NOTICE in workqueue:
- introduced class `Friendica\Util\Arrays` which will hold static methods for
  handling arrays that cannot be done with PHP's functions, like implode() on
  multi-dimensional arrays
- rewrote old-school for() loop to foreach()

* Added intial unit test with some tests on empty delimiters and/or sinle and
multi-dim array.

* Added test for for 3-dimensional arrays, thanks to  nupplaphil's feedback.
2018-07-30 21:24:26 -04:00
Hypolite Petovan
ecea7425f8 Rename DBA::is_result to DBA::isResult 2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a Rename DBM method calls to DBA method calls 2018-07-23 11:02:24 -04:00
Roland Häder
c17adaf333 Uncommon logger levels in Friendica (#5453)
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)

* Used constants instead of values (MrPetovan)
2018-07-22 14:07:44 -04:00
Hypolite Petovan
af6dbc654f Rename Friendica\Database\dba to Friendica\Database\DBA 2018-07-20 08:19:26 -04:00
Hypolite Petovan
daa1177e3a Update use statement lists with new Friendica\Database\dba class
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Hypolite Petovan
1b6727fb9c Fix notice in Util\Network 2018-07-17 21:00:22 -04:00
Hypolite Petovan
065d10e587 Fix function comments in Util\Network 2018-07-15 08:03:12 -04:00
Michael Vogel
0360f7197a Several more warnings ... (#5340)
* Some more warnings removed

* Even more warnings ...

* Will it ever end? ;-)

* Avoid warning in dbstructure

* Origin and OStatus ...

* There are more warnings solved ... yeah!

* And again ...

* We are not done yet

* And more ...

* And some new places ...

* And more in the feeds

* Avoid some more

* And some backend stuff

* Notifications cleared

* Some more stuff

* and again ...

* It's getting fewer ...

* Some warnings had been hidden in the notifications

* Fix the fix

* And another missing one ...

* We need the owner here, not the user

* Forgotten user

* And more ...

* And some more warnings disappeared ...

* Some more frontend warnings

* Some backend warnings removed

* Fixed sidebar for "vier"

* And more ...

* Some more ...

* And something for "remote self"

* Am I stuck in an endless loop?

* Fix: Clear tag and file field on update

* Preset page content
2018-07-10 08:27:56 -04:00
Michael
1d745c25a7 Some more places ... 2018-07-08 12:58:43 +00:00
Michael
7d6933c898 Avoid "Trying to get property of non-object" 2018-07-08 11:46:05 +00:00
Philipp Holzer
3f7e4f5bb6
redesign of locking & caching
- New Factory "CacheDriverFactory" for Cache and Locks
- Adding Redis/Memcached Locking
- Moved Lock to Core
- other improvements
2018-06-28 22:57:17 +02:00
Philipp Holzer
acf6a5cb9e
minor changes 2018-06-26 23:44:30 +02:00
Philipp Holzer
d409a92ca2
minor changes 2018-06-26 23:43:43 +02:00
Philipp Holzer
dd085ae592
minor changes 2018-06-26 23:42:26 +02:00
Philipp Holzer
130893673c
Bugfixing ILockDriver (forgot isLocked) 2018-06-26 23:33:02 +02:00
Philipp Holzer
a57e6cfa1b
Moved Lock.php back to Utils 2018-06-26 23:28:07 +02:00
Philipp Holzer
2260b9c873
Merge branch 'develop' of https://github.com/friendica/friendica into develop 2018-06-26 22:56:08 +02:00
Philipp Holzer
0218d16335
Lock abstraction (like the Cache)
- adding interface
- adding seperate drivers
- moving Lock to the Core package
2018-06-26 22:31:04 +02:00
Hypolite Petovan
e3584daef9
Merge pull request #5167 from VVelox/develop
a domain name is unlikely to be both a CNAME and A record
2018-06-26 08:05:34 -04:00
Zane C. Bowers-Hadley
8875cc7419 remove duplicate check 2018-06-26 05:03:45 -05:00
Hypolite Petovan
a5550b4702
Merge pull request #5253 from rabuzarus/20180616_-_magic_auth_test_2
Port hubzillas OpenWebAuth - remote authentification
2018-06-20 17:46:04 -04:00
rabuzarus
9f493357f4 port hubzillas OpenWebAuth - fix wrong table name + fix wrong method name 2018-06-20 20:11:26 +02:00
rabuzarus
149142b4bc port hubzillas OpenWebAuth - rename Verify class to OpenWebAuthToken 2018-06-20 19:24:02 +02:00
rabuzarus
1ab3f7bfc8 port hubzillas OpenWebAuth - HTTPSignature - comment out some ActivityPub parts 2018-06-20 19:05:33 +02:00
rabuzarus
863a49d8e7 port hubzillas OpenWebAuth - rework the HTTPHeaders class 2018-06-20 18:52:37 +02:00
rabuzarus
1148c29916 port hubzillas OpenWebAuth - use random_bytes() in crypto class + bugfixes 2018-06-20 18:45:37 +02:00
rabuzarus
f0235c4a98 port hubzillas OpenWebAuth - rename some methods and classes 2018-06-20 18:38:23 +02:00
miqrogroove
79446a625d
Update Emailer.php 2018-06-19 16:58:06 -04:00
miqrogroove
5b8619f501
Add Missing Fifth Argument to mail() Function Call
This is desperately needed to fix Issue #5190.  In case of any unexpected problem, the admin can use

`$a->config['system']['sendmail_params'] = false;`
2018-06-19 16:23:42 -04:00
rabuzarus
b65e4b278b port hubzillas OpenWebAuth - use Contact::getIdForURL to query for contact entry 2018-06-19 16:15:28 +02:00
rabuzarus
9195ea26b1 port hubzillas OpenWebAuth - add some notes to the doxygen to refer to hubzilla's source code 2018-06-19 13:30:55 +02:00
rabuzarus
af9116635b port hubzillas OpenWebAuth - readd some ActivityPup code to HTTPSig 2018-06-19 13:18:35 +02:00
rabuzarus
1c7f4e3c63 port hubzillas OpenWebAuth - remote authentification 2018-06-18 23:05:44 +02:00
VVelox
ea64ec21ac
a domain name is unlikely to be both a CNAME and A record 2018-06-03 04:29:06 -05:00
Andreas Neustifter
91e0a9227e Fix #4943.
PR #4939 introduced a bug that only surfaces when using Network from extern.
Use proper self reference to fix that.
2018-04-28 06:46:46 +00:00
Andreas Neustifter
9bf58e46f6 Changes requested by @MrPetovan. 2018-04-27 20:22:17 +00:00
Andreas Neustifter
70a781fa5a Proper error when rewrite fails during install.
When Curl tries to fetch the rewrite test URL and something goes wrong the user
has no clue what was the problem. This problems can include:
- The rewriting not working at all.
- HTTPS redirects do not work.
- Curl does not accept the presented SSL cert.

This commit fixes this by providing the Curl error message to the user to further
debug the problem.

Fixes #3629.~
2018-04-27 21:27:55 +02:00
Hypolite Petovan
00985fe340 Fix self warning in Util\Temporal 2018-04-23 00:03:27 -04:00
Marcus Müller
f9c34fee5a
[BUGFIX] Network: Remove URL/domain DNS_PTR checks 2018-04-12 19:28:52 +02:00
Michael
211ba75b22 Avoid "Failed to parse time string (-001-11-30T00:00:00+00:00 + 32 days)" 2018-04-04 18:58:25 +00:00
Hypolite Petovan
7acb4b0434
Merge pull request #4676 from annando/clean-url
Handle URL with unicode characters
2018-03-24 15:31:07 -04:00
Michael
055855bf9b Handle URL with unicode characters 2018-03-23 18:41:59 +00:00
Hypolite Petovan
27d94023ee Merge branch 'master' into develop 2018-03-23 06:15:55 -04:00
Michael
f4ba5d9799 Fix: Events on Diaspora now should look fine 2018-03-20 06:32:17 +00:00
Hypolite Petovan
542ff9b082 Move scripts/auth_ejabberd.php to bin/ 2018-03-18 23:17:31 -04:00
Michael
858fd127a1 Fix: subscribing to the old followers hadn't worked 2018-03-14 00:27:15 +00:00
Hypolite Petovan
d419d07f73 [Scrutinizer] Fix undeclared variables in src/ (except Protocol/)
- Use dba::selectFirst to remove intermediate variables `$r`
- Remove unused variable `$url_recipients` in Worker\Dellivery
2018-02-14 00:05:00 -05:00
rabuzarus
342b9af734 fix undeclared variables or wrong variable names (/src) 2018-02-12 16:08:28 +01:00
Hypolite Petovan
4050a7b8dc Replace forgotten datetime_convert() instances 2018-02-03 20:47:37 -05:00
Hypolite Petovan
cea80c78e4 Replace remaining functions in include/datetime by Temporal methods
- Fix uses statements
2018-02-03 20:47:37 -05:00
Hypolite Petovan
5cca8562bc Move datetimepicker javascript to field_datetime.tpl
- Add type hint to getDateTimeField() arguments
2018-02-03 09:53:45 -05:00