Commit graph

7032 commits

Author SHA1 Message Date
Michael
69c7e9af20 Let the worker run for an hour in daemon mode 2021-01-04 09:20:44 +00:00
Michael
74d7d7e164 Check for childf status 2021-01-03 22:57:25 +00:00
Michael
d70d180e4b Merge remote-tracking branch 'upstream/2020.12-rc' into fork 2021-01-03 10:06:17 +00:00
Hypolite Petovan
7e8f13d703
Merge pull request #9741 from annando/worker-cooldown
Additional worker cooldown
2021-01-02 15:04:29 -05:00
Michael
10b035b51a Additional worker cooldown 2021-01-02 19:33:50 +00:00
Michael
c0ac120578 Issue 9736: Fix for undroppable registrations 2021-01-02 09:11:38 +00:00
Michael
7a03b72060 Improved daemon test 2021-01-02 08:43:55 +00:00
Michael
78f67c1e0e Check for reaching the memory limit 2021-01-01 23:10:38 +00:00
Michael
a81ac835a1 The frontend worker is removed 2021-01-01 23:05:26 +00:00
Michael
9a6141dcbe Use "pcntl_fork" to fork processes 2021-01-01 19:35:29 +00:00
Michael
5dcc02594c Some more log levels 2020-12-31 20:44:33 +00:00
Michael
d1ea529cfb Issue 9704: Improved log levels 2020-12-31 20:14:13 +00:00
Michael Vogel
54db693e16
Merge pull request #9724 from MrPetovan/bug/notices
Various improvements
2020-12-31 17:30:50 +01:00
Hypolite Petovan
c69d8ee455
Merge pull request #9732 from annando/public-permissionset
Accept public and user contact id for permissionsets
2020-12-31 11:14:22 -05:00
Michael
a2c9aa8e11 Accept public and user contact id for permissionsets 2020-12-31 15:22:38 +00:00
Hypolite Petovan
422de110e6
Merge pull request #9727 from annando/notice
Fix a notice when the path is empty
2020-12-31 07:15:12 -05:00
Michael
fec5f2c217 Fix a notice when the path is empty 2020-12-31 07:54:56 +00:00
Hypolite Petovan
fff565a80b Prevent alt text of emoji image tags to be converted to smilies in BBCode::convert 2020-12-30 22:23:58 -05:00
Hypolite Petovan
beaef12296 Add missing first file/line in exception template 2020-12-30 21:15:01 -05:00
Hypolite Petovan
e342f69e21 Simplify item sanitization in Util\ACLFormatter 2020-12-30 21:11:24 -05:00
Hypolite Petovan
a12380a247
Fix typo in Model\Event 2020-12-30 09:20:46 -05:00
Michael
c5c9fda93c Improved logging, avoid fatal error 2020-12-30 07:13:47 +00:00
Michael
96e140a027 Merge remote-tracking branch 'upstream/2020.12-rc' into notices 2020-12-30 07:12:59 +00:00
Michael
d666501ee0 Fix fatal error 2020-12-29 22:14:54 +00:00
Michael
a294c19d6e Fix several notices 2020-12-29 21:38:23 +00:00
Tobias Diekershoff
cf65725373
Merge pull request #9713 from annando/annando/issue9712
Comment to Twitter post is posted to AP instead
2020-12-28 08:08:02 +01:00
Michael
152daaabfb Comment to Twitter post is posted to AP instead
Fixes friendica/friendica#9712
2020-12-28 06:49:23 +00:00
Hypolite Petovan
8c1e2b9800 Throw exception when item doesn't exist in Factory\Api\Mastodon\Status->createFromUriId
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-750464977
2020-12-27 21:15:21 -05:00
Michael
447bac077e Simplify the resizing 2020-12-26 21:24:36 +00:00
Michael
997319a41f Use the raw data instead of an object 2020-12-26 19:31:39 +00:00
Michael
7f56e2e7a9 Improve photo loading speed 2020-12-26 18:51:36 +00:00
Hypolite Petovan
f0eeb4900f Add support for Unicode in Model\Tag::store 2020-12-24 05:09:38 -05:00
Michael Vogel
71bd6c674b
Merge pull request #9701 from MrPetovan/bug/9636-frio-mobile-intros-buttons
[frio] Improve display of introduction action buttons on mobile
2020-12-23 19:50:16 +01:00
Hypolite Petovan
241cd32b14 Replace obsolete calls to $APP->is_mobile in templates 2020-12-23 03:25:55 -05:00
Hypolite Petovan
cab40636bd Add expected contact field in Module\Contact\Poke
- Address PHP Notice: Undefined index: photo in src/Module/Contact/Poke.php on line 94
2020-12-23 02:48:38 -05:00
Hypolite Petovan
586fb10176
Merge pull request #9697 from annando/improved-server
Server detection: Handle redirects, better Peertube detection
2020-12-22 11:14:07 -05:00
Michael Vogel
ae386a78a4
Merge pull request #9696 from MrPetovan/bug/9306-poke-privacy
Use correct request parameter type for poke privacy
2020-12-22 17:11:37 +01:00
Michael
ae8a376eab Fix wrong variable 2020-12-22 08:24:56 +00:00
Michael
a5096ea549 Server detection: Handle redirects, better Peertube detection 2020-12-22 08:12:36 +00:00
Hypolite Petovan
2ef5bf1e21 Use correct request parameter type for poke privacy 2020-12-22 01:02:42 -05:00
Hypolite Petovan
043e2224b0 Add mentions to poke posts 2020-12-22 01:02:06 -05:00
Hypolite Petovan
2ef4972782 Fix capitalization of Contact::magicLinkById calls 2020-12-22 01:01:43 -05:00
Hypolite Petovan
4b1180ec8b Restore autolink in share block content in BBCode::convertShare 2020-12-21 22:46:29 -05:00
Hypolite Petovan
b0234f4ef9 Remove autocomplete from 2FA code input fields 2020-12-21 00:25:21 -05:00
Hypolite Petovan
c8476f6838
Merge pull request #9687 from annando/drop-unused
Drop unused friendica tables
2020-12-20 19:11:45 -05:00
Hypolite Petovan
ec33957a4f
Merge pull request #9686 from annando/removed-unneeded
Remove unneeded configutation
2020-12-20 19:10:45 -05:00
Michael
1e27396851 Improved help texts 2020-12-20 16:22:25 +00:00
Michael Vogel
4ee029c9c7
Merge pull request #9684 from MrPetovan/bug/9678-required-translation
Add translation to untranslated strings in templates
2020-12-20 16:27:31 +01:00
Michael
246a90b0e6 Replaced tabs with spaces 2020-12-20 14:04:00 +00:00
Michael
6ebd023c4e Drop unused friendica tables 2020-12-20 14:01:46 +00:00
Michael
d755bbae8f Remove unneeded configutation 2020-12-20 08:56:32 +00:00
Hypolite Petovan
fbd0cefdf7 Add translation to Yourself option in view as select in profile
- Address https://github.com/friendica/friendica/issues/9682
2020-12-20 02:08:17 -05:00
Hypolite Petovan
a991f3dfcf Add translation to required labels for install checks
- Remove unused checks loop in install_base template
2020-12-20 02:08:13 -05:00
Hypolite Petovan
d5a90f384d
Merge pull request #9685 from annando/clean-avatar
Remove unused cached avatar photo entries
2020-12-20 02:04:16 -05:00
Michael
460b6d1c75 Remove unused cached avatar photo entries 2020-12-20 06:22:31 +00:00
Hypolite Petovan
65f74da45b Add translation to required labels on input fields
- Normalize display of required label
- Remove unused field_richtext template
2020-12-19 22:52:45 -05:00
Hypolite Petovan
5649861fde
Merge pull request #9681 from annando/fatal-php8
Quit when message is empty
2020-12-19 21:13:38 -05:00
Michael
92679de225 Remove orphaned avatar photo entries 2020-12-19 22:07:08 +00:00
Michael
3ec1270fde Quit when message is empty 2020-12-19 18:17:32 +00:00
Hypolite Petovan
fc19d98392
Merge pull request #9680 from annando/issue-9402
Issue 9402: Avoid message "invalid storage backend settings" on empty value
2020-12-19 13:07:02 -05:00
Michael Vogel
e66fba9757 Issue 9402: Avoid message "invalid storage backend settings" on empty value 2020-12-19 18:17:12 +01:00
Michael
944b0eadb7 Issue 9457: Fix remembering "personal" and "starred" 2020-12-19 16:48:12 +00:00
Hypolite Petovan
bcd61c8372
Merge branch '2020.12-rc' into bug/9656-purify-video-embed 2020-12-18 14:47:24 -05:00
Hypolite Petovan
95f099d26c Restore Mastodon emoji span classes
- Fix typo in replacement of [class] tag
2020-12-18 11:08:03 -05:00
Hypolite Petovan
20d9dcf7ac Bump BBCode version to 2020-12-18 2020-12-18 10:32:36 -05:00
Hypolite Petovan
0781f28ca6 Allow support for allowlisted iframe sources in Content\text\BBCode::convert
- Support Youtube, Vimeo and unused local embeds
2020-12-18 10:32:36 -05:00
Hypolite Petovan
ec0c9dcdb1 Remove support for [iframe] BBCode
- It was a huge gaping security hole, and now HTML Purify will remove the src attribute of all non-allowed sources anyway.
2020-12-18 10:32:36 -05:00
Hypolite Petovan
0dac6e9d34 Add general information header translation to admin site template 2020-12-17 22:52:30 -05:00
Michael
c1e8dbdbae Avoid "Duplicate entry" 2020-12-17 18:56:10 +00:00
Michael
66c1592171 Fix notices 2020-12-17 18:08:07 +00:00
Hypolite Petovan
38b17e1aae
Merge pull request #9668 from annando/keywarning
Fix warning "supplied key param cannot be coerced into a public key"
2020-12-17 08:25:25 -05:00
Michael
e713db4ac7 Delete tombstone contacts 2020-12-17 08:00:56 +00:00
Michael
a548e7c4be Fix warning "supplied key param cannot be coerced into a public key" 2020-12-17 07:07:54 +00:00
Michael
e22bb32247 Store the network profiler data 2020-12-17 06:23:03 +00:00
Hypolite Petovan
1414d43597
Merge pull request #9664 from annando/delete-contacts
Delete removed contacts
2020-12-16 11:28:56 -05:00
Michael
974f7bffc8 Indentation 2020-12-16 15:43:12 +00:00
Michael
a331a8cf0a Delete removed contacts 2020-12-15 22:56:46 +00:00
Michael Vogel
569ad89f10
Merge pull request #9661 from MrPetovan/bug/9651-apdelivery-inboxes
Clarify usage of ActivityPub\Transmitter::fetchTargetInboxes in Worker\APDelivery queuing
2020-12-15 22:05:59 +01:00
Hypolite Petovan
a2f14efd94
Remove reference to receivers when adding relay delivery tasks in Worker\Notifier
- Address https://github.com/friendica/friendica/pull/9661#issuecomment-745553051
2020-12-15 15:42:16 -05:00
Hypolite Petovan
6d3864a16b
Remove owner.deleted check in user deletion check in Model/Item 2020-12-15 14:24:42 -05:00
Hypolite Petovan
0951a50bcd Add item user owner data check in Model\Item::isValid
- Prevents deleted users from posting any item, manually or automatically through mirroring
2020-12-15 09:41:58 -05:00
Hypolite Petovan
8c17a6b4d9 Rename Model\User::getOwnerDataById parameter to better reflect intent 2020-12-15 09:41:10 -05:00
Hypolite Petovan
5f148dcb42 Add temporary console command to fix workerqueue row with corrupted parameter data
- It should be reverted just before the 2020.12 release
2020-12-15 00:20:49 -05:00
Hypolite Petovan
d59fcd5093 Clarify usage of ActivityPub\Transmitter::fetchTargetInboxes in Worker\APDelivery queuing
- $inbox is now always a string
- $receivers should be correctly populated now
- $target_id is renamed to $item_id and correctly initialized to 0 for non-item deliveries
2020-12-14 23:33:14 -05:00
Michael Vogel
e4228c6218
Merge pull request #9655 from MrPetovan/bug/fatal-errors
Fix several occasional fatal errors
2020-12-14 22:11:45 +01:00
Hypolite Petovan
481c5c9e81 Account for inbox array in Worker/APDelivery
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-744339671
2020-12-14 09:12:29 -05:00
Michael
c210e0b97f Issue 9657: Check the age of an item 2020-12-14 00:00:10 +00:00
Hypolite Petovan
0441b912ac Return early if an URI id cannot be obtained in ActivityPub\Processor::createItem
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-743769813
2020-12-13 13:42:08 -05:00
Michael
cd96955fcf Fix: posted unprepared posts hadn't been deleted 2020-12-13 18:17:50 +00:00
Michael
d938e37767 Set the return value 2020-12-13 17:22:50 +00:00
Hypolite Petovan
61aa4efa89 Account for missing contact in dfrn_request_post
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-743407998
2020-12-13 12:18:10 -05:00
Hypolite Petovan
8f10cf8e53 Simplify Contact::addRelationship call in ActivityPub\Processor::followUser
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-743382769
2020-12-13 12:16:04 -05:00
Michael
4626f98dbe Added logging 2020-12-13 16:38:12 +00:00
Michael
0eb4a600b0 Delay unprepared posts 2020-12-13 12:47:49 +00:00
Hypolite Petovan
c787281eff
Merge pull request #9652 from annando/issue-9584
Issue 9584: Only search posts from federated networks
2020-12-12 15:13:31 -05:00
Michael
c3d0ab56a5 Issue 9584: Only search posts from federated networks 2020-12-12 19:55:47 +00:00
Michael
297118f902 Archive/Unarchive at ActivityPub delivery 2020-12-12 16:45:23 +00:00
Hypolite Petovan
67573cf996
Merge pull request #9647 from annando/original-relay
Relay posts with the original protocol
2020-12-11 16:17:05 -05:00
Michael
61b3003f64 Standards 2020-12-11 20:20:27 +00:00
Michael
a43059df27 Relay posts with the original protocol 2020-12-11 06:35:38 +00:00
Hypolite Petovan
99b200868b Normalize return value in Database->fetch
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-741857058
2020-12-10 06:12:10 -05:00
Michael
965374596f Avoid dropping of incoming DFRN messages 2020-12-10 07:22:49 +00:00
Michael
20ded2b35a Parameters should be float ... 2020-12-10 00:02:23 +00:00
Michael
5fb83d0632 Improved performance profiler 2020-12-09 22:10:27 +00:00
Hypolite Petovan
9c0342b907
Merge pull request #9638 from annando/bad-priority
Check for bad worker priorities
2020-12-09 01:12:34 -05:00
Michael Vogel
33930b0bd9
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-12-09 06:58:19 +01:00
Michael Vogel
809035b872
Merge pull request #9635 from MrPetovan/bug/notices
Batch of notice fixes
2020-12-09 06:51:54 +01:00
Michael
dd94fb1242 Check for bad worker priorities 2020-12-08 21:58:32 +00:00
Michael
2cb71341b2 Fixes "Unknown column '729' in 'field list'" 2020-12-08 21:23:10 +00:00
Hypolite Petovan
c7a2988454 Check for the existence of array key before using it in Protocol\ActivityPub\Transmitter
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-739534960
2020-12-08 10:08:49 -05:00
Hypolite Petovan
99828c0fea Suppress notice message when guid isn't supplied in Module\Admin\Item\Source
- https://github.com/friendica/friendica/issues/9252#issuecomment-740052103
2020-12-08 10:00:09 -05:00
Michael
e17ca9cc35 Check for remote default avatars as well 2020-12-07 07:14:09 +00:00
Michael
a49a35f459 Centralized fetching of the default avatar 2020-12-07 06:43:43 +00:00
Michael
9acecfd9e6 Issue 9630: Prevent negative values for registered users 2020-12-06 18:14:05 +00:00
Michael Vogel
ce52d31afa
Merge pull request #9626 from MrPetovan/bug/9611-bbcode-convert-html-purify
Prevents share block new lines from being converted to HTML <br> tags
2020-12-06 15:53:18 +01:00
Hypolite Petovan
e6270bc46d Enable back references in reg exp in BBCode::convert
- Bump BBCode version
2020-12-06 08:57:06 -05:00
Hypolite Petovan
a863228e09
Merge pull request #9628 from annando/dfrn-delete
Don't create the parent during a deletion
2020-12-06 08:37:50 -05:00
Michael
1f1697222b Don't create the parent during a deletion 2020-12-06 09:54:34 +00:00
Hypolite Petovan
f141f5acf4 Prevents share block new lines from being converted to HTML <br> tags
- Address https://github.com/friendica/friendica/pull/9621#issuecomment-739333767
2020-12-05 19:55:16 -05:00
Michael
878a418c6b Code standards 2020-12-05 21:58:15 +00:00
Michael
2b8adf5073 Remove unused contacts 2020-12-05 21:07:48 +00:00
Michael Vogel
f9994548c1
Merge pull request #9621 from MrPetovan/bug/9611-bbcode-convert-html-purify
Add HTML Purify to BBCode::convert
2020-12-05 19:27:59 +01:00
Hypolite Petovan
1cc509c5ef Move BBCode version tagging inside of the hash to prevent item-content.rendered-hash overflow 2020-12-04 08:30:51 -05:00
Hypolite Petovan
e712706302 Add BBCode versioning
- This will trigger the re-conversion of displayed items on version update
2020-12-04 07:29:49 -05:00
Hypolite Petovan
a382798999 Add some more result panels to Babel 2020-12-04 07:29:48 -05:00
Hypolite Petovan
a0f6d678c4 Add HTML Purify to BBCode::convert
- Replace previous HTML cleanup using DOMDocument
- Remove obsolete HTML::sanitizeCSS method
- Use Strings::autoLinkRegEx for PageInfo::getRelevantUrlFromBody
- Update previous tests expectations
- Add new specific XSS tests
2020-12-04 07:29:48 -05:00
Michael
8e9a9b2049 Improved logging 2020-12-04 07:54:29 +00:00
Michael
9f96f3ef34 Moved updating personal contacts to updatecontact 2020-12-04 05:53:11 +00:00
Michael
8d999f54d0 Check and add a server 2020-12-03 22:32:51 +00:00
Michael
0c9a0ce64e Merge remote-tracking branch 'upstream/develop' into worker-command 2020-12-03 15:48:46 +00:00
Michael
edbdfbae6b workerqueue now has a "command" field 2020-12-03 15:47:50 +00:00
Michael
bd4dc10588 Ensure that the database.sql contains "if exists" 2020-12-02 08:50:45 +00:00
Michael
c1d1b189f7 Cleaned code 2020-12-02 08:36:23 +00:00
Michael
6c3b1ac4bd Moved direct storage 2020-12-02 05:41:33 +00:00
Michael
b54465ba9c Directly post non mirrored feed items 2020-12-02 05:08:39 +00:00
Michael
775075c5db Only spool mirrored posts 2020-12-02 05:07:44 +00:00
Michael
e9fecf1541 Only delay mirrored feeds 2020-12-02 04:53:54 +00:00
Michael
b2dadf0f92 Use a combined unique index 2020-12-02 00:34:10 +00:00
Michael
425440ec24 The network doesn't matter 2020-12-02 00:29:57 +00:00
Michael
c302b7c347 Check for existing post 2020-12-02 00:20:07 +00:00
Michael
4fbd0a46b5 Reducing parameter list 2020-12-02 00:05:03 +00:00
Michael
b047d31a4f Added logging and default config value 2020-12-01 23:46:50 +00:00
Michael
a283b1183b Move deletion 2020-12-01 23:04:04 +00:00
Michael Vogel
b3f71d174c Added logging 2020-12-01 23:54:49 +01:00
Michael
2aa302c570 New class for handling delayed posts 2020-12-01 22:11:29 +00:00
Michael
bb823c323b Configuration for the priority of the notification for expired messages 2020-11-30 21:40:55 +00:00
Hypolite Petovan
4f98da88c4
Merge pull request #9614 from annando/issue-8943
Issue 8943: Only check for too old postings for feeds
2020-11-30 16:09:27 -05:00
Michael
b30d2c9c6b Renamed function 2020-11-30 20:59:18 +00:00
Hypolite Petovan
9636ffe27d
Merge pull request #9615 from annando/issue-9329
Issue 9329: prevent "Expression #1 of SELECT list is not in GROUP BY clause"
2020-11-30 15:58:39 -05:00
Michael
ccc07b06de Issue 9329: prevent "Expression #1 of SELECT list is not in GROUP BY clause" 2020-11-30 20:44:21 +00:00
Michael
8bc799ff38 Issue 8943: Only check for too old postings for feeds 2020-11-30 20:32:56 +00:00
Michael
20649dd00e Replaced tab with space 2020-11-30 20:09:52 +00:00
Michael
1e09eab921 Another place found where "show less" had been "show more" 2020-11-30 19:52:57 +00:00
Michael
d4d55a5865 Issue 8605: "show less" now displays "show less" 2020-11-30 19:30:57 +00:00
Michael
5b19469a4c Fix Notice: Undefined variable: publish_at 2020-11-30 18:27:02 +00:00
Michael Vogel
d0f45c4ecb Fixed function name and variable 2020-11-30 09:59:29 +01:00
Michael
6e06e0cf20 New class for delayed postings 2020-11-30 06:59:00 +00:00
Michael
cbd1ba8da2 Post delay is in seconds 2020-11-30 06:23:27 +00:00
Michael
a7e0a1f7de The maximum delay should be a day 2020-11-30 06:19:10 +00:00
Michael Vogel
4c39c88b52 Adjusted log levels, removed spaces 2020-11-30 07:06:43 +01:00
Michael
3f3f56db57 Poll interval function moved to feed class, first steps for delayed posts 2020-11-30 05:39:12 +00:00
Hypolite Petovan
d05d5a0381
Merge pull request #9608 from annando/delete-table-view
Ensure that a view is a view and not a table
2020-11-29 16:33:07 -05:00
Michael Vogel
eb48a36061
Update src/Database/View.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-29 21:59:24 +01:00
Michael
5f1ea39bad Display posts that are reshared by the contact 2020-11-29 20:42:03 +00:00
Michael
7e6a9bd893 Ensure that a view is a view and not a table 2020-11-29 19:06:43 +00:00
Hypolite Petovan
ea2923be67
Merge pull request #9607 from annando/cron-priority
Ensure to add the cron forkhood worker task with medium priority
2020-11-29 12:49:02 -05:00
Michael Vogel
03af4062ce Ensure to add the cron forkhood worker task with medium priority 2020-11-29 17:41:20 +01:00
Michael
a68810301a Fix structure error 2020-11-29 11:43:07 +00:00
Michael
7ab63d2106 Store the protocol of the received message 2020-11-29 09:01:51 +00:00
Michael
8da8d3c4fd Only automatically reshare items from DFRN and AP 2020-11-29 00:05:46 +00:00
Michael
bda5d43f1e New "remote self" option: Native Reshare 2020-11-28 22:53:58 +00:00
Hypolite Petovan
96d4ec0f53
Merge pull request #9603 from annando/notice
Fixes notice "Undefined index: parent-uri"
2020-11-28 08:01:28 -05:00
Michael
1d4be7b01f Fixes notice "Undefined index: parent-uri" 2020-11-28 10:17:55 +00:00
Michael
b6f349076c Fix order of reshared items on the profile page 2020-11-28 06:23:17 +00:00
Michael
bd9f36622e Cast field data when ATTR_EMULATE_PREPARES is enabled 2020-11-27 11:24:31 +00:00
Hypolite Petovan
f0d6f8c45e
Merge pull request #9597 from annando/api-endpoints
API: Mastodon endpoints added as "unimplemented"
2020-11-26 09:34:36 -05:00
Michael Vogel
615eece22f
Update src/Module/Api/Mastodon/Unimplemented.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-26 14:35:06 +01:00
Michael
db5cd6e66c API: Mastodon endpoints added as "unimplemented" 2020-11-26 07:02:31 +00:00
Michael
818c064c0a The notifications parameters are now simplified 2020-11-25 19:56:39 +00:00
Hypolite Petovan
486b43f09d Avoid unmarking for archival an empty contact in Protocol\ActivityPub\Receiver
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-733198306
2020-11-24 17:32:52 -05:00
Hypolite Petovan
1342825401
Merge pull request #9586 from annando/inbox-status
Don't transmit to archived inboxes
2020-11-24 03:04:03 -05:00
Michael
495252690b available is not vital 2020-11-24 07:49:36 +00:00
Michael
23bc725ce9 Fix: Only echo on verbose 2020-11-23 19:47:30 +00:00
Michael
e4e9a20ac8 Don't transmit to archived inboxes 2020-11-23 19:25:22 +00:00
Michael
61ff99c410 Command line option to check initial values 2020-11-23 18:58:18 +00:00
Hypolite Petovan
794f98f479
Merge pull request #9578 from annando/onepoll-failed
OnePoll reworked, improved "failed" behaviour
2020-11-22 10:42:41 -05:00
Michael
7bdf22a0d5 Don't probe feeds so often 2020-11-22 14:56:38 +00:00
Michael
3ffd40c7da OnePoll reworked, improved "failed" behaviour 2020-11-22 14:42:24 +00:00
Hypolite Petovan
4fd9db1035
Merge pull request #9577 from annando/updateprofile
Contacts can now be updated from every theme
2020-11-22 08:14:09 -05:00
Michael
b52ba79620 Contacts can now be updated from every theme 2020-11-22 08:15:17 +00:00
Hypolite Petovan
ca823244cc Don't assume addons must have an *_install function
- Module-only addons don't have any
2020-11-21 23:19:03 -05:00
Hypolite Petovan
8b3ab4e6bb Refactor builtin_activity_puller() and format_like()
- Simplify output array
- Rename format_like() to format_activity()
- Remove duplicate parameters in format_activity()
2020-11-21 11:08:44 -05:00
Hypolite Petovan
e6362c4923
Merge pull request #9566 from annando/update-foo
Avoid multiple database update mails, changed log level
2020-11-21 10:53:06 -05:00
Michael
aec9f1ebf0 Remove unused config variable 2020-11-21 15:15:58 +00:00
Michael
1de6251627 Code cleaning 2020-11-21 14:58:48 +00:00
Michael Vogel
b40218eb0b Immediately fail when lock hadn't been acquired to prevent stocked updates 2020-11-21 14:17:14 +01:00
Michael Vogel
2a1c82cf05 Avoid multiple database update mails, changed log level 2020-11-21 13:28:06 +01:00
Michael
8a29d20083 Comments on PeerTube videos not working
Fixes #9407
2020-11-21 08:28:33 +00:00
Michael
1bc76fdb6d Watchdog mode to check if the daemon is running 2020-11-20 19:50:08 +00:00
Michael
cea2b13075 Parameter has to be float 2020-11-20 08:55:30 +00:00
Michael
e4c95efd80 Added minimal execution time for rendertime addon 2020-11-20 08:44:00 +00:00
Michael
32e98327a1 Fix warning 2020-11-19 21:27:08 +00:00
Hypolite Petovan
1acc5ffb38
Merge pull request #9553 from annando/insert-mode
Mode switch for insert
2020-11-19 16:25:09 -05:00
Hypolite Petovan
10a4802d81
Merge pull request #9552 from annando/zero-user
Avoid problems with uid=0
2020-11-19 16:23:28 -05:00
Michael
303aaa00ca Mode switch for insert 2020-11-19 19:34:48 +00:00
Michael Vogel
e4c6341bf4
Merge pull request #9551 from MrPetovan/task/4140-ldap-auth-logging
Make Model\User::getAuthenticationInfo accessible to addons
2020-11-19 18:21:34 +01:00
Michael
bd0e2dc0a8 Avoid problems with uid=0 2020-11-19 17:19:14 +00:00
Hypolite Petovan
a66e66359c Make Model\User::getAuthenticationInfo accessible to addons
- It contains the centralized authentication requirements for user records
2020-11-19 11:20:17 -05:00
Michael
3af5f6b8ee Some more foreign keys added 2020-11-19 06:26:30 +00:00
Michael Vogel
f69c043bec
Update src/Protocol/OStatus.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-18 18:07:20 +01:00
Michael
a1dcbedc6f Fix Notice: Undefined variable: valid in /src/Protocol/OStatus.php on line 526 2020-11-18 13:47:29 +00:00
Michael
0edc058a17 Ensure that the daemon is called faster and more reliably 2020-11-18 13:29:10 +00:00
Michael
f36ecdf6bf Replacing deprecated log calls 2020-11-18 09:14:12 +00:00
Michael
4f7d42a0d3 Fixed copy&paste error 2020-11-18 05:55:15 +00:00
Michael
b09ffa0697 Relocate system user creation 2020-11-18 05:33:17 +00:00
Michael
d7fa58d81c Ensure to never delete the "0" user 2020-11-18 05:24:04 +00:00
Michael
81a03b137b Test: only insert empty user 2020-11-18 05:04:17 +00:00
Michael
1e9d3342a3 Changed order of inserts 2020-11-18 00:13:39 +00:00
Michael
fed1ace311 Fix condition 2020-11-17 23:59:14 +00:00
Michael
317921e51c Changed order 2020-11-17 23:45:16 +00:00
Michael
3fe7d035d4 Merge remote-tracking branch 'upstream/develop' into post-user 2020-11-17 23:31:41 +00:00
Michael Vogel
dc5624b0b6
Merge pull request #9543 from MrPetovan/bug/notices
Address several notices
2020-11-18 00:30:31 +01:00
Hypolite Petovan
096cb19d12 Suppress notice when causer-id exists but not causer-link in Model\Item::isAllowedByUser
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-723440980
2020-11-17 18:06:16 -05:00
Hypolite Petovan
ccad67c68f Use correct contact key in Protocol\ActivityPub\Transmitter
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-719866843
2020-11-17 17:59:39 -05:00
Hypolite Petovan
93380b8471 Suppress notice while logging in Model\Contact
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-716042132
2020-11-17 17:57:37 -05:00
Hypolite Petovan
283b70928d Remove top-level parent check from Protocol\OStatus
- It's done in Item::insert instead
- Address part of https://github.com/friendica/friendica/issues/9252#issuecomment-729171051
2020-11-17 17:54:07 -05:00
Hypolite Petovan
54aef550c5 Remove superfluous mentions of parent-uri in Protocol\Diaspora
- Address part of https://github.com/friendica/friendica/issues/9252#issuecomment-729171051
2020-11-17 17:54:07 -05:00
Michael
7615c022be Improved logging 2020-11-17 22:41:53 +00:00
Michael
219c651289 Removed test logging 2020-11-17 22:38:52 +00:00
Michael
eaa58da25b New table "post-user" and more foreign keys 2020-11-17 22:33:44 +00:00
Hypolite Petovan
b2666e7794 Escape user name in introduction fields help text
- HTML help text aren't escaped in the template

# Conflicts:
#	src/Module/Notifications/Introductions.php
2020-11-16 18:21:11 -05:00
Hypolite Petovan
ba0d3b2435
Merge pull request #9537 from annando/item-lock
Fallback to database lock if locking fails
2020-11-16 16:05:24 -05:00
Michael
deb6b7a7c3 Fallback to database lock if locking fails 2020-11-16 19:46:20 +00:00
Hypolite Petovan
a69c98e32f
Merge pull request #9535 from annando/ap-relay
Relay code reworked to support AP delivery
2020-11-15 20:27:08 -05:00
Michael
0384bf3e76 Relay code reworked to support AP delivery 2020-11-15 23:28:05 +00:00
Michael Vogel
42be636118
Merge pull request #9515 from MrPetovan/task/9464-block-replies
Reject replies when author is blocked by thread owner
2020-11-15 18:44:48 +01:00
Hypolite Petovan
dbb33399bc Prevent image descriptions from being replaced by local smilies
- AP-received emojis have their code in the image description
2020-11-15 00:12:26 -05:00
Hypolite Petovan
b5d3fcb8d4 Move top-level permission check outside of Model\Item::getTopLevelParentData
- It wasn't checked when the direct parent was also the top-level parent
2020-11-14 10:11:26 -05:00
Hypolite Petovan
cb963a3259 Retrieve local top level parent item separately to check permissions in Model\Item::getTopLevelParentData 2020-11-14 10:11:26 -05:00
Hypolite Petovan
2e7c505ac0 Revert wrong item.thr-parent field usage in Protocol\OStatus 2020-11-14 10:08:52 -05:00
Hypolite Petovan
042f6b98ac Remove unnecessary data array assignment in Protocol\Feed 2020-11-14 10:08:51 -05:00
Hypolite Petovan
5ce8cc24de Clarify parameter type in DFRN::mail 2020-11-14 10:08:51 -05:00
Hypolite Petovan
ff66633a44 Remove references to item.parent-uri in Worker\OnePoll 2020-11-14 10:08:51 -05:00
Hypolite Petovan
a9d114316d Ensure the parent field isn't set during Item insertion
- Avoid a database error if a null value is provided
2020-11-14 10:08:51 -05:00
Hypolite Petovan
d3708cf1c2 Fix wrong variable use in Model\Item::getTopLevelParent
- It was preventing items at levels 3 and beyond to be inserted
- Logging for missing top level parent has been bumped to notice
2020-11-14 10:08:51 -05:00
Hypolite Petovan
355cd401ae Replace uri fields conditions by gravity condition in Model\Item::insert 2020-11-14 10:08:51 -05:00
Hypolite Petovan
ffc364f2a4 Reject replies when author is blocked by thread owner in Model\Item::insert
- Move user-level item permission to Model\Item::isAllowedByUser
- Add user-level check for comments on top-level item
2020-11-14 10:08:50 -05:00
Hypolite Petovan
0f2a5daf09 Replace confusing uses of item.parent-uri with expected item.thr-parent 2020-11-14 10:08:50 -05:00
Hypolite Petovan
0c3a5c815e Remove obsolete references to item.parent-uri 2020-11-14 10:08:50 -05:00
Hypolite Petovan
d7e1ce47bb Use item.thr-parent as expected in Model\Item::insert()
- Rework Model\Item::getTopLevelParent
- Backward compatibility with item.parent-uri is ensured
2020-11-14 10:08:50 -05:00
Hypolite Petovan
490ce976c1
Merge pull request #9531 from annando/fatal
Check for empty body to prevent a fatal error
2020-11-12 13:41:26 -05:00
Michael
ae363b74ad Check for empty body to prevent a fatal error 2020-11-12 16:52:55 +00:00
Hypolite Petovan
6dee10f340
Merge pull request #9530 from annando/fatal
Fix fatal errors
2020-11-12 07:57:53 -05:00
Michael
36c65643fb Fix fatal errors 2020-11-12 05:17:48 +00:00
Michael Vogel
acae3df0a2
Merge pull request #9526 from MrPetovan/bug/9525-mastodon-emojis-tag
Restore expected implementation of JsonLD::fetchElementArray
2020-11-12 05:47:46 +01:00
Hypolite Petovan
a8f16788f4 Prevent multiple replacements for the same emoji in Protocol\ActivityPub\Processor::replaceEmojis 2020-11-11 18:28:26 -05:00
Hypolite Petovan
42db861759
Merge pull request #9527 from annando/fetch-object-by-url
Fix: Fetch object by URL
2020-11-11 13:14:20 -05:00
Michael
ba38ab2c55 Fix: Fetch object by URL 2020-11-11 17:55:33 +00:00
Hypolite Petovan
fa003eaa84 Fix expected implementation of JsonLD::fetchElementArray
- Added expected field value matching
2020-11-11 11:19:08 -05:00
Michael Vogel
61dcd62921
Merge pull request #9522 from MrPetovan/bug/ap-blocked-followers
Prevent ActivityPub message transmission to blocked followers
2020-11-11 15:28:04 +01:00
Hypolite Petovan
0de8319c15 Filter blocked contacts out from Protocol\ActivityPub\Transmitter::getContacts 2020-11-11 09:18:51 -05:00
Hypolite Petovan
4fce6a919f Suppress notice when network page is empty 2020-11-11 03:05:12 -05:00
Hypolite Petovan
6b8c8b03c6 Prevent ActivityPub message transmission to blocked followers 2020-11-11 02:52:23 -05:00
Michael Vogel
7765bd8e43
Merge pull request #9512 from MrPetovan/bug/9501-admin-users-fixes
[frio] Improve admin user list display
2020-11-10 07:07:59 +01:00
Hypolite Petovan
b1bc8ebbfa
Merge pull request #9517 from annando/no-duplicated
Improve duplicate check
2020-11-09 16:00:52 -05:00
Michael
c4f1719e8d Improve duplicate check 2020-11-09 20:29:42 +00:00
Hypolite Petovan
8fe5da930a Only set the current notify as seen when user enabled detailed notifications 2020-11-09 11:41:21 -05:00
Hypolite Petovan
a35707ec8f Improve admin user field is_deletable to check user.account_removed 2020-11-09 10:08:33 -05:00
Hypolite Petovan
7debe1e999 [AP] Use contact.alias if it exists instead of contact.url for mention links
- Make mentions links handled by Mastodon for logged in users
2020-11-08 23:32:02 -05:00
Hypolite Petovan
edd439cfab Simplify code in Content\Text\BBCode::convert
- Use performWithEscapedTags instead of custom solution
2020-11-08 23:25:46 -05:00
Hypolite Petovan
ae00111f5b Fix redirect/form paths in Module\Admin\Users\Index|Active 2020-11-08 20:09:10 -05:00
Hypolite Petovan
ecb0c46323 Normalize mention formatting for AP 2020-11-08 14:21:20 -05:00
Hypolite Petovan
4b090c2c08 Never mention yourself in AP messages 2020-11-08 14:21:08 -05:00
Hypolite Petovan
388c0b69d6 Split admin/users into 6 separate modules
- They now feature working pagination
2020-11-08 12:53:12 -05:00
Hypolite Petovan
213716d44c Remove unused code in Module\Register 2020-11-08 12:53:12 -05:00
Hypolite Petovan
126ef0ae82 [frio] Add link to settings in account delegation page 2020-11-08 12:53:12 -05:00
Hypolite Petovan
ffb4292b0b Improve accuracy of User::getList with type = blocked
- user.blocked is used for pending registrations as well
2020-11-08 12:53:12 -05:00
Michael
498dda7999 Fix parser issues when a video is linked without a matching extension 2020-11-08 09:24:01 +00:00
Michael
eb8caaa5e7 Restore the connection check 2020-11-07 11:44:39 +00:00
Michael
8906615b2c Test if PDO doesn't work on the tests 2020-11-07 10:27:22 +00:00
Michael
84924d1c05 Test the tes 2020-11-07 10:12:31 +00:00
Michael
d6a1a836f1 Simplified connection test 2020-11-07 09:58:20 +00:00
Michael
3a5cdecb62 New function to fetch the database driver 2020-11-07 09:02:02 +00:00
Michael
43749c3069 The "attach" field is now deprecated 2020-11-07 08:22:59 +00:00
Michael
d383f49f1e The "[attach]" field is replaced by the "post-media" table 2020-11-06 04:14:29 +00:00
Hypolite Petovan
bb99b0bebe Allow models extending BaseModel to have an id equal to 0 2020-11-05 10:03:40 -05:00
Hypolite Petovan
c9c3d022bd
Merge pull request #9492 from annando/fix-fatal
Handle fatal error when attachment url is null
2020-11-04 09:56:53 -05:00
Hypolite Petovan
4e65b54b60
Merge pull request #9490 from annando/forum-fix
Fix: Posts sent to forums had been rejected
2020-11-04 09:56:20 -05:00
Michael
49fee4096a Handle fatal error when attachment url is null 2020-11-04 13:14:33 +00:00
Michael
29ec0bb98d Replaced debug log 2020-11-04 13:05:07 +00:00
Michael
e5704eb05a Fix: Posts sent to forums had been rejected 2020-11-04 08:57:21 +00:00
Michael Vogel
bf50f80399 Fix fatal error "Argument 2 passed to Friendica\Model\Post\Media::getAttachElement() must be of the type int, string given" 2020-11-04 07:58:04 +01:00
Michael
65b07aead4 Indention, documentation 2020-11-03 20:30:59 +00:00
Michael
4965d6aa54 The profile page does now shows reshared items 2020-11-03 19:24:47 +00:00
Hypolite Petovan
1e1d7a4411 Ensure we provide a mediaType string to Post\Media::getAttachElement
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-720101289
2020-11-02 00:23:08 -05:00
Michael
ba4685dfb1 API: Support for reshared items 2020-11-01 11:01:57 +00:00
Michael
c030275815 API: accounts and trends 2020-10-31 22:32:26 +00:00
Michael
752f5b09d7 Use the raw body if not null 2020-10-31 16:32:41 +00:00
Michael
e6030e5f82 API: Media attachments are now supported 2020-10-31 16:10:27 +00:00
Michael
42d246ef73 API: Media attachments are now supported 2020-10-31 16:09:27 +00:00
Michael
6b12ef14f5 Fixed spelling 2020-10-31 14:09:44 +00:00
Michael
8485c8c357 The post-media table now works with the "attach" field as well 2020-10-31 13:26:08 +00:00
Michael
db8be13bbf Fix order on network page 2020-10-30 22:13:14 +00:00
Michael
5956de645d Improve expiry query 2020-10-30 20:26:16 +00:00
Michael
da370c44ba Added lock for contacts, improved logging 2020-10-30 17:26:12 +00:00
Michael
930897046d Merge remote-tracking branch 'upstream/develop' into item-lock 2020-10-29 21:07:24 +00:00
Michael
46bd1704df Fix notice "Undefined index: network" and warning "strpos(): Empty needle" 2020-10-29 13:28:27 +00:00
Michael
56fe1400a7 Next renamed function 2020-10-29 09:03:06 +00:00
Michael
e3df7eb131 Superfluous to-do removed 2020-10-29 08:50:35 +00:00
Michael
5ac73a847d Functions renamed 2020-10-29 08:48:08 +00:00
Michael
e548d647aa New table for attached media files 2020-10-29 05:20:26 +00:00
Tobias Diekershoff
017bdd3fbb
Merge pull request #9460 from annando/issue-9457
Issue 9457: Fix network order for starred and mention
2020-10-27 11:25:16 +01:00
Michael
a012234d82 Publish the provider fields in the API 2020-10-26 19:40:09 +00:00
Michael
2f3918c3a3 Issue 9457: Fix network order for starred and mention 2020-10-26 06:54:10 +00:00
Michael
44a4b66539 Improved self contact detection 2020-10-25 20:40:25 +00:00
Michael
d8d96e6e61 Display the user fields for the admin account 2020-10-25 20:32:45 +00:00
Michael
319ceeda3b Publish the profile fields 2020-10-25 18:21:18 +00:00
Michael
463f8ee3f3 Use lowercase for tags 2020-10-25 17:59:28 +00:00
Michael
825189e8e9 Don't publish some fields 2020-10-25 17:42:42 +00:00
Michael
72efcc8169 "locked" is boolean 2020-10-25 16:59:38 +00:00
Michael
13b14bff91 Return 'null' on empty card 2020-10-25 16:55:05 +00:00
Michael
efcd76d3a7 Spaces to tabs 2020-10-25 16:26:47 +00:00
Michael
a643888aeb More data for the Mastodon status class 2020-10-25 16:13:31 +00:00
Michael
d9452588bd Avoid deleting newly create item-uri entries 2020-10-25 07:41:01 +00:00
Hypolite Petovan
59cb53b011
Merge pull request #9455 from annando/remote-self
Move "remote self" to the contact settings
2020-10-24 18:15:02 -04:00
Michael
89509f02e4 Move "remote self" to the contact settings 2020-10-24 21:42:49 +00:00
Michael
d639912f38 Disable the "proc_open" option when it isn't available 2020-10-24 19:33:38 +00:00
Michael
fd0e5cfe48 Added logging for executing child processes 2020-10-24 18:40:15 +00:00
Michael
8bd45ab857 "commented" is the default 2020-10-24 13:44:31 +00:00
Michael
adb660f1ad Issue 9451: We now do store the tab in a config again 2020-10-24 13:11:44 +00:00
Michael
58383f38d7 Alternative item insert lock mechanism 2020-10-24 13:09:35 +00:00
Michael
592ac53ffc Worker priority / no shadow worker 2020-10-24 08:05:03 +00:00
Michael
f405336680 Avoid duplicate item entries 2020-10-23 19:10:17 +00:00
Philipp
74305b3dc8
Merge pull request #9441 from annando/fatal
Fix Fatal error
2020-10-20 19:33:39 +02:00
Michael
c9d79040cb Fixes notice: Undefined index: nobody in /src/Util/HTTPSignature.php on line 450 2020-10-20 15:19:06 +00:00
Michael
097e3d6dcc Fix Fatal error: Uncaught TypeError: Argument 1 passed to Friendica\Model\Contact::getByURL() must be of the type string, null given 2020-10-20 15:15:33 +00:00
Hypolite Petovan
4719af6724
Merge pull request #9440 from annando/one-click-follow
Follow/Unfollow contact with a single click
2020-10-20 11:09:56 -04:00
Michael
33575a94fa Follow/Unfollow contact with a single click 2020-10-20 03:49:58 +00:00
Hypolite Petovan
feabf80476
Merge pull request #9437 from nupplaphil/task/httprequest_head
Add HTTPRequest::head() function
2020-10-19 08:36:00 -04:00
Hypolite Petovan
5232a8583f
Merge pull request #9436 from nupplaphil/task/test_notices
Fix notices/deprecation notes/wrong calls in "test" directory
2020-10-19 07:26:16 -04:00
Hypolite Petovan
335cd76baf
Merge pull request #9431 from annando/network-order
Network: Fix continuous load issues
2020-10-19 07:23:22 -04:00
Philipp
d524a9569f
lower loglevel 2020-10-18 22:32:36 +02:00
Philipp
a74d88c4ee
Remove 'headers' option occurrences and add a warning if used. 2020-10-18 22:31:26 +02:00
Philipp
c19f1a83ce
Remove option 'novalidate' flag from HTTPRequest options 2020-10-18 22:23:07 +02:00
Philipp
54d78f9ce1
Removed completely un-used 'http_auth' option from HTTPRequest 2020-10-18 22:19:03 +02:00
Philipp
61da51c2d5
Add HTTPRequest::head() function 2020-10-18 22:15:53 +02:00
Philipp
a6fc9cd32e
Remove $binary flag for HTTPRequest::get(), HTTPRequest::fetch(), HTTPRequest::fetchAll() (deprecated since PHP 5.1.3) 2020-10-18 20:56:31 +02:00
Philipp
d55ecb9288
Fix a lot of notices/warnings/deprecation notes in the test directory 2020-10-18 20:52:27 +02:00
Michael
90b5421c01 Use $get 2020-10-18 04:05:52 +00:00
Michael Vogel
7db4fa6bf4
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-17 21:24:51 +02:00