Commit graph

803 commits

Author SHA1 Message Date
Michael Vogel
efe358c617
Merge pull request #6746 from nupplaphil/issue/6338-notices
Fixing notices
2019-02-24 15:44:54 +01:00
Philipp Holzer
5b932867c3
Fixing https://github.com/friendica/friendica/issues/6338#issuecomment-466749280 2019-02-24 15:22:14 +01:00
Hypolite Petovan
67aa188830 Improve Logger calls
- Add context in various calls
- Remove deprecated Logger::log call in Processor
2019-02-23 17:32:13 -05:00
Hypolite Petovan
cb78e77850 Fix implicit mentions in outgoing ActivityPub posts
- Add usage of system.disable_implicit_mentions to disable implicit mention behavior
- Add usage of item own implicit mentions to be prepended to the outgoing body
2019-02-23 17:32:12 -05:00
Hypolite Petovan
3ac8576c8e Fix implicit mentions in incoming ActivityPub posts
- Use thr-parent instead of parent-uri to retrieve implicit mentions to remove from body
- Add potential implicit mentions to 'tags' array for storage in Processor::convertImplicitMentionsInTags()
- Add usage of system.disable_implicit_mentions to disable implicit mention behavior
2019-02-23 17:32:12 -05:00
Hypolite Petovan
fc47a07801 Fix Diaspora outgoing implicit mention
- Use name instead of nick for implicit mention
- Rename $parent to $toplevel_item in Diaspora::constructComment
- Use thread parent to retrieve the expected mention instead of the top level item
2019-02-23 17:32:12 -05:00
Hypolite Petovan
0cc0df9e3e Rename system.disable_mentions_removal config key to system.disable_implicit_mentions
- Update configuration key description
2019-02-23 17:32:11 -05:00
Hypolite Petovan
8c1db51a76 Improve Logger calls
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
Michael
ca7ceb6fe2 We should return something ;-) 2019-02-13 17:26:54 +00:00
Michael
d4baa25349 New configuration to disable the automatic mentions removal 2019-02-13 17:23:23 +00:00
Hypolite Petovan
63f083f6fb Include new lines in implicit mention regular expression 2019-02-13 08:08:46 -05:00
Michael
3b7e9cc3a2 This now should really prevent sending the follow requests only once 2019-02-10 18:59:05 +00:00
Michael
04f34de3a1 Multiples follows shouldn't be send anymore 2019-02-10 18:42:51 +00:00
Michael
58eaf0ba1c Prevent multiple send follow requests 2019-02-10 18:03:01 +00:00
Michael Vogel
c7308d98fa
Merge pull request #6614 from MrPetovan/task/6552-add-explicit-mentions
Add explicit mentions to ActivityPub/Diaspora comments
2019-02-10 00:52:40 +01:00
Hypolite Petovan
ed89a22995 Add context to some logger calls in ActivityPub\Processor 2019-02-09 08:34:54 -05:00
Hypolite Petovan
199fac3397 Prepend implicit author mentions in outgoing Diaspora comments
- Add Diaspora::prependParentAuthorMention method
2019-02-08 23:10:36 -05:00
Hypolite Petovan
e514ecb6fa Prepend implicit mentions to outgoing ActivityPub messages
- Add Transmitter::prependMentions method
- Fix Transmitter::mentionCallback return value when contact isn't found
2019-02-08 23:09:02 -05:00
Hypolite Petovan
e352408876 Remove implicit mentions from incoming ActivityPub messages
- Add Processor::getImplicitMentionList and Processor::removeImplicitMentionsFromBody methods
- Rename Processor::constructTagList to Processor::constructTagString
- Add implicit mention skip in Processor::constructTagString
- Invert parameter order in Processor::replaceEmojis
2019-02-08 22:57:35 -05:00
Hypolite Petovan
1eb607b351 Add missing non-empty data condition to Protocol\PortableContact 2019-02-08 09:24:04 -05:00
Hypolite Petovan
066ad8c01b Add PortableContact constants
- Fix typo in mod/admin
- Replace deprecated Logger::log calls
2019-02-08 08:38:13 -05:00
Michael
ebe767b290 Hopefully final fix for false notifications 2019-02-07 05:38:43 +00:00
Michael
16bf9c771d The automatic follow request is currently deactivated, due to false notifications 2019-02-06 21:34:44 +00:00
Michael
a7963fe18a AP: Automatically send follow requests for reshared items 2019-01-30 21:33:23 +00:00
Michael
fc0acd7b1f AP: Debug option to deliver via AP first 2019-01-30 19:33:08 +00:00
Michael
fce46f5124 AP: Follow a note to receive all upcoming activities 2019-01-30 16:30:01 +00:00
Michael
2c0ee72064 Ap: Clarify message distribution for forum posts 2019-01-30 13:07:23 +00:00
Michael
030c0b5dc6 Another preparation for forum posts via AP 2019-01-28 06:23:06 +00:00
Michael
ebb84f5e43 DFRN comments are now stored as comments again 2019-01-24 18:54:45 +00:00
Michael
7e31cebb67 Parameters redone 2019-01-23 22:04:14 +00:00
Michael
0fdab4ed10 Fix for several fatal errors 2019-01-23 21:54:20 +00:00
Hypolite Petovan
a6786ac814 Update array notation in Protocol\DFRN 2019-01-23 09:07:00 -05:00
Hypolite Petovan
f8c782380f Remove unused code/use statements 2019-01-23 09:06:58 -05:00
Hypolite Petovan
64847e7cc8 Fix types in doc blocks/prototypes 2019-01-23 09:06:58 -05:00
Hypolite Petovan
cef6757c92 Replace REGISTER_* constants by Module\Register::* ones 2019-01-22 22:24:15 -05:00
Hypolite Petovan
0cc1a07cfa Fix default value of contact parameter of OStatus::import in mod/salmon 2019-01-22 08:53:53 -05:00
Hypolite Petovan
604262a70e Extract title determination from OStatus::entryHeader logic 2019-01-22 01:59:22 -05:00
Hypolite Petovan
722284ca8e Fix unused $kw variable in Protocol\Diaspora 2019-01-21 11:12:51 -05:00
Hypolite Petovan
e7be87df93 Fix missing $ in front of variable names 2019-01-21 11:12:49 -05:00
Hypolite Petovan
7f2dc40601 Fix potential bugs without expected behavior change
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Hypolite Petovan
3d839bb176 Move Contact::ACCOUNT_TYPE_* constants to User::ACCOUNT_TYPE_*
- Keep Contact::TYPE_* constants for comparison with contact.contact-type
2019-01-21 10:56:27 -05:00
Hypolite Petovan
ad9c67663d Move Contact::Page_* constants to User::PAGE_FLAGS_* 2019-01-21 10:55:37 -05:00
Hypolite Petovan
4a95ca280d Remove unused code
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
Hypolite Petovan
cb3f09ae4f Refactor namespaces
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
Hypolite Petovan
070aa016e0 Update more PHPDoc, including in include/ 2019-01-21 10:39:28 -05:00
Hypolite Petovan
af9067a381 Update PHPDoc in mod/ 2019-01-21 10:39:27 -05:00
Hypolite Petovan
3282ce5389 Fix PHPDoc comments project-wide 2019-01-21 10:35:51 -05:00
Hypolite Petovan
55e54bb950 Replace deprecated Addon::callHooks with Hook::callAll
- Update documentation
2019-01-21 09:50:56 -05:00
Hypolite Petovan
895b3abf32 Remove/replace killme() with *exit() 2019-01-21 09:49:17 -05:00
Michael
70c183b495 AP Bugfix: We hadn't transmitted an tag url at all ... 2019-01-20 23:13:55 +00:00
Michael
e2427eb9da We only need to fetch the content once 2019-01-20 22:56:33 +00:00
Michael
9e7c59481f Improved ID detection 2019-01-20 22:19:53 +00:00
Michael
e5d694f7fa AP: Only reshare stuff that is AP content 2019-01-20 21:52:43 +00:00
Michael
809e556009 Transmit via BCC if contact is hidden, don't store announces 2019-01-19 16:44:15 +00:00
Michael
d813d72b1a Simplyfies AP relaying, fixes relaying of public contacts 2019-01-17 23:06:27 +00:00
Michael
c359c162a7 Issue 6282: Update the contact data regularly (including the network) 2019-01-16 21:39:56 +00:00
Hypolite Petovan
90e25faf44
Merge pull request #6447 from annando/peertube
Enable communication with Peertube
2019-01-14 08:40:42 -05:00
Michael
aa4aaf1971 Enable communication with Peertube 2019-01-14 12:10:11 +00:00
Hypolite Petovan
795268eb7a Fix undefined offset notices in Protocol\Email 2019-01-14 00:05:51 -05:00
Michael
d113ccd93c Making Friendica compatible to Nextcloud Social 2019-01-13 09:38:01 +00:00
Michael
297a549590 Issue 6282: Update the forum status of contacts 2019-01-12 16:09:27 +00:00
Michael
28f14c7d60 Don't show deleted contacts, changed "pending" behaviour 2019-01-12 13:28:14 +00:00
Michael
e3576fa0bd Don't accept private answers to public parents 2019-01-10 22:51:03 +00:00
Michael
1a702359f1 Unfollow should now work with Pleroma again 2019-01-10 07:24:12 +00:00
Michael
defc89fa9a Fixing the Accepting of contact requests 2019-01-09 22:30:26 +00:00
Hypolite Petovan
e447375cdd
Merge branch '2019.01-rc' into bug/6334-escape-get-app 2019-01-06 16:38:48 -05:00
Michael
9a4fc0f8bd Issue 6347: Removing the old way to fetch Diaspora posts to avoid Hubzilla problems 2019-01-06 07:43:11 +00:00
Hypolite Petovan
fc87c51bb4
Merge pull request #6377 from annando/ostatus-notice
Prevent a notice ... again
2019-01-04 11:28:31 -05:00
Michael
d8d5031935 Prevent a notice ... again 2019-01-04 15:34:53 +00:00
Hypolite Petovan
5e1ceb57de Escape global namespaced get_app() calls
- Add deprecated status
2019-01-03 21:27:36 -05:00
Hypolite Petovan
3095d4aa70 Add parent to private message notifications
- Fix item id for Diaspora private message notification
2018-12-30 01:10:10 -05:00
Hypolite Petovan
5abc22f6c5 Replace q() with DBA methods, fix code style
- Remove unused variables
- Fix doc block
- Fix indentation
2018-12-30 01:08:51 -05:00
Michael
fd6c64f9c1 Warning and notice fixed 2018-12-29 09:53:31 +00:00
Michael Vogel
94eca77041
Merge pull request #6315 from MrPetovan/bug/6309-add-fulltext-index-profile
Rework mod/match and mod/msearch
2018-12-27 18:04:06 +01:00
Hypolite Petovan
56d612b2f0
Merge pull request #6323 from annando/issue-6316
Issue 6316: Do not double encode / Avoid notice
2018-12-25 11:26:54 -05:00
Michael
ccb9be8f28 Issue 6316: Do not double encode / Avoid notice 2018-12-25 12:12:59 +00:00
Hypolite Petovan
a8b0aa8c8d Normalize expected format for event fields summary, desc and location
- Remove unnecessary HTML escaping on event submit
- Add HTML escaping on event display
- Add HTML to BBCode conversion for received ActivityPub events
2018-12-24 23:00:35 -05:00
Hypolite Petovan
acaee626f5 Remove include/ requires that are now done directly from Composer 2018-12-24 09:56:25 -05:00
Michael
c43bd890a5 The "Follow" activity shouldn't be send to Diaspora 2018-12-24 14:50:21 +00:00
Jeroen De Meerleer
2d9f4b560f Too fast 2018-12-22 17:23:18 +01:00
Jeroen De Meerleer
27eddfee27 Fixed bug
$curlResult is not an array
2018-12-22 17:19:34 +01:00
Hypolite Petovan
b6e1571b1e Fix various notices 2018-12-15 04:32:47 -05:00
Michael
6733b77b73 Make it simpler 2018-12-03 19:29:06 +00:00
Michael
d76003797a Fix for notice 2018-12-03 16:32:03 +00:00
Michael
51bce11b69 Issue 5911: Fix for fetching the correct user 2018-12-03 06:16:25 +00:00
Hypolite Petovan
57695d48b4
Merge pull request #6223 from annando/ap-dba-error
Fix for "Unknown column 'guid' in 'field list'"
2018-12-02 19:18:36 -05:00
Michael
2fd65503da Avoid database error that the field "guid" is not present in the contact table 2018-12-02 15:01:08 +00:00
Hypolite Petovan
458981f75c Replace x() by isset(), !empty() or defaults()
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Michael Vogel
3f4636d490
Merge pull request #6183 from MrPetovan/bug/6135-hide-follower-only-birthdays
Hide follower-only birthday reminders
2018-11-24 15:55:43 +01:00
Michael Vogel
42a3610a79
Merge pull request #6184 from MrPetovan/task/normalize-bbcode-hashtags
Normalize BBCode hashtags links
2018-11-24 13:14:50 +01:00
Michael
ea5ba309dc Some more AP blocking 2018-11-22 22:31:48 +00:00
Michael
2f7b138b09 Block AP delivery 2018-11-22 22:23:31 +00:00
Hypolite Petovan
4874f7f8ab Remove useless rawurlencode calls for building hashtag bbcode
- Fix some formatting
2018-11-22 09:32:41 -05:00
Hypolite Petovan
de5ee56d2f Move DFRN::birthdayEvent() to Event::createBirthday 2018-11-22 00:15:09 -05:00
Hypolite Petovan
d71e856535 Replace remaining occurrences of "0001-01-01" with DBA::NULL_DATE 2018-11-21 23:53:45 -05:00
Michael
27d1da0468 One space too much 2018-11-20 20:49:06 +00:00
Michael
5c39779b45 AP: Security check against forged "create" activities 2018-11-20 20:40:47 +00:00
Michael Vogel
9dfc970bd6
Merge pull request #6144 from Alkarex/ATOM-self
Correct self attribute in ATOM feeds
2018-11-18 12:31:15 +01:00
Alexandre Alapetite
bd19e93c09 Minor code relocation
https://github.com/friendica/friendica/pull/6144/files#r234385033
2018-11-17 01:36:54 +01:00
Alexandre Alapetite
dd65c5d150 Apply correct title encoding to all cases 2018-11-17 01:30:53 +01:00