Commit graph

9798 commits

Author SHA1 Message Date
Michael
4e3102bfb3 Diaspora: Don't check the author signature when author = parent author 2022-08-22 09:54:29 +00:00
Hypolite Petovan
2957a3def6
Merge pull request #11855 from annando/contact-id2
The contact-id of a wall posting is always the owner contact
2022-08-22 04:26:45 -04:00
Michael
2a0ca80630 The contact-id of a wall posting is always the owner contact 2022-08-22 07:54:48 +00:00
Hypolite Petovan
5f62a59d2f Ensure Util\Profiler->rendertime is bool
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1221228589
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1221244898
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1221333918
2022-08-21 07:44:12 -04:00
Roland Häder
4c6940583a
Changes:
- added missing type-hints
- first access level, then static
- reformatted code following code-style
2022-08-19 19:12:30 +02:00
Roland Häder
b3906326a4
Changed:
- changed double-quotes to single
- added some empty lines for better readability
2022-08-19 19:12:29 +02:00
Michael
51331ced9b Improved function to fetch the contact id 2022-08-18 10:13:46 +00:00
Michael
a4f1df68e4 Improved contact-id detection 2022-08-18 07:48:39 +00:00
Michael
531085890a Fetch the parent only - thread parents only on reshares 2022-08-17 19:39:20 +00:00
Michael
6070221364 Improved checks in "storeForUserByUriId" to reduce recursion depth 2022-08-17 05:28:24 +00:00
Michael
3e2c684319 Some more index / fatal erros fixed 2022-08-16 11:23:47 +00:00
Michael
bb52e5a804 Cascade on author deletion 2022-08-16 04:18:29 +00:00
Michael
4d617c9c48 This cache key doesn't exist anymore 2022-08-15 18:46:10 +00:00
Michael
5b3145d7ce Several performance improvements 2022-08-15 13:23:01 +00:00
Hypolite Petovan
946db2ab45 Normalize start_time and end_time parameter names in Friendica API event endpoints 2022-08-13 23:28:20 -04:00
pankraz
bd02340162 new event APIs 2022-08-13 23:28:19 -04:00
Roland Häder
c1c37da545
Changed double-quotes to single 2022-08-13 23:24:38 +02:00
Roland Häder
52d1b9905e
Fixes:
- fixed "get() on NULL invocation, PHP is case-sensitive here
- renamed $this->baseurl to $this->baseUrl (instance) in MoveToAvatarCache to
  make it same as everywhere else
2022-08-13 22:47:57 +02:00
Roland Häder
f579d687a9
Fixes:
- fixed $this usage (kept) and got rid of static context
- "imported" exception class
- added some nice text to it
2022-08-13 22:32:56 +02:00
Hypolite Petovan
21f3a56c42
Merge pull request #11841 from Quix0r/cleanups/type-hints-documentation
Cleanups/type hints + documentation
2022-08-13 10:43:11 -04:00
Michael
c6de91a8ec Don't delete the post when there is some undeleted post-user 2022-08-13 12:24:25 +00:00
Roland Häder
88cdb695b1
Changed:
- double-quotes to single
- more space around concated strings
- removed TODO as there is sadly no IOException in PHP
2022-08-13 13:35:50 +02:00
Michael
5c5ae00370 Improved performance when updating contacts 2022-08-13 09:01:48 +00:00
Roland Häder
ff5673e2d8
Changed:
- used $this->baseurl instead of DI::baseurl() (@MrPetovan)
2022-08-13 06:52:09 +02:00
Roland Häder
cfa575b8e5
Changes:
- added missing type-hints
- added documentation
- removed parameter $baseURL while it can be locally get the same way but
  lesser parameter
- used ActivityNamespace::SALMON_ME
- changed double-quotes to single
2022-08-12 14:01:40 +02:00
Roland Häder
074bae33c9
Changes:
- added some missing type-hints
- added some documentation
- added some empty lines to `@return` statements (code-style convention)
2022-08-12 13:36:34 +02:00
Roland Häder
33c7abd376
Changes:
- methods should ALWAYS start lower-case, not upper
- documented a bit more
2022-08-12 13:13:54 +02:00
Roland Häder
9794ce0c87
Changes:
- added type-hint for $type parameter
- documented method
- unsupported verbs logged
2022-08-12 13:09:59 +02:00
Philipp
a145712f04
Merge pull request #11837 from MrPetovan/task/remove-poke
Remove poke feature
2022-08-11 18:17:11 +02:00
Roland Häder
ae9bd4f3f2
Changes:
- reformatted and documented private method
- used [] instead of deprecated/discouraged array()
2022-08-10 17:10:59 +02:00
Hypolite Petovan
809beeee9d
Merge pull request #11838 from annando/asynchronous-conversation
Conversation entries will now be stored asynchronous if possible
2022-08-10 10:42:19 -04:00
Michael
e2896b449b Changes after code review 2022-08-10 13:43:00 +00:00
Michael
d9aee0b3ea Conversation entries will now be stored asynchronous if possible 2022-08-10 09:28:18 +00:00
Hypolite Petovan
4a885a13a6 Remove poke feature 2022-08-09 14:55:55 -04:00
Tobias Diekershoff
62be1c5614
Merge pull request #11835 from annando/sql-fetchqueue
Improve SQL-Queries / fixed "fetch_parents" setting
2022-08-08 23:00:48 +02:00
Michael
548b7f43a5 Improve SQL-Queries / fixed "fetch_parents" setting 2022-08-08 20:00:21 +00:00
fabrixxm
547b4684fd Add smarty3 dirs config
`FriendicaSmarty` get work dirs from config, with fallback if not set
2022-08-08 12:28:07 -04:00
Philipp
e0ec304d2a
Merge pull request #11830 from MrPetovan/task/11826-pluralization
Use L10n->tt instead of t() for plural strings
2022-08-08 15:35:54 +02:00
Tobias Diekershoff
7634fc2425 added Gàidhlig language translation
This adds the initial translation of Friendica core into Gàidhlig by @gunchleoc

redo of #11818
2022-08-08 11:37:39 +02:00
Hypolite Petovan
71084cf9f0 Use L10n->tt instead of t() for plural string in Module\BaseApi 2022-08-08 02:08:43 -04:00
Hypolite Petovan
c19e57e176 Use L10n->tt instead of t() for plural strings in Module\Admin\Federation 2022-08-08 02:08:40 -04:00
Hypolite Petovan
f917286d6e Use L10n->tt instead of t() for plural strings for polls in Model\Item 2022-08-08 01:52:16 -04:00
Hypolite Petovan
bff6a5a9ee Add support for additional interpolated variables in L10n->tt() 2022-08-08 01:51:42 -04:00
Michael
d60d2caef6 Improved queue processing 2022-08-07 19:24:50 +00:00
Michael
22c1873064 Merge remote-tracking branch 'upstream/develop' into loop-prevention 2022-08-06 17:11:04 +00:00
Michael
87a945b295 More prevention of double processing of the same content 2022-08-06 17:06:55 +00:00
Hypolite Petovan
963ebe9193
Merge pull request #11821 from tobiasd/20220805-typo
typo in console tool
2022-08-05 10:05:06 -04:00
Tobias Diekershoff
91911c4676 typo in console tool
@gunchleoc spottet a typo while working on the translations of Friendica. This fixes it.
2022-08-05 15:37:38 +02:00
fabrixxm
704bd95608 Fix WSOD when Renderer throws exception
`HTTPException` builds a simple static version of error page if
`Renderer` throws any exception while rendering the error page.
2022-08-05 15:28:21 +02:00
Hypolite Petovan
bd246b8cc2
Merge pull request #11817 from annando/double-processing
Avoid processing the same activity
2022-08-05 09:04:33 -04:00
Michael
8b698b183d Abort when public item cannot be inserted 2022-08-05 05:48:20 +00:00
Michael
8227367522 Remove test code, add documentation 2022-08-05 04:45:31 +00:00
Michael
f222e9d278 Avoid to provess the same activity 2022-08-04 21:52:10 +00:00
Hypolite Petovan
2e00797ebc
Merge pull request #11816 from annando/fetch-parents
New option to disable the fetching of parents
2022-08-04 16:00:00 -04:00
Michael
06f7244280 New option to disable the fetching of parents 2022-08-04 19:32:36 +00:00
Roland Häder
8105668caf
Added missing 'private' field, see Processor::processContent() where it is needed 2022-08-04 10:50:44 +02:00
Hypolite Petovan
196a1de7f2
Merge pull request #11812 from annando/ap-performance
Hopefully fixes loops during message processing
2022-08-03 03:00:50 -04:00
Michael
e82ef8890b Only process entries for existing posts 2022-08-03 05:14:07 +00:00
Michael
3463e34693 Don't always fetch parent posts 2022-08-03 04:51:57 +00:00
Michael
23ef4a99bb Changes after code review 2022-08-03 04:31:56 +00:00
Michael
f2eec66240 Hopefully fixes loops during message processing 2022-08-03 03:38:03 +00:00
Hypolite Petovan
49394aedeb Add password length limit if using the Blowfish hashing algorithm
- Add new page to reset a password that would be too long
- Add support for pattern parameter in field_password
2022-08-01 12:12:18 -04:00
Hypolite Petovan
067f06b166 Rework return_path session key handling
- Add new IHandleSessions::pop() method
- Remove redirection from Authentication::setForUser()
- Add explicit return_path form parameter to Login::form()
2022-08-01 12:10:43 -04:00
Michael
c8d1bf4cdf Code standards and updated database documentation 2022-08-01 07:06:30 +00:00
Michael
81b244f91e Option to activate or deactivate the background fetching 2022-08-01 06:59:20 +00:00
Michael
f7ec8d5b8e Improved log message 2022-08-01 05:59:59 +00:00
Michael
7d5b4808cd Merge branch 'fetch' into fetch-cache 2022-08-01 05:57:59 +00:00
Michael
4be6e9a27d Cache if an activity has recently been fetched 2022-08-01 05:56:55 +00:00
Michael
6c7dfd6958 New table to control the fetching process 2022-08-01 04:48:49 +00:00
Michael
3945de5e3b No blubb allowed 2022-08-01 00:58:56 +00:00
Michael
0347f4fc66 Remove test code 2022-07-31 16:01:56 +00:00
Michael
b6da15557b The post-reason / protocol is now filled in most cases 2022-07-31 15:54:35 +00:00
Michael
06a124338a Only store the inbox-queue on activated background processing 2022-07-31 08:10:47 +00:00
Michael
371f20a1aa Decoupling is deactivated by default now 2022-07-31 07:48:35 +00:00
Michael
8b4bf890f8 Issue 11798: Handling of empty author 2022-07-30 05:30:08 +00:00
Michael
f6d11e8401 Issue 11800: Remove entry from queue in any case. 2022-07-30 04:43:18 +00:00
Hypolite Petovan
da48453931
Merge pull request #11801 from annando/no-zero
Don't add zero as receiver
2022-07-29 21:15:20 -04:00
Michael
6383b07022 Don't add zero as receiver 2022-07-29 22:56:53 +00:00
Hypolite Petovan
2e75d442a5
Merge pull request #11793 from Quix0r/reformatted-arrays
Reformatted some arrays for better readability
2022-07-29 17:54:53 -04:00
Michael
653aaf1e26 Merge branch 'post-reason' of github.com:annando/friendica into post-reason 2022-07-29 21:31:34 +00:00
Michael
f9bf2424b1 Merge remote-tracking branch 'upstream/develop' into post-reason 2022-07-29 21:29:15 +00:00
Michael
699152e15e Add more post reasons 2022-07-29 21:28:22 +00:00
Michael Vogel
fa3c5d6c5e
Update src/Content/Conversation.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-07-29 21:59:53 +02:00
Michael
0971bcf165 Make the tests happy 2022-07-29 16:05:04 +00:00
Roland Häder
1210e235fb
Extracted as variable to have 2 more array fields moved to array initialization. 2022-07-29 17:20:09 +02:00
Roland Häder
676ca36c52
Changes:
- reformatted arrays
2022-07-29 17:20:07 +02:00
Michael
2c32429d8d Fix test 2022-07-29 14:56:40 +00:00
Michael
81aaacc67d Improvements for the "post-reason" 2022-07-29 14:17:53 +00:00
Roland Häder
95ac2aa54b
Fixed a possible NULL value (not valid, at least empty string) 2022-07-29 12:45:21 +02:00
Roland Häder
f8ed028013
Changed back to $cdata. 2022-07-29 12:41:08 +02:00
Hypolite Petovan
a20d05ba39
Merge pull request #11792 from Quix0r/fixes/get-request-value
Wrong variable name fixed (maybe copy-paste mistake) + used method instead of direct array access
2022-07-28 21:17:34 -04:00
Roland Häder
eaed3945d1
Changed:
- used `$this->getRequestValue($request, 'foo', <bar>)` instead of `$request['foo'] ?? <bar>`
- fixed wrong variable naming
- changed double-quotes to single
- see https://github.com/friendica/friendica/issues/11631#issuecomment-1196410497
2022-07-29 00:38:46 +02:00
Roland Häder
37bda3e5fb
Changes:
- fixed wrong type-hint uid => int
- added returned type-hint
- added some documentation
- formatted arrays a bit
2022-07-29 00:08:38 +02:00
Hypolite Petovan
5ec407699b
Merge pull request #11790 from annando/fetchactivity
Negative caching / config for receiver / fix fatals
2022-07-28 17:29:34 -04:00
Michael
b63ad63c29 Config for receiver / fix fatals 2022-07-28 21:16:42 +00:00
Hypolite Petovan
6e7823eaaa
Merge pull request #11784 from MrPetovan/task/11779-blocklist-notification
Add email notification to all users on server domain pattern block list update
2022-07-28 16:26:51 -04:00
Michael
f0499e7269 Use negative caching 2022-07-28 20:25:38 +00:00
Michael
1aacff4ce1 Fix fatal error 2022-07-28 19:35:25 +00:00
Michael
d12c9a8f58 Caching for fetched activities 2022-07-28 19:05:04 +00:00
Hypolite Petovan
f29d9be574
Merge pull request #11785 from annando/processing
Decoupling of relay posts / endless loop removed
2022-07-28 05:42:46 -04:00
Hypolite Petovan
97ccb4d2c4 Make server domain pattern block reason mandatory 2022-07-28 05:39:51 -04:00
Hypolite Petovan
5045f9e188 Add email notification to all users on server domain pattern block list update 2022-07-28 05:39:29 -04:00
Hypolite Petovan
1810b32c26 Move server domain pattern blocklist features to its own class
- Update tests
2022-07-28 05:38:50 -04:00
Hypolite Petovan
e445975c20 Use DBA::quoteIdentifier in Database::escapeFields 2022-07-28 05:37:22 -04:00
Roland Häder
09cb4c1540
Revert "Added logging of unsupported meta-tag records" 2022-07-28 06:00:58 +00:00
Michael
a27274b3b4 Avoid loops at deletion / decoupling for relay posts 2022-07-28 05:29:47 +00:00
Roland Häder
8fb0fa2921
Added logging of unsupported meta-tag records 2022-07-28 04:10:57 +02:00
Michael
3c71392f9e Avoid endless loop while deleting 2022-07-27 21:57:05 +00:00
Michael
505191dec5 Decouple the processor from the receiver 2022-07-27 20:59:42 +00:00
Michael
3af55de978 Issue 11776 - process replies via a worker task 2022-07-27 20:03:28 +00:00
Michael
ff9dc1e291 Merge remote-tracking branch 'upstream/develop' into untrusted 2022-07-27 17:56:56 +00:00
Michael
86105635ca Improved message handling / new activity relay handling 2022-07-27 17:39:00 +00:00
Hypolite Petovan
e11d3cfeb0 Add upload feature for domain pattern block list
- Add new /admin/blocklist/server/import route
- Add form on domain pattern blocklist index page
2022-07-27 11:54:50 -04:00
Hypolite Petovan
7d7a5a65e9 Add download feature for domain block list
- Add new /blocklist/domain/download route
- Add link on /friendica page
2022-07-27 11:54:50 -04:00
Hypolite Petovan
1b2182c43c Move system messages from boot to own class 2022-07-27 11:54:50 -04:00
Michael Vogel
f9777ce0dc
Merge pull request #11770 from MrPetovan/bug/notices
Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId
2022-07-25 21:01:12 +02:00
Hypolite Petovan
488f4dcaa4 Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1193953621
2022-07-25 12:07:42 -04:00
Roland Häder
d1b21eaf42
Changes:
- use local variables
2022-07-25 17:53:54 +02:00
Roland Häder
1ac1db6173
Changed:
- rewrote to almost one block of array initialization
2022-07-25 16:49:01 +02:00
Hypolite Petovan
65cd0def22 Fix wrong type-hint in Module/DFRN/Notify
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1193958648
2022-07-25 09:09:22 -04:00
Michael
7834359957 Merge remote-tracking branch 'upstream/develop' into untrusted 2022-07-24 21:58:49 +00:00
Michael
b546173747 IMproved handling of untrusted posts 2022-07-24 21:58:09 +00:00
Hypolite Petovan
a5d679ea95
Merge pull request #11759 from annando/enqueue-posts
Fetch missing posts via a queue
2022-07-24 15:38:44 -04:00
Michael
5ab94ea921 Option to store untrusted entries 2022-07-24 19:31:31 +00:00
Michael
51cc1f679f Added trust / isActivityGone 2022-07-24 14:26:06 +00:00
Michael
55b6a89c7c Optimizing 2022-07-24 13:49:57 +00:00
Michael
72bc92db62 Standards 2022-07-24 13:11:52 +00:00
Michael
6abb4d40d6 Handle changed parents 2022-07-24 13:09:35 +00:00
Michael
06280aa5a3 Recursively delete failed worker tasks 2022-07-24 09:26:52 +00:00
Michael
c2b2e8ae9f Standards 2022-07-23 23:15:08 +00:00
Michael
073695b33c Funkwhale context file moved 2022-07-23 23:10:47 +00:00
Roland Häder
86ef7c66d3
Changes:
- added some missing type-hints, thanks to @MrPetovan
2022-07-23 23:09:35 +02:00
Roland Häder
ba1c1049d6
Changes:
- added some type-hints
- added some documentation
- used self::exists() instead of DBA::exists('user', ['uid' => $uid])
2022-07-23 21:58:00 +02:00
Roland Häder
a2a7d04fa1
Changed double-quotes to single 2022-07-23 21:58:00 +02:00
Hypolite Petovan
edc49ec9b4 Add expected "users" property to NodeInfo usage property for all versions 2022-07-23 13:21:44 -04:00
Michael
6a19639ac2 Standards 2022-07-23 14:10:07 +00:00
Michael
5d6eb4670a We now store the conversation as well 2022-07-23 13:58:14 +00:00
Michael
abf39ff9cf Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-23 12:55:34 +00:00
Michael
8c602071c2 Bookwyrm posts now work 2022-07-23 12:50:15 +00:00
Michael
7eb410bed7 Conversation/context is now stored 2022-07-23 06:52:43 +00:00
Michael
54cebf5a88 Remove test code 2022-07-21 12:42:26 +00:00
Michael
4c5e9f206e Remove ignored undo 2022-07-21 11:47:23 +00:00
Michael
99f7270e18 Improved workerqueue handling 2022-07-21 08:55:45 +00:00
Michael
3966bff8a1 Fix standards 2022-07-21 08:14:47 +00:00
Michael
2e39cebcb9 Process the replies 2022-07-21 07:08:17 +00:00
Michael
4930e77eb3 We are now setting the corresponding worker id 2022-07-21 07:05:38 +00:00
Michael
28fb022425 Reset the recursion depth at a different place 2022-07-21 06:26:31 +00:00
Michael
c775833117 Use deferred tasks 2022-07-21 06:23:55 +00:00
Michael
d4a536137d database.sql updated, standards fixed 2022-07-21 05:42:53 +00:00
Michael
4a1fb1da12 Hourly process pending queue entries 2022-07-21 05:33:01 +00:00
Michael
1d13574225 Fetching of missing posts is reworked 2022-07-21 05:16:14 +00:00
Hypolite Petovan
650e05bcb5
Merge pull request #11758 from Quix0r/fixes/wrong-variable-name
Fixed variable name + used empty()
2022-07-20 07:55:38 -04:00
Roland Häder
4b5ae32ec6
Changes:
- ops, fixed variable name (thanks to @annando)
- also used empty() for an empty array (and false/null)
2022-07-20 11:54:28 +02:00
Michael Vogel
fc52296a77
Merge branch 'develop' into diaspora 2022-07-20 08:12:30 +02:00
Michael
c20c0a1812 Restore the original functionality 2022-07-20 05:47:30 +00:00
Michael
138a15404f Fix processing of incoming Diaspora messages 2022-07-20 05:38:53 +00:00
Michael
7dcd02938d Remove entries from queue / relay detection 2022-07-20 05:37:40 +00:00
Roland Häder
1fbda27aad
Changes:
- rewrote a lot local variables to an array and returned it instead of an
  anonymous array
- added more debug/warning logging in case something went wrong -> lesser guessing! ;-)
- changed double-quote to single
2022-07-20 01:08:15 +02:00
Hypolite Petovan
d69ac56338
Merge pull request #11753 from Quix0r/fixes/missing-contact-array
Fixed missing $contact array, at least initialize it empty
2022-07-19 17:58:02 -04:00
Roland Häder
2ef0566ba5
Fixed:
- "Undefined variable: contact in .../src/Protocol/Diaspora.php on line 4097
Trying to access array offset on value of type null in .../src/Protocol/Diaspora.php on line 4097"
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1189465336
2022-07-19 23:46:09 +02:00
Roland Häder
3c540517e7
Ops 2022-07-19 23:40:29 +02:00
Roland Häder
cf8698afe6
This is the correct way:
<?php
if (!isset($foo['account_removed) || $foo['account_removed'])
?>
2022-07-19 18:08:18 +02:00
Roland Häder
4e5179a7b3
Changes:
- added some missing type-hints
- fixed some documentation (e.g. empty * line between @param and @return/throws)
2022-07-19 18:02:38 +02:00
Roland Häder
cb2a052a70
Fixed E_NOTICE, for some strange reason 'account_removed' isn't around? 2022-07-18 23:49:58 +02:00
Michael
a676cf8bed Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-18 14:05:04 +00:00
Michael
ce38e63399 Add and delete entries 2022-07-18 14:03:49 +00:00
Hypolite Petovan
42d411712b
Merge pull request #11742 from annando/server-detection
Improved server detection
2022-07-18 08:50:59 -04:00
Hypolite Petovan
2e9d1a9046
Merge pull request #11746 from annando/warn
Check for GMP module
2022-07-18 08:49:50 -04:00
Michael
ac47aed1b4 Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-18 05:32:44 +00:00
Michael
af8e059990 Renamed platform definition file 2022-07-18 03:48:19 +00:00
Michael
3bd706fcfc Superfluous todo removed 2022-07-18 03:32:49 +00:00
Michael
2f462ffa16 Store incoming posts in a queue 2022-07-18 03:31:00 +00:00
Hypolite Petovan
121607b8d9
Merge pull request #11740 from annando/json-ld
Improved JsonLD parsing
2022-07-17 17:44:53 -04:00
Michael
46fdd9893c Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-17 15:42:09 +00:00
Philipp
6175f9086e
Merge pull request #11747 from annando/fixes
Emergency fixes to fix a bunch of fatal errors
2022-07-17 16:34:53 +02:00
Michael
9a4be84853 Only check for string value 2022-07-17 13:13:14 +00:00
Michael
6882e70024 Match the documentation 2022-07-17 13:00:34 +00:00
Michael
2ddf37f32d Emergency fixes to fix a bunch of fatal errors 2022-07-17 11:47:12 +00:00
Michael
23953be7cb Merge remote-tracking branch 'upstream/develop' into warn 2022-07-17 08:51:46 +00:00
Michael
f2a4aecc05 Check for GMP module 2022-07-17 06:34:37 +00:00
Michael
d52f52f45f Somed added documentation 2022-07-17 05:42:44 +00:00
Philipp
1894302011
Merge pull request #11739 from Quix0r/fixes/missing-return-statements
Fixes/missing return statements
2022-07-16 16:23:32 +02:00
Michael
0a19759e4f Fix wrong variable type 2022-07-16 13:44:35 +00:00
Michael
8b7cb5d9ef Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-16 12:44:21 +00:00
Roland Häder
cb7f52cc6a
Fixed:
- $item is the proper array here,
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1186119430
2022-07-16 12:19:09 +02:00
Michael
8db0e090d7 Merge remote-tracking branch 'upstream/develop' into json-ld 2022-07-16 09:33:24 +00:00
Michael
8cc362fb8b Improved JSonLD parsing 2022-07-16 09:25:12 +00:00
Michael
abe3fd7605 Improved check for invalid certificates 2022-07-16 08:27:38 +00:00
Roland Häder
ce7af4edb8
All these methods need to return an integer (0=Success) or otherwise doExecute()
will return NULL.
2022-07-16 08:17:47 +02:00
Michael
896fd3fc91 Use the redirect value 2022-07-14 05:39:25 +00:00
Roland Häder
a38209db1e
Changed:
- added a final check on $link_item, as it might not be initialized or no
  record was found, thanks to @AlfredSK for reporting this
- see #11632
2022-07-13 22:05:53 +02:00
Roland Häder
4cb5cadba8
Added returned type-int "int" 2022-07-13 21:10:50 +02:00
Hypolite Petovan
1d94e2866a Enable the view module in maintenance mode
- This allows to load the default theme CSS
- Theme scripts have been updated to reflect the possibility they will be included in maintenance mode
2022-07-12 19:48:36 -04:00
Philipp
74c5c66cb5
Add docs 2022-07-13 00:27:39 +02:00
Philipp
d74e57ef2c
include suggested changes 2022-07-13 00:23:12 +02:00
Philipp
a910fd8864
Split DBStructure & View to avoid DB-calls and dependencies for basic operations
- new "Definition" classes vor DB and Views
- new "Writer" classes to create SQL definitions for DB and Views
- DBStructure & View are responsible to execute DB-querys
2022-07-12 23:40:31 +02:00
Philipp
8e547510a0
Fix HTTP Client redirect Bug 2022-07-12 20:11:53 +02:00
Hypolite Petovan
74991d1f95 Fix type hint typo in Protocol\Email::messageGetPart
- Address https://github.com/friendica/friendica/issues/11724
2022-07-11 23:05:13 -04:00
Michael
dad05f1c76 Only fetch the first word for the platform 2022-07-10 13:52:38 +00:00
Michael
85c7bacb00 Improved server detection 2022-07-10 13:01:47 +00:00
Hypolite Petovan
05ed13a279
Merge pull request #11719 from nupplaphil/feat/type_use
adhere `use` and type-hints :-)
2022-07-09 17:42:42 -04:00
Hypolite Petovan
eb8237dd89 Remove unused uid parameter in Item::newURI 2022-07-09 07:39:51 -04:00
Philipp
e8fd495847
adhere use and type-hints :-) 2022-07-09 11:41:36 +02:00
Hank Grabowski
96d3b5bcf1 Merge branch 'develop' into feature-optional-network-group-count 2022-07-08 15:35:26 -04:00
Hank Grabowski
e57e1ba1e5 Make network counts at the group level system level configurable 2022-07-08 15:29:34 -04:00
Philipp
34f2b2f558
Add the right exceptions for BaseUrl::redirect and respect them when catching exceptions at the Trust page 2022-07-07 21:47:39 +02:00
Philipp
e4a83eafb8
Add a lot of log-points 2022-07-07 21:33:41 +02:00
Roland Häder
bf809c9d57
Fixed:
> TypeError: "Argument 2 passed to Friendica\Protocol\ActivityPub\Transmitter::sendContactReject()
> must be of the type int, string given

I followed here here the documentation, may fix #11708
2022-07-06 05:43:00 +02:00
Roland Häder
4875524101
Fixed:
- added exception to prevent `TypeError` because of missing `uri-id` entry
- maybe fixes #11708
2022-07-05 18:53:51 +02:00
Michael
cc75eb5d18 Improved server detection 2022-07-05 05:04:05 +00:00
Roland Häder
ba33c95e97
Fixes:
"Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of the type string, null given, called in /var/www/.../htdocs/mod/display.php on line 305"
2022-07-03 14:45:12 +02:00
Hypolite Petovan
181c142bb4 Remove overly strict type-hint in ActivityPub\Transmission::createCachedActivityFromItem
- Fix "Return value of Friendica\Protocol\ActivityPub\Transmitter::createCachedActivityFromItem() must be of the type array, bool returned" error
2022-07-02 22:16:59 -04:00
Hypolite Petovan
e6feed65bf Rename Smilies::pregHeart to better match its purpose
- Fix "Argument 1 passed to Friendica\Content\Smilies::pregHeart() must be of the type string, array given" error
2022-07-02 22:14:20 -04:00
Roland Häder
3326c4cb31
Added missing type-hints, #11700 2022-07-01 02:50:34 +02:00
Roland Häder
1ee0e6f711
Changes:
- no NULL anymore for 2nd parameter OEmbed::toHTML()
- some double-quotes to single
2022-06-30 15:03:12 +02:00
Roland Häder
6186aac792
Fixed type-hints 2022-06-30 14:58:45 +02:00
Roland Häder
99902bb478
Changes
- ops, also this needs change since null is no longer wanted
2022-06-30 14:52:37 +02:00
Roland Häder
5c0e8c62de
Changes
- renamed Widget::accounttypes() to Widget::accountTypes()
- fixed type-hint the documentation was wrong
2022-06-30 14:50:28 +02:00
Roland Häder
83cbe586ac
Changes
- renamed Item::visibleActivity() to Item::isVisibleActivity() as this returns
  a boolean value
- added some type-hints
- added some documentation
2022-06-30 14:18:13 +02:00
Roland Häder
e33f5612ab
Changes:
- added some type-hints
- added some documentation
- changed some double-quotes to single
2022-06-27 15:16:18 +02:00
Roland Häder
a392a22eee
Changes:
- added some type-hints
- fixed some documentation (void is lately returned, not null)
- added some documentation
2022-06-27 15:16:17 +02:00
Roland Häder
703ba1439b
Some empty lines 2022-06-27 15:16:17 +02:00
Roland Häder
98bc5216ef
A bit more documentation 2022-06-27 15:16:17 +02:00
Roland Häder
9871e9718e
Changes:
- added some type-hints
2022-06-27 15:16:16 +02:00
Roland Häder
6c5acf9ee0
Fixed:
- "Argument 3 passed to Friendica\Model\Photo::createPhotoForExternalResource()
  must be of the type string, null given
2022-06-27 15:16:16 +02:00
Roland Häder
ff9707713b
Fixed:
- Friendica\Content\BoundariesPager::renderFull(int $itemCount) must be
  compatible with Friendica\Content\Pager::renderFull(int $itemCount): string
2022-06-27 15:16:15 +02:00
Roland Häder
8e19998191
Fixes:
- more "bool expected but null returned" errors
2022-06-27 13:49:53 +02:00
Roland Häder
7c049abfda
Fixed:
- Contact/User::isBlocked() needs to return boolean, but sometimes (strangely)
  a NULL can come from database, so let's cast it

This tries to fix:
TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
2022-06-27 11:39:18 +02:00
Roland Häder
4bdce6948f
Changed:
- $publicContact['about'] can be NULL, causing following error:
--------------------------
Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of
the type string, null given, called in /.../src/Object/Api/Twitter/User.php
--------------------------
The "expensive" code there can be avoided being called by an empty string or
NULL to increase performance.
2022-06-26 23:28:48 +02:00
Philipp
e594656a48
Merge pull request #11684 from MrPetovan/bug/11651-ap-fetch-queue
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
2022-06-26 13:36:19 +02:00
Hypolite Petovan
91f5a7cc6b Convert potential spaces in Memcache(d) key names
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166475036
- Add test for space in cache keys
2022-06-26 07:30:30 -04:00
Philipp
b67e488236
adaptions 2022-06-26 10:13:32 +02:00
Philipp
0223c030a9
Improve 2 factor usage 2022-06-25 23:04:00 +02:00
Philipp
f3de8d7764
improve 2fa token field 2022-06-25 22:48:35 +02:00
Philipp
759d9d9f1a
Add more 2fa properties 2022-06-25 22:48:34 +02:00
Philipp
b86ff1e970
Rename 2FA recovery message 2022-06-25 22:48:34 +02:00
Hypolite Petovan
da32fa8fa6 Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
- These classes are used to flatten the recursive missing activity fetch that can hit PHP's maximum function nesting limit
- The original caller is responsible for processing the remaining queue once the original activity has been fetched
2022-06-25 12:40:54 -04:00
Hypolite Petovan
3c70d592f6
Merge pull request #11689 from Quix0r/rewrites/double-quotes-single
Changed more double-quotes to single
2022-06-25 12:02:01 -04:00
Roland Häder
e10dd20036
Made @TODO more clear? 2022-06-25 17:58:27 +02:00
Hypolite Petovan
a7d49877a8 Centralize share tag attribute extraction code in Content\Text\BBCode 2022-06-25 11:46:52 -04:00
Roland Häder
4164cdacf5
Changes:
- added type-hints
- added documentation
2022-06-25 16:48:37 +02:00
Roland Häder
804b759df1
Changes:
- let's get rid of that `Database::exists()` is being misused for checking table existence
- reformatted array
2022-06-25 16:48:37 +02:00
Roland Häder
f689faca99
Changed double-quotes to single 2022-06-25 16:48:36 +02:00
Roland Häder
88870d18be
Changes:
- added some type-hints
- added documentation
2022-06-25 16:48:36 +02:00
Roland Häder
39675fe683
Space for the rescue. ;-) 2022-06-25 16:48:35 +02:00
Roland Häder
b0693c1ad7
Reformatted array 2022-06-25 16:48:35 +02:00
Roland Häder
f12cc9648e
Changes:
- added some type-hints
- changed some double-quotes to single
2022-06-25 16:48:35 +02:00
Hypolite Petovan
aa133b5437 Add explicit gserver.site_name string truncate in Model\GServer
- Avoids "Data too long for column 'site_name'" database errors
2022-06-25 06:25:48 -04:00
Hypolite Petovan
a2afb101cd Fix off-by-one error in Message ID header count check in Util\Emailer 2022-06-25 05:35:24 -04:00
Hypolite Petovan
c75dbfd3d7 Update default value for LocalRelationship->priority to avoid null values
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166192993
2022-06-25 05:06:22 -04:00