Commit graph

3723 commits

Author SHA1 Message Date
Hypolite Petovan
0fbfb7c970 Prevents an endless loop when only the non-public contact is available in Contact::magicLinkByContact 2019-06-10 19:10:39 -04:00
Philipp Holzer
7c54edd4b4
Fixing Network::post() caused by wrong argument 2019-06-10 19:34:16 +02:00
Hypolite Petovan
9491c63934
Merge pull request #7247 from annando/fix-7242
Fixes PR 7242: Now the "post" function works again
2019-06-10 13:30:33 -04:00
Michael
7bbacd3878 Fixes PR 7242: Now the "post" function works again 2019-06-10 16:58:00 +00:00
Michael
7d0ebe8bbe Fix the detection of image posts 2019-06-10 16:06:54 +00:00
Hypolite Petovan
d7d44e1af7
Merge pull request #7245 from annando/unify-constants
Fix delivery counter for poking / unify delivery commands
2019-06-10 11:59:40 -04:00
Hypolite Petovan
151c026a8a
Merge pull request #7244 from nupplaphil/task/hidden_string
Introduce HiddenString for Config-Values
2019-06-10 10:50:41 -04:00
Michael
41dc243186 Fix delivery counter for poking / unify delivery commands 2019-06-10 14:19:24 +00:00
Philipp Holzer
50d8dbb123
Bugfixing wrong typed password setting 2019-06-10 15:46:51 +02:00
Philipp Holzer
4666b18e5b
Bugfixing empty password setting 2019-06-10 15:40:15 +02:00
Hypolite Petovan
165607ffe7
Merge pull request #7242 from nupplaphil/bugs/6917-php_warning
Add typed parameter for methods in `Friendica\Util\Network`
2019-06-10 09:22:27 -04:00
Philipp Holzer
357d9b5108
Introduce HiddenString for Config-Values 2019-06-10 14:46:31 +02:00
Philipp Holzer
cc7444d84d
Move internal recursion-counter to the end of all cur/fetchUrl parameters 2019-06-10 14:34:54 +02:00
Hypolite Petovan
1c6bf7d25a Add App parameter to Module\Profile::sidebar method prototype 2019-06-10 08:21:06 -04:00
Philipp Holzer
236c0dc248
Check $contact['id']
- see https://github.com/friendica/friendica/issues/6918#issuecomment-498043313
2019-06-10 12:36:42 +02:00
Philipp Holzer
10683a43c8
Add typed parameter for methods in Friendica\Util\Network 2019-06-10 12:06:41 +02:00
Dean Townsley
19e99f7e81 Use accessing function for session variable 2019-06-09 21:06:42 -05:00
Dean Townsley
5c93db4097 remove leftover logging 2019-06-09 21:06:42 -05:00
Dean Townsley
af85e498ce expand permission check to remote array
This check was preventing multiple private images from different
users on the same server from loading on the same page.
It was only checking for permission for the single id returned by the
remote_user() function rather than the multiple possible autheniticated
id's stored in the remote arry session variable.
2019-06-09 21:06:42 -05:00
Hypolite Petovan
8c5923bb46
Merge pull request #7233 from nupplaphil/bug/installer_replace_macro
Fixing Installer - ReplaceMacro
2019-06-06 20:37:11 -04:00
Philipp Holzer
79fe3c92c7
Fixing Installer - ReplaceMacro 2019-06-07 00:36:10 +02:00
Michael
52a3ece8b6 Added comments 2019-06-06 17:58:49 +00:00
Michael
44a49a8d7d Ensure that pokes are always send only via DFRN 2019-06-06 04:26:02 +00:00
Philipp
f1c044e3b6
Merge pull request #7221 from annando/issue-6799
Issue #6799 - remove linefeeds inside of a table structure
2019-06-02 11:28:43 +02:00
Michael
bcf0be5db1 Issue #6799 - remove linefeeds inside of a table structure 2019-06-02 04:18:38 +00:00
Hypolite Petovan
7875199167
Merge pull request #7218 from nupplaphil/bug/remove_queue_summary
Remove queue from Admin/Summary
2019-06-01 22:26:58 -04:00
Philipp Holzer
aba7c9f08c
Remove queue from Admin/Summary 2019-06-02 03:28:22 +02:00
Philipp Holzer
dec5983850
Remove .well-known hardening 2019-06-02 03:19:44 +02:00
Michael
9f026f1814 The only reason we don't defer is when it was a post to a relay 2019-06-01 11:28:37 +00:00
Hypolite Petovan
bbac95d692
Merge pull request #7213 from annando/fix-counter
The delivery counter now counts only successful deliveries
2019-06-01 07:12:31 -04:00
Michael
ecf809c7ae The delivery counter now counts only successful deliveries 2019-06-01 06:54:47 +00:00
Philipp
25433e79d5
Merge pull request #7211 from MrPetovan/bug/7209-admin-forbidden
Add themed themed error page or login page for /admin[/*]
2019-05-31 11:49:40 +02:00
Hypolite Petovan
f0de19dd8a
Merge pull request #7208 from nupplaphil/bug/6916-filetag
Adding null checks before FileTag method (fix fatal)
2019-05-31 01:47:52 -04:00
Hypolite Petovan
4b4a319af9 Add themed themed error page or login page for /admin[/*] 2019-05-31 00:23:30 -04:00
Hypolite Petovan
a9e534ea79
Merge pull request #7210 from annando/diaspora-edit
Fix edited messages for Diaspora
2019-05-30 15:25:29 -04:00
Michael
19e95ebdda Fix edited messages for Diaspora 2019-05-30 18:56:31 +00:00
Hypolite Petovan
ac294be746
Merge pull request #7207 from nupplaphil/bug/6917-php_warnings
Add hexadecimal check (fix warnings)
2019-05-30 09:31:50 -04:00
Philipp Holzer
c76258c370
catching nulls for FileTag 2019-05-30 13:54:35 +02:00
Philipp Holzer
4c5dd9f47c
Add more Strings::isHex() checks to photos 2019-05-30 10:30:15 +02:00
Philipp Holzer
694cd82d0e
Bugfix - author-network (adding to unset list during insert) 2019-05-29 21:48:03 +02:00
Philipp Holzer
7334be803d
Bugfix - item_id 2019-05-29 21:40:21 +02:00
Philipp Holzer
3de540d1d1
Adding hexadecimal check for photos
see https://github.com/friendica/friendica/issues/6917#issuecomment-492798238
2019-05-29 20:28:25 +02:00
Philipp Holzer
766a10b3b6
Adding author-network to ITEM::ITEM_FIELDLIST
see https://github.com/friendica/friendica/issues/6918#issuecomment-493515358
2019-05-29 20:09:20 +02:00
Philipp Holzer
15ffb70c5f
Adding item_id to Item::ITEM_FIELDLIST
see https://github.com/friendica/friendica/issues/6918#issuecomment-493515358
2019-05-29 20:08:21 +02:00
Philipp Holzer
5002bda5fc
Checking the existence of '-' before array operation
See https://github.com/friendica/friendica/issues/6918#issuecomment-491490533
2019-05-29 20:07:53 +02:00
Philipp
dc0978141c
Merge pull request #7202 from MrPetovan/bug/fatal-errors
Prevent fatal error in ACL::getFullSelectorHTML when accessing a profile as a remote visitor
2019-05-29 07:05:05 +02:00
Michael Vogel
64f51d337f
Merge pull request #7204 from MrPetovan/bug/notices
Check for array index existence
2019-05-29 07:04:46 +02:00
Philipp
9245942a0c
Merge pull request #7199 from MrPetovan/bug/7171-filer-network
Allow commas in saved folder names
2019-05-29 07:03:44 +02:00
Michael
824d35774b Fix "Undefined index: protocol" 2019-05-29 04:30:01 +00:00
Hypolite Petovan
8a0c568fe1 Check for href existence for links in Protocol\PortableContact
See https://github.com/friendica/friendica/issues/6918#issuecomment-495198587
2019-05-28 21:27:13 -04:00
Hypolite Petovan
5414d51d4c Prevent fatal error in ACL::getFullSelectorHTML when accessing a profile as a remote visitor
See https://github.com/friendica/friendica/issues/6916#issuecomment-495724811
2019-05-28 21:09:06 -04:00
Philipp
e557457158
Merge pull request #7201 from annando/mail-db-error
Fix Issue 7196
2019-05-28 20:02:39 +02:00
Philipp
32b8c6f65e
Merge pull request #7200 from annando/tag-process
Process incoming tag add requests
2019-05-28 19:43:23 +02:00
Michael
ae940755c7 Fix Issue 7196 2019-05-28 17:39:26 +00:00
Philipp
bae4a5e406
Merge pull request #7187 from MrPetovan/bug/7023-emailer-hooks
Enable addon using emailer hooks to skip default call to mail()
2019-05-28 08:02:48 +02:00
Philipp
be3d7759f0
Merge pull request #7198 from MrPetovan/task/6861-to-plaintext
Simplify BBCode::toPlaintext and HTML::toPlaintext
2019-05-28 07:49:25 +02:00
Hypolite Petovan
ed768c71ee Remove "f=&" nonsense from network module
- Fixes wrong redirect when using the sidebar filters
2019-05-27 17:45:27 -04:00
Hypolite Petovan
0fadc7730c Replace deprecated string-bases Model\FileTag calls with array-based ones 2019-05-27 17:40:08 -04:00
Hypolite Petovan
6de3449cae Add new fileToArray and arrayToFile methods to Module\FileTag 2019-05-27 17:38:36 -04:00
Hypolite Petovan
96402e306a Fix formatting of Model\FileTag
- Normalize indent style
- Remove extraneous new lines after ifs/foreachs
2019-05-27 17:38:32 -04:00
Hypolite Petovan
5d2bf73517 Add Babel result screen for compact HTML::toPlaintext 2019-05-27 12:02:28 -04:00
Hypolite Petovan
5f9fb1f14f Simplify BBCode::toPlaintext
- Keep white spaces after tags
2019-05-27 12:02:12 -04:00
Hypolite Petovan
596b5b0982 Simplify HTML::toPlaintext
- Keep new lines in plain text output
2019-05-27 12:01:48 -04:00
Hypolite Petovan
3c7e4b474b
Merge pull request #7193 from nupplaphil/bug/uimport_datetime
Fix NULL datetime for uimport/uexport
2019-05-27 09:13:01 -04:00
Hypolite Petovan
4e207ef786 Enable addon using emailer hooks to skip default call to mail() 2019-05-26 21:36:09 -04:00
Hypolite Petovan
01e71254d9 Replace defaults() calls on $_SESSION by Core\Session calls
- Replace direct calls to $_SESSION by Core\Session calls in Module\Login
2019-05-26 21:26:59 -04:00
Philipp Holzer
26d4214c19
added suggestions 2019-05-26 21:53:24 +02:00
Hypolite Petovan
e99e8096bf
Merge pull request #7191 from nupplaphil/bug/logfile_permission
Fixing logfile permission denied exceptions
2019-05-26 15:19:26 -04:00
Philipp Holzer
220f8f0862
friendica-6950 uimport doesn't support "pwdreset_time":null 2019-05-26 15:49:44 +02:00
Philipp
57f6086fcd
Merge pull request #7189 from MrPetovan/bug/7183-archives-profile-widget
Ensures Widget::postedByYear uid parameter is integer in Module\Profile
2019-05-26 14:42:25 +02:00
Philipp Holzer
b56b56ccb6
friendica-6379 Monolog - logfile permission denied 2019-05-26 14:33:09 +02:00
Hypolite Petovan
cc6a17d27a Ensures Widget::postedByYear uid parameter is integer in Module\Profile 2019-05-26 08:18:59 -04:00
Michael
ecf4789cc4 Process incoming tag add requests 2019-05-26 11:20:03 +00:00
Philipp
ea218438d2
Merge pull request #7186 from MrPetovan/bug/7183-archives-profile-widget
Restore profile archives widget
2019-05-26 08:16:54 +02:00
Philipp
6ceb74c365
Merge pull request #7184 from annando/add-tag
AP: We now transmit "add tag" activity
2019-05-26 08:14:18 +02:00
Hypolite Petovan
50e44f46ae Add profile archive URL pattern to Router 2019-05-25 19:08:43 -04:00
Hypolite Petovan
d27d4d8927 Move posted date widget to Content\Widget 2019-05-25 19:08:15 -04:00
Michael
32b1f75ece AP: We now transmit "add tag" activity / On Diaspora this is now supressed 2019-05-25 19:33:58 +00:00
Philipp
5c2cca432f
Merge pull request #7170 from MrPetovan/bug/6981-contact-request-blocked
Contact requests blocked
2019-05-25 20:20:36 +02:00
Philipp
bd0c536736
Merge pull request #7156 from MrPetovan/task/add-relationship-filter
Add contact relationship filter
2019-05-25 20:17:05 +02:00
Hypolite Petovan
08d7d42f81 Ensures Search methods return an empty ResultList instead of null
- Addresses https://github.com/friendica/friendica/issues/6916#issuecomment-494876901
2019-05-24 08:13:36 -04:00
Hypolite Petovan
0dae4f9492
Fix typo in Module\Contact
Follow-up to #7154, thanks to @AlfredSK
2019-05-23 13:01:40 -04:00
Hypolite Petovan
40ca25f4f7 Fix SQL error in Module\Admin\Summary 2019-05-21 17:01:15 -04:00
Michael
30143aa5b1 Identifier have to be escaped different than values 2019-05-21 05:34:41 +00:00
Michael
1f6f588872 Fix table name sanitation / enable table schemes 2019-05-20 20:38:18 +00:00
Hypolite Petovan
14a78807d7 Use self::isBlocked and self:isBlockedByUser in Model\Contact::addRelationship 2019-05-20 16:34:17 -04:00
Hypolite Petovan
7bbaf0757f Revert sending ActivityPub follow reject on Model\Contact::addRelationship failure 2019-05-20 16:33:09 -04:00
Hypolite Petovan
62dfcbb074 Prevent contact relationships with node- or user-level blocked contacts 2019-05-20 15:29:20 -04:00
Hypolite Petovan
ea77f214d7 Add return value to Model\Contact::addRelationship to remove protocol-specific code from it 2019-05-20 15:29:20 -04:00
Hypolite Petovan
10dfe4347b Ensure follow reject/accept object IDs are strings to avoid JsonLD normalize errors in ActivityPub\Transmitter 2019-05-20 15:29:20 -04:00
Hypolite Petovan
3114754f4b Refactor Model\Contact::addRelationship
- Remove unused parameter $item
- Replace q() call with DBA::insert
- Update check on $contact that can only be an array now
- Add moethod doc block
2019-05-20 15:29:20 -04:00
Hypolite Petovan
956ae6241d Add exception message chain, string trace and original object to JsonLD normalize error logging 2019-05-20 15:28:54 -04:00
Hypolite Petovan
bebff3271b Remove obsolete TODO comment in Module\Profile\Contacts 2019-05-20 15:10:34 -04:00
Hypolite Petovan
c65faecc8c Add current tab parameter to Model\Profile::getTabs 2019-05-20 15:09:33 -04:00
Hypolite Petovan
709eba6ce3 Move /viewcontacts to /profile/{nickname}/contacts[/{type}]
- Add contact relationship filter to profile contacts page
- Include feed contacts in contacts page and contact widget
2019-05-20 14:50:09 -04:00
Hypolite Petovan
e6742af65c Add contact relationship filter to /contact module 2019-05-20 14:50:09 -04:00
Hypolite Petovan
862159c712
Merge pull request #7165 from nupplaphil/task/mod_dirfind
Move mod/dirfind to src/Module/Search/Directory
2019-05-20 14:45:19 -04:00
Hypolite Petovan
0c9b76a585
Merge pull request #7173 from nupplaphil/task/mod_newmember
Move mod/newmember to src/Module/Welcome
2019-05-20 14:14:58 -04:00
Philipp Holzer
f97b72eb9f
Move mod/newmember to src/Module/Welcome 2019-05-20 20:12:20 +02:00
Philipp Holzer
3d67987cbc
simplification 2019-05-20 19:27:53 +02:00
Philipp Holzer
5e79d3fc82
Fixing method signature 2019-05-20 19:19:57 +02:00
Philipp Holzer
2bb2bb19fd
refactor method signature 2019-05-20 19:15:47 +02:00
Philipp Holzer
059b813090
Add PhpDoc / Code Standards 2019-05-20 19:14:39 +02:00
Philipp Holzer
58c8959da0
Add search types 2019-05-20 19:13:37 +02:00
Philipp Holzer
83fd03b124
Add PhpDoc 2019-05-20 18:44:44 +02:00
Philipp Holzer
1e36c68e48
Moving Search to Core, Refactor Objects 2019-05-20 18:42:27 +02:00
Hypolite Petovan
1cd7d50939
Merge pull request #7172 from nupplaphil/task/mod_notice_rm
Remove src/Module/Notice
2019-05-20 12:26:28 -04:00
Philipp Holzer
853f5cb92f
Remove src/Module/Notice
see https://github.com/friendica/friendica/pull/7159#issuecomment-493744623
2019-05-20 18:22:34 +02:00
Hypolite Petovan
325ba20141 Improve Diaspora raw text support in /babel module 2019-05-19 18:52:01 -04:00
Hypolite Petovan
3395f56036 Add Unicode support to autolink regular expression
- Explicitly exclude non-breaking spaces from URLs as \s doesn't include them
2019-05-19 18:51:55 -04:00
Hypolite Petovan
6f0c6e8926
Merge pull request #7160 from nupplaphil/task/mod_probe
Move mod/probe to src/Module/Probe
2019-05-19 15:06:13 -04:00
Hypolite Petovan
3ca64185a6
Merge pull request #7169 from annando/send-suggest
Sending contact suggestions does work again
2019-05-19 14:59:28 -04:00
Hypolite Petovan
58d5c6610c
Merge pull request #7168 from annando/suggest-receive
Suggestions can be processed again
2019-05-19 14:58:30 -04:00
Philipp
a758671a1b
Merge pull request #7154 from MrPetovan/task/refactor-widgets
Refactor widgets
2019-05-19 20:52:00 +02:00
Michael
a6cf036db2 Sending contact suggestions does work again 2019-05-19 17:59:37 +00:00
Michael Vogel
a3c95eeaab Suggestions can be processed again 2019-05-19 19:58:20 +02:00
Michael
6f3019ecdd Revert PR 7158 since it breaks umlauts 2019-05-19 09:34:49 +00:00
Philipp Holzer
419cc81ef1
renaming 2019-05-19 05:13:06 +02:00
Philipp Holzer
a7aae9603a
Split Directory Search as a base for further changes 2019-05-19 05:06:02 +02:00
Philipp Holzer
5b44fdc202
Split Directory Search as a base for further changes 2019-05-19 05:01:46 +02:00
Philipp Holzer
2520286b1f
some small improvements 2019-05-19 04:43:09 +02:00
Philipp Holzer
34a1e923dd
dependency lowering 2019-05-19 04:38:35 +02:00
Philipp Holzer
e00f110ef1
Move mod/dirfind to src/Module/DirFind 2019-05-19 04:28:16 +02:00
Philipp Holzer
492d7abe92
Renamed Diagnostic to Debug and deleted ItemSource (already defined) 2019-05-19 04:24:56 +02:00
Philipp Holzer
48bba87abe
Move mod/probe to src/Module/Probe 2019-05-19 04:24:18 +02:00
Hypolite Petovan
7a13582c67
Merge pull request #7159 from nupplaphil/task/mod_notice
Move mod/notice to src/Module/Notice
2019-05-18 22:16:35 -04:00
Hypolite Petovan
ec5c123f41
Merge pull request #7163 from nupplaphil/task/mod_starred
Move mod/starred to src/Module/Starred
2019-05-18 22:16:21 -04:00
Hypolite Petovan
596e95917e
Merge pull request #7164 from nupplaphil/task/mod_randprof
Move mod/randprof to src/Module/RandomProfile
2019-05-18 22:16:06 -04:00
Philipp Holzer
5f068b07f9
some improvements 2019-05-19 03:12:22 +02:00
Philipp Holzer
82e271589f
Move mod/starred to src/Module/Starred 2019-05-19 03:07:44 +02:00
Hypolite Petovan
d3a4ed0111
Merge pull request #7162 from nupplaphil/task/mod_view
Move mod/view to src/Module/Theme
2019-05-18 21:07:27 -04:00
Philipp Holzer
725984eb08
change route 2019-05-19 03:05:21 +02:00
Philipp Holzer
d91b3bb59c
remove unused dependencies 2019-05-19 02:53:36 +02:00
Philipp Holzer
d81c1d81b3
correct notice redirect 2019-05-19 02:53:35 +02:00
Philipp Holzer
ce3b121064
rename rawContent() to content() 2019-05-19 02:53:35 +02:00
Philipp Holzer
9092cb1beb
Move mod/notice to src/Module/Notice 2019-05-19 02:53:31 +02:00
Hypolite Petovan
33ec3d8051
Merge pull request #7161 from nupplaphil/task/mod_toggle_mobile
Move mod/toggle_mobile to src/Module/ToggleMobile
2019-05-18 20:14:27 -04:00
Hypolite Petovan
30945784c3
Merge pull request #7157 from nupplaphil/task/mod_notify
Move mod/notify to src/Module/Notify
2019-05-18 17:49:01 -04:00
Philipp Holzer
8bb85b1da7
Move mod/randprof to src/Module/RandomProfile 2019-05-18 22:17:57 +02:00
Philipp Holzer
d1d7fa394a
Move mod/view to src/Module/View 2019-05-18 21:23:12 +02:00
Philipp Holzer
295d90d496
Move mod/toggle_mobile to src/Module/ToggleMobile 2019-05-18 21:13:19 +02:00
Philipp Holzer
1483cd3fb4
rearrange content/init 2019-05-18 20:34:11 +02:00
Philipp Holzer
68fdc7215e
rearrange rawContent / content 2019-05-18 20:16:08 +02:00
Philipp
67a4a80076
Merge pull request #7158 from MrPetovan/bug/7150-unescape-xml-entities
Replace htmlspecialchars_decode with html_entity_decode in XML::unescape
2019-05-18 19:53:25 +02:00
Hypolite Petovan
c3d545987a Remove /contact/all path 2019-05-18 13:18:47 -04:00
Hypolite Petovan
8fb9722cdc Replace htmlspecialchars_decode with html_entity_decode in XML::unescape
- Replace htmlspecialchars with htmlentities in XML::escape
- This allows for converting all entities from Diaspora messages to regular characters
2019-05-18 13:15:51 -04:00
Philipp Holzer
56bd395b8a
Move mod/notify to src/Module/Notify 2019-05-18 18:59:41 +02:00
Hypolite Petovan
cff4577cc5
Merge pull request #7155 from nupplaphil/task/mod_opensearch
Move mod/opensearch to src/Module/OpenSearch
2019-05-18 12:46:54 -04:00
Hypolite Petovan
fc312e4c98
Merge pull request #7153 from annando/ap-mail-delivery
Fix receiver list for mails
2019-05-18 11:50:10 -04:00
Philipp Holzer
9f13ae6e73
Move mod/opensearch to src/Module/OpenSearch 2019-05-18 17:43:58 +02:00