Commit graph

1333 commits

Author SHA1 Message Date
Michael
fd1da74980 Fix fatal error because of unknown function "fetchUrl" 2020-07-27 11:50:36 +00:00
Michael
9b86f40a5f Store avatar cache fields only when needed 2020-07-25 11:48:52 +00:00
Michael Vogel
398e65d66b
Merge pull request #8911 from MrPetovan/task/curl_DI
Introduce "HTTPRequest" class
2020-07-25 09:50:20 +02:00
Michael
5545bafdee Fix notice "Undefined index: gravity in /src/Protocol/ActivityPub/Processor.php on line 556" 2020-07-21 19:55:24 +00:00
Michael Vogel
41141965fc
Merge pull request #8904 from MrPetovan/task/ap-conversion-admin-module
Add new admin debug module for ActivityPub
2020-07-21 21:32:06 +02:00
nupplaPhil
1998b7811b Fix fatal execution path for found Network::get() parameter execption 2020-07-21 03:19:05 -04:00
nupplaPhil
657d08f09f Rename "fetchUrl" and "fetchUrlFull" to "fetch" and "fetchFull" 2020-07-21 03:15:53 -04:00
nupplaPhil
7029012f27 Rename "HTTPRequest::curl()" to HTTPRequest::get() 2020-07-21 03:14:01 -04:00
nupplaPhil
e5649d6dbf Move "HTTPRequest::finalUrl" dynamic 2020-07-21 03:10:10 -04:00
nupplaPhil
60e18736b0 Move "Network::finalUrl" to "HTTPRequest" class 2020-07-21 03:09:40 -04:00
nupplaPhil
1aa07f87a4 Make "HTTPRequest::fetchUrl" dynamic 2020-07-21 03:04:58 -04:00
nupplaPhil
3b4cf87c95 Make "HTTPRequest::fetchUrlFull" dynamic 2020-07-21 03:02:52 -04:00
nupplaPhil
8793096c16 Make "HTTPRequest::post" dynamic 2020-07-21 03:02:51 -04:00
nupplaPhil
2973ed6448 Make "HTTPRequest::curl" dynamic 2020-07-21 03:01:12 -04:00
nupplaPhil
5344efef71 Move post/curl/fetchUrl/fetchUrlFull to own class "Network\HTTPRequest" 2020-07-21 02:56:10 -04:00
Hypolite Petovan
c26cc5b75e Expand scope of prepareObjectData in ActivityPub\Receiver 2020-07-20 00:38:45 -04:00
Hypolite Petovan
259a62f9dd Separate concerns between postItem and createItem in ActivityPub\Processor
- postItem now only posts items created with createItem without altering it
- createItem  now only creates an item array from an activity without posting it
- postItem scope is now public
2020-07-20 00:37:43 -04:00
Hypolite Petovan
3894976a2d Add support for image preview in attachments in ActivityPub\Processor
- Address https://github.com/friendica/friendica/issues/8676#issuecomment-650554955
2020-07-20 00:28:11 -04:00
Hypolite Petovan
05bd0d0b67 Add support for multiple Link as urls of Images in ActivityPub\Receiver
- Address https://github.com/friendica/friendica/issues/8676#issuecomment-650554955
2020-07-20 00:28:11 -04:00
Michael
5bf813d0ec Use "failed" field 2020-07-19 11:42:23 +00:00
Hypolite Petovan
911a23f18b Use PageInfo::appendDataToBody in ActivityPub\Processor::constructAttachList 2020-07-17 19:39:12 -04:00
Hypolite Petovan
25b3fa83fc Rename PageInfo::appendToBody to searchAndAppendToBody 2020-07-17 19:15:43 -04:00
Michael
c987785146 Use "contact-type" instead of "account-type" to avoid notices 2020-07-17 06:58:39 +00:00
Michael
0b93bcbbf9 Create a (meaningful) title 2020-07-17 05:27:45 +00:00
Michael
c47931172d Indention fixed 2020-07-17 04:46:42 +00:00
Michael
ecf6018b89 Atom feed generation is moved to the feed class 2020-07-17 04:40:20 +00:00
Michael
70699878ee Replaced more calls of "Probe::uri" with "Contact::getByURL" 2020-07-16 19:22:38 +00:00
Hypolite Petovan
dd85f48e0d
Merge pull request #8886 from annando/getidforurl-update
in "getidforurl" "no update" is now "update"
2020-07-16 09:23:30 -04:00
Michael
4a550ddcd8 Prevent "null" value when calling "getTagsFromUrl" 2020-07-16 06:13:47 +00:00
Michael
b0086a49e2 in "getidforurl" "no update" is now "update" 2020-07-15 21:08:42 +00:00
Hypolite Petovan
631095eefd
Merge pull request #8883 from annando/replace-getdetails
Replaced "getDetailsByURL" with "getByURL/getByURLForUser"
2020-07-15 13:49:27 -04:00
Michael
6d3949d54a Changed default value 2020-07-15 17:29:52 +00:00
Michael
e374aecc46 Changed parameter order for "getbyURLForUser" 2020-07-15 17:22:12 +00:00
Michael
fc0312451d Changed parameter order for getByURL 2020-07-15 17:06:48 +00:00
Michael
d9c6a46ffe Replaced "getDetailsByURL" with "getByURL/getByURLForUser" 2020-07-15 04:42:04 +00:00
Hypolite Petovan
5ba8b4a58a Add ffi_keyword_denylist key check to match previous call in Protocol\Feed 2020-07-14 14:50:52 -04:00
Hypolite Petovan
3e25fc3a72 Replace *_page_info function calls with Content\PageInfo equivalent 2020-07-14 10:15:04 -04:00
Michael
81928727f2 Issue 8866: Fix fetching feed links with missing base 2020-07-12 12:45:34 +00:00
Michael
0100e0df84 Some more invalid feed elements 2020-07-11 19:11:35 +00:00
Michael
e5a336ff77 Merge remote-tracking branch 'upstream/2020.06-rc' into valid-feed 2020-07-11 18:57:17 +00:00
Michael
b107a4984e Make feeds validate 2020-07-11 18:54:08 +00:00
Hypolite Petovan
090fa78057
Merge pull request #8862 from annando/issue-8860
Issue 8860: Activities weren't fetchable all the time
2020-07-11 14:14:03 -04:00
Michael
fb18325b6b Don't check the date on regular feeds 2020-07-11 16:29:18 +00:00
Michael
63dc6950d4 Issue 8860: Activities weren't fetchable all the time 2020-07-11 07:15:54 +00:00
Michael
87f054a642 Fix message "empty network" in gcontact::getid 2020-07-10 19:49:11 +00:00
Michael
c656aea152 Issue 8857: Fix follow accept answers 2020-07-10 05:30:12 +00:00
Michael
1f88bb8beb Fix the plink for reshared Diaspora posts 2020-07-09 19:19:18 +00:00
Michael
c947b7f211 "print_r" in logging replaced / obsolete stuff removed 2020-06-29 20:22:00 +00:00
Michael
f6ae7db0ca Further deprecated calls replaced 2020-06-28 17:50:11 +00:00
Michael
a1a9d4f657 Fix processing of received coordinates 2020-06-28 08:46:27 +00:00
Michael Vogel
c852e1479c
Merge pull request #8811 from MrPetovan/task/8517-probe-mobile-twitter
Add support for mobile profile URL to core twitter probing
2020-06-27 17:32:19 +02:00
Hypolite Petovan
e78db3fac6
Merge pull request #8817 from annando/ap-diaspora-delivery
Prevent delivering AP comments to Diaspora
2020-06-27 09:30:11 -04:00
Michael
de19f94aca Prevent delivering AP comments to Diaspora 2020-06-27 12:18:36 +00:00
Michael
ef56837b9e Fix receiving non public posts from AP 2020-06-27 10:35:45 +00:00
Hypolite Petovan
50d05cec83 Ensure url property of Probe::uri result is used authoritatively
- Some profile URLs aren't canonical and need to be updated during probe
2020-06-26 12:52:39 -04:00
Michael
a0ee12aade Fix notice "Undefined index: forum" 2020-06-26 05:29:00 +00:00
Hypolite Petovan
912ff069c0 Update getShareOpeningTag::getShareOpeningTag method signature
- Optional parameter $guid is now at the end
- Always provided parameter $posted is now mandatory
2020-06-21 09:42:37 -04:00
Tobias Diekershoff
797eff853a
Merge pull request #8790 from MrPetovan/bug/notices
Fix latest notice messages
2020-06-20 18:07:54 +02:00
Hypolite Petovan
a83681e93a Use Contact::getDetailsByURL instead of custom query in Protocol\OStatus
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-646457104
2020-06-19 07:10:39 -04:00
Hypolite Petovan
51bae35d2a Account for contact.ffi_keyword_denylist field being NULL by default in Protocol\Feed 2020-06-19 07:01:05 -04:00
Hypolite Petovan
1f20111c80 Replace share_header calls with BBCode::getShareOpeningTag 2020-06-18 08:53:57 -04:00
Hypolite Petovan
f544c8383b Implement pull request feedback
- Improve formatting of drop_item in mod/item
- Replace deprecated Logger::log() calls in Protocol\Feed::consume
2020-06-17 21:44:28 -04:00
Hypolite Petovan
eba964ec12 Deprecate consume_feed() in favor of Protocol\Feed::consume 2020-06-17 13:24:44 -04:00
Michael
1a86167ac5 Possibly fix "Undefined index: url" 2020-06-16 20:41:34 +00:00
Michael
b948887221 Reduced network request when probing 2020-06-14 13:37:28 +00:00
Hypolite Petovan
53b951a179 Strip the link preview URL from the end of the body if any in ActivityPub\Processor 2020-06-10 11:19:44 -04:00
Michael Vogel
6a23f51549
Merge pull request #8749 from MrPetovan/task/8676-ap-attachments
Add quote support in attachment title in ActivityPub\Processor
2020-06-09 22:23:26 +02:00
AlfredSK
66723023f9 fix-continue-warnings 2020-06-09 16:40:36 +00:00
Hypolite Petovan
fdb22320ff Add quote support in attachment title in ActivityPub\Processor 2020-06-09 08:53:48 -04:00
Hypolite Petovan
4d3dd28c44 Add check for existing attachment in ActivityPub\Processor::constructAttachList 2020-06-07 16:23:57 -04:00
Hypolite Petovan
01e9beffc2 [ActivityPub] Add support for more attachments structures
- Add support for type: Page into [attachment], type: Link using href attribute
- Ensure Receiver::process* parameter is an array
- Remove superfluous eptiness check in JsonLD::fetchElementArray
2020-06-07 15:41:11 -04:00
Hypolite Petovan
34463f37e4 Rename contact table column to ffi_keyword_denylist 2020-06-07 11:24:52 -04:00
Michael
62217735f0 Use webfinger in apcontact fetch 2020-06-04 21:55:14 +00:00
Michael
0acb5d4558 "parent = id" is replaced with gravity check 2020-05-28 16:02:36 +00:00
Michael
db907c2ff8 Issue 8700: Resolvable activities 2020-05-27 19:05:33 +00:00
Michael
973abb6196 Replace "id = parent" checks with "gravity" checks 2020-05-27 12:19:06 +00:00
Michael
e27915a819 Centralized gsid generation 2020-05-22 10:10:24 +00:00
Michael
efb1c630fd Fix warnings ("Divide by zero" and "key parameter is not a valid public key") 2020-05-18 02:58:08 +00:00
Michael
0cf517ad76 Use constants for the BBCode modes 2020-05-16 16:28:15 +00:00
Michael
079738a8b5 Fix a fatal error when an undo doesn't contain an object 2020-05-14 04:53:56 +00:00
Michael
13bd43f3f6 Store the diaspora signature differently 2020-05-13 05:48:26 +00:00
Michael
c4062ddb3b Removed "insert" parameter 2020-05-12 21:49:12 +00:00
Michael
06da3084f5 Restructured item insert 2020-05-12 20:13:48 +00:00
Hypolite Petovan
d35dc64660
Merge pull request #8611 from annando/issue-8610
Issue 8610: Implicit mentions work again
2020-05-09 16:03:45 -04:00
Michael
9679fad5e2 Concentrating functionality 2020-05-09 08:55:10 +00:00
Michael
eb4c14695c The implicit mentions are added in any case 2020-05-09 08:35:58 +00:00
Michael
bebc6615fc Removed unneeded functionality 2020-05-09 06:51:13 +00:00
Michael
d5f64e1156 Issue 8610: Implicit mentions work again 2020-05-09 06:33:59 +00:00
Hypolite Petovan
55acb51148 Check $item_profile is populated in ActivityPub\Transmitter
- Address https://github.com/friendica/friendica/issues/8475#issuecomment-625716446
2020-05-08 09:31:36 -04:00
Hypolite Petovan
8abaac6d79 Account for missing location value in ActivityPub\Receiver 2020-05-07 10:14:38 -04:00
Michael Vogel
64f1bc8a68
Merge pull request #8589 from MrPetovan/task/8588-ap-contacts-endpoint
Only output ActivityPub contacts in /followers and /following AP endpoints
2020-05-07 10:37:46 +02:00
Hypolite Petovan
63e7996891 Improve formatting in ActivityPub\Transmitter 2020-05-07 03:47:45 -04:00
Hypolite Petovan
eb8dcd43f3
Merge pull request #8597 from annando/notice
Fixed notice because of missing field
2020-05-07 03:46:38 -04:00
Michael
e3c08215f6 Fixed notice because of missing field 2020-05-07 07:34:00 +00:00
Hypolite Petovan
3c0547c6e8 Ensure post location received through ActivityPub is in plaintext 2020-05-06 22:41:59 -04:00
Hypolite Petovan
4e579e77f5 Only output ActivityPub contacts in /followers and /following
- Join contact table with apcontact to weed out non-AP contacts
2020-05-06 15:29:35 -04:00
Michael
806f4a0142 Added logging 2020-05-06 19:00:56 +00:00
Michael
7dea1ff6bd Issue 8586 again: Don't transmit participations 2020-05-06 17:30:21 +00:00
Michael
b9ee46824f Added missing field 2020-05-06 15:37:04 +00:00
Michael
62a4638ea8 Don#t group 2020-05-06 15:27:13 +00:00
Michael
22be2cce8a Issue 8586: Reduce the amount of item receivers 2020-05-06 15:20:49 +00:00
Hypolite Petovan
ccb69414d2 Combine getFollowers and getFollowing into getContacts in ActivityPub\Transmitter 2020-05-05 22:32:45 -04:00
Michael
0f042b064a Fix warning, notice and DB Error 2020-05-05 21:49:48 +00:00
Michael
3d4ace7a9d Merge branch 'no-term3' into no-term2 2020-05-05 16:09:50 +00:00
Michael
59675c4f0b Merge remote-tracking branch 'upstream/develop' into no-term2 2020-05-05 15:44:24 +00:00
Michael
d838dcbd8c Removed unused fields 2020-05-05 14:10:39 +00:00
Michael
2ee14bf5fe Merge remote-tracking branch 'upstream/develop' into post-delivery-data 2020-05-05 14:08:29 +00:00
Michael
84e3892955 Merge remote-tracking branch 'upstream/develop' into post-delivery-data 2020-05-05 13:16:01 +00:00
Michael
2f42e68dc8 Merge remote-tracking branch 'upstream/develop' into new-participation 2020-05-05 12:48:33 +00:00
Michael
b7e25d16e7 Removed usage of "tag" field 2020-05-05 05:11:59 +00:00
Hypolite Petovan
340bc57952 Ensure Tag::getByURIId parameter value in OStatus;;entryFooter
- Address https://github.com/friendica/friendica/issues/8473#issuecomment-623701081
- $item['uri-id'] isn't present for follow entry pseudo-items
2020-05-04 18:51:03 -04:00
Michael
1362748f59 Merge remote-tracking branch 'upstream/develop' into no-term2 2020-05-04 15:20:30 +00:00
Michael
4c86f2a3ec Merge remote-tracking branch 'upstream/develop' into new-participation 2020-05-04 15:01:42 +00:00
Michael
16d486dd24 Merge remote-tracking branch 'upstream/develop' into post-delivery-data 2020-05-04 14:40:52 +00:00
Hypolite Petovan
05cac4c186
Merge pull request #8570 from annando/tag-notice
Fix for "Undefined index: uri-id""
2020-05-04 09:30:14 -04:00
Michael
875d6b36e9 File and category aren't using "term" anymore 2020-05-03 15:13:40 +00:00
Michael
098ba4a667 "item-delivery-data" is now "post-delivery-data" 2020-05-02 19:34:02 +00:00
Michael
2a1cdfa36b Diaspora participations are now atored as activities 2020-05-02 08:52:11 +00:00
Michael
233d6eea2b Tags are now added to the body again 2020-05-02 05:43:00 +00:00
Michael
11406fd3b6 Fix for "Undefined index: uri-id"" 2020-05-02 05:14:30 +00:00
Michael
b0cb6536dd The old tag handling is removed 2020-05-02 05:08:05 +00:00
Michael
c3ecc19b41 Last "term" element renamed 2020-05-01 15:27:56 +00:00
Michael
70022393b7 Fix notice for missing "uri-id" 2020-05-01 12:42:22 +00:00
Michael
3b2ae5c4a9 function names changed 2020-05-01 06:01:22 +00:00
Michael
70e5639e29 Merge 2020-04-28 13:33:03 +00:00
Michael
5367620467 Merge remote-tracking branch 'upstream/develop' into write-tags 2020-04-28 08:03:26 +00:00
Michael
ce20081d28 Fix wrong field name 2020-04-28 03:52:07 +00:00
Michael
f521689ced Suppress XML logging of errors 2020-04-27 14:35:50 +00:00
Michael
5df5e9521b The tag table is now really used 2020-04-26 15:24:58 +00:00
Michael
7d111e2a6f Duplicated fields renamed 2020-04-25 07:29:02 +00:00
Michael
89dcab774d Prticipation is now a view as well 2020-04-24 17:55:49 +00:00
Michael
a5aa43469b Some more places with owner-view 2020-04-24 13:41:11 +00:00
Michael
3e5c3dce01 Next join replaced by view 2020-04-24 12:24:10 +00:00
Michael
778ff0689f AP: Interpret "update" as "create" when item isn't found 2020-04-23 19:57:20 +00:00
Michael
e19b1800a4 Added documentation 2020-04-20 12:19:26 +00:00
Michael
27ea747e99 Switchable contact probing 2020-04-20 09:47:26 +00:00
Michael
21103a5735 Store implicit mentions 2020-04-20 05:43:13 +00:00
Michael
538e212a84 Hashtag handling with Diaspora improved 2020-04-19 16:33:06 +00:00
Michael
66f5e7c0f8 Don't store URL with hashtags / OStatus-Diaspora-Improvements 2020-04-19 07:24:36 +00:00
Michael
3ce9386cb1 Improved body scanning, increased length 2020-04-18 10:05:30 +00:00
Michael
d9352f5a63 Use the new function when adding additional tags 2020-04-17 13:34:29 +00:00
Michael
6afcf5c8c7 Use "store" when possible 2020-04-17 07:55:23 +00:00
Michael
db657b0149 We now store the tags in two separate tables 2020-04-17 06:35:20 +00:00
Michael
126b95d873 Added documentation header 2020-04-15 20:59:45 +00:00
Michael
f871105ef9 Use name or nick 2020-04-15 20:52:30 +00:00
Michael
472518f0b5 Use the name as name 2020-04-15 20:45:04 +00:00
Michael
a4fd5033dd Function had been moved 2020-04-15 19:42:02 +00:00
Michael
2e0501e7c5 New model class for tag 2020-04-15 16:37:09 +00:00
Michael
cb593226bf Spaces and newlines 2020-04-15 11:39:00 +00:00
Michael
f52614e249 Merge remote-tracking branch 'upstream/develop' into term2tag 2020-04-15 11:31:52 +00:00