35643 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Roland Häder	7cbb818c93	Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() ... is the same and being handled over.	2022-06-18 05:19:24 +02:00
Roland Häder	89302d0843	Some outside code relies on returned "false"	2022-06-18 05:06:18 +02:00
Roland Häder	aaf5c323b6	Fixed indenting	2022-06-18 05:04:14 +02:00
Roland Häder	adb4aea6ad	Changes: ... - added some type-hints - replaced most double-quotes (only Diaspora.php, later more) with single - added some documentation - normalized indenting in Diaspora.php (I hope I got all?)	2022-06-18 05:03:10 +02:00
Roland Häder	51f43278d6	Fixed incompatible types	2022-06-17 18:00:36 +02:00
Roland Häder	88c40f3336	Ops, wrong type again	2022-06-17 17:18:31 +02:00
Roland Häder	a770634b95	Ops, wrong type	2022-06-17 17:18:31 +02:00
Roland Häder	36d56a4041	Continued: ... - changed back to 'return false;' as other methods heavily rely on false instead of an empty array as pointed out by @heluecht@pirati.ca - $fetched_contact should be initialized as an empty array, let's not make this code more crazier than it already is (see APContact::getByURL())	2022-06-17 17:18:31 +02:00
Roland Häder	c467bff79f	Some more type-hints added	2022-06-17 17:18:31 +02:00
Roland Häder	4f3321cc9f	Nore fixes	2022-06-17 17:18:31 +02:00
Roland Häder	10bb7d5625	Possible fix for ... Uncaught Exception TypeError: "Return value of Friendica\Model\APContact::getByURL() must be of the type array, bool returned"	2022-06-17 17:18:31 +02:00
Roland Häder	fdd237a090	Fix for "Uncaught Exception TypeError: "Argument 1 passed to ... Friendica\Model\APContact::unarchiveInbox() must be of the type string, null given" error message	2022-06-17 17:18:31 +02:00
Roland Häder	605e7d55b3	Continued: ... - added more type-hints - some methods in Diaspora returned void but integer was documented so I changed it to -1 to have a proper type-hint	2022-06-17 17:18:31 +02:00
Roland Häder	0c9aff8a09	Also need to declare $profile or otherwise an invocation of ... Receiver::getReceiverForActor() will fail.	2022-06-17 17:18:31 +02:00
Roland Häder	af8cd5ca86	Worker::getWaitingJobForPID() can also return FALSE on failure ... :-(	2022-06-17 17:18:31 +02:00
Roland Häder	227bab43a8	Ops, wrong type-hint here, must be string ($nickname can never be an integer).	2022-06-17 17:18:31 +02:00
Roland Häder	f7c1eaa858	Continued: ... - added type-hints - removed out-dated documentation - added some missing documentation	2022-06-17 17:18:31 +02:00
Roland Häder	e484b6d6dc	Continued: ... - added more type-hints - added some documentation - Contact::getAccountType() should only process string, not null	2022-06-17 17:18:31 +02:00
Roland Häder	45b5f67bca	Fix for non-existing record system.mobile_theme in config table	2022-06-17 17:18:31 +02:00
Roland Häder	5c9ce790bf	Fixed: ... - $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd parameter expect it to be string	2022-06-17 17:18:31 +02:00
Roland Häder	33768ea1c6	Some fixes: ... - $gsid's default value cannot sadly be 0, it now must be null to allow some code work - added some more type-hints - documented a bit more	2022-06-17 17:18:31 +02:00
Roland Häder	4e53666c70	Added more type-hints	2022-06-17 17:18:31 +02:00
Roland Häder	7560dccc08	Added again more type-hints	2022-06-17 17:18:31 +02:00
Roland Häder	2766c7d9cf	Continued: ... - added more type-hints - added some missing documentation	2022-06-17 17:18:31 +02:00
Roland Häder	a587217f47	Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool"	2022-06-17 17:18:31 +02:00
Roland Häder	dd54e52575	MrPetovan brought the right one up: ... > Since this is depending on remote systems, the log can quickly fill with unactionable messages.	2022-06-17 17:18:31 +02:00
Roland Häder	c351099c5a	Ops, bad type-hint here	2022-06-17 17:18:31 +02:00
Roland Häder	2c5595c358	Another incompatible method declaration fixed + type-hints added	2022-06-17 17:18:31 +02:00
Roland Häder	40d7f29a11	Continued: ... - more type-hints - fixed incompatible method declarations	2022-06-17 17:18:31 +02:00
Roland Häder	1edc6b3c3b	Added more type-hints for "App" classes	2022-06-17 17:18:31 +02:00
Roland Häder	42b04f397b	Added more type-hints	2022-06-17 17:18:31 +02:00
Roland Häder	aa5f0d5ec1	Added more type-hints and documented a few methods	2022-06-17 17:18:31 +02:00
Roland Häder	97e27cb523	Added more type-hints	2022-06-17 17:18:31 +02:00
Roland Häder	c2e889cfae	Added more type-hints	2022-06-17 17:18:31 +02:00
Hypolite Petovan	a8a21c7fb6	Merge pull request #11652 from Quix0r/fixes/causer-id ... Misspelled braces causing "undefined index 'causer-id'" message	2022-06-17 10:12:22 -04:00
Roland Häder	5106bb2881	Added parenthesis	2022-06-17 09:41:11 +02:00
Roland Häder	a903dbd77e	Wrong braces causing 'undefined index causer-id'. See #11632	2022-06-16 23:00:16 +02:00
Hypolite Petovan	51b31a846f	Merge pull request #11649 from Quix0r/fixes/return-type-fetch-content ... Fixes incompatible returned type from HTTPSignature::fetch() method	2022-06-16 13:16:06 -04:00
Roland Häder	6035de6883	Continued: ... - added more type-hints - also cannot return FALSE when array is set	2022-06-16 19:06:41 +02:00
Hypolite Petovan	341d8860d1	Merge pull request #11647 from Quix0r/fixes/type-error-exception ... Followup PR for bad #11624 PR	2022-06-16 11:53:15 -04:00
Roland Häder	51a7b5c584	Made also this one sweeter (null-coalscing)	2022-06-16 17:36:47 +02:00
Roland Häder	0e1f734b03	Also make this null-coalscing	2022-06-16 17:35:01 +02:00
Roland Häder	e8fee5644b	Ops, syntax errors get unnoticed with a simple editor. :-(	2022-06-16 17:10:02 +02:00
Roland Häder	624e4c192c	Changed to null-coalscing style (??) as sugguested by @MrPetovan	2022-06-16 16:59:54 +02:00
Roland Häder	962b06bf41	Added check as suggested by @MrPetovan for empty $message.	2022-06-16 16:54:51 +02:00
Roland Häder	f2b7326650	This will 2 things: ... 1) The first change prevents "expensive" code in HTML::toBBcode() to be executed just for an empty string which makes no sense. 2) The above change was maybe flawed as $apcontact['about'] would have never been created, not even empty which could have side effects Thanks to @annando to make me rethink this part of code.	2022-06-16 16:54:50 +02:00
Roland Häder	7814ba4fc4	Fixes for bad invocations of HTML::toBBCode() (1st parameter is now string)	2022-06-16 16:54:50 +02:00
Roland Häder	b200874f17	Ops: ... - wrong way around (!empty($foo)) is proper - also needed to be checked on $acitivty['content']	2022-06-16 16:54:50 +02:00
Roland Häder	b1e4c0931a	Fixes and type-hints: ... - added more checked type-hints as they prevent bad method invocations - fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong) argument, thanks to @tobias@social.diekershoff.de pointing this out.	2022-06-16 16:54:49 +02:00
Hypolite Petovan	bb57d45237	Merge pull request #11645 from Quix0r/fixes/e-notice_use ... Fixed possible "Trying to access array offset on value of type bool" E_NOTICE	2022-06-16 08:45:50 -04:00