Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2024-11-15 14:53:54 +00:00
Code Issues Projects Releases Packages Wiki Activity
35893 commits 3 branches 64 tags 246 MiB
Commit graph

10470 commits

Author SHA1 Message Date
Hypolite Petovan
3865733e18 Move Model\Profile::getMyUrl to UserSessions 2022-10-30 10:49:47 -04:00
Michael
eae1383f48 Merge remote-tracking branch 'upstream/develop' into quote 2022-10-30 11:38:17 +00:00
Michael
b402a760a8 Symplified code 2022-10-30 10:02:12 +00:00
Michael
a183723254 Improved handling of contact links 2022-10-30 10:02:01 +00:00
Michael
96a36568e2 Add quote to API 2022-10-30 01:20:05 +00:00
Michael
f569ccbbc2 Code is simplyfied 2022-10-29 22:55:39 +00:00
Michael
3c169b534e Improved handling of native quotes 2022-10-29 22:11:39 +00:00
Hypolite Petovan
e24078a4d2
Merge pull request #12074 from annando/fix-notification 
Accepting contact request does finally work per Mastodon API
 2022-10-29 15:55:40 -04:00
Michael
8bba8663fb Only fetch the needed field 2022-10-29 19:11:26 +00:00
Michael
f44c9e7975 Accepting contact request does finally work per Mastodon API 2022-10-29 19:04:29 +00:00
Hypolite Petovan
a2adb1cd93
Remove unused argument from L10n->tt() call in Model/Item.php 2022-10-28 13:45:09 -04:00
René Wagner
b99e7a9e92
fix exception when adding an poll option without votes 2022-10-28 18:51:35 +02:00
Hypolite Petovan
f418687a71
Merge pull request #12070 from annando/share 
Some more improvements for posts with shares
 2022-10-27 08:19:23 -04:00
Michael
deccea0228 More functions moved to content class 2022-10-27 05:44:44 +00:00
Michael
c65fff6f93 Some more improvements for posts with shares 2022-10-26 17:00:55 +00:00
Hypolite Petovan
0c4ebce391
Merge pull request #12067 from Quix0r/cleanup/type-hints-002 
Cleanup: missing type-hints, double-quotes, reformatted array
 2022-10-26 12:03:04 -04:00
Roland Häder
498d7f690a
Changes: 
- php-cs is now happy with it
 2022-10-26 17:59:10 +02:00
Roland Häder
03e09627e4
Used $this->isThreaded() instead as suggested by @MrPetovan 2022-10-26 17:59:07 +02:00
Roland Häder
3c50d5b70f
Changes: 
- made code more readable
 2022-10-26 01:31:34 +02:00
Roland Häder
2f1336339f
Changes: 
- added missing type-hints
- added missing documentation
- changed double-quotes to single
- Setters do ALWAYS return void
 2022-10-26 01:29:01 +02:00
Hypolite Petovan
22bfd3b4d6 Revert "Add email notification to all users on server domain pattern block list update" 
This reverts commit 5045f9e188 because the main stakeholder isn't using the feature and it's putting a strain on email server accountability vis-a-vis spam lists.

# Conflicts:
#	src/Moderation/DomainPatternBlocklist.php
 2022-10-25 19:02:55 -04:00
Roland Häder
5306bb3e31
Changes: 
- added more missing type-hints (checked them in body of the method)
- reformatted code a little (code-style)
- moved '/.well-known/host-meta' to constant Probe::HOST_META
 2022-10-25 20:25:13 +02:00
Hypolite Petovan
a7e9457ef2
Merge pull request #12061 from annando/share-rework 
The "share" handling is improved
 2022-10-25 09:04:16 -04:00
Michael
842a4bb904 Changed function name 2022-10-25 12:40:22 +00:00
Hypolite Petovan
2555596158
Merge pull request #12055 from nupplaphil/feat/usersess_decorator 
Extend `IHandleUserSessions` from `IHandleSessions` and adapt classes
 2022-10-25 07:52:23 -04:00
Michael
ebd175872d Improved description 2022-10-25 08:45:41 +00:00
Michael
1a0b63659b Merge remote-tracking branch 'upstream/develop' into share-rework 2022-10-25 08:31:01 +00:00
Michael
f54a886a5e The "share" handling is improved 2022-10-25 06:37:23 +00:00
Philipp
f03c5c7f89
implement feeback 2022-10-25 08:07:42 +02:00
Hypolite Petovan
dc2d96a502 Fix condition for follows export 
- Select follows instead of followers
- Filter out archived contacts
 2022-10-24 18:21:10 -04:00
Hypolite Petovan
142b399c84 Reformat Module\Settings\UserExport 
- Import IHandleUserSessions and DbaDefinition object in constructor
- Convert remaining double quotes to single quotes
- Convert static methods to dynamic to use class properties
- Remove unused POST permission from route
 2022-10-24 18:14:59 -04:00
Roland Häder
bf9f09182e
Changes: 
- added some missing type-hints
- no need for local array `$t` (changed to "anonymous" varriant)
- formatted some arrays
 2022-10-24 20:32:24 +02:00
Philipp
b5bc1b0844
Extend IHandleUserSessions from IHandleSessions and adapt classes 2022-10-23 20:41:17 +02:00
Tobias Diekershoff
b72d727a06
Merge pull request #12051 from Quix0r/hotfix/one-dollar-to-much 
Hotfix: One `$` to much ...
 2022-10-23 16:25:46 +02:00
Roland Häder
e8fe0c52e7
Hotfix: One $ to much ... 2022-10-23 13:15:34 +02:00
Philipp
b4b9f426db
Fix missing/wrong IHandleUserSessions usages 2022-10-23 11:32:43 +02:00
Philipp
a9963dc54b
Remove Core\Session 2022-10-21 19:36:42 +02:00
Philipp
7b3caca276
Update src/Content/Widget.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-10-21 19:35:34 +02:00
Philipp
44a9683008
Move "submanage" Session value into own methods 2022-10-21 19:35:34 +02:00
Philipp
cafb23f8f0
Reduce parentheses 2022-10-21 19:35:34 +02:00
Philipp
f15878195c
make App\Router easier 2022-10-21 19:35:34 +02:00
Philipp
7b35c570f9
Move DI dependency for App class 2022-10-21 19:35:33 +02:00
Philipp
134f98e22e
Move DI dependency for Navigation\Notifications\Factory\Introduction class 2022-10-21 19:35:33 +02:00
Philipp
a1997d73c2
Move DI dependency for Navigation\Notifications\Factory\FormattedNotify class 2022-10-21 19:35:33 +02:00
Philipp
f1cbb41a60
Move DI dependency for Navigation\Notifications\Factory\FormattedNavNotification class 2022-10-21 19:35:33 +02:00
Philipp
d76a2b6ad6
Move DI dependency for Content\Item class 2022-10-21 19:35:32 +02:00
Philipp
37ff477b55
Move DI dependency for App\Conversation class 2022-10-21 19:35:32 +02:00
Philipp
fa8a32e83c
Move DI dependency for App\Router class 2022-10-21 19:35:32 +02:00
Philipp
f83784cc63
Move DI dependency for App\Page class 2022-10-21 19:35:32 +02:00
Philipp
b3f9cef94a
UserSession class [3] - Refactor src/ files excluding Module/Model 2022-10-21 19:35:32 +02:00
Hypolite Petovan
a11c125f81
Merge pull request #12042 from nupplaphil/feat/usersession_Module_DepInj 
UserSession class [6] - Refactor src/Module/ files without DI
 2022-10-21 13:21:48 -04:00
Philipp
8ad83e5d5c
Add missing DI 2022-10-21 19:16:25 +02:00
Philipp
22198ea495
UserSession class [6] - Refactor src/Module/ files without DI 2022-10-21 10:25:07 +02:00
Philipp
bf39b5a948
Fix messages.po issue 2022-10-21 10:19:13 +02:00
Hypolite Petovan
f609386ca1
Merge pull request #12041 from nupplaphil/feat/usersession_Module 
UserSession class [5] - Refactor src/Module/ files with DI
 2022-10-20 20:32:54 -04:00
Philipp
eecc456e0c
UserSession class [5] - Refactor src/Module/ files with DI 2022-10-20 22:59:39 +02:00
Philipp
b4ffb0bde0
UserSession class [4] - Refactor src/Model/ files 2022-10-20 22:14:50 +02:00
Philipp
0b66b6e0d5
Move Session "exists" and "expire" to new class 2022-10-20 20:27:35 +02:00
Philipp
940619325d
Add SessionUsers class including tests 2022-10-20 20:27:34 +02:00
Hypolite Petovan
eaf1485c6f Fix using wrong variable in DomainPatterBlocklist::extractFromCSVFile 
- This was clobbering the internal block list structure from an associative array to a simple list
 2022-10-20 09:45:40 -04:00
Michael
4930737cc4 Legacy "include" fragments have been removed 2022-10-20 04:21:00 +00:00
Michael
d3e167c77c All references to boot.php are now removed 2022-10-19 20:38:25 +00:00
Michael
cfbba97e0a Fix Error: Uncaught Exception Error: "Class "Friendica\Content\Session" not found" 2022-10-19 19:16:01 +00:00
Michael
d47d78f2d4 old boot.php functions replaced in src/module (4) 2022-10-19 09:23:12 -04:00
Hypolite Petovan
956f196f7c Align pConfig calls in Module\Settings\Display 2022-10-19 09:20:48 -04:00
Hypolite Petovan
979e226d27 Suppress repetitive "missing cache key ping:events:XX" when there are no upcoming events 2022-10-19 09:17:28 -04:00
Michael
ae6d67ed1f old boot.php functions replaced in src/module (3) 2022-10-19 09:14:24 -04:00
Michael
c9f17e1ef5 old boot.php functions replaced in src/module (2) 2022-10-19 09:06:09 -04:00
Hypolite Petovan
47d9f91009 Add missing use statements in modules classes 2022-10-19 09:02:53 -04:00
Michael
d2da2492b7 old boot.php functions replaced in src/module 2022-10-19 08:53:45 -04:00
Hypolite Petovan
058abc0336
Simplify boolean statements in Content\Conversation 2022-10-19 08:05:31 -04:00
Michael
ee1acba9eb old boot.php functions replaced in /src 2022-10-19 07:56:25 -04:00
Michael
11944dda32 old boot.php functions replaced in various places 2022-10-19 07:44:08 -04:00
Philipp
692566d93b
Fix ERROR IHandleSessions 2022-10-19 08:07:12 +02:00
Tobias Diekershoff
d8fe8b1e8b
Merge pull request #12029 from annando/warning 
Suppress warning on load check
 2022-10-19 07:51:24 +02:00
Michael
196dda9487 Suppress warning on load check 2022-10-19 04:49:57 +00:00
Philipp
4a2f67aa9a
Move Core\Session::clear() to DI::session()->clear() 2022-10-18 21:13:58 +02:00
Philipp
a2eb0c7378
Move Core\Session::remove() to DI::session()->remove() 2022-10-18 21:13:28 +02:00
Philipp
315ed3ed22
Remove unused Core\Session::setMultiple() 2022-10-18 21:12:48 +02:00
Philipp
3a8bcb3fbf
Move Core\Session::set() to DI::session()->set() 2022-10-18 21:12:23 +02:00
Philipp
dfb5792773
Remove unused Core\Session::pop() method 2022-10-18 21:11:19 +02:00
Philipp
fb2b2f5c58
Remove unused Core\Session::create() method 2022-10-18 21:11:00 +02:00
Philipp
7ac86e49d1
Move Core\Session::get() to DI::session()->get() 2022-10-18 21:10:37 +02:00
Michael
ae82737445 Fix errors introduced by PR #11997 2022-10-18 18:32:20 +00:00
Roland Häder
c36da392f8
Changed: 
- re-added `null` again https://github.com/friendica/friendica/pull/11900#discussion_r979248182
- removed null coalescing operator
 2022-10-18 18:21:45 +02:00
Roland Häder
2773ac9909
Changed according feedback: 
- $posted_date should not allow NULL, instead use `?? ''` instead
- this happened in e.g. 2FA app-specific password listing
 2022-10-18 17:47:15 +02:00
Roland Häder
66b9cace9f
Changed: 
- first parameter can be null
 2022-10-18 17:47:15 +02:00
Roland Häder
26e0469de7
Merge branch 'develop' into rewrite/gravity-constants 2022-10-18 16:34:40 +02:00
Michael
6f68679375 The EOL constant is removed 2022-10-18 12:29:50 +00:00
Hypolite Petovan
abf52c0c11
Merge pull request #12012 from nupplaphil/feat/move_monolog 
Move Monolog to Addons
 2022-10-18 07:31:59 -04:00
Hypolite Petovan
ab9b60b9d2
Merge pull request #12014 from annando/usertosession 
The user related functions moved to the session class
 2022-10-18 07:30:21 -04:00
Michael
d43122c6d8 Check the readability before acessing /proc/loadavg 2022-10-18 08:02:55 +00:00
Michael
27e9f2b223 SIGTERM moved 2022-10-18 04:35:06 +00:00
Michael
33ac39c335 The user related functions moved to the session class 2022-10-17 21:11:00 +00:00
Philipp
497fc4e432
Move Monolog to Addons 2022-10-17 22:22:00 +02:00
Michael
fdfa1f8630 The notice and info have been moved 2022-10-17 18:55:22 +00:00
Michael
20291ddc2b Merge remote-tracking branch 'upstream/develop' into notice 2022-10-17 13:32:10 +00:00
Michael
e96fd5166a Fix wrong constant 2022-10-17 11:28:54 +00:00
Michael
4ff7c37f85 Replace "notice" calls 2022-10-17 11:27:32 +00:00
Michael
62a0d55fc8 The friendica constants have been moved to the app class 2022-10-17 10:37:48 +00:00
Michael
9bac8153ae Some more constants are moved to their specific classes 2022-10-17 09:24:32 +00:00
Michael
018858934b The priority is now a class constant 2022-10-17 05:49:55 +00:00
Michael
9ffa053c90 Merge remote-tracking branch 'upstream/develop' into linked-posts 2022-10-16 21:51:26 +00:00
Michael
f8f0dfa91a Detect linked posts and add them as quote 2022-10-16 21:37:05 +00:00
Hypolite Petovan
e556dc3c31 Add new frio.always_open_compose setting 
- This setting allows the New Post button to always open the Compose page instead of the modal by default
 2022-10-16 11:49:27 -04:00
Hypolite Petovan
d826fe0a3b Refactor files related to the Compose page and frio theme settings 
- Use dependencies instead of most DI calls in Module\Item\Compose
- Group translation strings in a subkey of the template variables array
- Rewrite array initializations in theme/frio/config
 2022-10-16 11:48:28 -04:00
Michael
8e1af9277a Improve quite generation 2022-10-15 13:00:52 +00:00
Roland Häder
ebf3b7e62d
Changes: 
- Content\Item versus Model\Item solved (?)
 2022-10-15 00:44:07 +02:00
Roland Häder
85ed0742cf
Fixed: 
- Content\Item versus Model\Item is really confusing!
 2022-10-15 00:44:07 +02:00
Roland Häder
8f92d1cc8e
Changes: 
- unified class import, we had these both:

````
use Friendica\Model\Item as ModelItem;
use Friendica\Object\Post as PostObject;
````

In first version the namespace was prefixing class name, in second suffixing it.
 2022-10-15 00:44:07 +02:00
Roland Häder
da66730e4f
Rewrite: 
- moved constants GRAVITY_* from boot.php to Friendica\Model\Item
- also rewrote some array initialization:

From:
````
<?php
$arr = [];
$arr['foo'] = "FOO";
````

To:
````
<?php
$arr['foo'] = "FOO";
````
- added a few type-hints
 2022-10-15 00:44:06 +02:00
Michael
3e868416c7 Check for post existence 2022-10-14 22:02:25 +00:00
Michael
88aceeb27f Merge remote-tracking branch 'upstream/2022.09-rc' into quote-uri-id 2022-10-14 19:11:15 +00:00
Michael
c2e57c5c0e Return the pageinfo when feed is shared 2022-10-14 04:43:46 +00:00
Michael
da2afbeae3 Merge remote-tracking branch 'upstream/2022.09-rc' into quote-again 2022-10-12 05:36:00 +00:00
Michael
e69b04d2df Only add the media for non federated posts 2022-10-12 05:34:55 +00:00
Hypolite Petovan
0480d9aebd Add missing post keys to retrieve pLink in Model\Event::prepareListForTemplate() 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1275117722
 2022-10-11 22:18:52 -04:00
Michael
0e82f64d71 Only attach images 2022-10-11 21:39:28 +00:00
Michael
f1f13db24f Simplified code 2022-10-11 20:48:47 +00:00
Michael
68d6e11d83 Fix attached media in quoted posts 2022-10-11 20:10:39 +00:00
Hypolite Petovan
9e74a1bd06 Contact array can be empty in Model\Contact::getAvatarPath 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1274195844
 2022-10-11 08:26:00 -04:00
Michael
a67a364b91 Merge remote-tracking branch 'upstream/2022.09-rc' into quote-uri-id 2022-10-11 05:19:21 +00:00
Michael
747139d186 Quoted posts from Twitter now contain media again 2022-10-10 23:18:58 +00:00
Michael
aeb4645ba6 New field "quote-uri-id" for quoted posts 2022-10-10 22:39:30 +00:00
Michael
028de0e228 Quote of quotes are visually improved 2022-10-10 12:30:07 +00:00
Michael
a21c04d55d Use "maxloadavg" when "worker_load_cooldown" is not defined 2022-10-10 06:01:07 +00:00
Hypolite Petovan
a10f55bb85
Merge pull request #11979 from annando/issue-11853 
Notices
 2022-10-09 17:45:33 -04:00
Hypolite Petovan
424dad886f
Merge pull request #11978 from annando/quote-simplified 
The quote functionality is simplified
 2022-10-09 17:26:22 -04:00
Michael
0d3aa681b4 The quote functionality is simplified 2022-10-09 21:16:36 +00:00
Hypolite Petovan
a4b0ebf160 Add a couple of cases to DateTimeFormat::fix() 
- Reworked method to perform more string replacements and fewer regular expression matches
 2022-10-09 09:34:38 -04:00
Hypolite Petovan
bee6506d33 Only call DateTimeFormat::fix() when there's an Exception 
- This prevents valid date/time strings to be mangled by fix()
 2022-10-09 09:34:30 -04:00
Michael Vogel
b5ad8c3e15
Merge pull request #11973 from MrPetovan/task/test-fixDateFormat 
Add tests for DateTimeFormat::fix()
 2022-10-08 17:11:10 +02:00
Michael
4552d36373 Issue 11975: Don't call the postupdate if the table is missing 2022-10-08 14:42:11 +00:00
Hypolite Petovan
47dd19ab95
Merge pull request #11974 from annando/issue-11969 
Issue 11969: Simplified share
 2022-10-08 10:04:07 -04:00
Michael
4a37c978c2 Issue 11969: Simplified share 2022-10-08 09:36:35 +00:00
Hypolite Petovan
345d307ae0 Add tests for DateTimeFormat::fix() 2022-10-07 23:10:50 -04:00
Hypolite Petovan
c0447ced48 Simplify method name for DateTimeFormat::fix 2022-10-07 23:10:50 -04:00
Hypolite Petovan
2cbc11403e Fix parameter names before being passed to Model\Event::store 
- Partial revert of 946db2ab45
 2022-10-07 17:20:22 -04:00
Michael
1ddeaaad4a And another weird date format 2022-10-07 19:56:02 +00:00
Michael
33d48f7d55 Use trim 2022-10-07 08:14:04 +00:00
Michael
f340fc6efa Harmonized regular expression 2022-10-07 08:00:09 +00:00
Michael
21bd2a8396 More whitespace 2022-10-07 07:57:20 +00:00
Michael
f8d4ab1830 Whitespace removed 2022-10-07 07:55:44 +00:00
Michael
ef934db614 Moved the share interpretation 2022-10-07 07:41:03 +00:00
Michael
d7a9745ffd Simplified share element 2022-10-07 05:51:36 +00:00
Michael
48182a95fb Improve quote share ("message_id" added) 2022-10-06 21:50:20 +00:00
Michael
6b917718fd Juts another date format fix 2022-10-06 21:09:52 +00:00
Michael
4c8a58c445 Akkoma is added to the federation statistics 2022-10-06 04:57:43 +00:00
Michael
f9b7f3acdb Added sharing check for DFRN 2022-10-05 21:11:09 +00:00
Michael
bde7283b04 Fix: Undefined array key "object_object_type" 2022-10-03 20:01:28 +00:00
Michael Vogel
0a7c9c66b5
Update src/Util/DateTimeFormat.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-10-03 19:04:49 +02:00
Michael
045238070b Issue 11938: Fix weird date formats 2022-10-03 16:12:22 +00:00
Hypolite Petovan
168827c8ae
Merge pull request #11957 from annando/issue-11891 
Issue 11891: Enable search for user@domain.tld
 2022-10-03 11:15:55 -04:00
Michael
4b8c631216 Issue 11891: Enable search for user@domain.tld 2022-10-03 13:53:19 +00:00
Michael
8347f0144b Fix log message 2022-10-03 11:42:50 +00:00
Michael
5127784acb Recursively check if the thread supports Diaspora 2022-10-03 11:04:57 +00:00
Michael
7395ae22f7 Issue 11952: Avoid to send AP related comments to Diaspora 2022-10-03 10:40:16 +00:00
Hypolite Petovan
38cf0666bd
Merge pull request #11955 from annando/issue-11953 
Fix picture link removal in "getAttachedData"
 2022-10-02 21:35:30 -04:00
Michael
1afbcb2486 Added description 2022-10-02 23:55:33 +00:00
Michael
bf4c5ba84f Improved URL handling 2022-10-02 20:42:21 +00:00
Michael
0de458e134 Case changed 2022-10-02 04:51:00 +00:00
Michael
6fb5e13b08 Add ♲ symbol 2022-10-01 22:36:02 +00:00
Michael
8d9cb974af Merge remote-tracking branch 'upstream/2022.09-rc' into transmit-quote 2022-10-01 22:30:44 +00:00
Michael
54d25ebc91 Fix picture link removal in "getAttachedData" 2022-10-01 22:26:37 +00:00
Michael
1e29c6f705 Ensure not to add the plink 2022-10-01 16:54:11 +00:00
Michael
2d6735a616 Issue 11953: Split a message in parts 2022-10-01 16:37:32 +00:00
Michael
8eb4ab2a33 Added comment for the deactivated part 2022-09-30 07:17:07 +00:00
Michael
d43b85e94b Don't transmit the shared attachments 2022-09-30 07:10:43 +00:00
Michael
59004711ec Support for transmitting quoted posts 2022-09-29 22:29:15 +00:00
Michael
a653c6350d Support for quoted links is added 2022-09-29 16:04:33 +00:00
Michael
9587787089 Add uri as well 2022-09-29 14:13:39 +00:00
Michael
6140f850e1 Detect the thread parent id if it is missing 2022-09-29 13:48:10 +00:00
Michael
ff80a25966 Additional checks for non follower content 2022-09-29 12:45:47 +00:00
Michael
b10496f4e9 Changed log level 2022-09-28 16:45:18 +00:00
Michael
d821afb418 Added logging of unexpected follow messages 2022-09-28 16:32:17 +00:00
Michael
c65f78e579 Only display reshared thread starting posts 2022-09-28 09:48:48 +00:00
Hypolite Petovan
c12ac42695
Merge pull request #11940 from annando/issue-11876 
Issue 11876: Fix local message distribution
 2022-09-27 12:07:30 -04:00
Michael
2def5e9f02 Issue 11876: Fix local message distribution 2022-09-27 15:58:16 +00:00
Philipp
0ce7b49cb3
Minor l10n issue 2022-09-27 10:52:17 +02:00
Michael
4c52772d84 Use class constant 2022-09-26 13:33:31 +00:00
Michael
5e51ab95fb Merge remote-tracking branch 'upstream/2022.09-rc' into worker-timeout 2022-09-26 13:26:56 +00:00
Hypolite Petovan
afac91fa34
Merge pull request #11936 from annando/youtube-shorts 
Added support for the "Youtube Shorts" URL
 2022-09-26 07:33:23 -04:00
Hypolite Petovan
e56e543a79
Merge pull request #11933 from nupplaphil/bug/module_returns 
Fix /api/v1/push/subscription
 2022-09-26 07:32:24 -04:00
Michael
297ddbb8c8 Added support for the "Youtube Shorts" URL 2022-09-26 07:04:35 +00:00
Michael
63ec808fb9 Issue 11932: Restore SQL performance 2022-09-26 06:39:28 +00:00
Philipp
883a2ee71b
Update src/Module/Api/Mastodon/PushSubscription.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-09-26 07:25:04 +02:00
Philipp
5c88813775
Update src/Module/Api/Mastodon/PushSubscription.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-09-26 07:24:55 +02:00
Philipp
006dbcf4ce
some code-beautification 2022-09-25 21:39:29 +02:00
Philipp
ad62265d08
Fix /api/v1/push/subscription 2022-09-25 21:39:28 +02:00
Michael
22ed028ba1 Simplified structure 2022-09-25 07:12:05 +00:00
Michael
662c846402 Issue 11919: Avoid possible memory problems 2022-09-25 06:34:13 +00:00
Hypolite Petovan
3e1b6890b7 Fix removing falsy text nodes in HTML::tagToBBCodeSub 
- This wrongly removed text nodes containing just '0'
 2022-09-24 22:03:49 -04:00
Michael
bca9069b22 Add the uri-id if missing 2022-09-24 21:53:27 +00:00
Michael Vogel
08ead52433
Merge pull request #11763 from tobiasd/marcor-newapi 
new event APIs
 2022-09-24 21:18:20 +02:00
Hypolite Petovan
5a236e0af2
Merge pull request #11925 from mexon/mat/dont-remove-slash 
Do not remove trailing slash from URIs
 2022-09-24 15:05:02 -04:00
Hypolite Petovan
02e9a867ae
Merge pull request #11926 from annando/sql-queries 
(Hopefully) SQL improvements
 2022-09-24 15:01:34 -04:00
Hypolite Petovan
080aa55302
Merge pull request #11924 from annando/error 
Fix error "Class 'Friendica\Worker\Worker' not found"
 2022-09-24 14:59:58 -04:00
Michael Vogel
b00947025a
Merge pull request #11922 from MrPetovan/bug/notices 
Ward against missing keys in Model\APContact::isRelay
 2022-09-24 20:02:21 +02:00
Michael
3911c9450b (Hopefully) SQL improvements 2022-09-24 17:56:07 +00:00
Michael
bd817d2391 Fix error "Class 'Friendica\Worker\Worker' not found" 2022-09-24 17:29:00 +00:00
Matthew Exon
7613433357 Do not remove trailing slash from URIs 2022-09-24 17:57:28 +02:00
Hypolite Petovan
6ca725e5b6 Check for network key existence before calling Probe::isProbable in Model\Contact 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1253225607
 2022-09-24 10:18:41 -04:00
Hypolite Petovan
ded5a0ac6a Ward against missing keys in Model\APContact::isRelay 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1231904280
 2022-09-24 09:56:12 -04:00
Michael Vogel
98a4c7a56c We can now configure the worker runtime limits 2022-09-24 10:00:41 +02:00
Hypolite Petovan
be9bbe1709
Merge pull request #11917 from annando/cooldown 
More cooldown calls for worker processes
 2022-09-22 22:39:04 -04:00
Michael
97e5477bde static cooldown moved to the cooldown function 2022-09-22 22:46:59 +00:00
Hypolite Petovan
264b8f27fd
Merge pull request #11918 from annando/fcontact 
Worker for updating fcontact entries
 2022-09-22 11:00:15 -04:00
Michael
e1341b6ad3 Fallback for load detection, additional checks 2022-09-22 05:45:42 +00:00
Michael
4939be065e Merge remote-tracking branch 'upstream/2022.09-rc' into cooldown 2022-09-22 04:31:50 +00:00
Hypolite Petovan
6a9d91c824
Merge pull request #11902 from annando/duplicates 
Detect and remove contact duplicates
 2022-09-21 21:23:37 -04:00
Michael Vogel
c87150819b Worker for updating fcontact entries 2022-09-21 22:47:09 +02:00
Michael Vogel
0fa281247d More cooldown calls for worker processes 2022-09-21 21:03:07 +02:00
Michael Vogel
6ee8a966bf Fix forum delivery in case of beiong addressed via "@" 2022-09-21 10:54:05 +02:00
Michael
36668dfdb1 Merge remote-tracking branch 'upstream/2022.09-rc' into duplicates 2022-09-21 03:46:25 +00:00
Hypolite Petovan
4deee0932c
Merge pull request #11910 from annando/logging 
Improved page rendering speed logging
 2022-09-20 21:05:58 -04:00
Michael Vogel
7ae500f28d Improved page rendering speed logging 2022-09-20 16:30:56 +02:00
Michael Vogel
199d8bbf35 Merge remote-tracking branch 'upstream/2022.09-rc' into relay-languages 2022-09-20 06:05:15 +02:00
Michael Vogel
6ba2c4bb01 Added documentation 2022-09-19 12:49:37 +02:00
Michael Vogel
3650feb256 "Count" parameter added 2022-09-19 12:46:28 +02:00
Michael Vogel
f08b08e0d8 Allow to reject specific languages on receiving posts via the relay 2022-09-19 12:36:12 +02:00
Michael Vogel
2525b3f2ae
Update src/Network/Probe.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-09-19 07:52:40 +02:00
Michael Vogel
e5c24f33f0 The fcontact table is now updated in the background to improve performance 2022-09-18 15:40:44 +02:00
Michael
79b64cc44f Detect and remove contact duplicates 2022-09-16 05:00:06 +00:00
Hypolite Petovan
636325efcc
Merge pull request #11899 from annando/native-xml 
Template based XML generation is replaced with native XML
 2022-09-11 04:39:39 -04:00
Michael
ff89c1a8bf Template based XML generation is replaced with native XML 2022-09-11 07:00:16 +00:00
Hypolite Petovan
cacfc6ec92 Enable POST route for /filerm module 
- This prevents a costly page empty page render when calling the module asynchronously
 2022-09-11 02:36:06 -04:00
Hypolite Petovan
bdd80eeaaf Fix wrong parameter name in Core\System::httpExit 2022-09-11 02:36:05 -04:00
Michael
63e1ad7dba Read the config at another place 2022-09-08 06:21:16 +00:00
Michael
ff677a1b27 Smarty: Configuration added to store without sub directories 2022-09-08 05:10:26 +00:00
Hypolite Petovan
7da43fe28a
Merge pull request #11892 from annando/pagecache 
Pagecache for frequently fetched pages
 2022-09-07 22:25:19 -04:00
Michael
a0b99f61ea Use the cached activity function 2022-09-07 19:46:24 +00:00
Michael
0121c2845a Test stuff removed 2022-09-06 22:56:56 +00:00
Michael
da658cbf1d Delete the cache entry when the post is changed or deleted 2022-09-06 21:51:47 +00:00
Michael
d7212cbbbc Function only needn't to be public 2022-09-06 20:47:18 +00:00
Michael
ec8377a8c7 Issue 11893: Postupdate to fix wrong parents 2022-09-06 20:00:06 +00:00
Michael
7c9f10e58f Merge remote-tracking branch 'upstream/2022.09-rc' into pagecache 2022-09-06 17:36:42 +00:00
Michael
2a4c6d44bb Don't transmit empty conversations 2022-09-06 15:18:41 +00:00
Michael
f0d151932e Issue 11890: Don't use empty contexts 2022-09-06 14:08:25 +00:00
Michael
6eb9dff807 Pagecache for frequently fetched pages 2022-09-06 06:04:41 +00:00
Hypolite Petovan
934a3a6721
Merge pull request #11887 from annando/maxload 
Pause the worker execution when the load is too high
 2022-09-04 15:54:40 -04:00
Hypolite Petovan
8f283985f0
Merge pull request #11884 from annando/language 
Improved language detection
 2022-09-04 15:52:29 -04:00
Michael
e2cb705468 Merge remote-tracking branch 'upstream/2022.09-rc' into language 2022-09-04 17:04:13 +00:00
Michael
437c230a6f Merge remote-tracking branch 'upstream/2022.09-rc' into database 2022-09-04 17:03:14 +00:00
Michael
96ae2c8f56 Merge remote-tracking branch 'upstream/2022.09-rc' into maxload 2022-09-04 17:01:35 +00:00
Michael
f5d6671fbd Merge remote-tracking branch 'upstream/2022.09-rc' into performance 2022-09-04 14:08:16 +00:00
Michael
12d4bae28f Merge remote-tracking branch 'upstream/2022.09-rc' into language 2022-09-04 14:05:46 +00:00
Michael
075638c0ae Pause the worker execution when the load is too high 2022-09-04 13:54:32 +00:00
Michael
f93418b295 Merge remote-tracking branch 'upstream/2022.09-rc' into database 2022-09-04 13:41:21 +00:00
Michael
c3d478aeed Improved logger calls 2022-09-04 09:22:15 +00:00
Michael
144547009b All URL fields are now binary and longer 2022-09-04 07:54:01 +00:00
Michael
f22a4ba6f5 Be more tolerant when receiving messages 2022-09-04 07:39:09 +00:00
Michael
4304aa9eec Improved language detection 2022-09-04 07:32:46 +00:00
Michael
9f2d3e6f88 Use AP data when possible 2022-09-04 07:15:04 +00:00
Michael
f7be610629 Fix logger warmings/errors 2022-09-03 13:32:41 +00:00
Michael
3e28d62bdb Fix receiving of reshared posts 2022-08-31 21:18:33 +00:00
Michael
cc43b567cb Some changes after code review 2022-08-31 19:03:37 +00:00
Michael
9ca470cc94 Reverted experimental change 2022-08-31 05:02:28 +00:00
Michael
f7b85092b0 Some more changed log levels 2022-08-31 05:01:22 +00:00
Michael
757a5c2de9 Loglevels are adjusted 2022-08-30 19:45:30 +00:00
Michael
3a840aa22d Some more warnings and erors are fixed 2022-08-28 19:27:21 +00:00
Michael
61cbcf85a1 Issue 11870: Weeks can now start at every day 2022-08-28 09:15:00 +00:00
Michael
3052ae71b7 Avoid warnings 2022-08-28 09:12:36 +00:00
Michael
4e02c347b6 Handle array 2022-08-28 04:14:39 +00:00
Michael
d54cf9cc21 Avoid warnings/fatal errors 2022-08-28 04:00:18 +00:00
Michael
2173fb38e0 Issue 11853/11867: Fix reshare of public posts 2022-08-27 21:22:49 +00:00
Michael
a0eaff8fd5 Fix issue 11865 2022-08-27 11:43:46 +00:00
Michael
ceb88c10e6 Warnings/Errors reduced - improved relay processing 2022-08-27 08:08:58 +00:00
Michael
1db70b8935 Merge remote-tracking branch 'upstream/develop' into database2 2022-08-25 18:48:24 +00:00
Michael
dd8279afc2 Some more protection against database errors 2022-08-25 18:47:07 +00:00
Tobias Diekershoff
fde853897f
Merge pull request #11863 from annando/database 
Avoid some database errors
 2022-08-25 13:49:05 +02:00
Michael
15d975f143 Avoid some database errors 2022-08-25 04:57:41 +00:00
Tobias Diekershoff
aaaf928650
Merge pull request #11857 from annando/diaspora-author-signature 
Diaspora: Don't check the author signature when author = parent author
 2022-08-22 15:02:57 +02:00
Michael
4e3102bfb3 Diaspora: Don't check the author signature when author = parent author 2022-08-22 09:54:29 +00:00
Hypolite Petovan
2957a3def6
Merge pull request #11855 from annando/contact-id2 
The contact-id of a wall posting is always the owner contact
 2022-08-22 04:26:45 -04:00
Michael
2a0ca80630 The contact-id of a wall posting is always the owner contact 2022-08-22 07:54:48 +00:00
Hypolite Petovan
5f62a59d2f Ensure Util\Profiler->rendertime is bool 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1221228589
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1221244898
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1221333918
 2022-08-21 07:44:12 -04:00
Roland Häder
4c6940583a
Changes: 
- added missing type-hints
- first access level, then static
- reformatted code following code-style
 2022-08-19 19:12:30 +02:00
Roland Häder
b3906326a4
Changed: 
- changed double-quotes to single
- added some empty lines for better readability
 2022-08-19 19:12:29 +02:00
Michael
51331ced9b Improved function to fetch the contact id 2022-08-18 10:13:46 +00:00
Michael
a4f1df68e4 Improved contact-id detection 2022-08-18 07:48:39 +00:00
Michael
531085890a Fetch the parent only - thread parents only on reshares 2022-08-17 19:39:20 +00:00
Michael
6070221364 Improved checks in "storeForUserByUriId" to reduce recursion depth 2022-08-17 05:28:24 +00:00
Michael
3e2c684319 Some more index / fatal erros fixed 2022-08-16 11:23:47 +00:00
Michael
bb52e5a804 Cascade on author deletion 2022-08-16 04:18:29 +00:00
Michael
4d617c9c48 This cache key doesn't exist anymore 2022-08-15 18:46:10 +00:00
Michael
5b3145d7ce Several performance improvements 2022-08-15 13:23:01 +00:00
Hypolite Petovan
946db2ab45 Normalize start_time and end_time parameter names in Friendica API event endpoints 2022-08-13 23:28:20 -04:00
pankraz
bd02340162 new event APIs 2022-08-13 23:28:19 -04:00
Roland Häder
c1c37da545
Changed double-quotes to single 2022-08-13 23:24:38 +02:00
Roland Häder
52d1b9905e
Fixes: 
- fixed "get() on NULL invocation, PHP is case-sensitive here
- renamed $this->baseurl to $this->baseUrl (instance) in MoveToAvatarCache to
  make it same as everywhere else
 2022-08-13 22:47:57 +02:00
Roland Häder
f579d687a9
Fixes: 
- fixed $this usage (kept) and got rid of static context
- "imported" exception class
- added some nice text to it
 2022-08-13 22:32:56 +02:00
Hypolite Petovan
21f3a56c42
Merge pull request #11841 from Quix0r/cleanups/type-hints-documentation 
Cleanups/type hints + documentation
 2022-08-13 10:43:11 -04:00
Michael
c6de91a8ec Don't delete the post when there is some undeleted post-user 2022-08-13 12:24:25 +00:00
Roland Häder
88cdb695b1
Changed: 
- double-quotes to single
- more space around concated strings
- removed TODO as there is sadly no IOException in PHP
 2022-08-13 13:35:50 +02:00
Michael
5c5ae00370 Improved performance when updating contacts 2022-08-13 09:01:48 +00:00
Roland Häder
ff5673e2d8
Changed: 
- used $this->baseurl instead of DI::baseurl() (@MrPetovan)
 2022-08-13 06:52:09 +02:00
Roland Häder
cfa575b8e5
Changes: 
- added missing type-hints
- added documentation
- removed parameter $baseURL while it can be locally get the same way but
  lesser parameter
- used ActivityNamespace::SALMON_ME
- changed double-quotes to single
 2022-08-12 14:01:40 +02:00
Roland Häder
074bae33c9
Changes: 
- added some missing type-hints
- added some documentation
- added some empty lines to `@return` statements (code-style convention)
 2022-08-12 13:36:34 +02:00
Roland Häder
33c7abd376
Changes: 
- methods should ALWAYS start lower-case, not upper
- documented a bit more
 2022-08-12 13:13:54 +02:00
Roland Häder
9794ce0c87
Changes: 
- added type-hint for $type parameter
- documented method
- unsupported verbs logged
 2022-08-12 13:09:59 +02:00
Philipp
a145712f04
Merge pull request #11837 from MrPetovan/task/remove-poke 
Remove poke feature
 2022-08-11 18:17:11 +02:00
Roland Häder
ae9bd4f3f2
Changes: 
- reformatted and documented private method
- used [] instead of deprecated/discouraged array()
 2022-08-10 17:10:59 +02:00
Hypolite Petovan
809beeee9d
Merge pull request #11838 from annando/asynchronous-conversation 
Conversation entries will now be stored asynchronous if possible
 2022-08-10 10:42:19 -04:00
Michael
e2896b449b Changes after code review 2022-08-10 13:43:00 +00:00
Michael
d9aee0b3ea Conversation entries will now be stored asynchronous if possible 2022-08-10 09:28:18 +00:00
Hypolite Petovan
4a885a13a6 Remove poke feature 2022-08-09 14:55:55 -04:00
Tobias Diekershoff
62be1c5614
Merge pull request #11835 from annando/sql-fetchqueue 
Improve SQL-Queries / fixed "fetch_parents" setting
 2022-08-08 23:00:48 +02:00
Michael
548b7f43a5 Improve SQL-Queries / fixed "fetch_parents" setting 2022-08-08 20:00:21 +00:00
fabrixxm
547b4684fd Add smarty3 dirs config 
`FriendicaSmarty` get work dirs from config, with fallback if not set
 2022-08-08 12:28:07 -04:00
Philipp
e0ec304d2a
Merge pull request #11830 from MrPetovan/task/11826-pluralization 
Use L10n->tt instead of t() for plural strings
 2022-08-08 15:35:54 +02:00
Tobias Diekershoff
7634fc2425 added Gàidhlig language translation 
This adds the initial translation of Friendica core into Gàidhlig by @gunchleoc

redo of #11818
 2022-08-08 11:37:39 +02:00
Hypolite Petovan
71084cf9f0 Use L10n->tt instead of t() for plural string in Module\BaseApi 2022-08-08 02:08:43 -04:00
Hypolite Petovan
c19e57e176 Use L10n->tt instead of t() for plural strings in Module\Admin\Federation 2022-08-08 02:08:40 -04:00
Hypolite Petovan
f917286d6e Use L10n->tt instead of t() for plural strings for polls in Model\Item 2022-08-08 01:52:16 -04:00
Hypolite Petovan
bff6a5a9ee Add support for additional interpolated variables in L10n->tt() 2022-08-08 01:51:42 -04:00
Michael
d60d2caef6 Improved queue processing 2022-08-07 19:24:50 +00:00
Michael
22c1873064 Merge remote-tracking branch 'upstream/develop' into loop-prevention 2022-08-06 17:11:04 +00:00
Michael
87a945b295 More prevention of double processing of the same content 2022-08-06 17:06:55 +00:00
Hypolite Petovan
963ebe9193
Merge pull request #11821 from tobiasd/20220805-typo 
typo in console tool
 2022-08-05 10:05:06 -04:00
Tobias Diekershoff
91911c4676 typo in console tool 
@gunchleoc spottet a typo while working on the translations of Friendica. This fixes it.
 2022-08-05 15:37:38 +02:00
fabrixxm
704bd95608 Fix WSOD when Renderer throws exception 
`HTTPException` builds a simple static version of error page if
`Renderer` throws any exception while rendering the error page.
 2022-08-05 15:28:21 +02:00
Hypolite Petovan
bd246b8cc2
Merge pull request #11817 from annando/double-processing 
Avoid processing the same activity
 2022-08-05 09:04:33 -04:00
Michael
8b698b183d Abort when public item cannot be inserted 2022-08-05 05:48:20 +00:00
Michael
8227367522 Remove test code, add documentation 2022-08-05 04:45:31 +00:00
Michael
f222e9d278 Avoid to provess the same activity 2022-08-04 21:52:10 +00:00
Hypolite Petovan
2e00797ebc
Merge pull request #11816 from annando/fetch-parents 
New option to disable the fetching of parents
 2022-08-04 16:00:00 -04:00
Michael
06f7244280 New option to disable the fetching of parents 2022-08-04 19:32:36 +00:00
Roland Häder
8105668caf
Added missing 'private' field, see Processor::processContent() where it is needed 2022-08-04 10:50:44 +02:00
Hypolite Petovan
196a1de7f2
Merge pull request #11812 from annando/ap-performance 
Hopefully fixes loops during message processing
 2022-08-03 03:00:50 -04:00
Michael
e82ef8890b Only process entries for existing posts 2022-08-03 05:14:07 +00:00
Michael
3463e34693 Don't always fetch parent posts 2022-08-03 04:51:57 +00:00
Michael
23ef4a99bb Changes after code review 2022-08-03 04:31:56 +00:00
Michael
f2eec66240 Hopefully fixes loops during message processing 2022-08-03 03:38:03 +00:00
Hypolite Petovan
49394aedeb Add password length limit if using the Blowfish hashing algorithm 
- Add new page to reset a password that would be too long
- Add support for pattern parameter in field_password
 2022-08-01 12:12:18 -04:00
Hypolite Petovan
067f06b166 Rework return_path session key handling 
- Add new IHandleSessions::pop() method
- Remove redirection from Authentication::setForUser()
- Add explicit return_path form parameter to Login::form()
 2022-08-01 12:10:43 -04:00
Michael
c8d1bf4cdf Code standards and updated database documentation 2022-08-01 07:06:30 +00:00
Michael
81b244f91e Option to activate or deactivate the background fetching 2022-08-01 06:59:20 +00:00
Michael
f7ec8d5b8e Improved log message 2022-08-01 05:59:59 +00:00
Michael
7d5b4808cd Merge branch 'fetch' into fetch-cache 2022-08-01 05:57:59 +00:00
Michael
4be6e9a27d Cache if an activity has recently been fetched 2022-08-01 05:56:55 +00:00
Michael
6c7dfd6958 New table to control the fetching process 2022-08-01 04:48:49 +00:00
Michael
3945de5e3b No blubb allowed 2022-08-01 00:58:56 +00:00
Michael
0347f4fc66 Remove test code 2022-07-31 16:01:56 +00:00
Michael
b6da15557b The post-reason / protocol is now filled in most cases 2022-07-31 15:54:35 +00:00
Michael
06a124338a Only store the inbox-queue on activated background processing 2022-07-31 08:10:47 +00:00
Michael
371f20a1aa Decoupling is deactivated by default now 2022-07-31 07:48:35 +00:00
Michael
8b4bf890f8 Issue 11798: Handling of empty author 2022-07-30 05:30:08 +00:00
Michael
f6d11e8401 Issue 11800: Remove entry from queue in any case. 2022-07-30 04:43:18 +00:00
Hypolite Petovan
da48453931
Merge pull request #11801 from annando/no-zero 
Don't add zero as receiver
 2022-07-29 21:15:20 -04:00
Michael
6383b07022 Don't add zero as receiver 2022-07-29 22:56:53 +00:00
Hypolite Petovan
2e75d442a5
Merge pull request #11793 from Quix0r/reformatted-arrays 
Reformatted some arrays for better readability
 2022-07-29 17:54:53 -04:00
Michael
653aaf1e26 Merge branch 'post-reason' of github.com:annando/friendica into post-reason 2022-07-29 21:31:34 +00:00
Michael
f9bf2424b1 Merge remote-tracking branch 'upstream/develop' into post-reason 2022-07-29 21:29:15 +00:00
Michael
699152e15e Add more post reasons 2022-07-29 21:28:22 +00:00
Michael Vogel
fa3c5d6c5e
Update src/Content/Conversation.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-07-29 21:59:53 +02:00
Michael
0971bcf165 Make the tests happy 2022-07-29 16:05:04 +00:00
Roland Häder
1210e235fb
Extracted as variable to have 2 more array fields moved to array initialization. 2022-07-29 17:20:09 +02:00
Roland Häder
676ca36c52
Changes: 
- reformatted arrays
 2022-07-29 17:20:07 +02:00
Michael
2c32429d8d Fix test 2022-07-29 14:56:40 +00:00
Michael
81aaacc67d Improvements for the "post-reason" 2022-07-29 14:17:53 +00:00
Roland Häder
95ac2aa54b
Fixed a possible NULL value (not valid, at least empty string) 2022-07-29 12:45:21 +02:00
Roland Häder
f8ed028013
Changed back to $cdata. 2022-07-29 12:41:08 +02:00
Hypolite Petovan
a20d05ba39
Merge pull request #11792 from Quix0r/fixes/get-request-value 
Wrong variable name fixed (maybe copy-paste mistake) + used method instead of direct array access
 2022-07-28 21:17:34 -04:00
Roland Häder
eaed3945d1
Changed: 
- used `$this->getRequestValue($request, 'foo', <bar>)` instead of `$request['foo'] ?? <bar>`
- fixed wrong variable naming
- changed double-quotes to single
- see https://github.com/friendica/friendica/issues/11631#issuecomment-1196410497
 2022-07-29 00:38:46 +02:00
Roland Häder
37bda3e5fb
Changes: 
- fixed wrong type-hint uid => int
- added returned type-hint
- added some documentation
- formatted arrays a bit
 2022-07-29 00:08:38 +02:00
Hypolite Petovan
5ec407699b
Merge pull request #11790 from annando/fetchactivity 
Negative caching / config for receiver / fix fatals
 2022-07-28 17:29:34 -04:00
Michael
b63ad63c29 Config for receiver / fix fatals 2022-07-28 21:16:42 +00:00
Hypolite Petovan
6e7823eaaa
Merge pull request #11784 from MrPetovan/task/11779-blocklist-notification 
Add email notification to all users on server domain pattern block list update
 2022-07-28 16:26:51 -04:00
Michael
f0499e7269 Use negative caching 2022-07-28 20:25:38 +00:00
Michael
1aacff4ce1 Fix fatal error 2022-07-28 19:35:25 +00:00
Michael
d12c9a8f58 Caching for fetched activities 2022-07-28 19:05:04 +00:00
Hypolite Petovan
f29d9be574
Merge pull request #11785 from annando/processing 
Decoupling of relay posts / endless loop removed
 2022-07-28 05:42:46 -04:00
Hypolite Petovan
97ccb4d2c4 Make server domain pattern block reason mandatory 2022-07-28 05:39:51 -04:00
Hypolite Petovan
5045f9e188 Add email notification to all users on server domain pattern block list update 2022-07-28 05:39:29 -04:00
Hypolite Petovan
1810b32c26 Move server domain pattern blocklist features to its own class 
- Update tests
 2022-07-28 05:38:50 -04:00
Hypolite Petovan
e445975c20 Use DBA::quoteIdentifier in Database::escapeFields 2022-07-28 05:37:22 -04:00
Roland Häder
09cb4c1540
Revert "Added logging of unsupported meta-tag records" 2022-07-28 06:00:58 +00:00
Michael
a27274b3b4 Avoid loops at deletion / decoupling for relay posts 2022-07-28 05:29:47 +00:00
Roland Häder
8fb0fa2921
Added logging of unsupported meta-tag records 2022-07-28 04:10:57 +02:00
Michael
3c71392f9e Avoid endless loop while deleting 2022-07-27 21:57:05 +00:00
Michael
505191dec5 Decouple the processor from the receiver 2022-07-27 20:59:42 +00:00
Michael
3af55de978 Issue 11776 - process replies via a worker task 2022-07-27 20:03:28 +00:00
Michael
ff9dc1e291 Merge remote-tracking branch 'upstream/develop' into untrusted 2022-07-27 17:56:56 +00:00
Michael
86105635ca Improved message handling / new activity relay handling 2022-07-27 17:39:00 +00:00
Hypolite Petovan
e11d3cfeb0 Add upload feature for domain pattern block list 
- Add new /admin/blocklist/server/import route
- Add form on domain pattern blocklist index page
 2022-07-27 11:54:50 -04:00
Hypolite Petovan
7d7a5a65e9 Add download feature for domain block list 
- Add new /blocklist/domain/download route
- Add link on /friendica page
 2022-07-27 11:54:50 -04:00
Hypolite Petovan
1b2182c43c Move system messages from boot to own class 2022-07-27 11:54:50 -04:00
Michael Vogel
f9777ce0dc
Merge pull request #11770 from MrPetovan/bug/notices 
Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId
 2022-07-25 21:01:12 +02:00
Hypolite Petovan
488f4dcaa4 Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1193953621
 2022-07-25 12:07:42 -04:00
Roland Häder
d1b21eaf42
Changes: 
- use local variables
 2022-07-25 17:53:54 +02:00
Roland Häder
1ac1db6173
Changed: 
- rewrote to almost one block of array initialization
 2022-07-25 16:49:01 +02:00
Hypolite Petovan
65cd0def22 Fix wrong type-hint in Module/DFRN/Notify 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1193958648
 2022-07-25 09:09:22 -04:00
Michael
7834359957 Merge remote-tracking branch 'upstream/develop' into untrusted 2022-07-24 21:58:49 +00:00
Michael
b546173747 IMproved handling of untrusted posts 2022-07-24 21:58:09 +00:00
Hypolite Petovan
a5d679ea95
Merge pull request #11759 from annando/enqueue-posts 
Fetch missing posts via a queue
 2022-07-24 15:38:44 -04:00
Michael
5ab94ea921 Option to store untrusted entries 2022-07-24 19:31:31 +00:00
Michael
51cc1f679f Added trust / isActivityGone 2022-07-24 14:26:06 +00:00
Michael
55b6a89c7c Optimizing 2022-07-24 13:49:57 +00:00
Michael
72bc92db62 Standards 2022-07-24 13:11:52 +00:00
Michael
6abb4d40d6 Handle changed parents 2022-07-24 13:09:35 +00:00
Michael
06280aa5a3 Recursively delete failed worker tasks 2022-07-24 09:26:52 +00:00
Michael
c2b2e8ae9f Standards 2022-07-23 23:15:08 +00:00
Michael
073695b33c Funkwhale context file moved 2022-07-23 23:10:47 +00:00
Roland Häder
86ef7c66d3
Changes: 
- added some missing type-hints, thanks to @MrPetovan
 2022-07-23 23:09:35 +02:00
Roland Häder
ba1c1049d6
Changes: 
- added some type-hints
- added some documentation
- used self::exists() instead of DBA::exists('user', ['uid' => $uid])
 2022-07-23 21:58:00 +02:00
Roland Häder
a2a7d04fa1
Changed double-quotes to single 2022-07-23 21:58:00 +02:00
Hypolite Petovan
edc49ec9b4 Add expected "users" property to NodeInfo usage property for all versions 2022-07-23 13:21:44 -04:00
Michael
6a19639ac2 Standards 2022-07-23 14:10:07 +00:00
Michael
5d6eb4670a We now store the conversation as well 2022-07-23 13:58:14 +00:00
Michael
abf39ff9cf Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-23 12:55:34 +00:00
Michael
8c602071c2 Bookwyrm posts now work 2022-07-23 12:50:15 +00:00
Michael
7eb410bed7 Conversation/context is now stored 2022-07-23 06:52:43 +00:00
Michael
54cebf5a88 Remove test code 2022-07-21 12:42:26 +00:00
Michael
4c5e9f206e Remove ignored undo 2022-07-21 11:47:23 +00:00
Michael
99f7270e18 Improved workerqueue handling 2022-07-21 08:55:45 +00:00
Michael
3966bff8a1 Fix standards 2022-07-21 08:14:47 +00:00
Michael
2e39cebcb9 Process the replies 2022-07-21 07:08:17 +00:00
Michael
4930e77eb3 We are now setting the corresponding worker id 2022-07-21 07:05:38 +00:00
Michael
28fb022425 Reset the recursion depth at a different place 2022-07-21 06:26:31 +00:00
Michael
c775833117 Use deferred tasks 2022-07-21 06:23:55 +00:00
Michael
d4a536137d database.sql updated, standards fixed 2022-07-21 05:42:53 +00:00
Michael
4a1fb1da12 Hourly process pending queue entries 2022-07-21 05:33:01 +00:00
Michael
1d13574225 Fetching of missing posts is reworked 2022-07-21 05:16:14 +00:00
Hypolite Petovan
650e05bcb5
Merge pull request #11758 from Quix0r/fixes/wrong-variable-name 
Fixed variable name + used empty()
 2022-07-20 07:55:38 -04:00
Roland Häder
4b5ae32ec6
Changes: 
- ops, fixed variable name (thanks to @annando)
- also used empty() for an empty array (and false/null)
 2022-07-20 11:54:28 +02:00
Michael Vogel
fc52296a77
Merge branch 'develop' into diaspora 2022-07-20 08:12:30 +02:00
Michael
c20c0a1812 Restore the original functionality 2022-07-20 05:47:30 +00:00
Michael
138a15404f Fix processing of incoming Diaspora messages 2022-07-20 05:38:53 +00:00
Michael
7dcd02938d Remove entries from queue / relay detection 2022-07-20 05:37:40 +00:00
Roland Häder
1fbda27aad
Changes: 
- rewrote a lot local variables to an array and returned it instead of an
  anonymous array
- added more debug/warning logging in case something went wrong -> lesser guessing! ;-)
- changed double-quote to single
 2022-07-20 01:08:15 +02:00
Hypolite Petovan
d69ac56338
Merge pull request #11753 from Quix0r/fixes/missing-contact-array 
Fixed missing $contact array, at least initialize it empty
 2022-07-19 17:58:02 -04:00
Roland Häder
2ef0566ba5
Fixed: 
- "Undefined variable: contact in .../src/Protocol/Diaspora.php on line 4097
Trying to access array offset on value of type null in .../src/Protocol/Diaspora.php on line 4097"
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1189465336
 2022-07-19 23:46:09 +02:00
Roland Häder
3c540517e7
Ops 2022-07-19 23:40:29 +02:00
Roland Häder
cf8698afe6
This is the correct way: 
<?php
if (!isset($foo['account_removed) || $foo['account_removed'])
?>
 2022-07-19 18:08:18 +02:00
Roland Häder
4e5179a7b3
Changes: 
- added some missing type-hints
- fixed some documentation (e.g. empty * line between @param and @return/throws)
 2022-07-19 18:02:38 +02:00
Roland Häder
cb2a052a70
Fixed E_NOTICE, for some strange reason 'account_removed' isn't around? 2022-07-18 23:49:58 +02:00
Michael
a676cf8bed Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-18 14:05:04 +00:00
Michael
ce38e63399 Add and delete entries 2022-07-18 14:03:49 +00:00
Hypolite Petovan
42d411712b
Merge pull request #11742 from annando/server-detection 
Improved server detection
 2022-07-18 08:50:59 -04:00
Hypolite Petovan
2e9d1a9046
Merge pull request #11746 from annando/warn 
Check for GMP module
 2022-07-18 08:49:50 -04:00
Michael
ac47aed1b4 Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-18 05:32:44 +00:00
Michael
af8e059990 Renamed platform definition file 2022-07-18 03:48:19 +00:00
Michael
3bd706fcfc Superfluous todo removed 2022-07-18 03:32:49 +00:00
Michael
2f462ffa16 Store incoming posts in a queue 2022-07-18 03:31:00 +00:00
Hypolite Petovan
121607b8d9
Merge pull request #11740 from annando/json-ld 
Improved JsonLD parsing
 2022-07-17 17:44:53 -04:00
Michael
46fdd9893c Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-17 15:42:09 +00:00
Philipp
6175f9086e
Merge pull request #11747 from annando/fixes 
Emergency fixes to fix a bunch of fatal errors
 2022-07-17 16:34:53 +02:00
Michael
9a4be84853 Only check for string value 2022-07-17 13:13:14 +00:00
Michael
6882e70024 Match the documentation 2022-07-17 13:00:34 +00:00
Michael
2ddf37f32d Emergency fixes to fix a bunch of fatal errors 2022-07-17 11:47:12 +00:00
Michael
23953be7cb Merge remote-tracking branch 'upstream/develop' into warn 2022-07-17 08:51:46 +00:00
Michael
f2a4aecc05 Check for GMP module 2022-07-17 06:34:37 +00:00
Michael
d52f52f45f Somed added documentation 2022-07-17 05:42:44 +00:00
Philipp
1894302011
Merge pull request #11739 from Quix0r/fixes/missing-return-statements 
Fixes/missing return statements
 2022-07-16 16:23:32 +02:00
Michael
0a19759e4f Fix wrong variable type 2022-07-16 13:44:35 +00:00
Michael
8b7cb5d9ef Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-16 12:44:21 +00:00
Roland Häder
cb7f52cc6a
Fixed: 
- $item is the proper array here,
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1186119430
 2022-07-16 12:19:09 +02:00
Michael
8db0e090d7 Merge remote-tracking branch 'upstream/develop' into json-ld 2022-07-16 09:33:24 +00:00
Michael
8cc362fb8b Improved JSonLD parsing 2022-07-16 09:25:12 +00:00
Michael
abe3fd7605 Improved check for invalid certificates 2022-07-16 08:27:38 +00:00
Roland Häder
ce7af4edb8
All these methods need to return an integer (0=Success) or otherwise doExecute() 
will return NULL.
 2022-07-16 08:17:47 +02:00
Michael
896fd3fc91 Use the redirect value 2022-07-14 05:39:25 +00:00
Roland Häder
a38209db1e
Changed: 
- added a final check on $link_item, as it might not be initialized or no
  record was found, thanks to @AlfredSK for reporting this
- see #11632
 2022-07-13 22:05:53 +02:00
Roland Häder
4cb5cadba8
Added returned type-int "int" 2022-07-13 21:10:50 +02:00
Hypolite Petovan
1d94e2866a Enable the view module in maintenance mode 
- This allows to load the default theme CSS
- Theme scripts have been updated to reflect the possibility they will be included in maintenance mode
 2022-07-12 19:48:36 -04:00
Philipp
74c5c66cb5
Add docs 2022-07-13 00:27:39 +02:00
Philipp
d74e57ef2c
include suggested changes 2022-07-13 00:23:12 +02:00
Philipp
a910fd8864
Split DBStructure & View to avoid DB-calls and dependencies for basic operations 
- new "Definition" classes vor DB and Views
- new "Writer" classes to create SQL definitions for DB and Views
- DBStructure & View are responsible to execute DB-querys
 2022-07-12 23:40:31 +02:00
Philipp
8e547510a0
Fix HTTP Client redirect Bug 2022-07-12 20:11:53 +02:00
Hypolite Petovan
74991d1f95 Fix type hint typo in Protocol\Email::messageGetPart 
- Address https://github.com/friendica/friendica/issues/11724
 2022-07-11 23:05:13 -04:00
Michael
dad05f1c76 Only fetch the first word for the platform 2022-07-10 13:52:38 +00:00
Michael
85c7bacb00 Improved server detection 2022-07-10 13:01:47 +00:00
Hypolite Petovan
05ed13a279
Merge pull request #11719 from nupplaphil/feat/type_use 
adhere `use` and type-hints :-)
 2022-07-09 17:42:42 -04:00
Hypolite Petovan
eb8237dd89 Remove unused uid parameter in Item::newURI 2022-07-09 07:39:51 -04:00
Philipp
e8fd495847
adhere use and type-hints :-) 2022-07-09 11:41:36 +02:00
Hank Grabowski
96d3b5bcf1 Merge branch 'develop' into feature-optional-network-group-count 2022-07-08 15:35:26 -04:00
Hank Grabowski
e57e1ba1e5 Make network counts at the group level system level configurable 2022-07-08 15:29:34 -04:00
Philipp
34f2b2f558
Add the right exceptions for BaseUrl::redirect and respect them when catching exceptions at the Trust page 2022-07-07 21:47:39 +02:00
Philipp
e4a83eafb8
Add a lot of log-points 2022-07-07 21:33:41 +02:00
Roland Häder
bf809c9d57
Fixed: 
> TypeError: "Argument 2 passed to Friendica\Protocol\ActivityPub\Transmitter::sendContactReject()
> must be of the type int, string given

I followed here here the documentation, may fix #11708
 2022-07-06 05:43:00 +02:00
Roland Häder
4875524101
Fixed: 
- added exception to prevent `TypeError` because of missing `uri-id` entry
- maybe fixes #11708
 2022-07-05 18:53:51 +02:00
Michael
cc75eb5d18 Improved server detection 2022-07-05 05:04:05 +00:00
Roland Häder
ba33c95e97
Fixes: 
"Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of the type string, null given, called in /var/www/.../htdocs/mod/display.php on line 305"
 2022-07-03 14:45:12 +02:00
Hypolite Petovan
181c142bb4 Remove overly strict type-hint in ActivityPub\Transmission::createCachedActivityFromItem 
- Fix "Return value of Friendica\Protocol\ActivityPub\Transmitter::createCachedActivityFromItem() must be of the type array, bool returned" error
 2022-07-02 22:16:59 -04:00
Hypolite Petovan
e6feed65bf Rename Smilies::pregHeart to better match its purpose 
- Fix "Argument 1 passed to Friendica\Content\Smilies::pregHeart() must be of the type string, array given" error
 2022-07-02 22:14:20 -04:00
Roland Häder
3326c4cb31
Added missing type-hints, #11700 2022-07-01 02:50:34 +02:00
Roland Häder
1ee0e6f711
Changes: 
- no NULL anymore for 2nd parameter OEmbed::toHTML()
- some double-quotes to single
 2022-06-30 15:03:12 +02:00
Roland Häder
6186aac792
Fixed type-hints 2022-06-30 14:58:45 +02:00
Roland Häder
99902bb478
Changes 
- ops, also this needs change since null is no longer wanted
 2022-06-30 14:52:37 +02:00
Roland Häder
5c0e8c62de
Changes 
- renamed Widget::accounttypes() to Widget::accountTypes()
- fixed type-hint the documentation was wrong
 2022-06-30 14:50:28 +02:00
Roland Häder
83cbe586ac
Changes 
- renamed Item::visibleActivity() to Item::isVisibleActivity() as this returns
  a boolean value
- added some type-hints
- added some documentation
 2022-06-30 14:18:13 +02:00
Roland Häder
e33f5612ab
Changes: 
- added some type-hints
- added some documentation
- changed some double-quotes to single
 2022-06-27 15:16:18 +02:00
Roland Häder
a392a22eee
Changes: 
- added some type-hints
- fixed some documentation (void is lately returned, not null)
- added some documentation
 2022-06-27 15:16:17 +02:00
Roland Häder
703ba1439b
Some empty lines 2022-06-27 15:16:17 +02:00
Roland Häder
98bc5216ef
A bit more documentation 2022-06-27 15:16:17 +02:00
Roland Häder
9871e9718e
Changes: 
- added some type-hints
 2022-06-27 15:16:16 +02:00
Roland Häder
6c5acf9ee0
Fixed: 
- "Argument 3 passed to Friendica\Model\Photo::createPhotoForExternalResource()
  must be of the type string, null given
 2022-06-27 15:16:16 +02:00
Roland Häder
ff9707713b
Fixed: 
- Friendica\Content\BoundariesPager::renderFull(int $itemCount) must be
  compatible with Friendica\Content\Pager::renderFull(int $itemCount): string
 2022-06-27 15:16:15 +02:00
Roland Häder
8e19998191
Fixes: 
- more "bool expected but null returned" errors
 2022-06-27 13:49:53 +02:00
Roland Häder
7c049abfda
Fixed: 
- Contact/User::isBlocked() needs to return boolean, but sometimes (strangely)
  a NULL can come from database, so let's cast it

This tries to fix:
TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
 2022-06-27 11:39:18 +02:00
Roland Häder
4bdce6948f
Changed: 
- $publicContact['about'] can be NULL, causing following error:
--------------------------
Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of
the type string, null given, called in /.../src/Object/Api/Twitter/User.php
--------------------------
The "expensive" code there can be avoided being called by an empty string or
NULL to increase performance.
 2022-06-26 23:28:48 +02:00
Philipp
e594656a48
Merge pull request #11684 from MrPetovan/bug/11651-ap-fetch-queue 
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
 2022-06-26 13:36:19 +02:00
Hypolite Petovan
91f5a7cc6b Convert potential spaces in Memcache(d) key names 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166475036
- Add test for space in cache keys
 2022-06-26 07:30:30 -04:00
Philipp
b67e488236
adaptions 2022-06-26 10:13:32 +02:00
Philipp
0223c030a9
Improve 2 factor usage 2022-06-25 23:04:00 +02:00
Philipp
f3de8d7764
improve 2fa token field 2022-06-25 22:48:35 +02:00
Philipp
759d9d9f1a
Add more 2fa properties 2022-06-25 22:48:34 +02:00
Philipp
b86ff1e970
Rename 2FA recovery message 2022-06-25 22:48:34 +02:00
Hypolite Petovan
da32fa8fa6 Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes 
- These classes are used to flatten the recursive missing activity fetch that can hit PHP's maximum function nesting limit
- The original caller is responsible for processing the remaining queue once the original activity has been fetched
 2022-06-25 12:40:54 -04:00
Hypolite Petovan
3c70d592f6
Merge pull request #11689 from Quix0r/rewrites/double-quotes-single 
Changed more double-quotes to single
 2022-06-25 12:02:01 -04:00
Roland Häder
e10dd20036
Made @TODO more clear? 2022-06-25 17:58:27 +02:00
Hypolite Petovan
a7d49877a8 Centralize share tag attribute extraction code in Content\Text\BBCode 2022-06-25 11:46:52 -04:00
Roland Häder
4164cdacf5
Changes: 
- added type-hints
- added documentation
 2022-06-25 16:48:37 +02:00
Roland Häder
804b759df1
Changes: 
- let's get rid of that `Database::exists()` is being misused for checking table existence
- reformatted array
 2022-06-25 16:48:37 +02:00
Roland Häder
f689faca99
Changed double-quotes to single 2022-06-25 16:48:36 +02:00
Roland Häder
88870d18be
Changes: 
- added some type-hints
- added documentation
 2022-06-25 16:48:36 +02:00
Roland Häder
39675fe683
Space for the rescue. ;-) 2022-06-25 16:48:35 +02:00
Roland Häder
b0693c1ad7
Reformatted array 2022-06-25 16:48:35 +02:00
Roland Häder
f12cc9648e
Changes: 
- added some type-hints
- changed some double-quotes to single
 2022-06-25 16:48:35 +02:00
Hypolite Petovan
aa133b5437 Add explicit gserver.site_name string truncate in Model\GServer 
- Avoids "Data too long for column 'site_name'" database errors
 2022-06-25 06:25:48 -04:00
Hypolite Petovan
a2afb101cd Fix off-by-one error in Message ID header count check in Util\Emailer 2022-06-25 05:35:24 -04:00
Hypolite Petovan
c75dbfd3d7 Update default value for LocalRelationship->priority to avoid null values 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166192993
 2022-06-25 05:06:22 -04:00
Hypolite Petovan
636b84b41c Update return value type-hint of GServer::getProtocol 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1164880874
 2022-06-25 05:06:22 -04:00
Hypolite Petovan
c5b46fe748
Merge pull request #11681 from Quix0r/fixes/item-guidfromuri-allow-null 
Allowing Item::getFromUri()'s 2nd parameter a null value
 2022-06-24 10:15:26 -04:00
Roland Häder
82bb36e13d
Changes: 
- Made Item::guidFromUri()'s $host parameter optional (allowing null)
- added some type-hints
- added documentation
- this may fix reported issue in #11630
 2022-06-24 03:17:57 +02:00
Philipp
2dc38e5632
Move documentation :-) 2022-06-23 23:23:36 +02:00
Philipp
5bf5b5e6c9
adaptions :-) 2022-06-23 23:01:09 +02:00
Philipp
12ba37e8d2
add more doc 2022-06-23 22:46:46 +02:00
Philipp
13783089e7
Add copyright 2022-06-23 22:44:17 +02:00
Philipp
d441b90bda
Respect Forwarded-For headers 2022-06-23 22:42:35 +02:00
Roland Häder
657a8a7cb5
Changes: 
- documented null value
- two ' to much!
 2022-06-23 17:30:17 +02:00
Roland Häder
202857ba7d
No need to log $tid here 2022-06-23 17:30:17 +02:00
Roland Häder
fd8f4269ff
Reformatted code 2022-06-23 17:30:17 +02:00
Roland Häder
5699b03e8d
Changes: 
- added some nodes to OpenSearch descriptor
- still no UTF-8 encoding!
- added some type-hints
 2022-06-23 17:30:16 +02:00
Roland Häder
a49fb9cbf9
Changes: 
- added some type-hints
- added documentation
 2022-06-23 17:30:16 +02:00
Roland Häder
84d3eecc33
Changes: 
- added some type-hints
- changed double-quotes to single
 2022-06-23 17:30:15 +02:00
Roland Häder
57e741f2cf
More type-hints added 2022-06-23 17:30:15 +02:00
Roland Häder
182c3db9b8
Changes: 
- added type-hints
- added missing documentation
 2022-06-23 17:30:15 +02:00
Roland Häder
b8353a6eb7
Changes: 
- reformatted some array
- added missing documentation
- added type-hints
- changed double-quotes to single
 2022-06-23 17:30:14 +02:00
Roland Häder
c6c936a80f
Added more type-hints 2022-06-23 17:30:14 +02:00
Roland Häder
3f74a59f73
Added some type-hints 2022-06-23 17:30:14 +02:00
Roland Häder
69a68be800
Added some missing type-hints 2022-06-23 17:30:13 +02:00
Roland Häder
d8ff966d21
Throw IAE again (should never become visible) 2022-06-23 17:30:13 +02:00
Roland Häder
35c78ce14c
Ops, cannot return Thread? 2022-06-23 17:30:12 +02:00
Roland Häder
c2e26b4f49
Changed: 
- Introduced InvalidArgumentException (should never come)
- added type-hints
 2022-06-23 17:30:12 +02:00
Roland Häder
2f3705f471
Continued: 
- renamed varibales to $camelCase
- added type-hints
- updated documentation
 2022-06-23 17:30:11 +02:00
Roland Häder
0ddb315b23
$id in Transmitter::sendContactAccept() is a string, see Introduction class 2022-06-23 16:48:00 +02:00
Hypolite Petovan
bf600905d3
Merge pull request #11676 from Quix0r/fixes/array-element-missing 
Maybe this fixes missing array element
 2022-06-23 09:06:59 -04:00
Roland Häder
636fef26f1
Maybe this fixes missing array element 2022-06-23 07:40:49 +02:00
Roland Häder
589d0360a4
So simple ... Ops! 2022-06-23 04:58:45 +02:00
Roland Häder
69676c9f7b
Changes: 
- enabled sub-directories for compiled/cached files which avoids large+slow
  directory descriptors
- changed some double-quotes to single
 2022-06-23 04:24:55 +02:00
Roland Häder
7eefb9aed8
Changed: 
- empty() is maybe superflous here, still I would prefer a code style that is
  written explicitly and not rely on "magic casting"
 2022-06-22 18:57:01 +02:00
Roland Häder
15d8341d9a
Converted multiple single-comment (//) to multi-line comment block (/* */) 2022-06-22 18:06:35 +02:00
Roland Häder
b996712ef7
Images::getInfoFromURL[Cached]() will both return empty arrays on error and 
that needs to be reflected here, too.
 2022-06-22 17:20:59 +02:00
Roland Häder
eb231bc548
Fixed: ?? didn't work here as bool won't be seen as null 2022-06-22 17:09:53 +02:00
Philipp
78bf7f187c
Merge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode 2022-06-22 16:51:23 +02:00
Roland Häder
d5441da49a
Fixed: 
- TypeError: "Argument 1 passed to Friendica\Util\XML::escape() must be of the
  type string, null given, called in src/Util/XML.php line 171
 2022-06-22 16:20:26 +02:00
Roland Häder
101cd2dd10
Changes: 
- added some documentation
- fixed some documentation
- changed more double-quotes to singl
 2022-06-22 16:14:14 +02:00
Roland Häder
ba45e59313
Changes: 
- added more type-hints
- added missing documentation
- Email::send() now returns what mail() returns (bool)
 2022-06-22 14:36:48 +02:00
Roland Häder
ee8d0ad619
Changes: 
- added more type-hints
- added some documentation
 2022-06-22 14:36:47 +02:00
Roland Häder
feec96cbc4
Return empty array on error (I hope it works this way). 2022-06-22 14:36:47 +02:00
Roland Häder
2dd7d465e8
Changes: 
- added more type-hints
- updated documentation
- changed double-quotes to single
 2022-06-22 14:36:47 +02:00
Roland Häder
74ab7648c6
Changes: 
- addHubLink()'s 2nd parameter is DOMElement
- added more type-hints
- converted double-quotes to single
 2022-06-22 14:36:46 +02:00
Roland Häder
12add2fb64
$data can turn into bool here 2022-06-22 14:36:46 +02:00
Roland Häder
08f55f0358
Ops, forgot to rename these, too. 2022-06-22 14:36:46 +02:00
Roland Häder
abd0d9f3fd
Changes 
- added type-hints
- added some documentation
- added default: block for unknown 'rel' value
- changed return type void to empty array
 2022-06-22 14:36:45 +02:00
Roland Häder
dfa95ea58d
Changes: 
- added type-hints
- added documentation
 2022-06-22 14:36:45 +02:00
Roland Häder
84bfc37bf1
Changes: 
- added more type-hints
- added missing documentation
 2022-06-22 14:36:45 +02:00
Hypolite Petovan
e9f7bb477d Add expected type-hint to BoundariesPager::renderFull 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1162634199
 2022-06-22 07:49:45 -04:00
Hypolite Petovan
7295138f8d Remove type-hint inconsistent with expected return value in Database->getVariable 2022-06-22 07:47:15 -04:00
Hypolite Petovan
d68f307337 Remove email subject encoding from ItemCCEmail constructor 
- It was wrongly re-encoded in Emailer::send
 2022-06-21 21:12:09 -04:00
Roland Häder
2f358607c7
Changes: 
- renamed Logger::getLogger() to getInstance() (@MrPetovan)
 2022-06-22 01:50:10 +02:00
Roland Häder
cdcfb4064b
Changes: 
- added type-hints
- added missing documentation
- renamed Logger::getWorker() to Logger::getLogger() as there is no worker class
  returned but the actual (inner) logger
 2022-06-21 21:22:16 +02:00
Roland Häder
80c8ec17c2
Fixed documentation 2022-06-21 18:43:25 +02:00
Roland Häder
0332a57bfd
Rewrote to suggestions from @MrPetovan (I tried to maintain the old way of 
['scheme' => 'table'] with my version).
 2022-06-21 18:13:01 +02:00
Roland Häder
5fe428d3e4
Fixed: 
- PHPUnit\Framework\Error\Notice:  Undefined index: language in /.../src/Util/EMailer/MailBuilder.php on line 122
 2022-06-21 13:47:40 +02:00
Roland Häder
1080a840f5
Changes: 
- Database->$driver can no longer be NULL, an empty string is fine anyway
 2022-06-21 13:47:39 +02:00
Roland Häder
945cd1a2c2
Fixed: 
- since $table can be now schema.table, this needs being taken care off
- maybe this foreach(explode()) is a bit an overkill as only 1 or 2 entries
  can be found in it
 2022-06-21 13:47:39 +02:00
Roland Häder
0d81a08e3c
WIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed? 2022-06-21 13:47:39 +02:00
Roland Häder
44a9ec9b17
Rewrite: 
- avoid having array|string for $table to have a "string" type-hint for $table
- you now have to do it for yourself by giving 'schema.table' as parameter
 2022-06-21 13:47:38 +02:00
Roland Häder
f62c28008a
Removed comment 2022-06-21 13:47:38 +02:00
Roland Häder
cefffde691
Changes: 
- added type-hints
- added some missing documentation
 2022-06-21 13:47:37 +02:00
Roland Häder
f1867463a0
Changes: 
- added more type-hints
 2022-06-21 13:47:37 +02:00
Roland Häder
77c37ff2db
Fixed: 
- Uncaught Exception TypeError: "Argument 3 passed to
  Friendica\Protocol\DFRN::createActivity() must be of the type string, null
  given, called ..."
 2022-06-21 13:47:37 +02:00
Tobias Diekershoff
4650ff53d9
Merge pull request #11662 from MrPetovan/bug/11661-splitattachment-null 
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
 2022-06-21 06:48:52 +02:00
Hypolite Petovan
d2ca812647
Merge pull request #11660 from Quix0r/fixes/more-type-hints-003 
More type-hints - Batch 003
 2022-06-20 21:53:17 -04:00
Roland Häder
3e522ed512
Fixed: 
- prevent NULL from being handled over to XML::escape()
- still I wonder that an object can be? It is a string-only accepting method
 2022-06-21 01:42:37 +02:00
Roland Häder
95f9eb34ac
Fixed indenting 2022-06-21 01:29:33 +02:00
Roland Häder
b6fa022a73
Changes: 
- added type-hints
- added some documentation
- marked some generic methods to be moved to Util\Strings class instead
 2022-06-20 23:50:24 +02:00
Roland Häder
fbae0b8bcf
Changes: 
- renamed ItemArrayFromMail() to getItemArrayFromMail() to follow naming-convetion
- added missing type-hints
- added missing documentation
 2022-06-20 21:22:46 +02:00
Roland Häder
ea22e88896
Added documentation 2022-06-20 21:02:34 +02:00
Roland Häder
752953e472
Changes: 
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean
 2022-06-20 21:00:19 +02:00
Hypolite Petovan
88eacbf66e Ensure parameter 4 of Post\Media::splitAttachment is a boolean value 2022-06-20 14:34:02 -04:00
Roland Häder
0c12e947dd
Changes: 
- null was 2nd argument's value before, an empty string is basically the same here
 2022-06-20 20:01:59 +02:00
Roland Häder
feb87e8dc3
Changes: 
- let's start throwing exceptions on e.g. invalid arguments instead of returning
  FALSE
 2022-06-20 19:09:08 +02:00
Roland Häder
4fb03cf163
Changes: 
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints
 2022-06-20 19:05:02 +02:00
Roland Häder
e96a548286
Changes: 
- dumped default value for $input
- added unknown 'platform' which prevents an "Undefined index: platform in
  /var/www/.../src/Model/GServer.php on line 940" error
 2022-06-20 18:56:22 +02:00
Roland Häder
6743de63f5
Changed: 
- DBA::exists() should only be used for checking if records exists.
- if you want to check if a table exists, please ALWAYS use
  DBStructure::existsTable() instead
 2022-06-20 08:20:07 +02:00
Roland Häder
9c80dd35e5
Both declarations must be the same 2022-06-20 08:07:12 +02:00
Tobias Diekershoff
13a5a30b28
Merge pull request #11659 from MrPetovan/bug/11511-relocate-quote-identifier 
Add missing identifier quote in Database->replaceInTableFields
 2022-06-20 06:26:33 +02:00
Roland Häder
cd3b01fd82
Changed: 
- cannot have type-hints :-(
 2022-06-20 03:48:34 +02:00
Roland Häder
94a594eeb2
Ops, wrong type-hint 2022-06-20 03:36:36 +02:00
Roland Häder
ec96f2252e
Changes: 
- added type-hints
- added some missing documentation
 2022-06-20 03:10:23 +02:00
Roland Häder
14bf72e4fe
Changes: 
- added some documentation
- added type-hints
 2022-06-20 02:48:05 +02:00
Roland Häder
97904ea7dd
Changes: 
- added type-hints
- added missing documentation
 2022-06-20 02:48:02 +02:00
Roland Häder
a0c8fc6d6e
Changes: 
- added more type-hints
 2022-06-20 02:48:02 +02:00
Hypolite Petovan
d48e40c1bf Add missing identifier quote in Database->replaceInTableFields 
- This caused hyphenated table names to fail the replace query
 2022-06-19 20:06:12 -04:00
Roland Häder
d276f2c62b
Changes: 
- added type-hints
- changed some double-quotes to single
 2022-06-20 01:00:29 +02:00
Hypolite Petovan
622b978a84
Merge pull request #11655 from Quix0r/fixes/more-type-hints-002 
More type-hints and documentation added
 2022-06-19 09:27:29 -04:00
Roland Häder
ed3c53a5f8
Ops, not here wanted. :-( 2022-06-19 14:06:32 +02:00
Roland Häder
bff57bb030
Changes: 
- added type-hints
- added returned type-hints in interface (I checked all)
 2022-06-19 14:00:31 +02:00
Roland Häder
c0d7f8944d
Some calls saved 2022-06-19 11:26:10 +02:00
Roland Häder
60f8c2d795
Changes: 
- added missing type-hints
- added documentation for a method
 2022-06-19 10:50:09 +02:00
Roland Häder
5792a01a01
Contact::getAccountType()'s parameter is never a string, ops 2022-06-19 09:36:24 +02:00
Roland Häder
f3599fa3e9
Changes: 
- dbstructure(null) is no longer possible, an empty string does it
 2022-06-19 09:13:10 +02:00
Tobias Diekershoff
a063a89c57
Accesskey was used twice 
The accesskey on the User Settings pages for the _account settings_ and the _two factor authentication_ were the same. This PR is assinging a new one to the 2FA.
 2022-06-19 06:30:00 +02:00
Roland Häder
b6bfe72083
Wrong returned type, has to be array 2022-06-19 02:40:07 +02:00
Roland Häder
7bb0cb5323
Changes: 
- added more type-hints
- DBStructure::existsTable() does no longer need array support for table name
  because this is no longer used (good work!)
 2022-06-19 02:11:12 +02:00
Roland Häder
2c5685c89c
Changes: 
- changed to proper "use Foo\Bar;"
- added doctag
- added return type as this is fixed
 2022-06-19 01:11:30 +02:00
Roland Häder
d7d2ad77ff
Ops, also this! 2022-06-18 23:31:52 +02:00
Roland Häder
39f2d197ea
Changed to suggestings (back to original) + fixed typo in scalar type 2022-06-18 23:30:37 +02:00
Roland Häder
6f1d52cf71
Changed back to suggestions by @MrPetovan 2022-06-18 23:24:08 +02:00
Roland Häder
fa14a02a19
Changes: 
- added type-hints
- added documentation
- changed double-quotes to single
 2022-06-18 23:12:52 +02:00
Roland Häder
f3b57008b5
Proper type is string 2022-06-18 18:41:16 +02:00
Roland Häder
41f34c4261
Maybe fix for: 
"Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"
 2022-06-18 18:30:50 +02:00
Roland Häder
9691bb06fb
Changes: 
- added more type-hints
- added missing documentation
 2022-06-18 18:21:29 +02:00
Roland Häder
94eb426151
Nodeinfo::getOrganization() doesn't need configuration object being inserted 
when you have DI::config() around.
 2022-06-18 17:56:33 +02:00
Roland Häder
c29c49797a
Added missing type-hints 2022-06-18 17:52:46 +02:00
Roland Häder
4e437190c5
Renamed variable, no need for "orig_" prefix 2022-06-18 17:50:11 +02:00
Roland Häder
a1a81cdc6b
Continued: 
- changed some double-quotes to single
- added missing type-hints
- added missing documentation
- fixed indenting a bit
 2022-06-18 17:46:34 +02:00
Roland Häder
8fc710f82a
Continued: 
- added more type-hints
- added some missing documentation
- Return the result from DBA::delete() to let other methods know about it
 2022-06-18 17:22:50 +02:00
Roland Häder
8ba3f13fae
Changes: 
- added more type-hints
- added missing documentation
 2022-06-18 17:09:46 +02:00
Roland Häder
7ec07178c8
Changes: 
- added missing type-hints
- added missing documentation
 2022-06-18 16:59:23 +02:00
Roland Häder
8756d92316
Continued: 
- prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned"
 2022-06-18 15:57:31 +02:00
Roland Häder
bd3a7b9877
Ops, needs to be a variable: 
Error: "Cannot pass parameter 2 by reference" at /var/www/.../src/Module/DFRN/Poll.php line 36
 2022-06-18 09:59:19 +02:00
Roland Häder
69cda4f760
Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be 
of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php
on line 37"
 2022-06-18 05:42:02 +02:00
Roland Häder
7cbb818c93
Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() 
is the same and being handled over.
 2022-06-18 05:19:24 +02:00
Roland Häder
89302d0843
Some outside code relies on returned "false" 2022-06-18 05:06:18 +02:00
Roland Häder
aaf5c323b6
Fixed indenting 2022-06-18 05:04:14 +02:00
Roland Häder
adb4aea6ad
Changes: 
- added some type-hints
- replaced most double-quotes (only Diaspora.php, later more) with single
- added some documentation
- normalized indenting in Diaspora.php (I hope I got all?)
 2022-06-18 05:03:10 +02:00
Roland Häder
88c40f3336 Ops, wrong type again 2022-06-17 17:18:31 +02:00
Roland Häder
a770634b95 Ops, wrong type 2022-06-17 17:18:31 +02:00
Roland Häder
36d56a4041 Continued: 
- changed back to 'return false;' as other methods heavily rely on false instead
  of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
  code more crazier than it already is (see APContact::getByURL())
 2022-06-17 17:18:31 +02:00
Roland Häder
c467bff79f Some more type-hints added 2022-06-17 17:18:31 +02:00
Roland Häder
4f3321cc9f Nore fixes 2022-06-17 17:18:31 +02:00
Roland Häder
10bb7d5625 Possible fix for 
Uncaught Exception TypeError: "Return value of
Friendica\Model\APContact::getByURL() must be of the type array, bool returned"
 2022-06-17 17:18:31 +02:00
Roland Häder
fdd237a090 Fix for "Uncaught Exception TypeError: "Argument 1 passed to 
Friendica\Model\APContact::unarchiveInbox() must be of the type string, null
given" error message
 2022-06-17 17:18:31 +02:00
Roland Häder
605e7d55b3 Continued: 
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
  changed it to -1 to have a proper type-hint
 2022-06-17 17:18:31 +02:00
Roland Häder
0c9aff8a09 Also need to declare $profile or otherwise an invocation of 
Receiver::getReceiverForActor() will fail.
 2022-06-17 17:18:31 +02:00
Roland Häder
af8cd5ca86 Worker::getWaitingJobForPID() can also return FALSE on failure ... :-( 2022-06-17 17:18:31 +02:00