Commit graph

660 commits

Author SHA1 Message Date
Tobias Diekershoff
97a6a742e7
Merge pull request #9922 from MrPetovan/bug/9666-video-bbcode-link
Try OEmbed first for [audio] and [video] tags
2021-02-10 11:33:42 +01:00
Hypolite Petovan
4a57ed1a31 Move HTTPS exception for YouTube and Vimeo to OEmbed::fetchUrl
- Both Youtube and Vimeo output OEmbed endpoint URL with HTTP but their OEmbed endpoint is only accessible by HTTPS ¯\_(ツ)_/¯
2021-02-09 23:25:18 -05:00
Hypolite Petovan
0927bb5f2c Harden OEmbed link discovery
- Check OEmbed call return code before storing response
- Stop at first successful OEmbed response
2021-02-09 23:25:18 -05:00
Hypolite Petovan
7653bc00df Try OEmbed first for [audio] and [video] tags 2021-02-09 23:20:28 -05:00
Michael
c3398511b4 New table "post-content" 2021-01-30 22:03:53 +00:00
Hypolite Petovan
e2c38f1347 Prevent hashtag parsing and replacement in image alternative text 2021-01-22 17:45:28 -05:00
Hypolite Petovan
215c6ecc14
Merge pull request #9843 from annando/no-filetag
Legacy file/category storage is removed
2021-01-21 18:50:57 -05:00
Michael
d2ea3eabfb Replace legacy file/category handling 2021-01-21 07:16:41 +00:00
Hypolite Petovan
35213630e8 Remove strictly numeric tags exception
- It prevented to use year number hashtags for no clear benefit
2021-01-20 08:10:20 -05:00
Michael
9ccfa37d3c Fixes 9814 - again 2021-01-18 20:19:13 +00:00
Michael
4157db5473 "item" is replaced by "post-view" / postupdate check added 2021-01-17 20:32:13 +00:00
Hypolite Petovan
fff565a80b Prevent alt text of emoji image tags to be converted to smilies in BBCode::convert 2020-12-30 22:23:58 -05:00
Hypolite Petovan
4b1180ec8b Restore autolink in share block content in BBCode::convertShare 2020-12-21 22:46:29 -05:00
Michael
3ec1270fde Quit when message is empty 2020-12-19 18:17:32 +00:00
Hypolite Petovan
bcd61c8372
Merge branch '2020.12-rc' into bug/9656-purify-video-embed 2020-12-18 14:47:24 -05:00
Hypolite Petovan
95f099d26c Restore Mastodon emoji span classes
- Fix typo in replacement of [class] tag
2020-12-18 11:08:03 -05:00
Hypolite Petovan
20d9dcf7ac Bump BBCode version to 2020-12-18 2020-12-18 10:32:36 -05:00
Hypolite Petovan
0781f28ca6 Allow support for allowlisted iframe sources in Content\text\BBCode::convert
- Support Youtube, Vimeo and unused local embeds
2020-12-18 10:32:36 -05:00
Hypolite Petovan
ec0c9dcdb1 Remove support for [iframe] BBCode
- It was a huge gaping security hole, and now HTML Purify will remove the src attribute of all non-allowed sources anyway.
2020-12-18 10:32:36 -05:00
Hypolite Petovan
e6270bc46d Enable back references in reg exp in BBCode::convert
- Bump BBCode version
2020-12-06 08:57:06 -05:00
Hypolite Petovan
f141f5acf4 Prevents share block new lines from being converted to HTML <br> tags
- Address https://github.com/friendica/friendica/pull/9621#issuecomment-739333767
2020-12-05 19:55:16 -05:00
Hypolite Petovan
e712706302 Add BBCode versioning
- This will trigger the re-conversion of displayed items on version update
2020-12-04 07:29:49 -05:00
Hypolite Petovan
a0f6d678c4 Add HTML Purify to BBCode::convert
- Replace previous HTML cleanup using DOMDocument
- Remove obsolete HTML::sanitizeCSS method
- Use Strings::autoLinkRegEx for PageInfo::getRelevantUrlFromBody
- Update previous tests expectations
- Add new specific XSS tests
2020-12-04 07:29:48 -05:00
Michael
20649dd00e Replaced tab with space 2020-11-30 20:09:52 +00:00
Michael
1e09eab921 Another place found where "show less" had been "show more" 2020-11-30 19:52:57 +00:00
Michael
d4d55a5865 Issue 8605: "show less" now displays "show less" 2020-11-30 19:30:57 +00:00
Michael
303aaa00ca Mode switch for insert 2020-11-19 19:34:48 +00:00
Hypolite Petovan
dbb33399bc Prevent image descriptions from being replaced by local smilies
- AP-received emojis have their code in the image description
2020-11-15 00:12:26 -05:00
Hypolite Petovan
edd439cfab Simplify code in Content\Text\BBCode::convert
- Use performWithEscapedTags instead of custom solution
2020-11-08 23:25:46 -05:00
Michael
498dda7999 Fix parser issues when a video is linked without a matching extension 2020-11-08 09:24:01 +00:00
Michael
46bd1704df Fix notice "Undefined index: network" and warning "strpos(): Empty needle" 2020-10-29 13:28:27 +00:00
Michael
a012234d82 Publish the provider fields in the API 2020-10-26 19:40:09 +00:00
Philipp
a6fc9cd32e
Remove $binary flag for HTTPRequest::get(), HTTPRequest::fetch(), HTTPRequest::fetchAll() (deprecated since PHP 5.1.3) 2020-10-18 20:56:31 +02:00
Hypolite Petovan
5abe069cba Remove Widget::accounts in favor of Widget::accounttypes 2020-10-13 22:30:40 -04:00
Hypolite Petovan
4d15cc01e2 Move network module to src/
- Update ForumManager to use a base URL
- Split network module into Conversation\Network and Search\Filed modules
- Implement boundaries pager in network module
- Allow no selection in filter widgets
2020-10-13 07:52:13 -04:00
Hypolite Petovan
4427876c05 Implement correct behavior for min_id in boundary pagination
- The previous behavior of since_id systematically showed the most recent results
2020-10-13 00:11:39 -04:00
Philipp
0449077126
Revert "Fix IHTTPResult::getHeader() - Now returns a string array, like expected - Fix usages - Fix dataset"
This reverts commit 80bd0a4d
2020-10-11 23:25:40 +02:00
Philipp
80bd0a4d5a
Fix IHTTPResult::getHeader()
- Now returns a string array, like expected
- Fix usages
- Fix dataset
2020-10-10 23:11:30 +02:00
Michael
35d8b078ce Renamed "Accounts" to "Account Types" 2020-10-10 07:14:18 +00:00
Michael
4b9cbac23e Filter for account type for contacts 2020-10-09 19:08:50 +00:00
Michael
00974324fe Don't show failed contacts 2020-10-07 20:06:15 +00:00
Hypolite Petovan
9954bf8adf
Merge pull request #9365 from annando/better-plaintext
Improve plaintext generation for language detection
2020-10-05 23:11:42 -04:00
Michael Vogel
20652870b6
Update src/Content/Text/BBCode.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-06 04:55:28 +02:00
Michael
6c3ffb75a6 Issue 9366: filter account types on the network page 2020-10-05 16:48:28 +00:00
Michael Vogel
397f239abb
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-05 17:40:06 +02:00
Michael
16224a7001 Improve plaintext generation for language detection 2020-10-05 12:50:18 +00:00
Michael
fe825b3634 Fix notice 2020-09-20 17:47:44 +00:00
Michael
a42217eae4 Fixes notice "Undefined index: text" 2020-09-20 07:45:19 +00:00
Michael
1a0db28d2e Only display redundant preview data with preview picture 2020-09-19 19:02:40 +00:00
Hypolite Petovan
043e04f484 Remove confirm template obsolete uses (except for contacts)
- Remove obsolete explode_querystring() function
- Remove $extra_inputs template variable
2020-09-12 09:09:15 -04:00
Michael
38ed5c943d Avoid probing non existing profiles 2020-08-19 05:24:53 +00:00
Michael
d9fc0ae0ea Using a constant value for the default avatar 2020-08-18 20:30:24 +00:00
Hypolite Petovan
c26b72a426 Rework commonFriendsVisitor widget
- Use new Contact\Relation method to fetch common contacts
- Replace reference to /common by /{nickname}/contacts/common
2020-08-05 00:19:48 -04:00
Michael
0c73531da1 Poco and gcontact (mostly) removed 2020-08-01 16:15:18 +00:00
Michael
71b6226909 Some more avatar function replacements 2020-07-28 19:30:55 +00:00
Hypolite Petovan
afb882048e Generate callstack value from inside Profiler::saveTimestamp
- Save a massive amount of time computing callstacks when profiling is disabled
2020-07-27 02:33:05 -04:00
nupplaPhil
657d08f09f Rename "fetchUrl" and "fetchUrlFull" to "fetch" and "fetchFull" 2020-07-21 03:15:53 -04:00
nupplaPhil
7029012f27 Rename "HTTPRequest::curl()" to HTTPRequest::get() 2020-07-21 03:14:01 -04:00
nupplaPhil
57587efe58 Move "getUserAgent()" to "HTTPRequest" class 2020-07-21 03:04:58 -04:00
nupplaPhil
1aa07f87a4 Make "HTTPRequest::fetchUrl" dynamic 2020-07-21 03:04:58 -04:00
nupplaPhil
5344efef71 Move post/curl/fetchUrl/fetchUrlFull to own class "Network\HTTPRequest" 2020-07-21 02:56:10 -04:00
Michael Vogel
ea8965759e
Merge pull request #8893 from MrPetovan/task/8797-strip-label-shortened-url
Add shortened URL link label stripping to PageInfo::stripTrailingUrlFromBody
2020-07-18 18:06:01 +02:00
Hypolite Petovan
972b65ba33 Add intermediate method PageInfo::appendDataToBody
- It handles the already existing attachment in the body case
2020-07-17 19:38:28 -04:00
Hypolite Petovan
25b3fa83fc Rename PageInfo::appendToBody to searchAndAppendToBody 2020-07-17 19:15:43 -04:00
Hypolite Petovan
8de66c0274 Add shortened URL link label stripping to PageInfo::stripTrailingUrlFromBody
- Add test cases for shortened URL link labels
2020-07-17 17:16:22 -04:00
Michael
b0086a49e2 in "getidforurl" "no update" is now "update" 2020-07-15 21:08:42 +00:00
Hypolite Petovan
631095eefd
Merge pull request #8883 from annando/replace-getdetails
Replaced "getDetailsByURL" with "getByURL/getByURLForUser"
2020-07-15 13:49:27 -04:00
Michael
e374aecc46 Changed parameter order for "getbyURLForUser" 2020-07-15 17:22:12 +00:00
Michael
fc0312451d Changed parameter order for getByURL 2020-07-15 17:06:48 +00:00
Michael
d9c6a46ffe Replaced "getDetailsByURL" with "getByURL/getByURLForUser" 2020-07-15 04:42:04 +00:00
Hypolite Petovan
0816e0330f Move export public calendar additional feature to core 2020-07-12 23:08:38 -04:00
Hypolite Petovan
d11125d234 Move network sidebar widget additional features to core
- Make Archives filter core
- Make Protocol filter core
2020-07-12 22:52:51 -04:00
Hypolite Petovan
6ad8bf0cca Remove network tabs additional features
- Remove New network tab
- Remove Bookmark network tab
2020-07-12 22:41:12 -04:00
Hypolite Petovan
b4eea625b6 Add another check for $a->user in Content\Nav
- Fix punctuation typo in logging call
2020-07-11 09:17:23 -04:00
Michael Vogel
af6f6d4957 Fix speed issues with the network page 2020-07-10 00:22:26 +02:00
Hypolite Petovan
68ecbcea34 Add logging to unexpected case in Content\Nav
- Address part of https://github.com/friendica/friendica/issues/8475#issuecomment-653912096
2020-07-08 09:56:40 -04:00
Michael
52bb1ff0f1 Some more replaced logger 2020-06-28 17:35:56 +00:00
Michael Vogel
f611c99ad7 Improve render speed by not probing for unknown contacts 2020-06-28 15:57:33 +02:00
Michael Vogel
713eda1dfe Empty lines removed 2020-06-28 08:23:53 +02:00
Michael Vogel
2756c3249b Fix notice "Undefined index: keywords" 2020-06-28 08:18:35 +02:00
Michael Vogel
7fd2c00171
Merge pull request #8792 from MrPetovan/task/share-block-guid
[frio] Add local post link to share block when guid attribute is present
2020-06-23 21:26:07 +02:00
Hypolite Petovan
faeffff8a3 [pre] blocks now preserve spaces
- Added test case
- Added English documentation
2020-06-23 07:53:18 -04:00
Hypolite Petovan
251a3791dd Keep spaces after non-tags in Content\BBCode::convert
- Added test case
2020-06-23 07:52:38 -04:00
Hypolite Petovan
d2aa68106b Make guid attribute available to convertShare callback 2020-06-21 09:45:00 -04:00
Hypolite Petovan
912ff069c0 Update getShareOpeningTag::getShareOpeningTag method signature
- Optional parameter $guid is now at the end
- Always provided parameter $posted is now mandatory
2020-06-21 09:42:37 -04:00
Hypolite Petovan
cd74fb8609 Add new Content\BBCode::getShareOpeningTag 2020-06-18 08:53:30 -04:00
Hypolite Petovan
f3323aff5e Deprecate page_info functions to new PageInfo class
- Add tests for parts not using remote requests
- Add scheme requirement for page info URLs
- Add policy to keep label from stripped Page Info links
2020-06-17 13:24:44 -04:00
Hypolite Petovan
f9ecbbd743 Exclude [img] tags from tag replacement
- It broke image captions by inserting an HTML link inside an HTML attribute
2020-06-16 16:34:16 -04:00
Michael Vogel
9b85d0b16e
Merge pull request #8740 from MrPetovan/task/frio-improve-share-display
[frio] Improve share blocks display
2020-06-11 07:32:29 +02:00
Hypolite Petovan
db3f90ec01 Replace mention to $_SERVER with parameter in Content\Markdown::convert
- $_SERVER key isn't always available, no idea what it was used for exactly
2020-06-10 11:40:18 -04:00
Hypolite Petovan
9b2d758c1a Add no-parsing block escaping in BBCode::setMentions 2020-06-10 10:16:07 -04:00
Hypolite Petovan
eaa7740da6 Remove superfluous code
- Remove explicit default parameter value in BBCode::convertShareCallback
- Remove Probe::$baseurl reset since the twitter probe sets the `baseurl` property
- Remove baseurl guessing in Probe::detect
2020-06-10 10:15:54 -04:00
Hypolite Petovan
a5f0225d60 Add mention support to shared content 2020-06-10 10:15:54 -04:00
Hypolite Petovan
e7f50a05d1 Move handle_tag() to Content\Item::replaceTag 2020-06-10 10:13:32 -04:00
Hypolite Petovan
89b3ae2657 Add null/empty string parameter value case in BBCode::convert
- Remove obsolete coalesce operator uses
2020-06-08 19:15:08 -04:00
Hypolite Petovan
472018191b Add tag escaping to BBCode::setTags 2020-06-08 18:40:20 -04:00
Hypolite Petovan
0bc7b89530 Replace existing block escaping by performWitEscaped* calls 2020-06-08 18:40:20 -04:00
Hypolite Petovan
348b71d0b0 Add new Strings::performWithEscapedBlocks methods
- Add new BBCode::performWithEscapedTags method
- Add tests
2020-06-08 18:40:20 -04:00
Hypolite Petovan
8eeb7807d3 Replace remaining instances with "allowlist", "denylist" and "blocklist" 2020-06-07 11:24:56 -04:00
Michael
d68372c872 Issue 8732: Fix fetch aved searches 2020-06-06 18:45:16 +00:00