Commit graph

10169 commits

Author SHA1 Message Date
Hypolite Petovan
14ebc4a821 Ensure $owner is set in ActivityPub\Transmitter::sendContactReject
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1289535020
2022-11-23 11:05:36 -05:00
Hypolite Petovan
7c6d54c989 Ensure $attachment has a width and a height when it's an image in Mastodon\Attachment
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1323274513
2022-11-23 11:00:15 -05:00
Hypolite Petovan
a5af1408d6 Ward against the possible case that $actor is empty in ActivityPub\Processor::createItem
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1323273452
2022-11-23 10:47:51 -05:00
Hypolite Petovan
a8eabae12f Ensure $owner is set in ActivityPub\Transmitter::sendActivity
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1322704863
2022-11-23 10:40:41 -05:00
Hypolite Petovan
8e67d28997 Return early if user contact doesn't exist in Mastodon\Notification::getType
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1321804594
2022-11-23 10:35:49 -05:00
Michael
7b563fd307 Tempory fix removed 2022-11-23 14:17:39 +00:00
Michael
352b7a0ac3 "MIRROR_FORWARDED" is removed 2022-11-23 14:00:34 +00:00
Michael
25992b063a Merge remote-tracking branch 'upstream/develop' into no-api-post 2022-11-23 06:28:24 +00:00
Michael
f600f68907 No more automated posts via mod/item.php 2022-11-23 06:27:40 +00:00
Hank Grabowski
733509561a Update Notify->iid to itemId for notification endpoint 2022-11-21 23:40:15 -05:00
Hank Grabowski
548fd3201d The two endpoints for unfavoriting/liking (and related things) was failing because it wasn't using the correct uuid in item.php in processing the action. 2022-11-21 16:49:20 -05:00
Hypolite Petovan
77e87da441 Create /profile/{nickname}/photos route
- Create new Profile\Photos\Index module class
- Update most references of the legacy /photos/{nickname} route
2022-11-20 17:15:07 -05:00
Hypolite Petovan
6dcc964ed8 Fix string interpolation in Model\Photo::upload 2022-11-20 17:07:08 -05:00
Hypolite Petovan
d4bb5223a4 Use guid from shared post in Protocol\Diaspora::getReshareDetails
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1321194769
2022-11-20 13:01:37 -05:00
Tobias Diekershoff
eec48057dc
Merge pull request #12221 from MrPetovan/bug/warnings
Fix various PHP 8 deprecations
2022-11-20 08:21:06 +01:00
Tobias Diekershoff
70ea419fcc
Merge pull request #12218 from MrPetovan/bug/frion-search-items
[frio] Improve search list display for web and mobile
2022-11-20 08:14:42 +01:00
Tobias Diekershoff
d1a85f1fa4
Merge pull request #12222 from MrPetovan/bug/12219-hovercard-stay-local
Fix support for `/contact/123456/conversations` URLs in Module\Contact\Hovercard
2022-11-20 08:10:42 +01:00
Hypolite Petovan
5f074bc4e7 Add support for Mastodon /authorize_interaction route
- It is used by Fedifind to follow people who set their Webfinger address in their Twitter bio
2022-11-19 19:55:01 -05:00
Hypolite Petovan
83c04ac433 Fix support for /contact/123456/conversations URLs in Module\Contact\Hovercard 2022-11-19 19:41:45 -05:00
Hypolite Petovan
99df11e99b Fix PHP 8 inheritance deprecation warnings in App\PAge and ParsedLogIterator 2022-11-19 19:30:48 -05:00
Hypolite Petovan
6f93ee7e49 Fix various PHP 8 deprecations 2022-11-19 19:15:47 -05:00
Hypolite Petovan
a147038c2e Ensure IEMail::getMessage returns a string 2022-11-19 19:15:47 -05:00
Hypolite Petovan
2a4985cd46 Fix database connection with sockets
- Reformat Database\Database.php file
- Reformat and fix spelling in static/defaults.config.php file
2022-11-19 19:15:43 -05:00
Hypolite Petovan
24804eb042 Hide non-functional mass deletion feature in search view 2022-11-19 17:16:01 -05:00
Philipp
5a2a8db21f
Merge pull request #12208 from MrPetovan/bug/12059-display-not-found
Improve error message when conversation isn't available in Module\Item\Display
2022-11-19 19:59:40 +01:00
Philipp
643d18b108
Merge pull request #12215 from MrPetovan/bug/hovercard-url
Fix support for `/contact/redir` URLs in Module\Contact\Hovercard
2022-11-19 19:53:38 +01:00
Hypolite Petovan
a91944af24 Fix constructor compatibility with BaseSettings parent class
- Address https://paste.metaversum.wtf/?fc75de3f8eba6e7d#813SFjJwWWaJERQyrEpGAVnL33xZpTRV4MZeKmzsAvK8
2022-11-19 13:33:05 -05:00
Hypolite Petovan
525eab395c Improve error message when conversation isn't available in Module\Item\Display
- Retrieve the parent post no matter what. Previously it was depending on the user's settings, which gave unpredictable behavior if the parent post wasn't retrieved for whatever reason.
- List possible reasons the conversation isn't showing up based on the condition in Model\Post::selectViewForUser
- Allow HTML in exception messages
2022-11-19 12:29:08 -05:00
Hypolite Petovan
de5097b772 Fix support for /contact/redir URLs in Module\Contact\Hovercard
- The feature was broken after the Redir route was moved
2022-11-19 12:28:54 -05:00
Thorsten
90567772bd Prevent division by zero. 2022-11-19 18:16:41 +01:00
Hypolite Petovan
3d5b81e4ef
Merge pull request #12213 from Schnoop/bugfix/NodeInfo
Fix that users property should be an object instead of array.
2022-11-19 11:59:33 -05:00
Thorsten
877369d964 Fix that user property should be an object instead of array. 2022-11-19 16:48:07 +01:00
Hypolite Petovan
6460218c0e Ensure register records aren't created with uid = 0
- uid = 0 matches system account and public contact records, giving unexpected display in pending user list. More importantly, the originally created user can't be approved since its user id is lost.
2022-11-18 16:04:02 -05:00
Thorsten
2edbd1a3e2 Reverted some changes that won't work with PHP7.3 2022-11-18 19:41:56 +01:00
Thorsten
7a39be8270 DDEV and some PHP8.1 fixes. 2022-11-18 12:03:55 +01:00
Thorsten
8a71bdc1a0 Add meta tag to attachment to show images in mastodon app. 2022-11-18 09:38:02 +01:00
Hypolite Petovan
e354f48765
Merge pull request #12200 from annando/ignore-view
"View" activities are now ignored
2022-11-17 15:28:34 -05:00
Michael
cdbfa34066 "View" activities are now ignored 2022-11-17 20:01:32 +00:00
Hypolite Petovan
293f147867
Merge pull request #12186 from nupplaphil/mod/editpost
Move mod/editpost.php to src\Module\Post\Edit
2022-11-16 16:14:07 -05:00
Philipp
81b21c4131
Revert "Remove geotag"
This reverts commit 5dc9319b
2022-11-16 21:20:24 +01:00
Philipp
9621279572
Make PHP-CS happy ... 2022-11-16 10:49:12 +01:00
Philipp
12fb897f54
Adhere PHP-CS 2022-11-16 08:56:37 +01:00
Philipp
e7fd4a4cd1
Remove legacy comments 2022-11-16 08:56:19 +01:00
Philipp
5dc9319bb2
Remove geotag 2022-11-16 08:50:57 +01:00
Philipp
db7af4c45b
Remove jotnets 2022-11-16 08:49:48 +01:00
Michael
ec92f7a81c Fix memory issue on displaying conversations 2022-11-16 04:57:46 +00:00
Philipp
09e01b9356
Replace $_SESSION 2022-11-15 22:52:23 +01:00
Philipp
00883c9dcb
Move mod/editpost.php to src\Module\Post\Edit 2022-11-15 22:32:46 +01:00
Philipp
53f3454874
Merge pull request #12184 from annando/duplicated-media
This fixes duplicated media in quoted posts
2022-11-15 21:17:19 +01:00
Hypolite Petovan
403b025b5d
Merge pull request #12179 from nupplaphil/mod/display
Move mod/(update_)display.php to src\Module
2022-11-15 15:14:17 -05:00
Michael
348156dbcf Simplify the check 2022-11-15 19:55:03 +00:00
Michael
eca52627c1 This fixes duplicated media in quoted posts 2022-11-15 19:48:43 +00:00
Philipp
59c97234f8
PHP-CS and license .. 2022-11-15 20:15:25 +01:00
Philipp
584e7a7e6d
Remove trailing slash in update_ calls 2022-11-15 20:11:38 +01:00
Philipp
eff7740a67
Address feedback 2022-11-15 19:53:53 +01:00
Hypolite Petovan
3a7586e3f7 Fix wrong user table field name in Repository\Notify
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314954594
2022-11-15 09:03:43 -05:00
Philipp
ba0b83b0b0
Make PHP-CS happy 2022-11-15 01:10:49 +01:00
Philipp
3259bd17dc
Move mod/(update_)display.php to src\Module 2022-11-15 00:57:47 +01:00
Philipp
5c05a3b0f6
Move mod/display.php "feed-item" to a src\Module\Item\Feed.php 2022-11-15 00:52:58 +01:00
Hypolite Petovan
fe547b7851 Centralize config.admin_email management in Model\User 2022-11-14 17:02:42 -05:00
Hypolite Petovan
cbe8d463b1 Don't create notify for deleted user accounts 2022-11-14 17:02:42 -05:00
Hypolite Petovan
48b1dceb19 Don't send item notifications to deleted user accounts 2022-11-14 17:02:42 -05:00
Hypolite Petovan
6df187478d Fixed wrong reference to user.expire in Model\User::getActorName
- Update field documentation to prevent further confusion
2022-11-14 17:02:41 -05:00
Hypolite Petovan
10e48a34f2 Ensure Post::toArray returns an array
- We don't handle query errors anyway
- Remove unused parameter do_close
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314245581
2022-11-14 14:53:54 -05:00
Hypolite Petovan
cb0fde5d7d Create new OStatus\Subscribe module class
- Move route from /ostatus_subscribe to /ostatus/subscribe
2022-11-14 13:48:47 -05:00
Hypolite Petovan
eb6b03b555 Add new OStatus\PortableContacts module class
- Retain existing route /poco for backward compatibility
- Remove unsupported links to /poco/{nickname} route
2022-11-14 13:48:46 -05:00
Hypolite Petovan
a1a0b6512c Create new OStatus\PubSub module class
- Retain previous route /pubsub for backward compatibility
2022-11-14 13:48:46 -05:00
Hypolite Petovan
a8759a9b86 Create new OStatus\PubSubHubBub module class
- Retaining the same /pubsubhubbub route to keep backward compatibility
2022-11-14 13:48:45 -05:00
Hypolite Petovan
63fc315ea0 Add support for Mastodon /reports API call 2022-11-14 12:22:54 -05:00
Hypolite Petovan
17a3a48210 Add new Moderation\Report domain classes 2022-11-14 12:22:52 -05:00
Michael
9506bf6989 Avoid duplicate media elements 2022-11-13 23:38:48 +00:00
Hypolite Petovan
4dc96daeb3 mail() requires additional headers to be separated by CRLF
- Rewrite Email->getAdditionalMailHeaderString to have only one string concatenation statement
2022-11-13 02:28:06 -05:00
Hypolite Petovan
eedde86a37 Remove superfluous property declaration in Settings\UserExport
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1312417007
2022-11-12 08:37:42 -05:00
Michael
5b70df63de Avoid link parsing problems in front of "share" elements 2022-11-12 11:20:26 +00:00
Hypolite Petovan
863977da66 Fix constructor parameters in Module\Settings\RemoveMe
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1311162326
2022-11-10 22:36:54 -05:00
Hypolite Petovan
256c8ab170 Remove RTL Override character from display names to show in notifications
- It was causing the notification message to be unreadable
2022-11-10 10:42:21 -05:00
Hypolite Petovan
71ab9e13f2 Flatten arbitrary contact structure in constructor of FormattedNavNotification 2022-11-10 10:41:02 -05:00
Philipp
477bec1977
Fix some PHP8.1 issues if possible 2022-11-09 23:58:23 +01:00
Philipp
6d7cfc8450
whops .. wrong legacy endpoint 2022-11-09 22:39:36 +01:00
Philipp
815d8975e6
Rename Match to MatchInterests because PHP8-lint rejects "match" 2022-11-09 22:36:02 +01:00
Philipp
7c66073e4b
Add license 2022-11-09 22:29:43 +01:00
Philipp
82c631eae3
Fix Guzzle InvalidArgumentException for POST with array parameters 2022-11-09 22:25:37 +01:00
Philipp
75360f3b8c
Move mod/mod/msearch & mod/match to src/Module 2022-11-09 22:17:50 +01:00
Hypolite Petovan
e6ada08e1b Delete mod/settings.php and its reference 2022-11-09 06:26:08 -05:00
Hypolite Petovan
5916544bc8 Move settings/features to src/Module 2022-11-09 06:26:08 -05:00
Hypolite Petovan
45c4439119 Move settings/connectors to src/Module 2022-11-09 06:26:05 -05:00
Hypolite Petovan
33d1df3c6d Move settings/addons to src/Module 2022-11-09 06:25:41 -05:00
Hypolite Petovan
3226b00995 Move settings/oauth to src/Module
- Add settings_content() permission checks to Module\BaseSettings
- Transform application token deletion GET links to POST forms to keep a single OAuth module class
2022-11-09 06:25:22 -05:00
Michael
d3bbed176f Merge remote-tracking branch 'upstream/develop' into warning 2022-11-09 07:35:31 +00:00
Michael
e9393fb509 Fix warning when loading invalid html 2022-11-09 06:38:31 +00:00
Michael
a7e576fda0 Fix warning: Undefined array key "public" 2022-11-09 06:31:05 +00:00
Hypolite Petovan
4a626ef101 Create new Contact\Redir module class
- Move /redir route to /contact/redir
2022-11-08 20:12:23 -05:00
Hypolite Petovan
386c08aa05 Remove superfluous calls to DI::baseUrl in Contact:photoMenu 2022-11-08 19:31:09 -05:00
Hypolite Petovan
a68c790c64 Create new Settings\RemoveMe module class
- Moved route from /removeme to /settings/removeme
- Combined templates into one
2022-11-08 18:33:54 -05:00
Michael
df8644c59c Performance improvements in public timeline 2022-11-08 21:48:42 +00:00
Hypolite Petovan
99d54dc711 Restore Item\Source module functionality 2022-11-08 11:53:09 -05:00
Michael
246021fdfa Store the source of incoming posts 2022-11-08 11:53:09 -05:00
Tobias Diekershoff
48090d1b70
Merge pull request #12142 from MrPetovan/task/homepage-verified
Add title to homepage verified check mark
2022-11-08 11:12:17 +01:00
Hypolite Petovan
0a20566199 Replace remaining occurrences of admin/users route by moderation/users 2022-11-08 04:26:11 -05:00
Hypolite Petovan
561f22cdc4 Add title to homepage verified check mark
- Decrease log level for not found Memcached keys
2022-11-08 04:20:19 -05:00
Hypolite Petovan
18f54f4425 New area "moderation"
- Moved several admin pages to the moderation area
- ACL still is checking for administrator credentials
2022-11-08 02:28:42 -05:00
Hypolite Petovan
c7dbe0b610 Create new OStatus\Repair module class
- Create corresponding template file
2022-11-07 21:44:18 -05:00
Michael
664071a0b1 Quoted reshares containing quoted reshares should now look fine 2022-11-07 20:44:20 -05:00
Philipp
bb97776dfb
The last PHPCS error .. 2022-11-07 20:35:07 +01:00
Philipp
d524f55e3e
Reduce error-throws :-) 2022-11-07 20:34:05 +01:00
Philipp
a81708091f
Make PHPCS happy 2022-11-07 20:32:55 +01:00
Philipp
2da2ac6826
make PHP CS happy? 2022-11-07 20:28:08 +01:00
Philipp
78a8ed6fe7
adhere feedback 2022-11-07 20:21:11 +01:00
Philipp
f13c91b320
Move mod/cal.php and mod/events.php to Module 2022-11-07 19:52:24 +01:00
Philipp
89fde911f9
Fix possible security issue 2022-11-07 19:52:13 +01:00
Roland Häder
3bdc20df15
Changed:
- added type-hints as follow-up commit to #12130
2022-11-07 19:18:34 +01:00
Michael Vogel
e6a5c172ce
Merge pull request #12131 from MrPetovan/task/4090-move-mod-salmon
Move mod/salmon.php to src/Module
2022-11-07 14:55:02 +01:00
Hypolite Petovan
7c7fc624f3
Fix code standards in Module\OStatus\Salmon 2022-11-07 07:54:12 -05:00
Tobias Diekershoff
44af6e4bc2 don't be pythonic 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
379eeb49eb make the standards check happy 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
cdfd51310e we don't need the 20... 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
594c17546b the config default parameter was deprecated 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
a9265220af add labels for the logger parameters 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
33c9d17bdb change the cURL success check and adopt the logger messages 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
fb04eb107b set the validation to false, and only set it to true if we were able to verify the link 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
64f290a055 avoide useless cURL request to the profile page 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
dd0811aec9 remove debugging tracers 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
5530b6fc75 reviews 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
1c65098013 clean up the used modules 2022-11-07 11:19:33 +01:00
Tobias Diekershoff
a1d57abfe4 add the new CheckRelMeProfileLink class to the worker 2022-11-07 11:15:55 +01:00
Tobias Diekershoff
028d823d96 add a help text to the profile settings indicating how to verify the homepage, or that the homepage is verified 2022-11-07 11:15:55 +01:00
Tobias Diekershoff
c8636db9f6 When the profile is updated, let the Worker verify the homepage link 2022-11-07 11:15:55 +01:00
Tobias Diekershoff
30b9a57a37 Let the Worker check the homepage of a profile daily 2022-11-07 11:15:54 +01:00
Hypolite Petovan
ec02664773 Add new OStatus\Salmon module class
- Add module instanciation in Module\DFRN\Notify
2022-11-06 20:42:05 -05:00
Hypolite Petovan
bd9292fe19 Convert static methods to dynamic in Module\DFRN\Notify 2022-11-06 20:38:33 -05:00
Hypolite Petovan
d5b29b1c61 Add follow/unfollow link to the contact actions menu 2022-11-06 19:03:21 -05:00
Michael
210200d330 Use different parser modes for Mastodon and Twitter-API 2022-11-06 20:02:43 +00:00
Michael
1d7d8788bd Support "fedifinder" to import contacts 2022-11-06 10:05:54 +00:00
Tobias Diekershoff
e582cd4543
Merge pull request #12125 from annando/pending
Don't show following/followed_by on pending
2022-11-06 10:26:11 +01:00
Michael
e10d714ef5 Don't show following/followed_by on pending 2022-11-06 08:18:28 +00:00
Tobias Diekershoff
4b5c6994b2
Merge pull request #12122 from annando/issue-2657
Issue 2657: Mentions will now be recognized by clients
2022-11-06 09:13:45 +01:00
Tobias Diekershoff
174151d4d0
Merge pull request #12124 from annando/issue-11832
Issue 11832: Avoid error when fetching group members
2022-11-06 09:12:22 +01:00
Tobias Diekershoff
d0318b3df6
Merge pull request #12123 from annando/issue-11831
Issue 11831: Activate "notify on new post" via API
2022-11-06 09:10:34 +01:00
Michael
b202354bbb Merge remote-tracking branch 'upstream/develop' into issue-2657 2022-11-06 07:08:55 +00:00
Michael
fe3713b8f3 Merge remote-tracking branch 'upstream/develop' into issue-11832 2022-11-06 07:07:32 +00:00
Michael
f1f40fbbf7 Merge remote-tracking branch 'upstream/develop' into issue-11831 2022-11-06 07:04:35 +00:00
Michael
92813dd2e4 Issue 11832: Avoid error when fetching group members 2022-11-06 06:42:33 +00:00
Michael
bc7d21183d Issue 11831: Activate "notify on new post" via API 2022-11-06 06:11:22 +00:00
Michael
40fb820aef Unused use removed 2022-11-06 06:00:19 +00:00
Michael
56ac879c92 Issue 2657: Mentions will now be recognized by clients 2022-11-06 05:43:34 +00:00
Hypolite Petovan
3e33ec0c0f Suppress InvalidArgument exceptions handling URLs in Model\Item::containsLink 2022-11-05 20:18:14 -04:00
Michael Vogel
ea49ab6e04
Merge pull request #12114 from MrPetovan/bug/12112-unFollow
Fix capitalization of unfollow links in Model\Contact
2022-11-06 00:21:27 +01:00
Hypolite Petovan
b9f0985467
Merge pull request #12116 from annando/issue-11846
Issue 11846: Fix client behaviour when following hash tags
2022-11-05 19:13:31 -04:00
Michael Vogel
52f74b6312
Update src/Object/Api/Mastodon/Status.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-11-05 23:51:16 +01:00
Michael
9fa3df3cbf "arrat" to "array" 2022-11-05 22:39:15 +00:00