Commit graph

1122 commits

Author SHA1 Message Date
Philipp Holzer
dc73117a62
code optimization 2019-09-30 14:03:15 +02:00
Philipp Holzer
49e812f3d3
Bugfix GetAllKeys() of Memcache
- Abstract Memcache and Memcached implementation
2019-09-30 14:03:15 +02:00
Philipp Holzer
d5dd12b8f8
Add Drone CI
- Add drone test environment
- Add drone config
- apt phpunit
- Fix api.php
- Fix item.php
- Fix DBStructure
- Check if caching is possible during tests
2019-09-30 14:03:12 +02:00
Michael
83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
Michael
6e9026e033 Renamed function, beginning to replace the "remote_user" function 2019-09-28 09:36:41 +00:00
Michael
704cdf1b5a New function to store the "remote" session value / making the changes work 2019-09-26 04:47:42 +00:00
Michael
ec66553032 Reworked "remote" cookie handling 2019-09-25 22:24:17 +00:00
Michael
d5c37001cd Empty the "remote" variable, avoid being remote to yourself 2019-09-25 07:02:07 +00:00
Michael
6a376c29d8 Fix session size problems 2019-09-25 05:57:32 +00:00
Michael
5254147ccc Fix "redir" loop 2019-09-23 22:13:20 +00:00
Hypolite Petovan
32707022bf Remove GET page parameter access from Core\ACL 2019-09-13 20:06:57 -04:00
Hypolite Petovan
1a81ed8616 Fix notice message when $return is undefined in Core\ACL 2019-09-13 20:06:22 -04:00
Michael
2dbd843ed2 Don't display ignored pending contacts, link to contact request page 2019-09-09 05:29:33 +00:00
Philipp Holzer
8273b88a3e
Add missing getPokeVerbs() method 2019-09-03 16:07:05 +02:00
Philipp
08b6f55a89
Merge pull request #7589 from annando/delivery-counter
Fix delivery counter / archive relay contacts
2019-09-03 15:59:49 +02:00
Michael
8947473c71 Contact details are now available when searching for a single contact 2019-09-02 05:33:13 +00:00
Michael
6af4c90dff Fix delivery counter / archive relay contacts 2019-09-02 03:25:05 +00:00
Hypolite Petovan
ce7ec11d1d
Merge pull request #7570 from nupplaphil/bug/friendica-7298
Some code hardenings for semaphore locking
2019-08-29 15:02:07 -04:00
Michael Vogel
cf170c9c02 Fixed count, added to-do 2019-08-28 06:44:37 +02:00
Michael Vogel
9b7432781b Don't transmit content to already archived contacts 2019-08-27 21:01:11 +02:00
Philipp Holzer
de7c026590
Some code hardenings for semaphore locking 2019-08-26 23:55:54 +02:00
Michael Vogel
a892156052 Output better comparable log entries for the worker 2019-08-23 07:23:32 +02:00
Michael
5a1a5a54dc Delivery count now counts the failed delivery attempts as well 2019-08-20 07:39:13 +00:00
Philipp Holzer
c803dcb6c5
Fix Locks
- Wrong return of lock releasing with DBA provider
- It's not possible to maintain Semaphore locks, since they aren't accessible by other processes
Should solve https://github.com/friendica/friendica/issues/7298#issuecomment-521996540
2019-08-17 19:33:36 +02:00
Philipp Holzer
2c73377b39
Create Core\Process as a base for followup work 2019-08-17 09:09:13 +02:00
Philipp Holzer
90b438e082
Move mode settings to App\Mode
- Move isAjax() to App\Mode
- Move isTablet() to App\Mode
- Move isMobile() to App\Mode
- Refactor last usage of App->isBackend()
2019-08-17 09:09:13 +02:00
Hypolite Petovan
feb720a3ee
Merge pull request #7518 from nupplaphil/bug/lock_unlink
Fix Lock-Unlink
2019-08-15 12:11:01 -04:00
Philipp Holzer
2369ea1d50
Fix Lock-Unlink
- Check if .sem file exists before unlinking it
- Fixing https://github.com/friendica/friendica/issues/7298#issuecomment-521670482
2019-08-15 17:55:17 +02:00
Philipp Holzer
290dd2ab39
moved rest of BaseURL 2019-08-15 17:36:07 +02:00
Philipp Holzer
734b63adba
Fixed wrong "BaseUrl" class (=> "BaseURL") 2019-08-15 17:23:35 +02:00
Philipp Holzer
08be92a862
Moved BaseURL to App namespace (because similar type as Arguments/Modules/Modes) 2019-08-15 17:23:00 +02:00
Philipp Holzer
689a2145f6
Add @see for SO link 2019-08-15 16:24:11 +02:00
Philipp Holzer
e2e109b8c1
Fix getAllKeys() method for memcache instances 2019-08-15 14:26:05 +02:00
Philipp Holzer
41e2031e6b
Console Lock
WIP
2019-08-15 14:26:04 +02:00
Philipp Holzer
0af9747c6c
Add Arguments & Modules class 2019-08-13 16:29:11 +02:00
Hypolite Petovan
f068d00645
Merge pull request #7510 from nupplaphil/bug/Fix_Redis_test
Fix Redis test
2019-08-13 06:41:07 -04:00
Philipp Holzer
b28e11fee8
- Remove deprecated Redis::delete() function 2019-08-13 08:54:26 +02:00
Philipp Holzer
31cfac1cfa
Fix Redis test
- Check if $redis_port is null
2019-08-13 08:32:08 +02:00
Michael Vogel
afac4b7698 Improved calculation of deferred tasks 2019-08-13 06:43:08 +02:00
Michael Vogel
e07a17daf6 Added config value 2019-08-11 23:07:06 +02:00
Michael Vogel
5c72aeb8d7 Worker: The retrial value can now skip retrial levels 2019-08-11 10:28:52 +02:00
Michael Vogel
35a487ae30 Don't fork worker on frontend by default 2019-08-08 22:42:12 +02:00
Philipp Holzer
a66580444f
Fixing sort of BaseURL usage for App & Cache usage 2019-08-04 20:01:15 +02:00
Philipp Holzer
3834d5e129
Renamed __toString() to getName() 2019-08-04 16:14:19 +02:00
Philipp Holzer
d2211bd6dd
Removed some leftovers 2019-08-04 15:58:53 +02:00
Philipp Holzer
19777baa79
- Move constants to the "Cache" class (more transparent than inside the interface) 2019-08-04 15:53:28 +02:00
Philipp Holzer
34e4968c06
Adding possibility to use a different cache-backend for locking and caching
- Renaming *LockDriver to *Lock since it isn't a "driver" anymore
2019-08-04 15:42:39 +02:00
Philipp Holzer
86bf2ee45a
Rename *CacheDriver to *Cache because they don't act as driver anymore 2019-08-04 10:26:53 +02:00
Philipp Holzer
d56bd28a07
Refactor Cache/Lock to DICE
- Refactor Cache classes
- Refactor Lock classes
- Improved test speed (removed some seperate class annotations)
2019-08-03 20:51:58 +02:00
Michael Vogel
e8459cce34
Merge pull request #7381 from MrPetovan/task/7309-frio-compose
[frio] New Compose page
2019-08-01 08:15:02 +02:00
Philipp Holzer
a60eb9e33d
Use DICE for Console
- Use Friendica\Core\Console as Controller for DI-library
- Refactor every console command to use DICE (when possible)
- Adjusting tests
2019-07-31 19:37:42 +02:00
Hypolite Petovan
3e6018b3f2 Add meta protocol group for private post support 2019-07-29 20:31:48 -04:00
Philipp Holzer
6c2cf494b5
Remove DependencyFactory
- Include all necessary classes in `dependencies.config.php`
- Add DI-reference to BaseObject (acts as a global registry)
- Refactor all static "init()" methods to use the global registry

- Refactor Logging for Worker-Logger a little bit
2019-07-27 23:54:12 +02:00
Hypolite Petovan
4ec4a04e49 Remove mod/ping from 2fa exception list
- Prevent asynchronous calls to redirect to /2fa in case of missing valid 2fa session
2019-07-23 20:03:08 -04:00
Philipp Holzer
a8e6a57e9b
Fixing installer 2019-07-21 14:21:02 +02:00
Philipp Holzer
55999730e0
Introduce DICE
- Adding dice library
- Adding dependency config

- Removing Factories
- Refactoring App\Mode constructor
- Refactoring App\Router constructor
- Refactoring BasePath for DI usage
- Refactoring ConfigFileLoader constructor
- Refactoring Profiler constructor

- Adjust entrypoints (index, console, worker, ..)

- Adding functional test for DI
- Fix tests because of refactorings
2019-07-21 01:22:10 +02:00
Hypolite Petovan
f5e07be04e Fix undefined property notice in L10n\L10n 2019-07-18 21:21:16 -04:00
Hypolite Petovan
11e4f906c2
Hot-fix: Core\L10n::t method passing parameter bug
Follow-up to #7379
2019-07-16 21:18:25 -04:00
Hypolite Petovan
0b97b32a59
Merge pull request #7379 from nupplaphil/task/refactor_l10n_for_test
Refactor L10n for testing
2019-07-16 16:03:42 -04:00
Philipp Holzer
92fb0a82ca
Dynamic config loading
- Move settings, defaults and dbstructure to directory 'static'
- Dynamic loading of config files (after the static loading)
- Filter out '-sample.config.php' and '-sample.ini.php' files
- Remove unnecessary ConfigFileManager
- Move ConfigFileLoader to Utils
- Add tests for multi-loading for INI, config and sample-filtering
2019-07-16 20:16:43 +02:00
Philipp Holzer
eb024a3718
Refactor L10n for testing
- Moving L10n to L10n\L10n
- Adding constructor information
- Adding to factory
- simplify/speedup tests
2019-07-16 16:44:47 +02:00
Hypolite Petovan
c6cd2b131d Add transitive type hints in Core\PConfig 2019-07-16 07:45:24 -04:00
Hypolite Petovan
68f5b639eb Restore $uid parameter integer type-hint in Config
- Add integer type-hint to Feature::isEnabled
2019-07-15 22:00:49 -04:00
Philipp Holzer
f70271aa5d
Allow nullable UID in PConfigCache 2019-07-15 21:14:13 +02:00
Philipp Holzer
d5de5b6789
Bugfixing bad UIDs for PConfig 2019-07-15 21:11:38 +02:00
Philipp Holzer
ebf00e32a1
minor phpdoc fixings 2019-07-15 20:54:33 +02:00
Philipp Holzer
74f7c16585
Fixup phpdoc 2019-07-15 20:19:52 +02:00
Philipp Holzer
9d98a4ce3a
Refactor PConfiguration 2019-07-15 20:13:53 +02:00
Philipp Holzer
6801e8b5ab
Fixing initial load config 2019-07-15 08:58:37 +02:00
Philipp Holzer
4af08d82b2
Added string type-hint for get() and a test case for it 2019-07-14 23:23:20 +02:00
Philipp Holzer
a654470061
fix phpdoc 2019-07-14 22:41:09 +02:00
Philipp Holzer
b48c22dc1a
minor fixing: phpdoc & type-hint 2019-07-14 22:31:53 +02:00
Philipp Holzer
a2c6240da0
some minor fixings 2019-07-14 22:26:36 +02:00
Philipp Holzer
4913502922
bugfix: add lost changes due merge 2019-07-14 22:12:45 +02:00
Philipp Holzer
c293eadb78
Improve & fixing Tests 2019-07-14 22:12:11 +02:00
Philipp Holzer
486f139342
Move Preload/JIT Configuration logic from Adapter to Core-Configuration 2019-07-14 22:09:07 +02:00
Philipp Holzer
c82127ffb7
Splitting ConfigCache & PConfigCache
- Remove IConfigCache & IPConfigCache
- Add new PConfigCache
- Add missing Logger::init() (bugfixing tests)
2019-07-12 22:53:37 +02:00
Philipp Holzer
e1d135238a
Revert default password setting & using "HiddenString" even for empty strings 2019-07-09 22:38:54 +02:00
Philipp Holzer
ab7c6499ff
Bugfixing DB/Installer
- default value with HiddenString
- Fixing checkDB during installation
2019-07-09 22:22:06 +02:00
Michael
6bb418c5a7 Use "received" instead of "created" when displaying posts in creation order 2019-07-07 21:30:33 +00:00
Michael
6041f74df6 New constant for federated protocols 2019-07-01 18:00:55 +00:00
Hypolite Petovan
b9ab613777 Merge branch 'master' into develop 2019-06-23 17:40:52 -04:00
Hypolite Petovan
d7d44e1af7
Merge pull request #7245 from annando/unify-constants
Fix delivery counter for poking / unify delivery commands
2019-06-10 11:59:40 -04:00
Hypolite Petovan
151c026a8a
Merge pull request #7244 from nupplaphil/task/hidden_string
Introduce HiddenString for Config-Values
2019-06-10 10:50:41 -04:00
Michael
41dc243186 Fix delivery counter for poking / unify delivery commands 2019-06-10 14:19:24 +00:00
Philipp Holzer
50d8dbb123
Bugfixing wrong typed password setting 2019-06-10 15:46:51 +02:00
Philipp Holzer
4666b18e5b
Bugfixing empty password setting 2019-06-10 15:40:15 +02:00
Philipp Holzer
357d9b5108
Introduce HiddenString for Config-Values 2019-06-10 14:46:31 +02:00
Philipp Holzer
cc7444d84d
Move internal recursion-counter to the end of all cur/fetchUrl parameters 2019-06-10 14:34:54 +02:00
Philipp Holzer
79fe3c92c7
Fixing Installer - ReplaceMacro 2019-06-07 00:36:10 +02:00
Hypolite Petovan
5414d51d4c Prevent fatal error in ACL::getFullSelectorHTML when accessing a profile as a remote visitor
See https://github.com/friendica/friendica/issues/6916#issuecomment-495724811
2019-05-28 21:09:06 -04:00
Hypolite Petovan
01e71254d9 Replace defaults() calls on $_SESSION by Core\Session calls
- Replace direct calls to $_SESSION by Core\Session calls in Module\Login
2019-05-26 21:26:59 -04:00
Philipp Holzer
26d4214c19
added suggestions 2019-05-26 21:53:24 +02:00
Philipp Holzer
220f8f0862
friendica-6950 uimport doesn't support "pwdreset_time":null 2019-05-26 15:49:44 +02:00
Hypolite Petovan
08d7d42f81 Ensures Search methods return an empty ResultList instead of null
- Addresses https://github.com/friendica/friendica/issues/6916#issuecomment-494876901
2019-05-24 08:13:36 -04:00
Philipp Holzer
3d67987cbc
simplification 2019-05-20 19:27:53 +02:00
Philipp Holzer
5e79d3fc82
Fixing method signature 2019-05-20 19:19:57 +02:00
Philipp Holzer
2bb2bb19fd
refactor method signature 2019-05-20 19:15:47 +02:00
Philipp Holzer
58c8959da0
Add search types 2019-05-20 19:13:37 +02:00
Philipp Holzer
83fd03b124
Add PhpDoc 2019-05-20 18:44:44 +02:00
Philipp Holzer
1e36c68e48
Moving Search to Core, Refactor Objects 2019-05-20 18:42:27 +02:00
Hypolite Petovan
bf82736522 Exclude /api and /proxy from 2fa check 2019-05-15 08:56:02 -04:00
Hypolite Petovan
78b651d2e8 Revert Use Contact::select() instead of DBA::select(‘contact) in Core\Session 2019-05-13 14:07:02 -04:00
Hypolite Petovan
e077f30d51 Use Contact::select() instead of DBA::select(‘contact) in Core\Session
- Replace remaining occurrences of $_SESSION with Session methods
2019-05-13 13:33:20 -04:00
Hypolite Petovan
d7e9b91181 Add two-factor authentication
- Add 2FA login interception in Session::setAuthenticatedForUser
- Add 2fa session variable holding the last auth code
2019-05-13 01:52:01 -04:00
Hypolite Petovan
6071fe81b4 Move Authentication::setAuthenticatedSessionForUser to Session::setAuthenticatedForUser 2019-05-13 01:51:59 -04:00
Hypolite Petovan
f0f44dbd84 Delete all addon hooks by default on uninstall 2019-05-08 00:46:13 -04:00
Tobias Diekershoff
959054f2f2 Add subject to DB Update email 2019-05-06 11:13:38 +02:00
Philipp Holzer
62fd5375dc
Move mod/maintenance to src/Module/Maintenance 2019-05-05 10:06:50 +02:00
Philipp Holzer
6ff3389f6e
add status code to System::externalRedirect 2019-05-04 09:16:37 +02:00
Philipp Holzer
d716a3326f
Move Console namespace one level up 2019-05-02 23:17:35 +02:00
Philipp
2628da422a
Merge pull request #7068 from MrPetovan/task/7047-theme-error-page
Themed error page redux
2019-05-02 21:15:29 +02:00
Hypolite Petovan
358baa9f62 Add themed error pages
- Module init, post and rawContent-triggered HTTPException generate the classic bare HTTP status page
- Module content-triggered HTTPException generate themed error pages
- Trim System::httpExit to the bare minimum
2019-05-02 11:26:56 -04:00
Hypolite Petovan
6df37afb82 Various feedback items
- Add logger call on theme install failure
- Add todo in Module\Admin\DBSync
2019-05-02 09:55:49 -04:00
Hypolite Petovan
9f4fb4906a Move addon admin list generation to Core\Addon 2019-05-02 09:55:49 -04:00
Hypolite Petovan
9774c95b80 Remove duplicate $baseurl template variable
- Remove unused $overwriteURL parameter in Renderer::replaceMacros
2019-05-02 09:55:48 -04:00
Hypolite Petovan
fb503e82bf Normalize how we store enabled addons/themes in config value to straight comma-separated list 2019-05-02 09:52:54 -04:00
Hypolite Petovan
9bbb438534 Move admin/addons to src/Module
- Add Module\Admin\Addons\Index class
- Add route for admin/addons
- Add addons admin aside menu entry
- Remove unused template admin/addons.tpl from base and frio
- Remove addon list from mod/admin
2019-05-02 09:52:44 -04:00
Hypolite Petovan
9227aab837 Add system.allowed_themes config key handling in Core\Theme
- Add Theme::setAllowedList method
- Update the allowed theme list on theme install/uninstall
- Add theme file inclusion on uninstall allowing for theme_uninstall function to be called
- Removing logging from frontend methods
2019-05-02 09:52:42 -04:00
Philipp Holzer
bc8d444989
remove extraneous space 2019-04-21 12:45:50 +02:00
Philipp Holzer
3ca8fa0e00
Support for APCu caching 2019-04-21 12:45:19 +02:00
Hypolite Petovan
e9c230e109
Merge pull request #7018 from nupplaphil/feature/6245-Block_shell
New Command "BlockedServers"
2019-04-20 11:01:01 -04:00
Philipp Holzer
8660f6d86f
Rename BlockedServers to ServerBlock 2019-04-20 16:40:27 +02:00
Philipp Holzer
fa71a9a0ce
Improve redis configuration
- basic authentication
- switch database (0 - 15)
2019-04-20 13:40:40 +02:00
Philipp Holzer
f05f02409e
Add update possibility to BlockedServers 2019-04-20 13:24:33 +02:00
Philipp Holzer
7ce76d153a
rename description to reason 2019-04-20 12:54:38 +02:00
Philipp Holzer
55d2473ec2
Add tests & default reason 2019-04-20 12:53:17 +02:00
Philipp Holzer
e25f269aab
New command "BlockedServers" 2019-04-20 10:42:28 +02:00
Philipp Holzer
03e149270b
bugfix 2019-04-14 14:40:26 +02:00
Philipp Holzer
58c9566c3d
code style & install-403 fix 2019-04-14 14:24:01 +02:00
Philipp Holzer
d90eb6a811
Remove php_path duplicate in auto-install 2019-04-14 14:24:00 +02:00
Philipp Holzer
8fe606660d
trim whitespaces 2019-04-14 14:23:59 +02:00
Philipp Holzer
3a0664d827
fixing auto install tests 2019-04-14 14:23:58 +02:00
Philipp Holzer
677cb205f5
fix auto install 2019-04-14 14:23:58 +02:00
Philipp Holzer
90a38a00d8
Adding basepath, urlpath, hostname and ssl_policy to installation 2019-04-14 14:23:06 +02:00
Philipp Holzer
fbd056327a
DBA-Logger fix 2019-04-13 20:46:58 +02:00
Hypolite Petovan
75387ea171
Merge pull request #6991 from fabrixxm/fix/invalid-storage-on-legacy
Allow set empty string storage class for legacy
2019-04-11 09:04:48 -04:00
Hypolite Petovan
9162f714e0 Add uri to missing session data logging context in Session handlers 2019-04-11 05:26:37 -04:00
Philipp Holzer
dc48690ed5
Remove hostname blacklisting 2019-04-11 00:09:59 +02:00
fabrixxm
72bee45079 Revert b2794bb2c 'Allow set empty string storge class for legacy' 2019-04-10 08:35:44 +02:00
fabrixxm
b2794bb2c9 Allow set empty string storge class for legacy
Legacy storage is defined by an empty string.
`StorageManager::setBackend()` now accept an empty string as a valid
backend storage.
2019-04-09 16:32:15 +02:00
Philipp Holzer
63660b6fc0
Removed unnecessary class 2019-04-09 08:31:19 +02:00
Philipp Holzer
318a3ca785
Create own base URL class which holds the whole base url business logic 2019-04-09 08:31:16 +02:00
Tobias Diekershoff
c4fef79f32 Add subject to DB Update email 2019-04-08 10:55:18 +02:00
Michael
46a99a05a1 Remove the queue from the core 2019-04-05 18:04:39 +00:00
Hypolite Petovan
cc64471e4c Sanitize addon path items 2019-03-31 21:53:08 -04:00
Hypolite Petovan
b529c03a20 Sanitize theme path items
- Sanitize theme style/color/scheme path items
2019-03-31 21:52:48 -04:00
Hypolite Petovan
6aac84dc8e Add Theme::getAllowedList method 2019-03-31 21:41:38 -04:00
Philipp Holzer
363d6b72ae
wrong indent 2019-03-30 19:10:19 +01:00
Philipp Holzer
0a447cb61b
wrong indent 2019-03-30 19:08:47 +01:00
Philipp Holzer
e0b1f4f251
Hardening ConfigUpgrade 2019-03-30 18:54:22 +01:00
Hypolite Petovan
09e03c9213
Merge branch 'develop' into task/6778-add-storage-move-to-cron 2019-03-27 14:13:42 -04:00
Hypolite Petovan
ef0545645a
Merge pull request #6942 from annando/worker-fast-commands
Command based pre fetching of worker tasks
2019-03-27 09:28:15 -04:00
Michael
83ff2b0382 We don't need to escape values anymore 2019-03-26 21:58:03 +00:00
Michael
2e0697c70e Notifications do work now again 2019-03-26 21:55:48 +00:00
Hypolite Petovan
753b1e0f25
Merge pull request #6935 from nupplaphil/issue/missing_basepath
Fixing basepath issue
2019-03-26 08:23:50 -04:00
Philipp Holzer
040504dca9
fixing config value setting 2019-03-26 08:13:49 +01:00
Philipp Holzer
9ec29f1e8e
straight the config value check 2019-03-26 08:00:41 +01:00
Philipp Holzer
7d88b800b8
Fixing Basepath 2019-03-25 20:53:46 +01:00
Philipp Holzer
d78598b64e
Fixing basepath issue 2019-03-25 09:39:33 +01:00
Hypolite Petovan
898f7e7e38 Add connector collapsible panel in permission
- Replace HTML string by structured array in jot_networks hook
- Add collapsed panel when there are more than two connectors
2019-03-24 22:40:50 -04:00
Hypolite Petovan
76414a5169
Merge pull request #6920 from nupplaphil/feature/basepath/hostname_config
Removing basepath/hostname from admin site settings
2019-03-24 20:15:13 -04:00
Philipp Holzer
23654ce566
Added Update checks
- Logging
- Console
- Admin overview
2019-03-24 22:51:30 +01:00
Philipp Holzer
3cf0cb71f1
Fixing tests 2019-03-24 20:41:11 +01:00
Philipp Holzer
49def0dc27
Adding ConfigFileSaver and tests 2019-03-24 13:47:35 +01:00
Hypolite Petovan
0c8c97171a Revert logic change in query in NotificationsManager->setSeen 2019-03-23 22:16:12 -04:00
Hypolite Petovan
410f34d7fd Add storage backend move cronjob
- Fix typos in Console\Storage and Worker\CronJobs
2019-03-23 21:47:33 -04:00
Philipp Holzer
383a6715c3
Added first version of ConfigCacheSaver 2019-03-23 19:34:54 +01:00
Michael
a09c5b692c Command based pre fetching of worker tasks 2019-03-23 06:08:18 +00:00
Philipp
c5cbba3416 Fix boolean value 2019-03-22 23:31:47 -04:00
Philipp Holzer
69fa6161e5 Refactor installer 2019-03-22 23:31:45 -04:00
Philipp Holzer
1a2527cdba Move AppMode 2019-03-22 23:22:32 -04:00
Jeroen De Meerleer
2d263b08e3 code style 2019-03-22 23:13:30 -04:00
Jeroen De Meerleer
a01a53a9f0 Fixed notifications order 2019-03-22 23:13:29 -04:00
Philipp Holzer
25b6db6aca Moving Profiling to class 2019-03-22 23:07:39 -04:00
Philipp Holzer
8237e73e26 Adding REAMDEs to directories 2019-03-22 22:56:57 -04:00
Philipp Holzer
3261ffbd99 bugfix - mixed fields with condition 2019-03-22 22:56:56 -04:00
Philipp Holzer
ec2c84a4e9 code lisibility & filter optimization 2019-03-22 22:55:48 -04:00
Philipp Holzer
4496df79ab Replace "q" calls 2019-03-22 22:55:48 -04:00
Philipp Holzer
b2edb85588 Replace "q" calls 2019-03-22 22:55:48 -04:00
Hypolite Petovan
385e3a09f2 Add loop to console storage move
- Add timestamp to output messages
2019-03-20 00:42:50 -04:00
Hypolite Petovan
8ddbeb087f Add limit parameter to storage move query
- Fixes out-of-memory errors with large tables
- Add database statement closing
- Add meaningful variable names
- Remove useless DBA::isResult check
2019-03-20 00:41:57 -04:00
Hypolite Petovan
7e2e2f425e Check that provided class implements IStorage in StorageManager::setBackend
- Add notice in admin if setting value change failed
- Add notice in console if setting value change failed
2019-03-19 22:42:44 -04:00
Hypolite Petovan
f225a6c51a Reformat code
- Reformat Console\Storage
- Reformat Core\StorageManager
- Simplify logic in Worker\CronJobs
2019-03-19 22:42:05 -04:00
Philipp Holzer
b22ff7419e
refactor naming & superfluous check 2019-03-17 09:57:34 +01:00
Philipp Holzer
8c6e6b5dea
Fixing .htconfig 2019-03-16 20:31:10 +01:00
Philipp Holzer
1acd5c7d22
- Adding additional legacy .htconfig information 2019-03-16 20:06:53 +01:00
Philipp Holzer
cf17c72fd7
Adapt Logging messages 2019-03-11 21:36:41 +01:00
Philipp Holzer
8a358d5c98
Add Logger entry 2019-03-11 21:27:36 +01:00
Philipp Holzer
9a60eab152
Skip update if already done 2019-03-11 21:21:01 +01:00
Hypolite Petovan
a2ec9e676e
Revert "Avoid double update runs" 2019-03-09 18:28:48 -05:00
Philipp Holzer
f7c7851c2d
replaced duplicate code with method 2019-03-09 20:50:06 +01:00
Philipp Holzer
20498d1d40
replaced duplicate code with method 2019-03-09 20:50:00 +01:00
Philipp Holzer
7047a13ffa
added phpdoc 2019-03-09 20:49:59 +01:00
Philipp Holzer
e46a7cdf80
Avoid double update runs 2019-03-09 20:49:59 +01:00
Michael
ea71a4e83a Refetch new jobs only once per execution loop 2019-03-08 20:39:58 +00:00
Tobias Diekershoff
5df246e9af
Merge pull request #6825 from annando/empty-spawn
Worker: Don't spawn without jobs
2019-03-08 07:26:22 +01:00
Michael
d87abe9563 Worker: Don't spawn without jobs 2019-03-08 05:53:36 +00:00
Philipp Holzer
07bd4cec65
Fixing redis cachekey 2019-03-04 21:28:36 +01:00
Philipp Holzer
d7426e697d
Fixing redis cachekey 2019-03-04 21:09:20 +01:00
Philipp Holzer
3e53dab817
Fixing redis cachekey 2019-03-04 21:00:41 +01:00
Michael
f2560c42d1 Reduce the default maximum load for the worker to 20 2019-03-02 18:41:12 +00:00
Michael
9427d7f628 We have to fetch the data this way 2019-03-02 13:07:29 +00:00
Michael
16c2ae89e8 Sent update mails to administrators only once 2019-03-02 12:57:47 +00:00
Philipp Holzer
16ff5af221
Fix handling table name during storage move 2019-03-01 18:07:08 +01:00
Philipp Holzer
739449926c
'%' is deprecated 2019-02-27 20:30:08 +01:00
Philipp Holzer
4a47425bfd
admin mail list seems wrong escaped 2019-02-27 20:17:35 +01:00
Michael
c3b12b63c8 Added some description, changed logger call 2019-02-27 09:49:26 +00:00
Michael
505a34d40e Log the time as decimal 2019-02-27 09:12:40 +00:00
Michael
78960d4bde Removed unneeded spaces 2019-02-27 09:11:37 +00:00
Michael
5e440aa035 The cron interval is minutes - so we have to convert it into seconds 2019-02-27 08:55:25 +00:00
Michael
0ee1ea5f29 The log text is now shorter 2019-02-27 08:41:45 +00:00
Michael
11e39da6cc And moving the block back to the old place 2019-02-27 07:08:44 +00:00
Michael
e1cc7262de Respawing when quitting 2019-02-27 07:04:21 +00:00
Michael
528636c9f4 Using constants is nicer 2019-02-27 06:55:04 +00:00
Michael
fb371e1048 Merge remote-tracking branch 'upstream/2019.03-RC' into worker2 2019-02-27 06:41:14 +00:00
Michael
40573120b9 Enhanced logging, stopping worker after cron lifetime 2019-02-27 06:36:19 +00:00
Hypolite Petovan
05d8bf6b54 Fix wrong use of array_shift in Core\Worker 2019-02-25 07:11:35 -05:00
Michael Vogel
df5ea1fab0
Merge pull request #6732 from MrPetovan/bug/1777-fix-blocked-contact-group
Allow to remove blocked contact from groups
2019-02-24 14:30:36 +01:00
Hypolite Petovan
4e3f780621
Merge pull request #6740 from nupplaphil/issue/6503-force_update
Fixing force-flag for lock-release
2019-02-24 07:04:54 -05:00
Philipp Holzer
d1c7815c4e
added whitespace 2019-02-24 12:51:58 +01:00
Philipp Holzer
aae58815a8
Adjust update parameters:
-f|--force         Force the update command (Even if the database structure matches)
-o|--override      Override running or stalling updates
2019-02-24 12:24:09 +01:00
Michael
4bad2645e5 We should execute the worker job for normal situations ;-) 2019-02-24 10:52:40 +00:00
Michael
ee300a7db6 Ensure that the database update will be processed anyway 2019-02-24 10:43:29 +00:00
Philipp Holzer
7ce549c294
fixing delete 2019-02-24 10:27:56 +01:00
Philipp Holzer
9b07132b80
Fixing force-flag for lock-releasing 2019-02-24 10:08:28 +01:00
Hypolite Petovan
7e499647e3 Add System::jsonError method for ajax call returns 2019-02-23 17:32:40 -05:00
Michael
7703875b55 Fixes "Undefined property: Friendica\App::$queue" 2019-02-23 16:08:02 +00:00
Hypolite Petovan
44953f045e
Merge pull request #6730 from nupplaphil/dba_reconnect
DBA::(re-)connect fix for basePath
2019-02-23 08:45:31 -05:00
Hypolite Petovan
1a0398a5b3
Merge pull request #6723 from nupplaphil/issue/6658-worker_id
Adding worker ID to log
2019-02-23 08:38:08 -05:00
Philipp Holzer
a73235b6ee
Fixing DBA::(re-)connect() 2019-02-23 12:49:56 +01:00
Philipp Holzer
8760d89eb8
reverting back workerLogger to Logger 2019-02-23 10:24:22 +01:00
Philipp Holzer
5b2f394e3e
Fixing #issuecomment-456403983 2019-02-23 10:16:07 +01:00
Philipp Holzer
40e9bbeb88
cleanup 2019-02-23 00:53:31 +01:00
Philipp Holzer
13807129aa
fixing preload adapter 2019-02-23 00:23:41 +01:00
Philipp Holzer
1dee89f215
fixing tests and preload config 2019-02-23 00:09:57 +01:00
Philipp Holzer
8d56fb8fbe
bugfix marking of db-values 2019-02-22 23:57:04 +01:00
Philipp Holzer
b47fc97b06
readded note 2019-02-22 23:55:13 +01:00
Philipp Holzer
16863c5d82
switched back to logger 2019-02-22 23:53:20 +01:00
Philipp Holzer
8c3aebc376
Bugfixings in Config
- replaced usage of "!<unset>!" with null-returns
- fixed bool settings (0/1)
- fixed overriding config-values
- fixed basepath problems
2019-02-22 23:51:13 +01:00
Philipp Holzer
9c12f3f226
Formatting logger to new style 2019-02-22 20:41:13 +01:00
Philipp Holzer
cec6f49023
Removed unused code 2019-02-22 20:24:10 +01:00
Philipp Holzer
ee37632695
Adding worker id & functionname to worker logs 2019-02-22 20:10:27 +01:00
Hypolite Petovan
4375edd63e
Merge pull request #6719 from annando/worker-scheduler
New scheduler mechanism - now to the correct branch
2019-02-21 16:12:19 -05:00
Michael
7810227040 Reverted test stuff 2019-02-21 19:34:12 +00:00
Michael
3450f12cba Changed log calls 2019-02-21 19:32:31 +00:00
Philipp Holzer
c2176aad36
bugfix 2019-02-18 14:45:24 +01:00
Philipp Holzer
5127a113aa
set config_loaded with uid 2019-02-18 14:40:35 +01:00
Philipp Holzer
1194e9b41e
set config_loaded with uid 2019-02-18 14:34:30 +01:00
Philipp Holzer
5157084969
negative set 2019-02-18 14:10:04 +01:00
Philipp Holzer
2fc81898da
Preload Adapter Fix 2019-02-18 14:02:09 +01:00
Philipp Holzer
f536107911
Fixing value check for configuration 2019-02-18 11:29:51 +01:00
Philipp Holzer
86aaa6565e
Fixing saveLog() 2019-02-18 11:29:51 +01:00
Philipp Holzer
a3d6062476
check if value is set
get basepath with config instead cache
2019-02-18 11:29:42 +01:00
Hypolite Petovan
256e845c5d
Merge pull request #6641 from nupplaphil/config_followup
Config FollowUp
2019-02-17 17:56:31 -05:00
Philipp Holzer
0a318925a4
bugfixing adapter get() in case of no connection 2019-02-17 20:44:14 +01:00
Philipp Holzer
ad1254c49c
performance improvement in case of db-load 2019-02-17 20:44:14 +01:00
Philipp Holzer
e1d9d67632
renamed Logger::setLogger() to Logger::init() 2019-02-17 20:44:08 +01:00
Philipp Holzer
80f1feabe5
Refactoring Logging to use Configuration 2019-02-17 20:43:52 +01:00
Philipp Holzer
eafcf3592d
Config FollowUp
- New Configuration (Config is now only holding the instance)
- New PConfiguration (PConfig is now only holding the instance)

- Config & PConfig-Adapter don't need "ConfigCache" anymore

- DB-Connection is now outside App->reload() for better dependency-chaining
2019-02-17 20:40:27 +01:00
Michael
a1a1367d6e Added function description 2019-02-17 19:20:24 +00:00
Michael
061d959e7f Code cleanup 2019-02-17 18:55:17 +00:00
Michael
01d6ba85ff The number of workers per priority is now calculated dynamically 2019-02-17 03:22:29 +00:00
Philipp Holzer
d87a6e5a67
fixed line intends 2019-02-17 02:09:39 +01:00
Philipp Holzer
88fd871844
refactoring & test fixing 2019-02-17 01:18:21 +01:00
Philipp Holzer
0a7861da65
Dependency of callstack moved one layer up 2019-02-16 23:17:10 +01:00
Philipp Holzer
5e6e1a8025
Introducing Profiler 2019-02-16 23:11:30 +01:00
Philipp Holzer
11a7f97fe7
friendica-6667 Installer needs to check fileinfo module 2019-02-16 22:17:34 +01:00
Michael
0845089a0f New scheduler mechanism 2019-02-16 15:03:37 +00:00
Philipp Holzer
b321ef776d
added type-hint 2019-02-14 17:54:34 +01:00
Philipp Holzer
347d959f25
fixing #6652 Manual installer bricked 2019-02-14 17:44:17 +01:00
Michael
ca529d9de7 The process id is currently not supported. 2019-02-14 13:30:41 +00:00
Michael
e20a675953 The setting "worker_fetch_limit" now only has an impact on high priority processes 2019-02-14 06:53:04 +00:00
Michael
f6e8246e75 Ensure that "strtotime" returns the correct timestamp 2019-02-12 06:42:45 +00:00
Hypolite Petovan
5cf5f33a1c
Merge pull request #6640 from annando/worker-stats
Fix worker statistics
2019-02-11 22:00:55 -05:00
Michael
742b472994 Fix: Workerqueue processes had been killed too early 2019-02-11 22:39:59 +00:00
Hypolite Petovan
d6a82c6c2d
Merge pull request #6638 from Ixiter/develop-markdown-anchors
ACL network - fixed preselected acl items
2019-02-11 07:23:32 -05:00
Peter Liebetrau
3dede5dbd2 ACL network - fixed preselected acl items 2019-02-11 10:00:42 +01:00
Michael
f65b35901e Fix worker statistics 2019-02-11 08:59:14 +00:00
Michael
5fc6c0ef38 Fix: Corected config value name 2019-02-11 04:39:24 +00:00
Philipp Holzer
199ceeadbf
Adding ConfigCacheLoaderTest 2019-02-10 13:39:48 +01:00
Philipp Holzer
2a42f8dded
Adding ConfigCacheTest 2019-02-10 12:30:13 +01:00
Hypolite Petovan
b2c2971551
Merge pull request #6619 from annando/worker-again
Furtner improval of the worker speed
2019-02-09 19:50:35 -05:00
Michael
171cfe8f44 Furtner improval of the worker speed 2019-02-09 23:10:15 +00:00
Hypolite Petovan
337c02bd80 Cache config adapter connection status to reduce number of calls to DBA::isConnected() 2019-02-08 20:12:07 -05:00
Hypolite Petovan
3aa77685fc
Merge pull request #6611 from annando/worker-performance
Improved worker performance (changed keys, changed queries)
2019-02-08 17:46:04 -05:00
Michael
5e5a2c3cc1 Improved worker performance (changed keys, changed queries) 2019-02-08 21:48:41 +00:00
Philipp Holzer
cb791024e4
Refactor ConfigMockTrait to mocked ConfigCache 2019-02-07 20:44:03 +01:00
Hypolite Petovan
e6a7c52f7d
Add missing App parameter in addon (un)install calls
Follow-up to #6581 
Fixes https://github.com/friendica/friendica/issues/6386#issuecomment-461080531
2019-02-06 22:28:17 -05:00
Hypolite Petovan
a0b14a46cb
Merge pull request #6581 from nupplaphil/config_refact
Config Refactoring
2019-02-06 09:57:41 -05:00
Michael
b0411b46c4 Separate config options to display the worker jobs per minute 2019-02-06 07:37:45 +00:00
Philipp Holzer
fcd7627c49
method refactoring & docblock 2019-02-06 00:02:25 +01:00
Philipp Holzer
7947db8537
codeblock updates 2019-02-05 23:58:38 +01:00
Philipp Holzer
3cd654e76f
bugfixing ini-loading 2019-02-05 23:47:40 +01:00
Philipp Holzer
62c79e1c4f
codeblock updates 2019-02-05 23:42:49 +01:00
Philipp Holzer
d9e38be4df
Creating legacy config loading method 2019-02-05 23:36:01 +01:00
Philipp Holzer
b79bd63231
move isDirectoryUsable to System 2019-02-05 22:30:18 +01:00
Philipp Holzer
6a9d73f7d9
Refactoring ConfigCacheLoader methods 2019-02-05 22:27:57 +01:00
Philipp Holzer
800dbc7f44
Removed implicit ::getApp() instance and added docblock 2019-02-05 21:54:55 +01:00
Philipp Holzer
4b82e47034
Moved addon directory constant 2019-02-04 09:33:55 +01:00
Philipp Holzer
f779110154
Updating type-hints and some naming conventions 2019-02-04 09:32:13 +01:00
Philipp Holzer
d78ac57514
Updating type-hints and some naming conventions 2019-02-04 09:30:48 +01:00
Philipp Holzer
1c51d7d22f
Typo at addon-directory-name ... 2019-02-04 02:21:23 +01:00
Philipp Holzer
bdfe0c35fb
Typo at addon-directory-name ... 2019-02-04 02:14:20 +01:00
Philipp Holzer
f2f8c97b7c
Bugfixing Addon-config 2019-02-04 02:06:15 +01:00
Philipp Holzer
d6dd74690d
Bugfixing Config output for memcached_hosts[] 2019-02-04 01:19:01 +01:00
Philipp Holzer
90e88d6c35
Bugfixing AutomaticInstallation test 2019-02-04 00:04:16 +01:00
Philipp Holzer
bc73d4bd2b
Adding descriptions 2019-02-03 23:39:30 +01:00
Philipp Holzer
f3da5b3a2f
Bugfixing PConfig 2019-02-03 23:22:05 +01:00
Philipp Holzer
1e0e1674f2
4) Adding Factories to other entrypoints 2019-02-03 22:46:50 +01:00
Philipp Holzer
4af0119b73
3) Introducing ConfigFactory 2019-02-03 22:22:04 +01:00
Philipp Holzer
5c50684b50
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:32:31 +01:00
Philipp Holzer
f40c57fc20
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:05:44 +01:00
Philipp Holzer
d43a8184f4
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:04:41 +01:00
Philipp Holzer
be6b229534
1) Refactor App->config[] into Core\Config 2019-02-03 18:54:25 +01:00
Philipp Holzer
433d6abe8c
Refactoring DBA-mocking tests
- Reducing DB-dependencies
- Creating DB-cache mocks
- Creating DB-lock mocks
- Switching to mocked dependencies for Cache/Lock/App
2019-02-02 19:03:15 +01:00
Hypolite Petovan
64847e7cc8 Fix types in doc blocks/prototypes 2019-01-23 09:06:58 -05:00
Hypolite Petovan
25b8628762 Fix missing new in throw calls in Core\StorageManager 2019-01-21 11:12:51 -05:00
Hypolite Petovan
78931afa6f Fix error message in Console\GlobalCommunityBlock 2019-01-21 11:12:50 -05:00
Hypolite Petovan
7f2dc40601 Fix potential bugs without expected behavior change
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Philipp Holzer
1b802548b2 revert phpdoc change 2019-01-21 10:54:41 -05:00
Philipp Holzer
9e0be97703 Bugfixing legacy loglevel 2019-01-21 10:54:41 -05:00
Philipp Holzer
282507922a Reset map function name 2019-01-21 10:54:41 -05:00
Philipp Holzer
b5afd2a21d change regex for fail2ban 2019-01-21 10:54:40 -05:00
Philipp Holzer
aa15c0e094 Bugfixing Monolog
- Default Loglevel for logs set to 'info'
- Default config level is set to 'notice'
- using 'notice' for auth-failures
- Bugfixing wrong usage of legacy 'log()'
2019-01-21 10:54:39 -05:00
Hypolite Petovan
4a95ca280d Remove unused code
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
Hypolite Petovan
d1c6ec9718 Update namespaces declaration in include/
- Remove unused use statements
- Add required use statements
2019-01-21 10:44:45 -05:00
Hypolite Petovan
14e4ab544a Update namespace use calls in mod/ 2019-01-21 10:44:21 -05:00
Hypolite Petovan
cb3f09ae4f Refactor namespaces
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
Hypolite Petovan
070aa016e0 Update more PHPDoc, including in include/ 2019-01-21 10:39:28 -05:00
Hypolite Petovan
af9067a381 Update PHPDoc in mod/ 2019-01-21 10:39:27 -05:00
Hypolite Petovan
3282ce5389 Fix PHPDoc comments project-wide 2019-01-21 10:35:51 -05:00
Philipp Holzer
2e602afd3e Add Monolog 2019-01-21 10:10:40 -05:00
fabrixxm
518f28a7bf Small fixes
- Avoid an intermediate variable
- Use `rawContent()` in `Attach` module
- Small typo
2019-01-21 10:08:09 -05:00
Hypolite Petovan
2f49c4a058 Revert "Add monolog" 2019-01-21 10:08:09 -05:00
fabrixxm
24d7ffa3fe Update "storage" console command
add support to move data in 'attach' table
2019-01-21 10:00:48 -05:00
Philipp Holzer
6e48df2163 Refactor Loglevels 2019-01-21 10:00:46 -05:00
Philipp Holzer
6150c2fa9c Bugfixing 2019-01-21 09:59:11 -05:00
Philipp Holzer
8f9c0fe149 Adding Develop and normal Logging instances 2019-01-21 09:59:08 -05:00
Philipp Holzer
fe8f0e0045 Add Monolog 2019-01-21 09:58:05 -05:00
Jeroen De meerleer
2bfc3d1a0c begone 2019-01-21 09:50:59 -05:00
Jeroen De Meerleer
33f7fd72ca Enable logged in users to force a certain language 2019-01-21 09:50:58 -05:00
Jeroen De Meerleer
b440b4c338 Updated towards code standards 2019-01-21 09:50:58 -05:00
Jeroen De meerleer
e0777b6bc9 forcing language by parameter 2019-01-21 09:50:58 -05:00
Hypolite Petovan
55e54bb950 Replace deprecated Addon::callHooks with Hook::callAll
- Update documentation
2019-01-21 09:50:56 -05:00
Hypolite Petovan
895b3abf32 Remove/replace killme() with *exit() 2019-01-21 09:49:17 -05:00
fabrixxm
b2211d31b9 Fix StorageManager::move() 2019-01-21 09:12:37 -05:00
fabrixxm
8addcf9844 Fix storage backend class names
This should be tested on all supported PHP versions
2019-01-21 09:12:32 -05:00
fabrixxm
2f935a1fbf Fix unregister storage backend 2019-01-21 09:12:30 -05:00
fabrixxm
f2b29f6591 Fix moving stored data 2019-01-21 09:12:30 -05:00