Commit graph

2538 commits

Author SHA1 Message Date
Philipp
c17bc55158
Introduce InvalidClassStorageException and adapt the code for it 2021-08-16 23:27:42 +02:00
Philipp
d0536ebea7
Rename ISelectableStorage to IWritableStorage 2021-08-16 23:27:42 +02:00
Philipp
eb035771f1
Revert Photo::getImageDataForPhoto return-type change 2021-08-16 23:27:42 +02:00
Philipp
57438afbb3
- Moved the description for the specific storage exception first
- Introduced exceptions for try to get invalid storage
- ReferenceStorageException now extends StorageException
2021-08-16 23:27:42 +02:00
Philipp
470ba8b61b
Fixup Database behaviour 2021-08-16 23:27:42 +02:00
Philipp
90c99520bb
Fix Storage Exceptions 2021-08-16 23:27:42 +02:00
Philipp
29c7552df5
Refactor IStorage 2021-08-16 23:27:42 +02:00
Philipp
5dcdf2322e
Split IStorage and ISelectableStorage and make their behaviour homogenous 2021-08-16 23:27:41 +02:00
Michael
7158b35f58 Added logging, removed superfluous comments 2021-08-16 15:23:34 +00:00
Hypolite Petovan
7082582655 Add the attachments to the $item for the prepare_body_content_filter hook
- Allows filtering on attachments that are added later to the post content
2021-08-16 05:28:08 -04:00
Michael
c85ce2f6b0 Add a payload 2021-08-16 06:11:26 +00:00
Michael
69c816eb17 Trim whitespace 2021-08-15 22:09:32 +00:00
Michael
e3f8f371a7 Use the existing VAPID key generation 2021-08-15 21:54:24 +00:00
Michael
69f11c4a84 Adding the VAPID keys 2021-08-15 21:24:23 +00:00
Michael
977d28353c Transmit push subscriptions 2021-08-15 20:52:46 +00:00
Michael
c78d490c2e Some more standards 2021-08-15 16:24:12 +00:00
Michael
f29cef175e Remove spaces 2021-08-15 16:22:23 +00:00
Michael
19f3cad56c Preparation for creating push notification 2021-08-15 16:18:25 +00:00
Michael
5056376902 We need to create a vapid public and private key 2021-08-15 12:57:29 +00:00
Michael
74f3cbc383 Improved error check, added "put" 2021-08-15 07:28:26 +00:00
Michael
167a12ef54 Styling 2021-08-15 00:43:07 +00:00
Michael
e28a4265c5 API: First steps to support subscriptions 2021-08-15 00:30:41 +00:00
Michael
ce46ab2573 The Matrix and XMPP address is now transported via AP as well 2021-08-10 23:49:09 +00:00
Michael
8e074a5fe4 Simplify event storing 2021-08-10 10:24:14 +00:00
Michael
15b93b4459 "getUserNickname" is now "getLoggedInUserNickname" 2021-08-09 19:48:39 +00:00
Michael
4495e83eca Merge remote-tracking branch 'upstream/develop' into app-user2 2021-08-09 15:32:32 +00:00
Michael
b8fa75b2dd Changed function name 2021-08-09 15:29:07 +00:00
Michael
bee04f86ee Matrix addresses can be entered in the profile 2021-08-09 01:39:09 +00:00
Michael
28090bd793 Get rid of App->user completely 2021-08-08 19:30:21 +00:00
Michael
fc283ab928 Remove direct calls to App->user 2021-08-08 10:14:56 +00:00
Michael
9664efd66b Added some description 2021-08-07 20:09:25 +00:00
Michael
6a23b17c95 Respect the postopts values for scheduled posts 2021-08-06 18:49:17 +00:00
Michael
4bc3e8c141 Don't send "accept" when we accept anything 2021-08-06 04:02:22 +00:00
Michael
835152d418 Simplified signature creation 2021-08-05 08:42:46 +00:00
Michael
a26a2a0228 Make the system owner ready for Diaspora 2021-08-05 08:30:44 +00:00
Michael Vogel
c73130aa6b Create the Diaspora signature for the correct user 2021-08-05 08:58:50 +02:00
Michael
ec3eead034 Don't set the pconfig values on manual mode 2021-08-03 05:39:04 +00:00
Michael
6c8a4a2552 Use a centralized function to delete delayed entries 2021-08-02 20:56:34 +00:00
Michael
2e2d1bf81d Added option to define a schedule date when posting items 2021-08-01 13:01:31 +00:00
Michael
929de9081e All needed fields are now filled 2021-07-30 13:22:06 +00:00
Michael
4137a6250b Delayed now return their id on insert 2021-07-30 06:20:10 +00:00
Michael
5e75ba3083 guid function is now public 2021-07-30 06:19:25 +00:00
Michael
a1828430e5 Fixing variables 2021-07-29 14:58:04 +00:00
Michael
20e69c1e71 Return as array 2021-07-29 10:46:40 +00:00
Michael
6ea3d4aa61 Added API calls, removed fields 2021-07-29 10:34:31 +00:00
Michael
fbbe9a3c1f "wid" is not an item field 2021-07-29 03:57:37 +00:00
Michael
2951243b07 Preparation for delayed posts 2021-07-28 22:22:00 +00:00
Hypolite Petovan
dfb043ce60 Add Exception for empty User::getOwnerDataById(0 return case in Protocol\ActivityPub\Transmitter::getProfile()
- Address https://github.com/friendica/friendica/issues/10473#issuecomment-882781552
- Add try-catch blocks to all references of Protocol\ActivityPub\Transmitter::getProfile()
2021-07-27 16:46:08 -04:00
Michael
9226b98724 Performance: Moved filter call after content generation 2021-07-27 12:24:22 +00:00
Michael
c89533a70b Support for stacked profiler analysis 2021-07-27 04:57:29 +00:00
Michael
5a87ccf026 Getter/Setter for theme info 2021-07-25 19:39:10 +00:00
Michael
866dbf9f89 Use getter/setter for timezone value 2021-07-24 21:16:53 +00:00
Michael
8f46064430 Using getter/setter functions 2021-07-24 20:34:07 +00:00
Michael
d56793dd09 Fix field name 2021-07-24 13:24:26 +00:00
Michael
30aad250df App->contact is now removed 2021-07-24 11:49:11 +00:00
Michael
0fe5759d8a Fixed avatar fetching for mail and feed 2021-07-24 10:32:55 +00:00
Michael
2502a9192d Many more app-variables removed 2021-07-24 10:09:39 +00:00
Michael
c17e1d7e0b Removed unused code from the profile sidebar 2021-07-23 13:05:53 +00:00
Michael
afe3c8954c Simplified functionality to load the profile in the sidebar 2021-07-23 12:39:37 +00:00
Michael
bb222209bc Some small performance tweaks 2021-07-22 15:35:30 +00:00
Michael
69c6a5f567 Avoid "DB Error" messages 2021-07-21 03:43:30 +00:00
RealKinetix
cf32a4b7cc Sanitize negative status count on APContact
Similar to PR #10499, Mastodon apparently has some counting flaws and
can present a negative status count for a user, causing Friendica to
fail (at least under PHP 8) with:

[20-Jul-2021 16:35:18 UTC] PHP Fatal error:  Uncaught PDOException: SQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'statuses_count' at row 1 in /home/friendicadev/friendica/src/Database/Database.php:560
Stack trace:
  thrown in /home/friendicadev/friendica/src/Database/Database.php on line 560

This change prevents values lower than 0 from being assigned to
statuses_count.
2021-07-20 10:11:04 -07:00
Hypolite Petovan
f3131c6277 Manually add Persian to post body language detection 2021-07-19 14:00:31 -04:00
Michael
d2408c1f1b Merge remote-tracking branch 'upstream/develop' into loop-prevention 2021-07-19 12:07:34 +00:00
Michael
64026ed979 Simplify code 2021-07-19 12:07:02 +00:00
Michael
58cec97358 Merge remote-tracking branch 'upstream/develop' into loop-prevention 2021-07-19 07:51:29 +00:00
Michael
2647514603 Detection of local requests 2021-07-19 06:14:14 +00:00
Michael
aa6313dee6 Improved detection for a local contact 2021-07-19 04:15:57 +00:00
Michael
424a85bb94 Fetch local data without HTTP requests 2021-07-18 18:54:25 +00:00
Michael
d8bf9c4601 Prevent loop also when fetching the outbox 2021-07-18 16:42:55 +00:00
Michael
2030691f9f Improved event storing / improved performance when fetching events 2021-07-18 15:05:46 +00:00
Michael
ea056b93fa Fix notice in events 2021-07-17 20:27:18 +00:00
Michael
dd2abf254d Issue 10506 - again. Improved check for pictured in body 2021-07-17 07:55:19 +00:00
Michael
596bb9fa7c Fixed wrong parameter 2021-07-17 05:25:04 +00:00
Michael
89f7ee2cc5 Prevent endless loop when updating contact by probe 2021-07-17 04:57:21 +00:00
Michael
feab53b58b Issue 10506: Fix for multiple picture posts 2021-07-17 04:32:46 +00:00
Hypolite Petovan
4dc6b29046
Merge pull request #10503 from annando/no-legacy-dfrn
Legacy DFRN transport layer is removed
2021-07-15 16:24:07 -04:00
Michael
c1e681e007 Improved comment 2021-07-15 17:42:03 +00:00
Michael
3a5523820c Legacy DFRN transport layer is removed 2021-07-15 13:28:32 +00:00
RealKinetix
a0107be2af Negative numbers in following is a thing too
Check & sanitize 'following' as well, as per:
https://mastodon.social/@BLUW
2021-07-14 13:51:30 -07:00
RealKinetix
f16b1df83f Adjust where the code is to avoid empty warning
Shifted the code to avoid:
PHP Warning:  Undefined array key "totalItems" in /home/friendicadev/friendica/src/Model/APContact.php on line 277
2021-07-14 13:46:38 -07:00
RealKinetix
c1db1c980e Fix indent to standards 2021-07-14 12:17:03 -07:00
RealKinetix
2ebebe9abc Sanitize negative followers count on APContact
Please see
https://github.com/friendica/friendica/issues/9498#issuecomment-818894106
and related discussion regarding this - it appears it's possible for AP
users, maybe just Mastodon users, to have a negative followers count.
This causes fatal errors in Friendica, so I think we should sanitize
this input.
2021-07-14 10:15:19 -07:00
Michael
0277589fbd Removed experimental code 2021-07-14 02:59:29 +00:00
Michael
6fceab0cc8 Merge remote-tracking branch 'upstream/develop' into subscribe 2021-07-14 02:54:12 +00:00
Michael
1466afe3b2 Automatically subscribe to the followings of a given AP account 2021-07-13 06:06:08 +00:00
Michael
e5c312a066 Issue 10491: Possibility for simple shortening added 2021-07-12 14:11:51 +00:00
Michael
e151a2dc41 Fixes "Undefined index: nick" 2021-07-12 06:25:48 +00:00
Michael
d267ba999c We now use the new account-user-view (and fixed the function name) 2021-07-11 09:39:34 +00:00
Michael
b46b88cc10 Fix fatal error 2021-07-10 21:08:55 +00:00
Michael
07d2dfcd60 Some more "convertForUriId" replacements 2021-07-10 12:58:48 +00:00
Michael
e0fdde3287 Fix the tests, hopefully 2021-07-09 17:13:54 +00:00
Michael
04580ad4fb Don't update automatically to make tests happy 2021-07-09 16:20:22 +00:00
Michael
0735a22cdd Fix notice "undefined index: uri" 2021-07-09 14:52:22 +00:00
Michael
9ac284ec3a Update on empty uri-id 2021-07-09 08:46:42 +00:00
Michael
6e79da0b0c The uri-id is now in all contact tables 2021-07-09 07:09:33 +00:00
Michael
c63d3f4604 Fix tests 2021-07-09 06:37:45 +00:00
Michael
d8974c9a2a Function renamed to better reflect the functionality 2021-07-09 06:29:24 +00:00
Michael
88f147c6a7 Always update on missing uri-id, check for uri-id in contact before removal 2021-07-09 04:38:36 +00:00
Michael
901c3f4855 we now have got an uri-id field for the contact table 2021-07-08 18:59:58 +00:00
Michael
178bc543e3 New founction to count threads 2021-07-08 17:32:41 +00:00
Michael
c972cce740 Avoid notice 2021-07-08 16:38:02 +00:00
Michael
165c6ddc63 "convert" changed to "convertForItem" 2021-07-08 15:41:46 +00:00
Michael
f29bd23ea8 New function to convert BBCode for a given ID 2021-07-08 13:47:46 +00:00
Michael
f3452d86c4 Improved logging, improved link check 2021-07-06 17:40:40 +00:00
Michael
ecf0b67d9d Just look at HTTP links 2021-07-06 16:10:10 +00:00
Michael
234bdff7ab Improved link check 2021-07-06 15:06:15 +00:00
Michael
098cd543ea Cleaned code for contact avatars 2021-07-06 10:36:00 +00:00
Michael
8bfa15cf23 Simplify the attachment handling 2021-07-06 08:57:49 +00:00
Michael
93309a3728 Quit on empty uri-id 2021-07-06 06:45:53 +00:00
Michael
cdc18387fd Use the uri-id directly in the bbcode converter 2021-07-06 05:25:30 +00:00
Michael
f8ce59b411 Use the post uri-id for false reshares 2021-07-06 04:36:45 +00:00
Michael
903c646a62 Style 2021-07-05 19:42:17 +00:00
Michael
aed5e4cc96 New struture for post related links 2021-07-05 18:45:49 +00:00
Michael
90588ddb8e Avoid proxyfying images that are removed or replaced later 2021-07-05 07:00:35 +00:00
Michael
7188ed745c Merge remote-tracking branch 'upstream/develop' into proxy 2021-07-05 03:44:15 +00:00
Michael
b09f555f4f Merge remote-tracking branch 'upstream/develop' into notice 2021-07-05 03:03:41 +00:00
Michael
1b6d0f8b1f Fix notice "Undefined index: account-type" 2021-07-04 21:26:08 +00:00
Michael
e519b782fd Simplified proxy handling 2021-07-04 21:24:49 +00:00
Michael
dfc1b1e7a5 Allow search for only locally published contacts 2021-07-04 19:58:02 +00:00
Michael
f0268b57be Use "getOwnerDataById" and "getOwnerDataByNick" to fetch owner data 2021-07-04 17:25:08 +00:00
Michael
582fd613e0 Ensure that the network is set for "self" contac ts 2021-07-04 14:17:10 +00:00
Michael
74a0bfc6da Ensure to not update the "self" contact 2021-07-04 12:38:35 +00:00
Michael
87cc17337b Fix local follow (and local contact data update) 2021-07-04 12:35:48 +00:00
Michael
f37e808e02 Fix test 2021-07-03 15:47:11 +00:00
Michael
c72abe48a8 Fixed fetching private local images 2021-07-03 15:29:27 +00:00
Hypolite Petovan
dfd711d111
Merge pull request #10450 from annando/discoverable
AP: Support "discoverable"
2021-06-30 21:16:11 -04:00
Michael
e2dc36a691 AP: Support "discoverable" 2021-06-30 05:40:11 +00:00
Michael
ec49afa116 Guess the mimetype in advance 2021-06-30 04:28:03 +00:00
Michael
19aef93560 Unified avatar paths 2021-06-29 20:26:58 +00:00
Michael
9edc75e29d Improved avatar handling (timestamps for caching) 2021-06-29 06:15:45 +00:00
Michael
2f06d271bb Use a default value for "uid" 2021-06-28 13:58:06 +00:00
Michael
a1a584f444 External resources are cacheable 2021-06-28 13:09:00 +00:00
Michael
8ac9b37176 Merge remote-tracking branch 'upstream/2021.06-rc' into proxy2 2021-06-28 10:11:41 +00:00
Michael
6f350c1e59 Use signed requests for fetching private images 2021-06-28 10:08:51 +00:00
Michael
7e200174d6 Replace attachment links in the body 2021-06-28 04:53:20 +00:00
Hypolite Petovan
faac5b71ce
Merge pull request #10437 from annando/reduce-proxy
Reduce the usage of the "proxifyUrl" function
2021-06-27 22:41:14 -04:00
Hypolite Petovan
005ba8c388
Merge pull request #10435 from nupplaphil/feat/di_cleanup
Add constructor injection for ExternalResource Storage
2021-06-27 21:02:03 -04:00
Michael
b46b7b08ba Reduce the usage of the "proxifyUrl" function 2021-06-27 11:50:10 +00:00
Philipp
b5acc07eaf
Add todo for develop phase 2021-06-26 21:17:10 +02:00
Michael
de2898988b Inverted condition 2021-06-26 11:31:37 +00:00
Michael
258d5fa695 Issue 10433: Only notify when there had been changes 2021-06-26 11:29:58 +00:00
Philipp
f1f3fa7216
Add constructor injection for ExternalResource 2021-06-25 20:13:50 +02:00
Michael Vogel
d9d30d9555
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-06-25 20:00:59 +02:00
Michael
ed4a18f079 Function to return the avatar and header path for a given contact id 2021-06-25 17:03:35 +00:00
Michael
ee25246e41 Standards 2021-06-24 17:37:50 +00:00
Michael
9276f6823b New class for external resources 2021-06-24 17:30:22 +00:00
Michael
96809b3fdd API: Improved avatar handling 2021-06-24 07:08:38 +00:00
Michael
d5e5a6ea23 Fix fatal error: Uncaught TypeError: Argument 1 passed to Friendica\Model\Post\Media::existsByURIId() must be of the type int, null given 2021-06-21 03:53:53 +00:00
Michael
7dd5ea42e9 An empty user id does not have children 2021-06-19 06:27:25 +00:00
Michael
fe07dc828b Fix noscrape publishing and pulling, added header 2021-06-17 11:23:32 +00:00
Michael
ebd4f59d02 Merge remote-tracking branch 'upstream/2021.06-rc' into public-timeline 2021-06-16 21:01:20 +00:00
Michael
11d2440425 New functions for the post-view view 2021-06-16 10:16:01 +00:00
Michael
5211c12b0c Merge remote-tracking branch 'upstream/2021.06-rc' into public-timeline 2021-06-16 05:58:11 +00:00
Michael
3796e13142 Force a directory update if previously published 2021-06-16 05:23:43 +00:00
Michael
1ced04e54c Merge remote-tracking branch 'upstream/2021.06-rc' into profile-publish 2021-06-16 05:01:16 +00:00
Michael
c17f23423f Chec for missing profile first 2021-06-15 22:01:30 +00:00
Michael
e994d02791 Add a profile entry if missing 2021-06-15 21:39:28 +00:00
Michael
0ab24510ef Centzralized functionality to update and publish profile changes 2021-06-15 11:12:44 +00:00
Michael
d348e4afca Possibly fixes notice "Undefined index: private in .../src/Model/Item.php on line 3115" 2021-06-14 18:34:11 +00:00
Michael
24cc82f396 API: (hopefully) improves speed of the public timeline 2021-06-12 15:19:56 +00:00
Michael
56f07d412b Addec comments on forum delivery 2021-06-06 10:07:21 +00:00
Michael
73b0af52fb Use "self" 2021-06-06 09:24:12 +00:00
Michael
b269a2da87 Respect the "unlisted" setting for forum posts 2021-06-06 09:19:29 +00:00
Michael
e2b8d5379b Public forums are now posting unlisted 2021-06-05 18:38:21 +00:00
Michael
8a9f633ce2 Merge remote-tracking branch 'upstream/2021.06-rc' into forum-handling 2021-06-05 06:14:06 +00:00
Michael
98c314599c Don't lose ownership on forum posting 2021-06-05 06:13:10 +00:00
Michael
5df1b59bb3 Fix "Undefined index: post-type in .../src/Model/Item.php on line 2888" 2021-06-02 17:43:30 +00:00
Michael
842cbbaf09 Added notifications for follow requests 2021-06-01 21:13:16 +00:00
Michael
49459821be Renamed function 2021-06-01 14:23:12 +00:00
Michael
3f0937dd42 API: Show activity notifications 2021-06-01 05:51:03 +00:00
Hypolite Petovan
d99286640d
Merge pull request #10348 from annando/fix-diaspora-comment
Fix commenting on mobile to Diaspora
2021-05-31 19:27:53 -04:00
Michael
be7a01f086 Fix commenting on mobile to Diaspora 2021-05-31 19:39:50 +00:00
Hypolite Petovan
52cf924558 Check for post-type key existence in Model\Item::addVisualAttachments
- Address https://github.com/friendica/friendica/issues/10169#issuecomment-844324800
2021-05-31 08:29:50 -04:00
Hypolite Petovan
302070875c Ensure nodeinfo-provided protocols are strings in Model\GServer::parseNodeinfo2
- https://github.com/friendica/friendica/issues/10168#issuecomment-828281803
2021-05-31 00:47:03 -04:00
Philipp
bdc2cd000b
Update avatar after user creation 2021-05-30 20:47:21 +02:00
Michael
2df14fab3b Ensure that the public contact exists when a user is created 2021-05-30 12:04:26 +00:00
Michael
6f730bd671 Add relevant link after media links had been removed 2021-05-30 06:13:20 +00:00
Michael
0249048534 More logging for the contact discovery 2021-05-29 17:24:50 +00:00
Michael
b28acc7dad Improved logging for local probing, avoid worker fork 2021-05-29 11:11:26 +00:00
Michael
c6a56985a8 Changed comments 2021-05-26 18:15:07 +00:00
Michael
016911a20c Setting the post reason and causer 2021-05-26 14:21:28 +00:00
Michael
785f8124ed Issue 10306: Improve local delivery 2021-05-26 09:24:37 +00:00
Michael
09f29cd577 Avoid notices because of empty fields 2021-05-25 13:11:23 +00:00
Michael
da8d5f5015 Issue 9926: Limit the length of data to store in the apcontact table 2021-05-24 19:44:24 +00:00
Hypolite Petovan
a24febb8b6
Merge pull request #10283 from very-ape/fix-message-button
Fix message button using a more targeted approach.
2021-05-23 18:49:21 -04:00
very-ape
7776c5f690 Implement code changes from review. 2021-05-23 13:25:25 -07:00
Tobias Diekershoff
0ca929dccd
Merge pull request #10304 from annando/fix-emptymissing-photos
Fix missing media on posts to Mastodon
2021-05-23 15:34:34 +02:00
Michael
36c5e360f6 Fix missing media on posts to Mastodon 2021-05-23 13:29:25 +00:00
Michael
b7a7ae58e9 Issue 10232: Improved search for embedded media links 2021-05-23 12:35:05 +00:00
Michael Vogel
d00a4eacdc
Update src/Model/Mail.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-23 07:37:17 +02:00
very-ape
b2bc911eb2 Merge branch 'fix-message-button' of https://github.com/very-ape/friendica into fix-message-button 2021-05-22 15:32:08 -07:00
very-ape
ceb409dae8 Replace $contact with $profile_contact in sidebar function. 2021-05-22 15:30:46 -07:00
Michael
c18cbe95a6 Fix inserting mails 2021-05-22 18:20:11 +00:00
Michael
6fe916a390 API: improved mail handling 2021-05-22 13:37:04 +00:00
Michael
0c21588ab9 Don't delete local tombstone contacts 2021-05-22 08:25:30 +00:00
very-ape
bd9a469392
Merge branch '2021.06-rc' into fix-message-button 2021-05-21 23:40:49 -07:00
very-ape
34eb81a187 Don't retrieve a contact record we've already been given. 2021-05-21 22:49:35 -07:00
Michael
9d4b29d9c0 Fix for empty profile pages 2021-05-22 05:34:10 +00:00
very-ape
c22ef3e79e Fix message button using a more targeted approach. 2021-05-21 14:28:01 -07:00
Hypolite Petovan
26d3f5433b
Merge pull request #10280 from very-ape/fix-message-button
Fix Message button.
2021-05-21 14:57:28 -04:00
very-ape
97a9ec4e40 Bug fix: last commit results in logged-in user's contacts being displayed on contact profile sidebar. 2021-05-21 11:38:50 -07:00
very-ape
93926e99b8 Use getByNickname as suggested in code review. 2021-05-21 10:15:32 -07:00
very-ape
fe52719d37 Fix Message button. 2021-05-20 23:30:42 -07:00
Hypolite Petovan
315dddbcb9
Merge pull request #10277 from very-ape/authenticate-hook
Bug fix: allow authentication addons to create users again.
2021-05-20 15:05:55 -04:00
very-ape
e2d93b57da
Update src/Model/User.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-20 11:54:30 -07:00
very-ape
d66f1e30ae Apply suggestions from code review
Also clean up some code, make it less needlessly verbose.

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-20 11:35:33 -07:00
Hypolite Petovan
0e368c4ba4 Fix display of RTL tags 2021-05-20 08:39:36 -04:00
very-ape
c89241dbd8 Bug fix: add missing changes. 2021-05-20 00:19:09 -07:00
very-ape
9ab57de356 Bug fix: allow authentication addons to create users again. 2021-05-20 00:16:08 -07:00
Hypolite Petovan
09cf32926d
Merge pull request #10275 from very-ape/authenticate-hook
Move the 'authenticate' hook deeper into the authentication flow so t…
2021-05-19 16:51:15 -04:00
very-ape
9ddaabc22d Move the 'authenticate' hook deeper into the authentication flow so that password authentication addons are consulted whenever a user's password needs confirming. 2021-05-19 13:11:31 -07:00
Michael
916c51c630 Fix fatal errors / added some API todo 2021-05-17 19:20:31 +00:00
Michael
48d703d278 Fiy missing "in" 2021-05-17 06:03:14 +00:00
Michael
2e6cf056c1 Whitespace removed 2021-05-17 06:01:47 +00:00
Michael
cb7206d92f Reverted yesterdays panic coding 2021-05-17 05:59:41 +00:00
Hypolite Petovan
a44cf44708
Remove duplicated conditions, improve variables names in Model\APContact 2021-05-16 16:10:22 -04:00
Michael
6f2fcd2859 Don't use compacted data when parsing accounts 2021-05-16 16:41:07 +00:00
Michael
dd16bccbc8 Fix for sending content via connectors 2021-05-16 14:30:15 +00:00
Michael
14c1f7167a API: We now can upload photos 2021-05-16 09:56:02 +00:00
Michael
45c2cc3887 API: Account actions 2021-05-14 21:51:32 +00:00
Michael
5219080149 Fix url comparism 2021-05-13 15:01:35 +00:00
Michael
7975bc244d Refine OAuth flow 2021-05-13 11:26:56 +00:00
Michael
4476634f6c Fix list of accounts 2021-05-11 23:39:08 +00:00
Michael
e9fe92a5d7 Merge remote-tracking branch 'upstream/develop' into api-again 2021-05-11 21:21:32 +00:00
Hypolite Petovan
cac038639d Capitalize post action translation strings 2021-05-11 16:01:07 -04:00
Michael
bade0a2345 Improved cards handling, simplified Bearer handling 2021-05-11 19:15:05 +00:00
Tobias Diekershoff
7789ea2507
Merge pull request #10228 from MrPetovan/bug/warnings
[PHP 8] Fix undefined template variables
2021-05-11 06:10:29 +02:00
Hypolite Petovan
48ac619599 Check unparseURL parameter type in APContact::getByURL
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-832421258
2021-05-10 21:52:26 -04:00
Hypolite Petovan
abc0616d33 Fix undefined variables in profile/vcard.tpl 2021-05-10 18:59:49 -04:00
Hypolite Petovan
2c6bf754d5 Fix undefined variables in wall_thread.tpl
- Remove unused "num_comments_text" template variable
- Remove unused "item.postops" template variable mention
2021-05-10 18:59:09 -04:00
Michael
f5c7f9670f Remove blanks 2021-05-09 11:54:34 +00:00
Michael
5bb5c44bd9 API: added account related endpoints 2021-05-09 09:35:51 +00:00
Michael
3bbf543d25 API: Some more endpoints 2021-05-08 19:21:52 +00:00
Michael
d842a4ff87 Suggestions are now supported as well 2021-05-08 11:03:50 +00:00
Michael
dd38cc330f API: We now support two more timeline api endpoints 2021-05-07 21:28:48 +00:00
Michael
6be6803983 Improved code structure 2021-05-07 11:41:10 +00:00
Michael
95f741c427 Improve data of shared posts 2021-05-07 06:26:41 +00:00
Michael
f683f791ee Avoid duplicated attachments / unwanted attachments 2021-05-05 16:46:55 +00:00
Michael
be29a42d74 Ignore identical provider and author 2021-05-04 06:08:40 +00:00
Michael
b3e511eb0c No link guessing for DFRN / Don't show redundant data 2021-05-04 05:18:03 +00:00
Michael
77e1ec6df2 Improved link detection 2021-05-02 17:33:32 +00:00
Michael
73c0bff665 Add missing provider url and name 2021-05-01 17:03:50 +00:00
Michael
4b12c54345 API: photos are now directly stored as attached data and not in the body anymore 2021-05-01 15:48:19 +00:00
Michael
6f7e063b34 Fixes "PHP Notice: Undefined variable: item in src/Model/Post/Media.php on line 561" 2021-05-01 07:10:27 +00:00
Michael
3217de30fa Merge branch 'avoid-duplicates' of github.com:annando/friendica into avoid-duplicates 2021-04-30 22:35:20 +00:00
Michael
c840ee82af Avoid empty posts on Diaspora 2021-04-30 22:35:16 +00:00
Michael Vogel
4889e82489
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-04-30 22:31:24 +02:00
Michael
3666742e7b Added comment 2021-04-30 06:11:13 +00:00
Michael
75a90f5e5d Avoid problems with an empty body 2021-04-30 04:45:31 +00:00