Friendica/friendica-github
1
0
Fork 0
mirror of https://github.com/friendica/friendica synced 2024-12-26 06:40:21 +00:00
Code Issues Projects Releases Packages Wiki Activity
21171 commits 3 branches 64 tags 237 MiB
Commit graph

2066 commits

Author SHA1 Message Date
Michael
9171b2a0f3 It's possibly better to use context links that do exist 2018-10-04 09:46:29 +00:00
Michael
06a59c8312 Funkwhale documentation added 2018-10-04 05:29:22 +00:00
Michael
72fc89d033 Simplified attachment handling 2018-10-04 05:26:00 +00:00
Michael
f6277970fa Added some to-do 2018-10-03 19:35:01 +00:00
Michael
11a7f6c3e1 Unused "use" removed 2018-10-03 19:17:40 +00:00
Michael
cbfc3d0c28 Fix error / "about" is now converted to BBCode 2018-10-03 19:00:32 +00:00
Michael
221e197658 Tags are now transmitted as expected 2018-10-03 18:27:01 +00:00
Michael
a9a1ac808b Attachments do work now 2018-10-03 17:36:55 +00:00
Jonny Tischbein
ee32459358 goaway with argument 2018-10-03 18:28:04 +02:00
Michael
78a7e130ae Another renamed function 2018-10-03 15:50:21 +00:00
Michael
8841519c0d Renamed functions 2018-10-03 15:41:51 +00:00
Jonny Tischbein
3c9b33176f Static reason for login failure to prevent bruteforce 2018-10-03 14:32:16 +02:00
Jonny Tischbein
3ecabe0291 Fix goaway url when login failed + using info to display message 2018-10-03 13:10:49 +02:00
Michael
1fe55679fc Moved documentation 2018-10-03 09:53:12 +00:00
Michael
acd1caa114 The function is only needed in the same class 2018-10-03 09:45:54 +00:00
Michael Vogel
ec898ecd2a
Merge pull request #5792 from MrPetovan/task/add-cache-console 
Add Cache console
 2018-10-03 11:17:43 +02:00
Michael
3ab837f3c7 Functionality is now split 2018-10-03 09:15:38 +00:00
Michael
4d2e5c2bbe AP class will be split in processor, receiver and transmitter 2018-10-03 06:15:07 +00:00
Hypolite Petovan
2a7327a41c
Fix spaces in Cache\Memcachedriver 2018-10-03 00:24:26 -04:00
Michael
76cdc9e594 Renamed class 2018-10-02 20:14:28 +00:00
Michael
518d461a8f Issue 5811: "objects" instead of "object" 2018-10-02 20:12:38 +00:00
Hypolite Petovan
505350c9fb
Merge pull request #5794 from annando/ap1 
ActivityPub support
 2018-10-02 11:24:04 -04:00
Michael
3020b0fdc4 Fix missing mentions 2018-10-02 14:48:57 +00:00
Michael
fcfd04bcc9 Normalize the mentions and ensure to not have duplicates 2018-10-02 09:04:32 +00:00
Michael
d4f6261b81 Avoid notice 2018-10-02 08:31:58 +00:00
Michael
6020605d5c Account deletion could work now. 2018-10-01 19:22:13 +00:00
Michael Vogel
103535d620
Merge pull request #5773 from MrPetovan/task/rewrite-js-hooks 
Rewrite JS hooks
 2018-10-01 17:10:30 +00:00
Michael
72c3a62e7f Profile update is now done via APDelivery 2018-10-01 05:44:56 +00:00
Michael
9f481c1f5e + is * 2018-09-30 20:48:29 +00:00
Michael
fdc396e197 "rawcontent" is now a baseobject method 2018-09-30 20:47:28 +00:00
Michael
5456ef0185 Profile update and some more is now added 2018-09-30 20:26:30 +00:00
Michael
761bdafa34 Correct content type 2018-09-30 14:13:07 +00:00
Michael
a8b776c189 There is now "rawContent" for technical endpoints 2018-09-30 13:15:10 +00:00
Michael
cb44aa83c7 Object instead of Display 2018-09-30 12:21:57 +00:00
Michael
e71f497295 Renamed 2018-09-30 08:14:05 +00:00
Michael
2fc79e3886 Superfluous, since we only fetch this data 2018-09-30 07:48:13 +00:00
Michael
82987d018a Some changes for better code quality 2018-09-30 07:21:57 +00:00
Michael
b043c7e0f2 Changed constant name to keep compatible with PHP 5 2018-09-28 15:25:20 +00:00
Michael
da79566125 Relocated function 2018-09-28 03:56:41 +00:00
Michael
30f67d6e14 removed unneded line 2018-09-27 21:14:01 +00:00
Michael
793387e2b5 Only communicate with contacts that aren't pending 2018-09-27 15:26:20 +00:00
Michael
c4994626e9 Corrected function names 2018-09-27 13:31:32 +00:00
Michael
de8787dd5b Changed comment 2018-09-27 12:01:16 +00:00
Michael
e01d5e4b31 Function naming ... 2018-09-27 11:56:05 +00:00
Michael
cb9be8a7ab UUID is now createUUID 2018-09-27 11:52:15 +00:00
Michael
5639054699 Diaspora in AP - and changed function name 2018-09-27 11:39:17 +00:00
Michael
fa868fbaf2 Some more documentation 2018-09-27 03:28:56 +00:00
Michael
897929ad40 Avoid warnings, added documentation 2018-09-26 22:45:13 +00:00
Michael
9c62727e1d Added doxygen data 2018-09-26 22:02:14 +00:00
Michael
f7d7d94111 Added some doxygen headers 2018-09-26 21:38:37 +00:00
Michael
dd38b7e329 Avoid warnings 2018-09-26 20:36:47 +00:00
Michael
60b0759b50 UUID instead of GUID 2018-09-26 20:03:46 +00:00
Michael
9ec30010c5 APContact stuff is moved to an own class 2018-09-26 17:24:29 +00:00
Michael
f3814ae1fc Changed conversation url (used for AP) 2018-09-26 13:12:27 +00:00
Michael
4699741f00 Fix delivery only for comments to native networks 2018-09-26 13:00:48 +00:00
Michael
67d2f8594c Some more clean up 2018-09-26 07:42:40 +00:00
Hypolite Petovan
c80045edaf Remove obsolete lines from Console\Config 2018-09-25 23:00:00 -04:00
Hypolite Petovan
be0f71bedb Add new Cache console command 2018-09-25 22:59:22 -04:00
Hypolite Petovan
d420a4dec2 Add informative public static members to Core\Cache 2018-09-25 22:58:04 -04:00
Hypolite Petovan
71c08a044f Add ICacheDriver->getAllKeys method 2018-09-25 22:52:32 -04:00
Hypolite Petovan
640f76b05a Improve doc blocks in cache drivers 2018-09-25 22:51:41 -04:00
Hypolite Petovan
d1148f61ea Add missing "outdated" parameter to ICacheDriver->clear in Core\Cache 2018-09-25 22:46:45 -04:00
Michael
e91a1dfa8e Cleaned code 2018-09-25 21:18:37 +00:00
Michael
834422d52f Merge remote-tracking branch 'upstream/develop' into ap1 2018-09-24 21:48:40 +00:00
Michael
5e3f71680c Disabled logging 2018-09-24 21:47:10 +00:00
Michael
59c137b946 Variable fix 2018-09-24 05:35:47 +00:00
Hypolite Petovan
a6996601d5
Merge pull request #5789 from friendica/master 
Update develop from master-2019.09
 2018-09-23 18:55:20 -04:00
Michael
b386add315 Switch contacts from OStatus to ActivityPub 2018-09-23 22:12:12 +00:00
Michael
094c27add6 Update person, undo activity and improved security checks 2018-09-23 19:25:20 +00:00
Michael
8c7e5bb776 all endpoints are now working 2018-09-23 17:29:31 +00:00
Michael
feeec908d3 We can delete notes / changed credits 2018-09-23 09:20:25 +00:00
Michael
6df6d82427 We can now like and dislike 2018-09-23 08:52:07 +00:00
Michael
a56565fa99 AP is enabled for all users 2018-09-22 23:49:27 +00:00
Michael
ca574e1027 We can now like and dislike 2018-09-22 23:17:01 +00:00
Hypolite Petovan
adbc1d3224 Missing $a to $this conversion in App 2018-09-22 12:45:49 -04:00
Michael
c083ae047c Merge remote-tracking branch 'upstream/2018.08-rc' into ap1 2018-09-22 15:18:53 +00:00
Michael
214407bdc8 Improve communication 2018-09-22 14:12:54 +00:00
Tobias Diekershoff
684dfd5bbd
Merge pull request #5780 from annando/fix-relocation 
Hopefully fixes relocations that hadn't been executed
 2018-09-22 10:56:11 +02:00
Michael
b3e3147697 Issue 5768: This logging should help finding the origin of the problem 2018-09-22 07:09:27 +00:00
Michael
0dbb6313a5 Hopefully fixes relocations that hadn't been executed 2018-09-22 06:47:35 +00:00
Michael
b906b083bc The target inbox is now generated after the permission bloxk 2018-09-22 05:58:56 +00:00
Michael
71cbe56293 Use the follower collection 2018-09-22 04:49:16 +00:00
Michael
b7744ae3eb Inherit the receivers from the previous post 2018-09-22 04:39:04 +00:00
Michael
b44fc62708 Improvements to signature check, private posts do work now again 2018-09-21 22:31:33 +00:00
Benjamin Lorteau
489d5f41d2 Add Doxygen headers for multiple function in App 2018-09-21 09:54:40 -04:00
Benjamin Lorteau
f0cdd25e34 Register Friendica stylesheet using App->registerStylesheet() 
- Remove mentions of {{$stylesheet}} in head.tpl templates
 2018-09-21 09:54:09 -04:00
Michael
4c224fbddd Deliver everything to all receivers in the thread 2018-09-21 12:06:36 +00:00
Michael
59cd6611ec Direkt delivery is done 2018-09-21 05:41:18 +00:00
Michael
5310d54c13 Fetch the receiver from the parent posting as well 2018-09-21 04:51:54 +00:00
Michael
355346298b LD signatures will now be checked when receiving messages 2018-09-21 03:39:32 +00:00
Hypolite Petovan
2ae6556b32 Add new 'head' hook 
- Add new App->registerStylesheet method
- Reworked App->init_pagehead into App->initHead
 2018-09-20 21:30:51 -04:00
Hypolite Petovan
1eaa523e61 Remove unused App->page['end'] 
- Remove unused empty templates
 2018-09-20 21:02:28 -04:00
Hypolite Petovan
55f1d7b90e Add new footer hook 
- Add new App->footerScripts array
- Add footer.tpl template
- Add documentation
- Rework App->init_page_end to App->initFooter
 2018-09-20 21:01:05 -04:00
Michael
752b5fe284 Outgoing posts are now signed 2018-09-20 21:45:23 +00:00
Michael
11310f4cf0 Relocated AP signature functions, reduced magic auth functions 2018-09-20 18:16:14 +00:00
Michael
0866fbaf8c Code cleaning / wrong table for flags 2018-09-20 09:50:03 +00:00
Michael
0d51474e73 Relocated function 2018-09-20 05:37:01 +00:00
Michael
34cb0aa406 JSON-LD stuff is now in a separate file 2018-09-20 05:30:07 +00:00
Michael
f20bed67a9 Table "apcontact" is now in use / added functionality to handle JSON-LD 2018-09-20 05:00:49 +00:00
Jonny Tischbein
807ad14521 calculate form return_url for post and message instead of using SESSION var 2018-09-19 23:55:29 +02:00
Michael
5de4afecf1 Table for AP contacts, JSON-LD parser included 2018-09-18 22:09:27 +00:00
Michael
cb073bea61 Private posts with Mastodon don't work - but this is expected 2018-09-18 19:36:27 +00:00
Michael Vogel
bd0515714c
Merge pull request #5765 from MrPetovan/bug/php7-remove-pear-text_highlighter 
[php7] Remove PHP code highlighting
 2018-09-18 18:34:46 +00:00
Michael Vogel
1fa37586ca
Merge pull request #5764 from MrPetovan/task/update-mrpetovan-email-address 
Update "mrpetovan" email address
 2018-09-18 14:26:58 +00:00
Michael
464650d4d7 Public posts to Pleroma do work now, limited posts to Hubzilla and Mastodon as well 2018-09-18 07:28:35 +00:00
Hypolite Petovan
382a7f5acd Create new HTML::toMarkdown wrapper 2018-09-17 23:17:41 -04:00
Michael
f772ece86f New delivery module for ap 2018-09-17 21:13:08 +00:00
Michael Vogel
e68c48e88f
Merge pull request #5763 from MrPetovan/task/improve-getsiteinfo 
Use OEmbed data when available no matter the type
 2018-09-17 06:40:04 +00:00
Michael
91d1b4de5d We now use the conversation data with AP 2018-09-17 05:51:05 +00:00
Michael
699a4140f9 Now sending does finally work - and some AP standards are improved as well 2018-09-16 20:12:48 +00:00
Michael
e4d28629e4 First posting tests 2018-09-16 17:47:00 +00:00
Hypolite Petovan
102adf86ae Restore partial condition in OEmbed block of ParseUrl::getSiteInfo 2018-09-16 09:18:31 -04:00
Hypolite Petovan
96ed7525b7 Improve whitespace display from/to BBCode/HTML 2018-09-16 09:05:54 -04:00
Hypolite Petovan
ba4f368b45 Remove references to pear/Text_Highlighter 2018-09-16 09:05:00 -04:00
Hypolite Petovan
d6adcb9734 Remove text highlighting from BBCode::convert 
- Move code blocks escaping from BBCode::toMarkdown to BBCode::convert
- Use "language-" class prefix for expected syntax highlighting
 2018-09-16 09:04:25 -04:00
Michael
629cca1963 Added function to fetch missing data, code bugfixing 2018-09-16 13:04:00 +00:00
Michael
6f3b2b6586 Handling of unlisted posts, better uid detection 2018-09-16 09:06:09 +00:00
Michael
1f98414bdd Some code cleanup 2018-09-16 05:49:13 +00:00
Hypolite Petovan
9d0a6f90b6 Update "mrpetovan" email address 
- Fix Tobias' email address
- Fix copypasted doc block in Console/PostUpdate
 2018-09-15 19:28:38 -04:00
Michael
a7f5c1f4c6 Likes work now 2018-09-15 23:06:03 +00:00
Michael
2eabe45a8e Contact reject does work now as well 2018-09-15 22:25:58 +00:00
Michael
e45206ae5d Merge remote-tracking branch 'upstream/2018.08-rc' into ap1 2018-09-15 20:49:46 +00:00
Michael
f5104f3e46 Removed harcoded host names 2018-09-15 20:48:24 +00:00
Michael
86bd283705 The whole contact handling does work now, yeah ... 2018-09-15 20:31:05 +00:00
Michael
6a8ebc8639 Contact follow and unfollow workd partially 2018-09-15 18:54:45 +00:00
Michael
96f575fe28 Processing of personal inbox enabled 2018-09-15 10:14:56 +00:00
Michael
35854a0ad1 Adding "(AP)" to the server name when posted via AP 2018-09-15 10:13:41 +00:00
Michael
957c70d1c6 Several improvements 2018-09-15 07:40:19 +00:00
Michael
fb5b6e4a14 New uri format for our posts that is AP compatible 2018-09-15 07:37:34 +00:00
Michael
2e7ca76e15 More fields to import / like could possibly work 2018-09-14 21:10:49 +00:00
Michael
61e2c7d20d Added AP to many network conditions / enabling inbox processing 2018-09-14 16:51:32 +00:00
Hypolite Petovan
5b5e5ef4db Use OEmbed data when available no matter the type 2018-09-13 21:50:52 -04:00
Michael
7b45bdea17 Preparation for adding more networks there 2018-09-13 22:12:33 +00:00
Michael
c2f6b166c7 We now use the regular probing function 2018-09-13 21:57:41 +00:00
Michael
8c00e88f79 The endless saga of the fight against notices continues 2018-09-13 21:11:52 +00:00
Hypolite Petovan
70c94abd8e
Merge pull request #5759 from annando/issue-5733 
Issue 5733: Removing contacts does work now on the same machine as well
 2018-09-12 19:40:03 -04:00
Michael
f7b03bc5f3 Missing $ 2018-09-12 21:33:44 +00:00
Michael
67fa0ed433 Signature check added 2018-09-12 21:30:10 +00:00
Michael
969311cb44 Replacing the non standard "title" with "name" 2018-09-12 18:48:18 +00:00
Michael
7daa46503d Don't risk incompatibilities 2018-09-12 06:13:04 +00:00
Michael
96d10c25e3 Issue 5733: Removing contacts does work now on the same machine as well 2018-09-12 06:05:14 +00:00
Michael
8c07baf54b Better http answers 2018-09-12 06:01:28 +00:00
Michael
f566db52d3 And more notices ... 2018-09-11 08:04:14 +00:00
Michael
8b96a53fba Burn notices, burn 2018-09-11 04:10:11 +00:00
Michael
0a5476591d Activitity pub - first commit with much test code 2018-09-10 21:07:25 +00:00
Hypolite Petovan
791a77f441 Add overwrite parameter to App->loadConfigFile 2018-09-08 02:37:53 -04:00
Michael
99244d33f5 Fix for #5732 - too much links had been detected as photos 2018-09-07 06:10:33 +00:00
Hypolite Petovan
480d792356
Merge pull request #5732 from annando/fix-picture-posts 
Fix: Posts with pictures will now look good again on connector networks
 2018-09-06 19:00:44 -04:00
Michael
2592c3891c forgotten $ 2018-09-06 21:10:48 +00:00
Michael
1d4a5402ff Picture posts do work again - everything else should work as well 2018-09-06 20:30:16 +00:00
Hypolite Petovan
e735a14db9
Merge pull request #5736 from annando/issue-5733 
Issue 5733: Changing relationship values does work now again with DFRN
 2018-09-06 13:19:24 -04:00
Hypolite Petovan
d27cf0cb60
Merge pull request #5740 from annando/fix-fatal 
Fix fatal error due to missing "use"
 2018-09-06 11:58:07 -04:00
Michael
e9a73e4480 Fix fatal error due to missing "use" 2018-09-06 13:27:03 +00:00
Michael
6113fdc940 Issue 5733: Changing relationship values does work now again with DFRN 2018-09-06 09:20:45 +00:00
Philipp Holzer
bd2b3b1ef5
LockDriverFixings 
- release Locks in case of failures
- adding some cache tests
 2018-09-06 08:11:18 +02:00
Michael
04fb885857 Fix: Posts with pictures will now look good again on connector networks 2018-09-06 04:24:34 +00:00
rabuzarus
75a2576f78 use magic links in single event view 2018-09-06 01:42:35 +02:00
Michael
9ef1d827f3 Restore the behaviour to remove the remote contact upon termination 2018-09-05 05:02:06 +00:00
Hypolite Petovan
59d06b6c78
Merge pull request #5719 from annando/notices-yeah 
Good news, everyone - again somce notices removed
 2018-09-04 19:09:11 -04:00
Michael
821429fdf1 Good news, everyone - again somce notices removed 2018-09-04 17:48:09 +00:00
Hypolite Petovan
9744f0e780 Update ParseUrl::getSiteinfo type recognition 
- Added obsolete twitter card type provision
 2018-09-02 17:50:27 -04:00
Hypolite Petovan
8bcc3c6860 Fix formatting in Util/ParseUrl 
- Remove commented out code
- Replace double quotes with simple quotes
- Remove parentheses for language construct
- Add spaces around operators
- Rename variables
 2018-09-02 17:46:28 -04:00
Hypolite Petovan
69e7c7feca Fix photo attachment display 
- Remove double image display
- Add domain link display to all attachments
 2018-09-02 17:26:05 -04:00
Michael
5250552fe2 Removed obsolete post update that sometimes never finishes 2018-09-02 17:48:25 +00:00
Tobias Diekershoff
deca48e39d
Merge pull request #5711 from annando/and-again 
The days are getting shorter, like the list of removed notices ...
 2018-09-02 14:48:47 +02:00
Michael
703c668a37 More notices ... 2018-09-02 08:01:13 +00:00
Michael
fd7e45042a The days are getting shorter, like the list of removed notices ... 2018-09-02 07:47:48 +00:00
Michael
4fcae18289 Issue 5262: Comments to a forum post aren't distributed via push 2018-09-01 03:23:12 +00:00
Michael Vogel
196ef0111c
Merge pull request #5704 from MrPetovan/bug/fix-unfollow 
Fix unfollow sharing-only contacts (except connector protocols)
 2018-08-31 15:40:51 +00:00
Michael
380eeaab88 Still there had been notices - must have a good camouflage 2018-08-31 05:08:22 +00:00
Hypolite Petovan
804cfa0320 Reorganize Protocol constants 
- Add ActivityPub protocol constant
- Add Protocol::NATIVE_SUPPORT
- Sort/group constant names
 2018-08-30 17:47:48 -04:00
Michael
a3570d0027 Fix: Missing gserver entries - show correct server platform 2018-08-30 09:52:38 +00:00
Tobias Diekershoff
070e1e73d6
Merge pull request #5702 from annando/and-a-notice 
and now for something completely different: A removed notice
 2018-08-30 06:37:39 +02:00
Michael
02da827560 and now for something completely different: A removed notice 2018-08-30 04:05:32 +00:00
Hypolite Petovan
f18650f3b8
Merge pull request #5700 from annando/issue-5653 
Issue 5653: The mastodonemoji addon hadn't got all needed data.
 2018-08-29 20:17:15 -04:00
Michael
c72d1bc8fd Issue 5653: The mastodonemoji addon hadn't got all needed data. 2018-08-29 20:46:52 +00:00
Michael
9bff31f18f Issue 5691: Post dates of feeds sometimes had been wrong 2018-08-29 19:11:43 +00:00
Michael Vogel
c7f8f190b9 Oh no, even more notices ... (#5697) 2018-08-29 14:28:13 -04:00
Michael
67227570d8 "Does" is now "perform" 2018-08-29 13:06:56 +00:00
Michael Vogel
601851f3d0 Removed notice - pokes do now work mostly (#5693) 2018-08-29 09:00:01 -04:00
Michael
d489712824 The post update version can now be set. 2018-08-29 11:48:40 +00:00
Michael Vogel
cf6140e86f Ensure that the post update doesn't end prematurely (#5684) 2018-08-28 07:56:25 -04:00
Jeroen De Meerleer
9ddb6abe08 Added widget class to invitationsbox (#5675) 2018-08-27 13:36:44 -04:00
Tobias Diekershoff
df3b1be3b7
Merge pull request #5679 from annando/neverending-notices 
The neverending story of removing notices continues ...
 2018-08-27 09:12:38 +02:00
Michael
8d911b1465 The neverending story of removing notices continues ... 2018-08-27 05:37:10 +00:00
Tobias Diekershoff
6c8ed888f5
Merge pull request #5676 from annando/issue-3501 
Issue 3501: Mail contacts can be added again
 2018-08-27 06:16:42 +02:00
Philipp
2838e4ebaf Automatic Install Tests & Doku (#5674) 
* Automatic Installation Testing
- New dev-library "mikey179/vfsStream"
- created "reload" method for App-Reloads
- ConsoleTest now using virtual directory
- Adding Automatic Installation Tests
- Fixing some probable install-failures

* Updating README for Automatic Installation

* Updating README for Automatic Installation

* Bugfix normal installation

* Fixing copying of config files
 2018-08-27 00:15:55 -04:00
Michael
2079caea14 Issue 3501: Mail contacts can be added again 2018-08-26 19:49:39 +00:00
Michael
5e82323456 Avoid useless contact updates 2018-08-26 07:56:33 +00:00
Michael
1280bb56df Removed notices in notifications 2018-08-26 05:27:50 +00:00
Michael Vogel
49dad00570 Issue 5260: Ensure that user data is really deleted (#5666) 
* Issue 5260: Ensure that user data is really deleted

* Missing files
 2018-08-25 17:48:50 -04:00
Michael
927e0ee0a2 Isse 4726: Fixes the condition for showing hidden contacts 2018-08-25 16:38:26 +00:00
Michael Vogel
edcd0a3744 Issue 4960: Ignoring and blocking of contacts should work again (#5657) 
* Issue 4960: Ignoring and blocking of contacts should work again

* Renamed functions

* This function should be renamed as well.

* We now have a frontend to block and ignore public contacts

* Hide some parts for public contacts

* Removed notices, public contact is now accessible from dirfind as well

* We now show contact conversations and contact posts

* We now use a new conversation mode

* The update functionality is disabled until it will work completely

* Fixing tabs chaos

* Update after posts on the contacts page will now work

* Show connect link
 2018-08-25 09:48:00 -04:00
Tobias Diekershoff
6a549d4cfb
Merge pull request #5659 from annando/notices-oh-no 
Oh no ... there are still some notices that want to be removed ...
 2018-08-24 14:46:21 +02:00
Michael
82d097879b Oh no ... there are still some notices that want to be removed ... 2018-08-24 11:09:58 +00:00
Roland Häder
61693419e8 Cleanups: isResult() more used, readability improved (#5608) 
* [diaspora]: Maybe SimpleXMLElement is the right type-hint?

* Changes proposed + pre-renaming:
- pre-renamed $db -> $connection
- added TODOs for not allowing bad method invocations (there is a
  BadMethodCallException in SPL)

* If no record is found, below $r[0] will fail with a E_NOTICE and the code
doesn't behave as expected.

* Ops, one more left ...

* Continued:
- added documentation for Contact::updateSslPolicy() method
- added type-hint for $contact of same method
- empty lines added + TODO where the bug origins that $item has no element 'body'

* Added empty lines for better readability

* Cleaned up:
- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)

* Re-fixed DBM -> DBA switch

* Fixes/rewrites:
- use empty()/isset() instead of deprecated x()
- merged 2 nested if() blocks into one
- avoided nested if() block inside else block by rewriting it to elseif()
- $contact_id is an integer, let's test on > 0 here
- added a lot spaces and some empty lines for better readability

* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)

* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
- fixed mixure with "Contact::* rewrite"

* Ops, one still there (return is no function)

* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.

* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...

* Ops, was added accidentally ...

* Ops, why these wrong moves?

* Ops, one to much (thanks to MrPetovan)

* Ops, wrong moving ...

* moved back to original place ...

* spaces added

* empty lines add for better readability.

* convertered spaces -> tab for code indenting.

* CR request: Add space between if and brace.

* CR requests fixed + move reverted
- ops, src/Module/*.php has been moved to src/Network/ accidentally
- reverted some parts in src/Database/DBA.php as pointed out by Annando
- removed internal TODO items
- added some spaces for better readability
 2018-08-24 01:05:49 -04:00
Michael Vogel
dc3d2d5988 "dba" is now "DBA". This hadn't been respected at some places (#5655) 
* "dba" is now "DBA". This hadn't been respected at some places

* Cleaning up unneeded stuff
 2018-08-23 09:51:58 -04:00
Michael Vogel
20127a77b3 Removing a small notice in the network.php (#5652) 2018-08-22 18:46:44 -04:00
Michael Vogel
54aee2aaa7 Removed notices that revealed themselfes over night ... (#5645) 
* Removed notices that revealed themselfes over night ...

* And more notices removed that occured over night

* One more ..

* Some more notices of the day ...
 2018-08-21 17:35:09 +02:00
Michael
334c628511 And again ... notices 2018-08-20 21:20:21 +00:00