Commit graph

2243 commits

Author SHA1 Message Date
Hypolite Petovan
ca9cad3491 Move hook-related methods from Core\Addon to Core\Hook 2018-10-22 16:50:54 -04:00
Hypolite Petovan
0aa7671119 Add new Core\Hook class 2018-10-22 16:49:53 -04:00
Michael Vogel
c0abff0bda
Merge pull request #5990 from MrPetovan/task/move-apps-out-of-app
Road to Router Part 4: Move $apps out of App
2018-10-22 22:47:22 +02:00
Philipp Holzer
3072c56057
goaway fix in App 2018-10-22 22:15:50 +02:00
Philipp Holzer
32af52842b
adding defaults in mod/redir.php 2018-10-22 22:13:41 +02:00
Philipp Holzer
363d00cc45
Adding $a->getBaseURL for Worker in profile_photo
Adding a TODO for Contact::magicLink
2018-10-22 22:13:39 +02:00
Philipp Holzer
34989480e1
removed unnecessary System use 2018-10-22 22:13:39 +02:00
Philipp Holzer
3edad1591e
replaced $return_url to $return_path to make it more clear that it is a relative path to the Friendica baseurl 2018-10-22 22:13:37 +02:00
Philipp Holzer
a9510ffcdf
description fix 2018-10-22 22:13:37 +02:00
Philipp Holzer
d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect() 2018-10-22 22:13:35 +02:00
Philipp Holzer
2ef81108b3
Renamed System::redirect() to $a->redirect() 2018-10-22 22:13:22 +02:00
Benjamin Lorteau
339a5da946 Move $apps out of App
- Move $nav_sel out of App
- Add new Content\Nav::getAppMenu() method
2018-10-22 16:02:15 -04:00
Hypolite Petovan
e3fe25383c Add static keyword for Core\L10n properties 2018-10-22 15:58:42 -04:00
Hypolite Petovan
c6f0bea51d Move $strings from App to Core\L10n
- Add L10n::init() call in App constructor
- Improve pushLang/popLang
- Remove no longer needed references to App
2018-10-22 15:58:42 -04:00
Michael Vogel
baa1094489
Merge pull request #5987 from MrPetovan/task/empty-index-php
Road to Router Part 2: Empty index.php
2018-10-22 21:56:13 +02:00
Benjamin Lorteau
37f00b5fd1 Use System::httpExit for 403 error in App 2018-10-22 15:16:59 -04:00
Hypolite Petovan
a0bd96d587 Remove unwarranted doxygen comments in App 2018-10-22 08:17:55 -04:00
Michael
5c13ecdf6e Improved parsing of AP profiles 2018-10-22 07:24:47 +00:00
Hypolite Petovan
e2c5a423c5 Improve App->runFrontend formatting
- Use single-quotes instead of double
- Use strpos() instead of substr()
- Add/remove comments
- Use Config::get default value and drop the exact match for config.private_addons
2018-10-22 00:07:56 -04:00
Hypolite Petovan
279196959c Move index.php content to App->runFrontend
- Replace all x() by !empty() in App
- Replace all killme() with exit()
2018-10-21 22:24:47 -04:00
rabuzarus
72a7671010
Merge pull request #5986 from annando/improve-5984
Improve PR 5984: better check for remote users as well
2018-10-22 00:03:19 +02:00
Michael
8e11f055b1 Improve PR 5984: better check for remote users as well 2018-10-21 21:56:46 +00:00
Michael Vogel
277fe547a1
Merge pull request #5978 from MrPetovan/task/make-username-length-configurable
Make username length configurable
2018-10-21 23:42:44 +02:00
Hypolite Petovan
4ec56a0975 Sets maximum to 64 for username_min/max_length config keys 2018-10-21 17:28:40 -04:00
Hypolite Petovan
1176a4240a
Merge pull request #5985 from annando/ap-followers
AP: We now send the previous followers collection as well
2018-10-21 17:05:34 -04:00
Michael
bb3f07b0b7 We now send the previous followers collection as well 2018-10-21 20:49:50 +00:00
Michael
9b387a226c Fix webmentions and microformats ("redir" only for logged in users) 2018-10-21 20:23:08 +00:00
Hypolite Petovan
c1bca43fee Changing default/max values for username_min/max_length
- Restoring legacy default values (3 and 48 respectively)
- Lowering the max value to 150 to take the full profile URL length into
account
2018-10-21 15:10:51 -04:00
Hypolite Petovan
b08408c086 Add safeguard for username_min|max_length mutual exclusion 2018-10-21 08:28:24 -04:00
Michael Vogel
f14dae8d77
Merge pull request #5979 from MrPetovan/task/mock-legacy-module
Encapsulate legacy module functions in a BaseModule-inherited class
2018-10-21 10:02:44 +02:00
Michael Vogel
614a549d28
Merge pull request #5976 from MrPetovan/bug/5975-add-missing-l10n-poplang
Add missing L10n::popLang calls
2018-10-21 09:40:49 +02:00
Hypolite Petovan
b6075de6f8
Merge pull request #5982 from annando/ap-inboxes
Bugfix: We hadn't deliverd AP posts to all intended receivers
2018-10-21 02:57:22 -04:00
Michael
1c54c27784 Bugfix: We hadn't deliverd AP posts to all intended receivers 2018-10-21 06:10:24 +00:00
Michael
c4cc7a4afb The limit for dbclean is now configurable 2018-10-21 05:41:40 +00:00
Hypolite Petovan
1a37224910 Change file_exists to is_readable in LegacyModule 2018-10-20 22:42:04 -04:00
Hypolite Petovan
5326cc0c2e Add Friendica\LegacyModule class 2018-10-20 22:34:26 -04:00
Hypolite Petovan
d360bf926a Use username_min/max_length config keys in Model\User::create 2018-10-20 16:33:54 -04:00
Philipp Holzer
4392858662
Move Global Functions - Part 3
- Replaced every CACHE definition
- Moved check_url to App->checkURL()
- Removed unused definition "ZCURL_TIMEOUT"
2018-10-20 18:19:55 +02:00
Hypolite Petovan
4ffcb77554 Simplify L10n::t + sprintf instances 2018-10-20 09:02:35 -04:00
Hypolite Petovan
a8d3a4d218 Add missing L10n::popLang calls 2018-10-20 09:02:10 -04:00
Michael
fea48fa85e AP: Transmitting and receiving with non AP contacts 2018-10-20 07:53:45 +00:00
Hypolite Petovan
a2666b0d02
Remove reference to deleted include/security.php 2018-10-19 15:11:51 -04:00
Benjamin Lorteau
d9209b9c7a Use local temporary directory for PasswordExposedChecker cache 2018-10-19 11:26:48 -04:00
Hypolite Petovan
f104817967
Merge pull request #5967 from annando/ap-nick
Fix function naming
2018-10-19 10:38:51 -04:00
Michael
bedab33e0b Fix function naming 2018-10-19 13:08:46 +00:00
Hypolite Petovan
ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security
Move and Split include/security
2018-10-19 08:55:08 -04:00
Jonny Tischbein
cafd5ca781 update function names in logger and comments 2018-10-19 10:03:52 +02:00
Michael
cdeb4682ef Use nickname based mentions for AP 2018-10-19 05:27:54 +00:00
Michael Vogel
8cecc9fb97
Merge pull request #5962 from friendica/bug/5960-fix-register-email-translation-params
Remove superfluous L10n::t() parameter in Model\user
2018-10-19 05:34:24 +02:00
Michael Vogel
45156652cc
Merge pull request #5963 from MrPetovan/bug/5956-catch-more-diaspora-magic-links
Diaspora: Widen the magic link regular expression
2018-10-19 05:30:52 +02:00
Hypolite Petovan
d0681075bf Add itemsource module 2018-10-18 22:49:25 -04:00
Hypolite Petovan
eb714f0487 Diaspora: Widen the magic link regular expression 2018-10-18 22:39:06 -04:00
Hypolite Petovan
8315940c39
Merge pull request #5961 from annando/simpler-item
The handling with item-content and item-activity had been simplified
2018-10-18 18:24:09 -04:00
Hypolite Petovan
18763e32af
Remove superfluous L10n::t() parameter in Model\user 2018-10-18 18:22:48 -04:00
Michael
0628b44f8e The handling with item-content and item-activity had been simplified 2018-10-18 21:35:48 +00:00
Hypolite Petovan
ee32cf6b92
Restore preshare prepending in BBCode::convertShare
Fixes #5955
Follow-up to #5942
2018-10-18 11:23:48 -04:00
Michael
688174e6c0 AP: Fix "null" receiver 2018-10-18 12:25:57 +00:00
Michael
8035bad8e2 AP: Fix a notice / avoid an error when fetched content hadn't been an array 2018-10-18 05:54:44 +00:00
Hypolite Petovan
da2a17495d
Merge pull request #5951 from annando/endless-contact
Avoid endless loop when trying to fetch contact id
2018-10-18 00:44:07 -04:00
Hypolite Petovan
6d420dfe9e
Merge pull request #5950 from annando/no-polling
For test purposes we can now deactivate polling
2018-10-18 00:43:35 -04:00
Michael
92816dc725 Improved loop detection 2018-10-18 03:33:08 +00:00
Michael
35da40c2cb Avoid endless loop when trying to fetch contact id 2018-10-18 03:01:34 +00:00
Michael
d307aa1484 For test purposes we can now deactivate polling 2018-10-18 02:46:02 +00:00
Jonny Tischbein
a937cf06a3 add remaning/moving to files not touch by refactoring because of typo 2018-10-17 22:35:49 +02:00
Michael Vogel
a19f8d642d
Merge pull request #5942 from MrPetovan/feature/3218-add-convert-share-callback
Add BBCode::convertShare callback parameter
2018-10-17 22:01:02 +02:00
Jonny Tischbein
f3fc1f36ca Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments 2018-10-17 21:30:41 +02:00
Michael Vogel
389685e099
Merge pull request #5920 from MrPetovan/bug/remove-password-from-register
Avoid storing plaintext password in register table
2018-10-17 21:04:11 +02:00
Hypolite Petovan
e254ace9d5
Merge pull request #5947 from annando/uri-id
Use "uri-id" for item relations
2018-10-17 14:45:40 -04:00
Michael
62ad755980 Use "uri-id" for item relations 2018-10-17 18:34:24 +00:00
Jonny Tischbein
ce2b1f5715 Rename function Authentication::authenticate_success to Authentication::success 2018-10-17 18:45:32 +02:00
Jonny Tischbein
45e5a7f59f remove unsed require_onces of security.php 2018-10-17 18:39:27 +02:00
Hypolite Petovan
057385a4ec Add $is_quote_share parameter to convert share callback
- Restore former behavior when content is present before [share] block
2018-10-17 08:20:56 -04:00
Jonny Tischbein
05be2db725 Move include/security tp /src/Core/Authentication and /src/Util/Security 2018-10-17 14:19:58 +02:00
Hypolite Petovan
9239ecc5e0 Rework BBCode::convertShare to accept a callback function
- Create default convertShare callback from previous code
- Remove $simplehtml = 8 case (moved to Twitter addon)
2018-10-17 01:13:18 -04:00
Hypolite Petovan
b5fb81f535 Add Mastodon/Pleroma protocol guessing 2018-10-17 01:10:07 -04:00
Hypolite Petovan
c50be325bd Remove unused parameter $selected in Model\Item::fieldlist 2018-10-16 18:30:24 -04:00
Hypolite Petovan
341b83d1df Fix Undefined index: photo in ActivityPub/Receiver 2018-10-16 18:29:28 -04:00
Hypolite Petovan
cb854b8b10 Fix Undefined index: timezone in Protocol\Diaspora 2018-10-16 18:29:08 -04:00
Hypolite Petovan
2b1d15de87 Fix undefined index: id in Protocol\Diaspora 2018-10-16 18:28:27 -04:00
Hypolite Petovan
c4318fe05e Fix notices in Parse URL feature 2018-10-16 18:27:13 -04:00
Hypolite Petovan
e9c9eb9c66 Fix notice in Worker\Delivery 2018-10-16 18:26:43 -04:00
Hypolite Petovan
ff643c4b6a
Merge pull request #5940 from JonnyTischbein/issue_update_display_network
Fix redirect after edit post to /update_*
2018-10-16 13:37:19 -04:00
Jonny Tischbein
be2e6c3929 Fix Issue #5896 by setting static return for edit_post to display item page (kind of revert parts of #5774) 2018-10-16 19:14:55 +02:00
Hypolite Petovan
93c6dddc0d
Merge pull request #5939 from annando/onepoll
Onepoll hadn't polled anymore / small relocation in zrlinit for better logging
2018-10-16 11:27:48 -04:00
Michael
35a73b729f Onepoll hadn't polled anymore / small relocation in zrlinit for better logging 2018-10-16 13:17:01 +00:00
Tobias Diekershoff
dbd2aa1196
Merge pull request #5938 from annando/magic-loop
Avoid endless loop at magic auth
2018-10-16 09:17:17 +02:00
Michael
012fe3c11e Avoid endless loop at magic auth 2018-10-16 06:32:12 +00:00
Hypolite Petovan
481b0ac138 Fix notices in include/enotify 2018-10-15 23:13:00 -04:00
Hypolite Petovan
0de1351a09 Fix notices in Network\Probe 2018-10-15 23:12:29 -04:00
Michael
8d0f4710a4 Signed Diaspora posts should now be stored more reliable 2018-10-15 21:42:55 +00:00
Benjamin Lorteau
9e1065ff87 Improve transition from previous behavior
- Simplify Model\User methods parameter list
- Use DBA methods in mod/regmod
- Replace killme with exit in mod/regmod
- Simplify goaway() calls
2018-10-15 11:58:52 -04:00
Tobias Diekershoff
664afbcafb
Merge pull request #5926 from annando/defer-worker
Poddibility to defer worker execution
2018-10-15 08:02:51 +02:00
Michael
e2762e032c Poddibility to defer worker execution 2018-10-15 05:19:35 +00:00
Michael Vogel
0080d117ee
Merge pull request #5923 from MrPetovan/task/improve-contact-module
Improve Contact module
2018-10-15 06:02:55 +02:00
Hypolite Petovan
aa8039373a Update formatting of Module\Contact
- Replace double quotes with single
- Align array declarations
- Replace q() call with Model\User::getOwnerDataById()
2018-10-14 18:30:02 -04:00
Hypolite Petovan
a883a99fe6 Replace string fields by array in Module\Contact 2018-10-14 18:27:24 -04:00
Hypolite Petovan
12ddb3bb54 Replace unwarranted uses of $a->data['contact'] 2018-10-14 18:25:44 -04:00
Hypolite Petovan
57e8fb5cb1 Normalize uses of defaults() in Module\Contact
- Remove uses without default value
- Add relevant uses
2018-10-14 18:24:02 -04:00
Hypolite Petovan
756a4f1111 Fix remaining instances of "contacts" 2018-10-14 18:02:54 -04:00
Jonny Tischbein
3a95644848 Add Support for relativeDateTime in future + update Admin user waiting for deleting table header 2018-10-14 22:57:44 +02:00
Hypolite Petovan
74c5f1f684
Merge pull request #5891 from JonnyTischbein/move_module_contacts
Move module contacts
2018-10-14 16:42:50 -04:00
Jonny Tischbein
e41c59b193 Fix batch action choice - All Actions for one contact were taken before 2018-10-14 21:38:38 +02:00
Jonny Tischbein
d54e56c659 Fix batch action query + Fix Namespace import 2018-10-14 21:14:32 +02:00
Hypolite Petovan
ce74a4d9a1
Merge pull request #5921 from annando/ap-video
ActivityPub: Rudimentary support for videos
2018-10-14 14:05:51 -04:00
Jonny Tischbein
5fd4402074 code standards + fixing navigation links to /contact/... 2018-10-14 20:03:22 +02:00
Michael Vogel
68af56a10e
Merge pull request #5912 from MrPetovan/bug/fix-code-tag-nonsense
Fix [code] tag whitespace nonsense
2018-10-14 20:00:19 +02:00
Michael
37ad4a7d22 ActivityPub: Rudimentary support for videos 2018-10-14 17:57:44 +00:00
Hypolite Petovan
540adaf829 Use Model\Register methods in modules
- Update registration emails to avoid storing the plaintext password in
the register table
- Remove redundant sprintf() when used with L10n::t()
- Remove redundant Systen::baseUrl() with goaway()
2018-10-14 12:26:18 -04:00
Hypolite Petovan
59d6dd809d
Merge pull request #5906 from annando/ap-switch
OStatus contacts are now automatically converted to AP
2018-10-14 12:04:52 -04:00
Hypolite Petovan
123992384b Create Model\Register
- Add Model\User::exists method
2018-10-14 11:34:34 -04:00
Hypolite Petovan
7f143c3159 Fix various spelling mistakes 2018-10-14 11:32:54 -04:00
Hypolite Petovan
a769efae38 Remove whitespace clearing around code tags
- Normalize inline code blocks to <code>
2018-10-14 07:43:44 -04:00
Hypolite Petovan
6606c9cbb2
Merge pull request #5910 from nupplaphil/acctlink_followup
FollowUp Acctlink move
2018-10-14 06:27:02 -04:00
Hypolite Petovan
6c80601a4a
Merge pull request #5902 from nupplaphil/Install_Class_to_methods
Install class bugfixing & tests & changed method signature
2018-10-14 06:23:33 -04:00
Philipp Holzer
248c1b8074
Type hinting & call bugfixing 2018-10-14 10:37:19 +02:00
Philipp Holzer
753f61f633
FollowUp Acctlink move 2018-10-14 10:31:11 +02:00
Michael
6be04a73e3 The outbox is now more complete / No more duplicates in the receiver array 2018-10-14 07:47:04 +00:00
Hypolite Petovan
db0b848ae3
Merge pull request #5904 from annando/ap-announce
AP: Announce will now work
2018-10-13 20:17:14 -04:00
Hypolite Petovan
07da170bcf
Merge pull request #5905 from nupplaphil/move_global_functions
Move global functions
2018-10-13 19:46:57 -04:00
Michael
e829e074fc Location, coord and app are now processed as well 2018-10-13 21:37:39 +00:00
Michael
aab4fa0c31 The instrument is now added, updating AP contacts is now enabled 2018-10-13 20:36:44 +00:00
Michael
f60468677e We now transmit location and application as well. 2018-10-13 19:49:20 +00:00
Michael
8b9aa80aad "to" is now used for mentions, "cc" for everything else 2018-10-13 18:59:39 +00:00
Michael
efad4936b0 OStatus contacts are now automatically converted to AP 2018-10-13 18:13:01 +00:00
Philipp Holzer
4f7cb049fb
isAjax bugfix 2018-10-13 19:10:46 +02:00
Michael Vogel
514ec1be6d
Merge pull request #5903 from nupplaphil/move_module_acctlink
Move module AcctLink
2018-10-13 19:09:59 +02:00
Philipp Holzer
3f729df258
Renamed AcctLink to Acctlink 2018-10-13 19:03:38 +02:00
Philipp Holzer
2c541afd47
Moved functions out of boot.php into class
- z_root() => $a->getBaseURL()
- absurl() => removed because no usage
- is_ajax() => $a->isAjax()
- current_load() => System::currentLoad()
- argc() => $a->argc
- argv($x) => $a->getArgumentValue($x)
2018-10-13 19:03:08 +02:00
Michael
3c48a1f787 AP: Announce will now work 2018-10-13 16:41:29 +00:00
Philipp Holzer
508032cf9a
Move Module AcctLink 2018-10-13 18:32:14 +02:00
Philipp Holzer
c32ac7f194
Install Class to methods
- Bugfixing Install checks (worked not as expected)
- Changed static methods from Install to class functions
- Added tests
2018-10-13 18:09:53 +02:00
Michael
d23386f9b2 Catching error when compacting doesn't work 2018-10-13 13:17:10 +00:00
Jonny Tischbein
bfa05156ca change links from /contacts to /contact 2018-10-13 13:29:56 +02:00
Jonny Tischbein
738cb4ace6 finish refactoring to Module\Contact 2018-10-13 11:35:51 +02:00
Jonny Tischbein
cdbddd0103 Renaming functions and class 2018-10-13 11:23:52 +02:00
Michael
4d4dd1a99c Some beautification 2018-10-12 20:52:22 +00:00
Michael
5af0ee1b95 We can now store it without any problem 2018-10-12 18:53:13 +00:00
Michael
914b3a9e3e Merge remote-tracking branch 'upstream/develop' into fix-diaspora-signature 2018-10-12 18:52:22 +00:00
Michael
1b18be6715 The virtuel fields for the diaspora signatures have to be removed at any time 2018-10-12 18:47:32 +00:00
Hypolite Petovan
986528b77f
Revert "We now store the diaspora comment data as well" 2018-10-12 10:35:43 -04:00
Jonny Tischbein
93ab82b7f0 Rename Contacts:content function 2018-10-11 23:45:01 +02:00
Jonny Tischbein
ba95487abf Upate Contacts module file 2018-10-11 23:41:27 +02:00
Jonny Tischbein
80ea86113d Move mod Contacts to /src/Module 2018-10-11 23:14:12 +02:00
Hypolite Petovan
735a5980bd
Merge pull request #5889 from annando/ap-store-diaspora
We now store the diaspora comment data as well
2018-10-11 16:42:53 -04:00
Hypolite Petovan
90254fd74b
Merge pull request #5888 from nupplaphil/curl_result_tests
Curl result tests
2018-10-11 16:42:09 -04:00
Michael
8268288953 We now store the diaspora comment data as well 2018-10-11 20:38:57 +00:00
Hypolite Petovan
fc19373ec4
Merge pull request #5887 from annando/ap-store-conversation
Store conversation data directly from the AP receiver
2018-10-11 16:32:00 -04:00
Philipp Holzer
b099cba4b4
CurlResult Tests & RegEx fix 2018-10-11 22:18:27 +02:00
Michael
1bf7521af8 Store conversation data directly from the AP receiver 2018-10-11 20:08:04 +00:00
Philipp Holzer
00bf0c24b6
CurlResult Tests 2018-10-11 21:19:38 +02:00