Commit graph

6774 commits

Author SHA1 Message Date
Michael
3ec1270fde Quit when message is empty 2020-12-19 18:17:32 +00:00
Hypolite Petovan
fc19d98392
Merge pull request #9680 from annando/issue-9402
Issue 9402: Avoid message "invalid storage backend settings" on empty value
2020-12-19 13:07:02 -05:00
Michael Vogel
e66fba9757 Issue 9402: Avoid message "invalid storage backend settings" on empty value 2020-12-19 18:17:12 +01:00
Michael
944b0eadb7 Issue 9457: Fix remembering "personal" and "starred" 2020-12-19 16:48:12 +00:00
Hypolite Petovan
bcd61c8372
Merge branch '2020.12-rc' into bug/9656-purify-video-embed 2020-12-18 14:47:24 -05:00
Hypolite Petovan
95f099d26c Restore Mastodon emoji span classes
- Fix typo in replacement of [class] tag
2020-12-18 11:08:03 -05:00
Hypolite Petovan
20d9dcf7ac Bump BBCode version to 2020-12-18 2020-12-18 10:32:36 -05:00
Hypolite Petovan
0781f28ca6 Allow support for allowlisted iframe sources in Content\text\BBCode::convert
- Support Youtube, Vimeo and unused local embeds
2020-12-18 10:32:36 -05:00
Hypolite Petovan
ec0c9dcdb1 Remove support for [iframe] BBCode
- It was a huge gaping security hole, and now HTML Purify will remove the src attribute of all non-allowed sources anyway.
2020-12-18 10:32:36 -05:00
Hypolite Petovan
0dac6e9d34 Add general information header translation to admin site template 2020-12-17 22:52:30 -05:00
Michael
c1e8dbdbae Avoid "Duplicate entry" 2020-12-17 18:56:10 +00:00
Michael
66c1592171 Fix notices 2020-12-17 18:08:07 +00:00
Hypolite Petovan
38b17e1aae
Merge pull request #9668 from annando/keywarning
Fix warning "supplied key param cannot be coerced into a public key"
2020-12-17 08:25:25 -05:00
Michael
e713db4ac7 Delete tombstone contacts 2020-12-17 08:00:56 +00:00
Michael
a548e7c4be Fix warning "supplied key param cannot be coerced into a public key" 2020-12-17 07:07:54 +00:00
Michael
e22bb32247 Store the network profiler data 2020-12-17 06:23:03 +00:00
Hypolite Petovan
1414d43597
Merge pull request #9664 from annando/delete-contacts
Delete removed contacts
2020-12-16 11:28:56 -05:00
Michael
974f7bffc8 Indentation 2020-12-16 15:43:12 +00:00
Michael
a331a8cf0a Delete removed contacts 2020-12-15 22:56:46 +00:00
Michael Vogel
569ad89f10
Merge pull request #9661 from MrPetovan/bug/9651-apdelivery-inboxes
Clarify usage of ActivityPub\Transmitter::fetchTargetInboxes in Worker\APDelivery queuing
2020-12-15 22:05:59 +01:00
Hypolite Petovan
a2f14efd94
Remove reference to receivers when adding relay delivery tasks in Worker\Notifier
- Address https://github.com/friendica/friendica/pull/9661#issuecomment-745553051
2020-12-15 15:42:16 -05:00
Hypolite Petovan
6d3864a16b
Remove owner.deleted check in user deletion check in Model/Item 2020-12-15 14:24:42 -05:00
Hypolite Petovan
0951a50bcd Add item user owner data check in Model\Item::isValid
- Prevents deleted users from posting any item, manually or automatically through mirroring
2020-12-15 09:41:58 -05:00
Hypolite Petovan
8c17a6b4d9 Rename Model\User::getOwnerDataById parameter to better reflect intent 2020-12-15 09:41:10 -05:00
Hypolite Petovan
5f148dcb42 Add temporary console command to fix workerqueue row with corrupted parameter data
- It should be reverted just before the 2020.12 release
2020-12-15 00:20:49 -05:00
Hypolite Petovan
d59fcd5093 Clarify usage of ActivityPub\Transmitter::fetchTargetInboxes in Worker\APDelivery queuing
- $inbox is now always a string
- $receivers should be correctly populated now
- $target_id is renamed to $item_id and correctly initialized to 0 for non-item deliveries
2020-12-14 23:33:14 -05:00
Michael Vogel
e4228c6218
Merge pull request #9655 from MrPetovan/bug/fatal-errors
Fix several occasional fatal errors
2020-12-14 22:11:45 +01:00
Hypolite Petovan
481c5c9e81 Account for inbox array in Worker/APDelivery
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-744339671
2020-12-14 09:12:29 -05:00
Michael
c210e0b97f Issue 9657: Check the age of an item 2020-12-14 00:00:10 +00:00
Hypolite Petovan
0441b912ac Return early if an URI id cannot be obtained in ActivityPub\Processor::createItem
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-743769813
2020-12-13 13:42:08 -05:00
Michael
cd96955fcf Fix: posted unprepared posts hadn't been deleted 2020-12-13 18:17:50 +00:00
Michael
d938e37767 Set the return value 2020-12-13 17:22:50 +00:00
Hypolite Petovan
61aa4efa89 Account for missing contact in dfrn_request_post
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-743407998
2020-12-13 12:18:10 -05:00
Hypolite Petovan
8f10cf8e53 Simplify Contact::addRelationship call in ActivityPub\Processor::followUser
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-743382769
2020-12-13 12:16:04 -05:00
Michael
4626f98dbe Added logging 2020-12-13 16:38:12 +00:00
Michael
0eb4a600b0 Delay unprepared posts 2020-12-13 12:47:49 +00:00
Hypolite Petovan
c787281eff
Merge pull request #9652 from annando/issue-9584
Issue 9584: Only search posts from federated networks
2020-12-12 15:13:31 -05:00
Michael
c3d0ab56a5 Issue 9584: Only search posts from federated networks 2020-12-12 19:55:47 +00:00
Michael
297118f902 Archive/Unarchive at ActivityPub delivery 2020-12-12 16:45:23 +00:00
Hypolite Petovan
67573cf996
Merge pull request #9647 from annando/original-relay
Relay posts with the original protocol
2020-12-11 16:17:05 -05:00
Michael
61b3003f64 Standards 2020-12-11 20:20:27 +00:00
Michael
a43059df27 Relay posts with the original protocol 2020-12-11 06:35:38 +00:00
Hypolite Petovan
99b200868b Normalize return value in Database->fetch
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-741857058
2020-12-10 06:12:10 -05:00
Michael
965374596f Avoid dropping of incoming DFRN messages 2020-12-10 07:22:49 +00:00
Michael
20ded2b35a Parameters should be float ... 2020-12-10 00:02:23 +00:00
Michael
5fb83d0632 Improved performance profiler 2020-12-09 22:10:27 +00:00
Hypolite Petovan
9c0342b907
Merge pull request #9638 from annando/bad-priority
Check for bad worker priorities
2020-12-09 01:12:34 -05:00
Michael Vogel
33930b0bd9
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-12-09 06:58:19 +01:00
Michael Vogel
809035b872
Merge pull request #9635 from MrPetovan/bug/notices
Batch of notice fixes
2020-12-09 06:51:54 +01:00
Michael
dd94fb1242 Check for bad worker priorities 2020-12-08 21:58:32 +00:00
Michael
2cb71341b2 Fixes "Unknown column '729' in 'field list'" 2020-12-08 21:23:10 +00:00
Hypolite Petovan
c7a2988454 Check for the existence of array key before using it in Protocol\ActivityPub\Transmitter
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-739534960
2020-12-08 10:08:49 -05:00
Hypolite Petovan
99828c0fea Suppress notice message when guid isn't supplied in Module\Admin\Item\Source
- https://github.com/friendica/friendica/issues/9252#issuecomment-740052103
2020-12-08 10:00:09 -05:00
Michael
e17ca9cc35 Check for remote default avatars as well 2020-12-07 07:14:09 +00:00
Michael
a49a35f459 Centralized fetching of the default avatar 2020-12-07 06:43:43 +00:00
Michael
9acecfd9e6 Issue 9630: Prevent negative values for registered users 2020-12-06 18:14:05 +00:00
Michael Vogel
ce52d31afa
Merge pull request #9626 from MrPetovan/bug/9611-bbcode-convert-html-purify
Prevents share block new lines from being converted to HTML <br> tags
2020-12-06 15:53:18 +01:00
Hypolite Petovan
e6270bc46d Enable back references in reg exp in BBCode::convert
- Bump BBCode version
2020-12-06 08:57:06 -05:00
Hypolite Petovan
a863228e09
Merge pull request #9628 from annando/dfrn-delete
Don't create the parent during a deletion
2020-12-06 08:37:50 -05:00
Michael
1f1697222b Don't create the parent during a deletion 2020-12-06 09:54:34 +00:00
Hypolite Petovan
f141f5acf4 Prevents share block new lines from being converted to HTML <br> tags
- Address https://github.com/friendica/friendica/pull/9621#issuecomment-739333767
2020-12-05 19:55:16 -05:00
Michael
878a418c6b Code standards 2020-12-05 21:58:15 +00:00
Michael
2b8adf5073 Remove unused contacts 2020-12-05 21:07:48 +00:00
Michael Vogel
f9994548c1
Merge pull request #9621 from MrPetovan/bug/9611-bbcode-convert-html-purify
Add HTML Purify to BBCode::convert
2020-12-05 19:27:59 +01:00
Hypolite Petovan
1cc509c5ef Move BBCode version tagging inside of the hash to prevent item-content.rendered-hash overflow 2020-12-04 08:30:51 -05:00
Hypolite Petovan
e712706302 Add BBCode versioning
- This will trigger the re-conversion of displayed items on version update
2020-12-04 07:29:49 -05:00
Hypolite Petovan
a382798999 Add some more result panels to Babel 2020-12-04 07:29:48 -05:00
Hypolite Petovan
a0f6d678c4 Add HTML Purify to BBCode::convert
- Replace previous HTML cleanup using DOMDocument
- Remove obsolete HTML::sanitizeCSS method
- Use Strings::autoLinkRegEx for PageInfo::getRelevantUrlFromBody
- Update previous tests expectations
- Add new specific XSS tests
2020-12-04 07:29:48 -05:00
Michael
8e9a9b2049 Improved logging 2020-12-04 07:54:29 +00:00
Michael
9f96f3ef34 Moved updating personal contacts to updatecontact 2020-12-04 05:53:11 +00:00
Michael
8d999f54d0 Check and add a server 2020-12-03 22:32:51 +00:00
Michael
0c9a0ce64e Merge remote-tracking branch 'upstream/develop' into worker-command 2020-12-03 15:48:46 +00:00
Michael
edbdfbae6b workerqueue now has a "command" field 2020-12-03 15:47:50 +00:00
Michael
bd4dc10588 Ensure that the database.sql contains "if exists" 2020-12-02 08:50:45 +00:00
Michael
c1d1b189f7 Cleaned code 2020-12-02 08:36:23 +00:00
Michael
6c3b1ac4bd Moved direct storage 2020-12-02 05:41:33 +00:00
Michael
b54465ba9c Directly post non mirrored feed items 2020-12-02 05:08:39 +00:00
Michael
775075c5db Only spool mirrored posts 2020-12-02 05:07:44 +00:00
Michael
e9fecf1541 Only delay mirrored feeds 2020-12-02 04:53:54 +00:00
Michael
b2dadf0f92 Use a combined unique index 2020-12-02 00:34:10 +00:00
Michael
425440ec24 The network doesn't matter 2020-12-02 00:29:57 +00:00
Michael
c302b7c347 Check for existing post 2020-12-02 00:20:07 +00:00
Michael
4fbd0a46b5 Reducing parameter list 2020-12-02 00:05:03 +00:00
Michael
b047d31a4f Added logging and default config value 2020-12-01 23:46:50 +00:00
Michael
a283b1183b Move deletion 2020-12-01 23:04:04 +00:00
Michael Vogel
b3f71d174c Added logging 2020-12-01 23:54:49 +01:00
Michael
2aa302c570 New class for handling delayed posts 2020-12-01 22:11:29 +00:00
Michael
bb823c323b Configuration for the priority of the notification for expired messages 2020-11-30 21:40:55 +00:00
Hypolite Petovan
4f98da88c4
Merge pull request #9614 from annando/issue-8943
Issue 8943: Only check for too old postings for feeds
2020-11-30 16:09:27 -05:00
Michael
b30d2c9c6b Renamed function 2020-11-30 20:59:18 +00:00
Hypolite Petovan
9636ffe27d
Merge pull request #9615 from annando/issue-9329
Issue 9329: prevent "Expression #1 of SELECT list is not in GROUP BY clause"
2020-11-30 15:58:39 -05:00
Michael
ccc07b06de Issue 9329: prevent "Expression #1 of SELECT list is not in GROUP BY clause" 2020-11-30 20:44:21 +00:00
Michael
8bc799ff38 Issue 8943: Only check for too old postings for feeds 2020-11-30 20:32:56 +00:00
Michael
20649dd00e Replaced tab with space 2020-11-30 20:09:52 +00:00
Michael
1e09eab921 Another place found where "show less" had been "show more" 2020-11-30 19:52:57 +00:00
Michael
d4d55a5865 Issue 8605: "show less" now displays "show less" 2020-11-30 19:30:57 +00:00
Michael
5b19469a4c Fix Notice: Undefined variable: publish_at 2020-11-30 18:27:02 +00:00
Michael Vogel
d0f45c4ecb Fixed function name and variable 2020-11-30 09:59:29 +01:00
Michael
6e06e0cf20 New class for delayed postings 2020-11-30 06:59:00 +00:00
Michael
cbd1ba8da2 Post delay is in seconds 2020-11-30 06:23:27 +00:00
Michael
a7e0a1f7de The maximum delay should be a day 2020-11-30 06:19:10 +00:00
Michael Vogel
4c39c88b52 Adjusted log levels, removed spaces 2020-11-30 07:06:43 +01:00
Michael
3f3f56db57 Poll interval function moved to feed class, first steps for delayed posts 2020-11-30 05:39:12 +00:00
Hypolite Petovan
d05d5a0381
Merge pull request #9608 from annando/delete-table-view
Ensure that a view is a view and not a table
2020-11-29 16:33:07 -05:00
Michael Vogel
eb48a36061
Update src/Database/View.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-29 21:59:24 +01:00
Michael
5f1ea39bad Display posts that are reshared by the contact 2020-11-29 20:42:03 +00:00
Michael
7e6a9bd893 Ensure that a view is a view and not a table 2020-11-29 19:06:43 +00:00
Hypolite Petovan
ea2923be67
Merge pull request #9607 from annando/cron-priority
Ensure to add the cron forkhood worker task with medium priority
2020-11-29 12:49:02 -05:00
Michael Vogel
03af4062ce Ensure to add the cron forkhood worker task with medium priority 2020-11-29 17:41:20 +01:00
Michael
a68810301a Fix structure error 2020-11-29 11:43:07 +00:00
Michael
7ab63d2106 Store the protocol of the received message 2020-11-29 09:01:51 +00:00
Michael
8da8d3c4fd Only automatically reshare items from DFRN and AP 2020-11-29 00:05:46 +00:00
Michael
bda5d43f1e New "remote self" option: Native Reshare 2020-11-28 22:53:58 +00:00
Hypolite Petovan
96d4ec0f53
Merge pull request #9603 from annando/notice
Fixes notice "Undefined index: parent-uri"
2020-11-28 08:01:28 -05:00
Michael
1d4be7b01f Fixes notice "Undefined index: parent-uri" 2020-11-28 10:17:55 +00:00
Michael
b6f349076c Fix order of reshared items on the profile page 2020-11-28 06:23:17 +00:00
Michael
bd9f36622e Cast field data when ATTR_EMULATE_PREPARES is enabled 2020-11-27 11:24:31 +00:00
Hypolite Petovan
f0d6f8c45e
Merge pull request #9597 from annando/api-endpoints
API: Mastodon endpoints added as "unimplemented"
2020-11-26 09:34:36 -05:00
Michael Vogel
615eece22f
Update src/Module/Api/Mastodon/Unimplemented.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-26 14:35:06 +01:00
Michael
db5cd6e66c API: Mastodon endpoints added as "unimplemented" 2020-11-26 07:02:31 +00:00
Michael
818c064c0a The notifications parameters are now simplified 2020-11-25 19:56:39 +00:00
Hypolite Petovan
486b43f09d Avoid unmarking for archival an empty contact in Protocol\ActivityPub\Receiver
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-733198306
2020-11-24 17:32:52 -05:00
Hypolite Petovan
1342825401
Merge pull request #9586 from annando/inbox-status
Don't transmit to archived inboxes
2020-11-24 03:04:03 -05:00
Michael
495252690b available is not vital 2020-11-24 07:49:36 +00:00
Michael
23bc725ce9 Fix: Only echo on verbose 2020-11-23 19:47:30 +00:00
Michael
e4e9a20ac8 Don't transmit to archived inboxes 2020-11-23 19:25:22 +00:00
Michael
61ff99c410 Command line option to check initial values 2020-11-23 18:58:18 +00:00
Hypolite Petovan
794f98f479
Merge pull request #9578 from annando/onepoll-failed
OnePoll reworked, improved "failed" behaviour
2020-11-22 10:42:41 -05:00
Michael
7bdf22a0d5 Don't probe feeds so often 2020-11-22 14:56:38 +00:00
Michael
3ffd40c7da OnePoll reworked, improved "failed" behaviour 2020-11-22 14:42:24 +00:00
Hypolite Petovan
4fd9db1035
Merge pull request #9577 from annando/updateprofile
Contacts can now be updated from every theme
2020-11-22 08:14:09 -05:00
Michael
b52ba79620 Contacts can now be updated from every theme 2020-11-22 08:15:17 +00:00
Hypolite Petovan
ca823244cc Don't assume addons must have an *_install function
- Module-only addons don't have any
2020-11-21 23:19:03 -05:00
Hypolite Petovan
8b3ab4e6bb Refactor builtin_activity_puller() and format_like()
- Simplify output array
- Rename format_like() to format_activity()
- Remove duplicate parameters in format_activity()
2020-11-21 11:08:44 -05:00
Hypolite Petovan
e6362c4923
Merge pull request #9566 from annando/update-foo
Avoid multiple database update mails, changed log level
2020-11-21 10:53:06 -05:00
Michael
aec9f1ebf0 Remove unused config variable 2020-11-21 15:15:58 +00:00
Michael
1de6251627 Code cleaning 2020-11-21 14:58:48 +00:00
Michael Vogel
b40218eb0b Immediately fail when lock hadn't been acquired to prevent stocked updates 2020-11-21 14:17:14 +01:00
Michael Vogel
2a1c82cf05 Avoid multiple database update mails, changed log level 2020-11-21 13:28:06 +01:00
Michael
8a29d20083 Comments on PeerTube videos not working
Fixes #9407
2020-11-21 08:28:33 +00:00
Michael
1bc76fdb6d Watchdog mode to check if the daemon is running 2020-11-20 19:50:08 +00:00
Michael
cea2b13075 Parameter has to be float 2020-11-20 08:55:30 +00:00
Michael
e4c95efd80 Added minimal execution time for rendertime addon 2020-11-20 08:44:00 +00:00
Michael
32e98327a1 Fix warning 2020-11-19 21:27:08 +00:00
Hypolite Petovan
1acc5ffb38
Merge pull request #9553 from annando/insert-mode
Mode switch for insert
2020-11-19 16:25:09 -05:00
Hypolite Petovan
10a4802d81
Merge pull request #9552 from annando/zero-user
Avoid problems with uid=0
2020-11-19 16:23:28 -05:00
Michael
303aaa00ca Mode switch for insert 2020-11-19 19:34:48 +00:00
Michael Vogel
e4c6341bf4
Merge pull request #9551 from MrPetovan/task/4140-ldap-auth-logging
Make Model\User::getAuthenticationInfo accessible to addons
2020-11-19 18:21:34 +01:00
Michael
bd0e2dc0a8 Avoid problems with uid=0 2020-11-19 17:19:14 +00:00
Hypolite Petovan
a66e66359c Make Model\User::getAuthenticationInfo accessible to addons
- It contains the centralized authentication requirements for user records
2020-11-19 11:20:17 -05:00