Commit graph

545 commits

Author SHA1 Message Date
nupplaPhil
0b309245b1
Improve check 2020-02-02 22:43:41 +01:00
nupplaPhil
0e13428210
Move "App::getSenderEmailAddress()" to "Emailer::getSiteEmailAddress()" 2020-02-02 22:43:40 +01:00
nupplaPhil
206b53477e
Fix Lookup 2020-02-02 22:43:39 +01:00
nupplaPhil
9428466d1d
Set Sitename / site email as sender for system emails 2020-02-02 22:43:39 +01:00
nupplaPhil
abad42f7d2
fix wrong template 2020-02-02 22:43:38 +01:00
nupplaPhil
3291728059
Extract System emails from enotify
- Removed every SYSTEM_EMAIL occurrence in enotify
- Introduced a "SystemMailBuilder" for build system emails
- Replaced every SYSTEM_EMAIL usage in the classes with calling this builder
- Added tests for this new Builder
- Split the email templates between "base" template for email and concrete usages for different use cases
2020-02-02 22:43:35 +01:00
Hypolite Petovan
703ad99464 Add Util\Network::appendQueryParam method 2020-01-31 19:39:15 -05:00
nupplaPhil
f6aea0d65a
Fix invalid "emailer_prepare" Hook
- Use IEmail instead of array data
- Introduce "composer" based library for phpmailer
2020-01-29 20:20:40 +01:00
nupplaPhil
6350b210a6
Renaming - part 2 :-) 2020-01-27 00:01:17 +01:00
nupplaPhil
765a0d8892
Some Renames:
- EMail => EMail
- toEmail => toAddress
- fromEmail => fromAddress
2020-01-26 23:47:16 +01:00
nupplaPhil
4efba4d0cf
fix boolean field 2020-01-26 21:35:04 +01:00
nupplaPhil
2b8f067715
Introduce interface for emailing and create email classes 2020-01-26 21:35:04 +01:00
nupplaPhil
915abe8a33
Add explicit parameters to Sender::send() method signature 2020-01-26 21:35:03 +01:00
nupplaPhil
ea9d3b7438
Make EMailer util dynamic 2020-01-26 21:35:03 +01:00
Hypolite Petovan
db518e7ef2 Fix birthday display and setting
- Add new translation string
2020-01-20 07:47:10 -05:00
Hypolite Petovan
353dab166e Rename PermissionSet::fetchIDForPost to PermissionSet::getIdFromACL
- Allow creating/retrieving a permission set id with arbitrary parameters
- Rename ACLformatter->sanitize to ACLFormatter->sanitizeItem
- Move PermissionSet::sortPermissions to ACLformatter->sanitize
2020-01-20 07:32:47 -05:00
Hypolite Petovan
04d620fc2f
Merge pull request #8142 from nupplaphil/task/di_config
CleanUp Config namespace
2020-01-19 22:22:57 -05:00
nupplaPhil
ed9392469e
Remove unneeded Config namespace usages 2020-01-19 22:50:44 +01:00
nupplaPhil
d5a473abda
Shorten "PConfiguration" to "PConfig" again, since the Wrapper is gone 2020-01-19 22:23:44 +01:00
Michael
dcbd44ab88 Removed the rest of the @brief fields 2020-01-19 20:44:01 +00:00
nupplaPhil
cb80108957
Shorten "Configuration" to "Config" again, since the Wrapper is gone 2020-01-19 21:29:36 +01:00
nupplaPhil
21640ec5d8
Add missing Friendica\DI namespace to files (PHPStorm inspection) 2020-01-19 21:26:42 +01:00
nupplaPhil
6c36fd9e01
Move Config::get() to DI::config()->get() 2020-01-19 21:21:13 +01:00
nupplaPhil
d6efc90194
cleanup namespace usages for L10n 2020-01-19 16:31:33 +01:00
nupplaPhil
d83f6335eb
Move L10n::getCurrentLang() calls to DI::l10n()->getCurrentLang() calls 2020-01-19 16:31:19 +01:00
nupplaPhil
cb4ad529f4
Move L10n::getDay() calls to DI::l10n()->getDay() calls 2020-01-19 16:31:18 +01:00
nupplaPhil
5dfee31108
Move L10n::t() calls to DI::l10n()->t() calls 2020-01-19 16:31:16 +01:00
Philipp
af88c2daa3
Merge pull request #8135 from annando/brief
@brief is removed completely
2020-01-19 12:31:02 +01:00
Michael
0a4119adaf @brief is removed completely 2020-01-19 06:05:23 +00:00
Hypolite Petovan
0b9aec4569
Add missing use Friendica\DI statement in Util\Emailer 2020-01-18 16:28:42 -05:00
Hypolite Petovan
58f69481e6
Merge pull request #8130 from nupplaphil/task/di_pconfig
Move PConfig to DI::pConfig()
2020-01-18 13:57:57 -05:00
nupplaPhil
800694e9b3
Remove unused use statements & remove PConfig class 2020-01-18 17:02:59 +01:00
nupplaPhil
9e9429b56d
Move PConfig::get() to DI::pConfig()->get() 2020-01-18 16:50:57 +01:00
nupplaPhil
424c87195b
CleanUp Cache namespace
- Introduce enum "Duration"
- Introduce enum "Type"
- Move "Cache\Cache" to "BaseCache"
2020-01-18 15:41:19 +01:00
Michael
8215c493cf The archive functionality is working again 2020-01-15 04:06:30 +00:00
nupplaPhil
a38b0f7eaf
Move remaining namespaces and delete Core\Cache.php 2020-01-07 00:51:02 +01:00
nupplaPhil
fe078410a1
Move Cache::get() to DI::cache()->get() 2020-01-07 00:45:49 +01:00
nupplaPhil
f68929633b
Move Cache::set() to DI::cache()->set() 2020-01-07 00:41:20 +01:00
nupplaPhil
f0eea6f875
Remove get_app() in favor of DI::app() 2020-01-04 23:42:01 +01:00
nupplaPhil
3f34229752
Move redundant System::baseUrl() to DI::baseUrl() calls 2019-12-30 23:00:08 +01:00
nupplaPhil
c1dbb25656
Creating interfaces for Config/PConfig & fix tests 2019-12-29 20:18:19 +01:00
nupplaPhil
50be94aa5e
Remove deprecated App::getHostName() - process methods to DI::baseUrl()->getHostName() 2019-12-29 20:17:47 +01:00
nupplaPhil
181529f3df
Refactor dynamic App::getProfiler() to static DI::profiler() 2019-12-29 20:17:42 +01:00
nupplaPhil
388b963714
Replace BaseObject class with DI::* calls 2019-12-29 20:17:38 +01:00
nupplaPhil
1de3f186d7
Introduce new DI container
- Adding Friendica\DI class for getting dynamic classes
- Replacing BaseObject::getApp() with this class
2019-12-29 20:16:55 +01:00
Hypolite Petovan
61c6daeff0 Add timezone information to logger timestamp 2019-12-24 16:07:36 -05:00
Michael Vogel
a3b7f08f78 Don't guess the site info / restrict the description length 2019-11-15 14:28:42 +01:00
Hypolite Petovan
03bf1dcbd3 Move Object\Image static methods to Util\Images
- Optimize imports in modified files
2019-11-02 07:48:45 -04:00
Philipp Holzer
f4ad82bcfb
make ACLFormatter::expand() nullable and return an empty array
- optimize tests
2019-11-01 15:43:16 +01:00
Philipp Holzer
aa7be41728
Fix ACLFormatterTest
- Add nullable to expand() function again
- Add angle bracket support to toString()
2019-11-01 14:13:29 +01:00
Michael
bef7eeed13 Fix 7778: Don't return empty string in permissions 2019-10-29 06:01:50 +00:00
Hypolite Petovan
9f460c6797
Merge pull request #7765 from nupplaphil/task/move_text
Move include/text.php to class structure
2019-10-23 15:57:01 -04:00
Philipp Holzer
c9e1098dd2
Adapt naming convention 2019-10-23 21:39:00 +02:00
Philipp Holzer
ad67fd3aa8
Move is_a_date_arg to DateTimeFormat::isYearMonth
- Improved functionality
- Added tests
2019-10-23 02:39:28 +02:00
Philipp Holzer
5843a80b6c
Move perms2str to ACLFormatter::aclToString()
- including new tests
2019-10-23 00:54:34 +02:00
Philipp Holzer
f65f7f11c3
Move expand_acl to ACLFormatter::expand()
- including tests
2019-10-23 00:40:14 +02:00
Philipp Holzer
04a86dad75
remove superfluous line 2019-10-22 22:52:40 +02:00
Philipp Holzer
1fe9b789f3
Add some PHP doc 2019-10-22 22:51:52 +02:00
Philipp Holzer
6b2c28e2d7
Add checks & realpath() usage
- New util class "FileSystem"
- Add check in admin summary too
2019-10-22 22:47:37 +02:00
Philipp Holzer
0e84a843a4
Add Fallback in case the logfile isn't accessible.
- Fixes https://github.com/friendica/friendica/issues/7756#issuecomment-544227862
2019-10-21 21:53:55 +02:00
Michael
4664249fec Improved comment 2019-10-17 21:49:29 +00:00
Michael
36ba7fa79c Merge remote-tracking branch 'upstream/develop' into http-417 2019-10-17 21:37:24 +00:00
Hypolite Petovan
5dcf6bfc58 Remove extra spaces before closing parentheses in src/ 2019-10-16 08:58:09 -04:00
Hypolite Petovan
146646c4d4 Replace deprecated calls to defaults() by ?? and ?: in src/ 2019-10-16 08:38:52 -04:00
Michael
440da8a9f4 eol 2019-10-12 14:07:22 +00:00
Michael
c1ab93a5d8 Strings.php: Spaces are transformed to Tabs. 2019-10-12 10:28:18 +00:00
Hypolite Petovan
2c2beb5c0a
Revert Util\Strings::escapeHtml changes from #7725
- Breaks display of inserted mentions
2019-10-11 22:19:20 -04:00
dew-git
e1e1d26b5b Revert random_int changes. 2019-10-11 00:00:15 -08:00
dew-git
b5dac16def Comply with coding style. 2019-10-10 20:50:51 -08:00
dew-git
811cdcdfcb Fix security vulnerbilities.
Fix possible length extension attack, predicable generators, timing attacks on hash comparision and improved formatting.
2019-10-10 15:21:41 -08:00
Michael
83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
Michael
6e9026e033 Renamed function, beginning to replace the "remote_user" function 2019-09-28 09:36:41 +00:00
Michael
3dd94355b7 Fix permissions when viewing photos, applying same fix to items as well 2019-09-27 05:49:23 +00:00
Michael
704cdf1b5a New function to store the "remote" session value / making the changes work 2019-09-26 04:47:42 +00:00
Michael
5254147ccc Fix "redir" loop 2019-09-23 22:13:20 +00:00
Hypolite Petovan
f51b275b17 Add parameter type hints in Temporal::getDateofBirthField 2019-09-21 10:52:55 -04:00
Hypolite Petovan
118e737a49 Remove dependency to App object in Temporal::getDateofBirthField 2019-09-21 05:15:52 -04:00
Michael
5ea8116cfd Workaround for HTTP error 417 2019-09-02 20:39:51 +00:00
Philipp Holzer
df7ec0cdf7
php notice fixings
addons:
- bufferapp (missing errorcode)
- twitter (wrong field name 'nickname')
core:
- bbcode (incomplete attachementdata)
- crypto (uninitialized key)
2019-08-27 08:27:07 +02:00
Philipp Holzer
08be92a862
Moved BaseURL to App namespace (because similar type as Arguments/Modules/Modes) 2019-08-15 17:23:00 +02:00
Michael
b4c673a620 We now use a central function for fetching the postdata 2019-07-30 22:26:01 +00:00
Philipp Holzer
6c2cf494b5
Remove DependencyFactory
- Include all necessary classes in `dependencies.config.php`
- Add DI-reference to BaseObject (acts as a global registry)
- Refactor all static "init()" methods to use the global registry

- Refactor Logging for Worker-Logger a little bit
2019-07-27 23:54:12 +02:00
Hypolite Petovan
46f7b79c7d Switch server blocklist check to case-insensitive shell wildcard 2019-07-25 22:36:25 -04:00
Hypolite Petovan
3812d3d445 Enable two-factor app-specific passwords for ejabberd 2019-07-23 05:11:33 -04:00
Philipp Holzer
55999730e0
Introduce DICE
- Adding dice library
- Adding dependency config

- Removing Factories
- Refactoring App\Mode constructor
- Refactoring App\Router constructor
- Refactoring BasePath for DI usage
- Refactoring ConfigFileLoader constructor
- Refactoring Profiler constructor

- Adjust entrypoints (index, console, worker, ..)

- Adding functional test for DI
- Fix tests because of refactorings
2019-07-21 01:22:10 +02:00
Philipp Holzer
346290cc23
Reverted indention 2019-07-16 21:54:22 +02:00
Philipp Holzer
46a260aa01
Fix indentations 2019-07-16 20:19:56 +02:00
Philipp Holzer
92fb0a82ca
Dynamic config loading
- Move settings, defaults and dbstructure to directory 'static'
- Dynamic loading of config files (after the static loading)
- Filter out '-sample.config.php' and '-sample.ini.php' files
- Remove unnecessary ConfigFileManager
- Move ConfigFileLoader to Utils
- Add tests for multi-loading for INI, config and sample-filtering
2019-07-16 20:16:43 +02:00
Philipp Holzer
c82127ffb7
Splitting ConfigCache & PConfigCache
- Remove IConfigCache & IPConfigCache
- Add new PConfigCache
- Add missing Logger::init() (bugfixing tests)
2019-07-12 22:53:37 +02:00
Philipp Holzer
7c54edd4b4
Fixing Network::post() caused by wrong argument 2019-06-10 19:34:16 +02:00
Michael
7bbacd3878 Fixes PR 7242: Now the "post" function works again 2019-06-10 16:58:00 +00:00
Philipp Holzer
cc7444d84d
Move internal recursion-counter to the end of all cur/fetchUrl parameters 2019-06-10 14:34:54 +02:00
Philipp Holzer
10683a43c8
Add typed parameter for methods in Friendica\Util\Network 2019-06-10 12:06:41 +02:00
Dean Townsley
19e99f7e81 Use accessing function for session variable 2019-06-09 21:06:42 -05:00
Dean Townsley
5c93db4097 remove leftover logging 2019-06-09 21:06:42 -05:00
Dean Townsley
af85e498ce expand permission check to remote array
This check was preventing multiple private images from different
users on the same server from loading on the same page.
It was only checking for permission for the single id returned by the
remote_user() function rather than the multiple possible autheniticated
id's stored in the remote arry session variable.
2019-06-09 21:06:42 -05:00
Philipp Holzer
4c5dd9f47c
Add more Strings::isHex() checks to photos 2019-05-30 10:30:15 +02:00
Philipp Holzer
3de540d1d1
Adding hexadecimal check for photos
see https://github.com/friendica/friendica/issues/6917#issuecomment-492798238
2019-05-29 20:28:25 +02:00
Hypolite Petovan
4e207ef786 Enable addon using emailer hooks to skip default call to mail() 2019-05-26 21:36:09 -04:00
Hypolite Petovan
956ae6241d Add exception message chain, string trace and original object to JsonLD normalize error logging 2019-05-20 15:28:54 -04:00
Hypolite Petovan
3395f56036 Add Unicode support to autolink regular expression
- Explicitly exclude non-breaking spaces from URLs as \s doesn't include them
2019-05-19 18:51:55 -04:00
Michael
6f3019ecdd Revert PR 7158 since it breaks umlauts 2019-05-19 09:34:49 +00:00
Hypolite Petovan
8fb9722cdc Replace htmlspecialchars_decode with html_entity_decode in XML::unescape
- Replace htmlspecialchars with htmlentities in XML::escape
- This allows for converting all entities from Diaspora messages to regular characters
2019-05-18 13:15:51 -04:00
Michael
87b98b8249 Sending direct messages via AP does work now - receiving is pending 2019-05-14 17:50:45 +00:00
Michael
eef85584c2 AP: Parsing of messages from Pleroma should work now again 2019-04-26 06:17:37 +00:00
Michael
af92f46a2d Workaround for systems who don't use a correct context in ActivityPub 2019-04-25 13:30:30 +00:00
Philipp Holzer
1480380af6
Basepath Hardening 2019-04-14 16:17:58 +02:00
Philipp Holzer
03e149270b
bugfix 2019-04-14 14:40:26 +02:00
Philipp Holzer
1dd1684885
Hardening save method in BaseURL 2019-04-10 20:38:39 +02:00
Philipp Holzer
40c075cf47
BaseURL hardening 2019-04-09 08:48:04 +02:00
Philipp Holzer
edd4f06ad0
Adding tests 2019-04-09 08:31:18 +02:00
Philipp Holzer
318a3ca785
Create own base URL class which holds the whole base url business logic 2019-04-09 08:31:16 +02:00
Hypolite Petovan
6f94e51ba6 Add Strings::sanitizeFilePathItem method 2019-03-31 21:39:19 -04:00
Michael
55325f191b Merge remote-tracking branch 'upstream/develop' into ap-delivery-failure 2019-03-26 21:36:46 +00:00
Michael
198e150ba8 Archive inboxes after 5 days of delivery failures 2019-03-25 21:51:32 +00:00
Philipp Holzer
d78598b64e
Fixing basepath issue 2019-03-25 09:39:33 +01:00
Philipp Holzer
23654ce566
Added Update checks
- Logging
- Console
- Admin overview
2019-03-24 22:51:30 +01:00
Philipp Holzer
49def0dc27
Adding ConfigFileSaver and tests 2019-03-24 13:47:35 +01:00
Philipp Holzer
fa31bb6dde
remove basepath and hostname from admin panel and add update path 2019-03-24 13:47:31 +01:00
Philipp Holzer
383a6715c3
Added first version of ConfigCacheSaver 2019-03-23 19:34:54 +01:00
Philipp Holzer
d03dedee63 Set Timezone to 'UTC' for every Logger (Develop) 2019-03-22 23:14:48 -04:00
Philipp Holzer
f63956851b Adding Logger Tests 2019-03-22 23:13:26 -04:00
Philipp Holzer
aee348fa02 Adding Logger Tests 2019-03-22 23:13:26 -04:00
Philipp Holzer
7bebb03f95 Fix php doc 2019-03-22 23:13:25 -04:00
Philipp Holzer
eec4ee3fed Rename & Testfix 2019-03-22 23:13:25 -04:00
Philipp Holzer
cc8a6c85ae typo 2019-03-22 23:13:24 -04:00
Philipp Holzer
7658916540 Added StreamLoggerTest 2019-03-22 23:13:24 -04:00
Philipp Holzer
81ba5376d0 Added StreamLogger and ProfilerLogger 2019-03-22 23:13:23 -04:00
Philipp Holzer
22f1983cc0 cleanup sysloglogger 2019-03-22 23:11:14 -04:00
Philipp Holzer
25b6db6aca Moving Profiling to class 2019-03-22 23:07:39 -04:00
Philipp Holzer
4810ca570f Refactored Logging environment (cleaned up) 2019-03-22 23:00:38 -04:00
Philipp Holzer
21158e7699 Syslog - Disabling 2019-03-22 22:55:46 -04:00
Philipp Holzer
d712d36814 Adding UID and Level To String mapping 2019-03-22 22:52:46 -04:00
Philipp Holzer
ae40963507 Code cleanup 2019-03-22 22:52:46 -04:00
Philipp Holzer
ec59e538fc Adding ident 2019-03-22 22:52:46 -04:00
Philipp Holzer
9c5e0ae415 Adding SyslogLogger 2019-03-22 22:52:45 -04:00
Michael
0aab620d32 Enable remote authentication with HTTP Signatures 2019-03-19 06:44:51 +00:00
Michael
a876c20850 Use HTTP-Signature to authenticate when fetching photos. 2019-03-18 22:33:20 +00:00
Hypolite Petovan
0c738c4f8b Exclude punctuation from domain in autolinker regular expression 2019-03-17 19:37:26 -04:00
Hypolite Petovan
8f96e383a7
Remove new lines from domain name part of autolinker regular expression in Util\Strings
- Fixes issue where the autolinker would include the next paragraph is a pathless URL was followed by new lines.
2019-03-11 14:37:56 -04:00
Hypolite Petovan
184b51ec56 Move autolink regex in Util\Strings 2019-03-09 23:25:53 -05:00
Hypolite Petovan
d40cbdce32 Remove unnecessary @throws tag in Util\Network 2019-03-08 22:39:08 -05:00
Michael
a911baf8e5 Avoid transmitting a deletion message when we don't have a key 2019-03-04 06:52:43 +00:00
Michael
888e2ce2a9 Added forgotten "use" 2019-03-03 07:05:57 +00:00
Michael
3237dab1a4 Added warning about an empty key 2019-03-03 07:01:11 +00:00
Michael
0b2cdf5d26 Issue 6395: Don't log details to avoid memory issues 2019-02-28 09:07:24 +00:00
Philipp Holzer
2b53784094
Reuse existing Strings::getRandomHex function 2019-02-27 18:32:25 +01:00
Hypolite Petovan
8c1db51a76 Improve Logger calls
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
Hypolite Petovan
1917f04153 Rewrite Term class
- Move term type constants from TERM_* to Term::*
- Move term object type constants from TERM_OBJ_* to Term::OBJECT_TYPE_*
- Add Term::isType() method
- Add Strings::startsWith()  method
2019-02-23 17:32:11 -05:00
Hypolite Petovan
1a0398a5b3
Merge pull request #6723 from nupplaphil/issue/6658-worker_id
Adding worker ID to log
2019-02-23 08:38:08 -05:00