mirror of
https://github.com/friendica/friendica
synced 2024-12-23 16:40:17 +00:00
61693419e8
* [diaspora]: Maybe SimpleXMLElement is the right type-hint? * Changes proposed + pre-renaming: - pre-renamed $db -> $connection - added TODOs for not allowing bad method invocations (there is a BadMethodCallException in SPL) * If no record is found, below $r[0] will fail with a E_NOTICE and the code doesn't behave as expected. * Ops, one more left ... * Continued: - added documentation for Contact::updateSslPolicy() method - added type-hint for $contact of same method - empty lines added + TODO where the bug origins that $item has no element 'body' * Added empty lines for better readability * Cleaned up: - no more x() (deprecated) usage but empty() instead - fixed mixing of space/tab indending - merged else/if block goether in elseif() (lesser nested code blocks) * Re-fixed DBM -> DBA switch * Fixes/rewrites: - use empty()/isset() instead of deprecated x() - merged 2 nested if() blocks into one - avoided nested if() block inside else block by rewriting it to elseif() - $contact_id is an integer, let's test on > 0 here - added a lot spaces and some empty lines for better readability * Rewrite: - moved all CONTACT_* constants from boot.php to Contact class * CR request: - renamed Contact::CONTACT_IS_* -> Contact::* ;-) * Rewrites: - moved PAGE_* to Friendica\Model\Profile class - fixed mixure with "Contact::* rewrite" * Ops, one still there (return is no function) * Rewrite to Proxy class: - introduced new Friendica\Network\Proxy class for in exchange of proxy_*() functions - moved also all PROXY_* constants there as Proxy::* - removed now no longer needed mod/proxy.php loading as composer's auto-load will do this for us - renamed those proxy_*() functions to better names: + proxy_init() -> Proxy::init() (public) + proxy_url() -> Proxy::proxifyUrl() (public) + proxy_parse_html() -> Proxy::proxifyHtml() (public) + proxy_is_local_image() -> Proxy::isLocalImage() (private) + proxy_parse_query() -> Proxy::parseQuery() (private) + proxy_img_cb() -> Proxy::replaceUrl() (private) * CR request: - moved all PAGE_* constants to Friendica\Model\Contact class - fixed all references of both classes * Ops, need to set $a here ... * CR request: - moved Proxy class to Friendica\Module - extended BaseModule * Ops, no need for own instance of $a when self::getApp() is around. * Proxy-rewrite: - proxy_url() and proxy_parse_html() are both non-module functions (now methods) - so they must be splitted into a seperate class - also the SIZE_* and DEFAULT_TIME constants are both not relevant to module * No instances from utility classes * Fixed error: - proxify*() is now located in `Friendica\Util\ProxyUtils` * Moved back to original place, ops? How did they move here? Well, it was not intended by me. * Removed duplicate (left-over from split) constants and static array. Thank to MrPetovan finding it. * Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils. * Rewrite: - stopped using deprecated NETWORK_* constants, now Protocol::* should be used - still left them intact for slow/lazy developers ... * Ops, was added accidentally ... * Ops, why these wrong moves? * Ops, one to much (thanks to MrPetovan) * Ops, wrong moving ... * moved back to original place ... * spaces added * empty lines add for better readability. * convertered spaces -> tab for code indenting. * CR request: Add space between if and brace. * CR requests fixed + move reverted - ops, src/Module/*.php has been moved to src/Network/ accidentally - reverted some parts in src/Database/DBA.php as pointed out by Annando - removed internal TODO items - added some spaces for better readability
178 lines
4.2 KiB
PHP
178 lines
4.2 KiB
PHP
<?php
|
|
/**
|
|
* @file mod/wall_attach.php
|
|
*/
|
|
|
|
use Friendica\App;
|
|
use Friendica\Core\Config;
|
|
use Friendica\Core\L10n;
|
|
use Friendica\Core\System;
|
|
use Friendica\Database\DBA;
|
|
use Friendica\Model\Contact;
|
|
use Friendica\Util\DateTimeFormat;
|
|
use Friendica\Util\Mimetype;
|
|
|
|
function wall_attach_post(App $a) {
|
|
|
|
$r_json = (x($_GET,'response') && $_GET['response']=='json');
|
|
|
|
if ($a->argc > 1) {
|
|
$nick = $a->argv[1];
|
|
$r = q("SELECT `user`.*, `contact`.`id` FROM `user` LEFT JOIN `contact` on `user`.`uid` = `contact`.`uid` WHERE `user`.`nickname` = '%s' AND `user`.`blocked` = 0 and `contact`.`self` = 1 LIMIT 1",
|
|
DBA::escape($nick)
|
|
);
|
|
|
|
if (! DBA::isResult($r)) {
|
|
if ($r_json) {
|
|
echo json_encode(['error' => L10n::t('Invalid request.')]);
|
|
killme();
|
|
}
|
|
return;
|
|
}
|
|
} else {
|
|
if ($r_json) {
|
|
echo json_encode(['error' => L10n::t('Invalid request.')]);
|
|
killme();
|
|
}
|
|
|
|
return;
|
|
}
|
|
|
|
$can_post = false;
|
|
$visitor = 0;
|
|
|
|
$page_owner_uid = $r[0]['uid'];
|
|
$page_owner_cid = $r[0]['id'];
|
|
$page_owner_nick = $r[0]['nickname'];
|
|
$community_page = (($r[0]['page-flags'] == Contact::PAGE_COMMUNITY) ? true : false);
|
|
|
|
if ((local_user()) && (local_user() == $page_owner_uid)) {
|
|
$can_post = true;
|
|
} else {
|
|
if ($community_page && remote_user()) {
|
|
$contact_id = 0;
|
|
|
|
if (is_array($_SESSION['remote'])) {
|
|
foreach ($_SESSION['remote'] as $v) {
|
|
if ($v['uid'] == $page_owner_uid) {
|
|
$contact_id = $v['cid'];
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
if ($contact_id > 0) {
|
|
$r = q("SELECT `uid` FROM `contact` WHERE `blocked` = 0 AND `pending` = 0 AND `id` = %d AND `uid` = %d LIMIT 1",
|
|
intval($contact_id),
|
|
intval($page_owner_uid)
|
|
);
|
|
|
|
if (DBA::isResult($r)) {
|
|
$can_post = true;
|
|
$visitor = $contact_id;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
if (! $can_post) {
|
|
if ($r_json) {
|
|
echo json_encode(['error' => L10n::t('Permission denied.')]);
|
|
killme();
|
|
}
|
|
notice(L10n::t('Permission denied.') . EOL );
|
|
killme();
|
|
}
|
|
|
|
if (! x($_FILES,'userfile')) {
|
|
if ($r_json) {
|
|
echo json_encode(['error' => L10n::t('Invalid request.')]);
|
|
}
|
|
killme();
|
|
}
|
|
|
|
$src = $_FILES['userfile']['tmp_name'];
|
|
$filename = basename($_FILES['userfile']['name']);
|
|
$filesize = intval($_FILES['userfile']['size']);
|
|
|
|
$maxfilesize = Config::get('system','maxfilesize');
|
|
|
|
/* Found html code written in text field of form,
|
|
* when trying to upload a file with filesize
|
|
* greater than upload_max_filesize. Cause is unknown.
|
|
* Then Filesize gets <= 0.
|
|
*/
|
|
|
|
if ($filesize <= 0) {
|
|
$msg = L10n::t('Sorry, maybe your upload is bigger than the PHP configuration allows') . EOL .(L10n::t('Or - did you try to upload an empty file?'));
|
|
if ($r_json) {
|
|
echo json_encode(['error' => $msg]);
|
|
} else {
|
|
notice($msg . EOL);
|
|
}
|
|
@unlink($src);
|
|
killme();
|
|
}
|
|
|
|
if ($maxfilesize && $filesize > $maxfilesize) {
|
|
$msg = L10n::t('File exceeds size limit of %s', formatBytes($maxfilesize));
|
|
if ($r_json) {
|
|
echo json_encode(['error' => $msg]);
|
|
} else {
|
|
echo $msg . EOL ;
|
|
}
|
|
@unlink($src);
|
|
killme();
|
|
}
|
|
|
|
$filedata = @file_get_contents($src);
|
|
$mimetype = Mimetype::getContentType($filename);
|
|
$hash = System::createGUID(64);
|
|
$created = DateTimeFormat::utcNow();
|
|
|
|
$fields = ['uid' => $page_owner_uid, 'hash' => $hash, 'filename' => $filename, 'filetype' => $mimetype,
|
|
'filesize' => $filesize, 'data' => $filedata, 'created' => $created, 'edited' => $created,
|
|
'allow_cid' => '<' . $page_owner_cid . '>', 'allow_gid' => '','deny_cid' => '', 'deny_gid' => ''];
|
|
|
|
$r = DBA::insert('attach', $fields);
|
|
|
|
@unlink($src);
|
|
|
|
if (! $r) {
|
|
$msg = L10n::t('File upload failed.');
|
|
if ($r_json) {
|
|
echo json_encode(['error' => $msg]);
|
|
} else {
|
|
echo $msg . EOL ;
|
|
}
|
|
killme();
|
|
}
|
|
|
|
$r = q("SELECT `id` FROM `attach` WHERE `uid` = %d AND `created` = '%s' AND `hash` = '%s' LIMIT 1",
|
|
intval($page_owner_uid),
|
|
DBA::escape($created),
|
|
DBA::escape($hash)
|
|
);
|
|
|
|
if (! DBA::isResult($r)) {
|
|
$msg = L10n::t('File upload failed.');
|
|
if ($r_json) {
|
|
echo json_encode(['error' => $msg]);
|
|
} else {
|
|
echo $msg . EOL ;
|
|
}
|
|
killme();
|
|
}
|
|
|
|
if ($r_json) {
|
|
echo json_encode(['ok' => true]);
|
|
killme();
|
|
}
|
|
|
|
$lf = "\n";
|
|
|
|
echo $lf . $lf . '[attachment]' . $r[0]['id'] . '[/attachment]' . $lf;
|
|
|
|
killme();
|
|
// NOTREACHED
|
|
}
|