From 031d5a5d8fac2f946631be1b8f7c7e5a5e7a071a Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Wed, 8 May 2024 10:12:28 +0100 Subject: [PATCH] Fix deploy running even if a packaging stage fails (#1659) --- .github/workflows/build_and_deploy.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_and_deploy.yaml b/.github/workflows/build_and_deploy.yaml index 94bf92f..5253048 100644 --- a/.github/workflows/build_and_deploy.yaml +++ b/.github/workflows/build_and_deploy.yaml @@ -104,7 +104,7 @@ jobs: - windows runs-on: ubuntu-latest name: ${{ needs.prepare.outputs.deploy == 'true' && 'Deploy' || 'Deploy (dry-run)' }} - if: always() && !failure() && !cancelled() + if: always() && !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') environment: ${{ needs.prepare.outputs.deploy == 'true' && 'packages.element.io' || '' }} steps: - name: Download artifacts