From 93524d34be64040a9e1a04983c690d8372f729e2 Mon Sep 17 00:00:00 2001 From: R Midhun Suresh Date: Wed, 31 Jan 2024 18:00:03 +0530 Subject: [PATCH 1/4] Use powershell shell instead of pwsh --- .github/workflows/build_windows.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build_windows.yaml b/.github/workflows/build_windows.yaml index d32b679..ea28731 100644 --- a/.github/workflows/build_windows.yaml +++ b/.github/workflows/build_windows.yaml @@ -156,6 +156,7 @@ jobs: - run: yarn run build:res - name: Build App + shell: powershell run: | yarn electron-builder --publish never -w ${{ steps.config.outputs.build-args }} From 88d89dd81d63bf95db52c2b78fd079b51bc3dfa3 Mon Sep 17 00:00:00 2001 From: R Midhun Suresh Date: Wed, 31 Jan 2024 18:03:56 +0530 Subject: [PATCH 2/4] Move to correct step --- .github/workflows/build_windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build_windows.yaml b/.github/workflows/build_windows.yaml index ea28731..fb961a2 100644 --- a/.github/workflows/build_windows.yaml +++ b/.github/workflows/build_windows.yaml @@ -111,6 +111,7 @@ jobs: - name: Install and configure eSigner CKA if: inputs.sign + shell: powershell run: | Set-StrictMode -Version 'Latest' @@ -156,7 +157,6 @@ jobs: - run: yarn run build:res - name: Build App - shell: powershell run: | yarn electron-builder --publish never -w ${{ steps.config.outputs.build-args }} From b54bd8f3e0e877ddf86ab4fda467d1af8759981b Mon Sep 17 00:00:00 2001 From: R Midhun Suresh Date: Wed, 31 Jan 2024 18:16:51 +0530 Subject: [PATCH 3/4] Use powershell throughout --- .github/workflows/build_windows.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_windows.yaml b/.github/workflows/build_windows.yaml index fb961a2..a6f3f4c 100644 --- a/.github/workflows/build_windows.yaml +++ b/.github/workflows/build_windows.yaml @@ -1,6 +1,11 @@ # This workflow relies on actions/cache to store the hak dependency artifacts as they take a long time to build # Due to this extra care must be taken to only ever run all build_* scripts against the same branch to ensure # the correct cache scoping, and additional care must be taken to not run untrusted actions on the develop branch. + +# window-latest by default uses the pwsh shell which breaks codeSigningCert in the workflow +defaults: + run: + shell: powershell on: workflow_call: secrets: @@ -111,7 +116,6 @@ jobs: - name: Install and configure eSigner CKA if: inputs.sign - shell: powershell run: | Set-StrictMode -Version 'Latest' From 3f82adbebcbda0f1a442ab5bfd3accbea6f9d183 Mon Sep 17 00:00:00 2001 From: R Midhun Suresh Date: Wed, 31 Jan 2024 19:15:14 +0530 Subject: [PATCH 4/4] Format --- .github/workflows/build_windows.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build_windows.yaml b/.github/workflows/build_windows.yaml index a6f3f4c..75101e3 100644 --- a/.github/workflows/build_windows.yaml +++ b/.github/workflows/build_windows.yaml @@ -4,8 +4,8 @@ # window-latest by default uses the pwsh shell which breaks codeSigningCert in the workflow defaults: - run: - shell: powershell + run: + shell: powershell on: workflow_call: secrets: