From ec62b8b2cff95f17bee0a18c2321f4f7b3dc0b5e Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Thu, 26 May 2022 20:58:27 +0100
Subject: [PATCH] Update windows-requirements.md (#368)

* Update windows-requirements.md

* Update windows-requirements.md
---
 docs/windows-requirements.md | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/docs/windows-requirements.md b/docs/windows-requirements.md
index 6ff446e..17e0d16 100644
--- a/docs/windows-requirements.md
+++ b/docs/windows-requirements.md
@@ -4,10 +4,12 @@
 
 If you want to build native modules, make sure that the following tools are installed on your system.
 
+- [Git for Windows](https://git-scm.com/download/win)
 - [Node 14](https://nodejs.org)
-- [Python 3](https://www.python.org/downloads/)
+- [Python 3](https://www.python.org/downloads/) (if you type 'python' into command prompt it will offer to install it from the windows store)
 - [Strawberry Perl](https://strawberryperl.com/)
-- [Rust](https://rustup.rs/)
+- [Rustup](https://rustup.rs/)
+- [NASM](https://www.nasm.us/)
 - [Build Tools for Visual Studio 2019](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019) with the following configuration:
   - On the Workloads tab:
     - Desktop & Mobile -> C++ build tools
@@ -17,10 +19,17 @@ If you want to build native modules, make sure that the following tools are inst
     - C++ CMake tools for Windows
 
 Once installed make sure all those utilities are accessible in your `PATH`.
+
+If you want to be able to build x86 targets from an x64 host install the right toolchain:
+```cmd
+rustup toolchain install stable-i686-pc-windows-msvc
+rustup target add i686-pc-windows-msvc
+```
+
 In order to load all the C++ utilities installed by Visual Studio you can run the following in a terminal window.
 
 ```
-call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat" amd64
+call "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Auxiliary\Build\vcvarsall.bat" amd64
 ```
 
 You can replace `amd64` with `x86` depending on your CPU architecture.