Matrix/element-ios
Matrix/element-ios
1
0
Fork 0
mirror of https://github.com/vector-im/element-ios.git synced 2024-09-29 07:42:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #981 from vector-im/alert_access_id

Browse source 
Automatic tests: Add accessibility id in alert view controller.
This commit is contained in:
giomfo 2017-01-27 11:35:01 +01:00 committed by GitHub
commit 44eb70556c
6 changed files with 31 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Vector/ViewController/ContactDetailsViewController.m
View file

@ -836,6 +836,7 @@
strongSelf->currentAlert = nil;
}];
currentAlert.mxkAccessibilityIdentifier = @"ContactDetailsVCIgnoreAlert";
[currentAlert showInViewController:self];
break;
}

5
Vector/ViewController/HomeViewController.m
View file

@ -687,6 +687,7 @@
}];
currentAlert.mxkAccessibilityIdentifier = @"HomeVCUseGoogleAnalyticsAlert";
[currentAlert showInViewController:self];
}
@ -898,6 +899,7 @@
}];
currentAlert.mxkAccessibilityIdentifier = @"HomeVCCheckDeviceIdAlert";
[currentAlert showInViewController:self];
}
}
@ -1273,6 +1275,7 @@
currentAlert.sourceView = createNewRoomImageView;
currentAlert.mxkAccessibilityIdentifier = @"HomeVCCreateRoomAlert";
[currentAlert showInViewController:self];
}
@ -1339,8 +1342,8 @@
strongSelf->currentAlert = nil;
}];
currentAlert.mxkAccessibilityIdentifier = @"HomeVCRoomCreationInProgressAlert";
[currentAlert showInViewController:self];
}
}
}

3
Vector/ViewController/RoomParticipantsViewController.m
View file

@ -1313,6 +1313,7 @@
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomParticipantsVCLeaveAlert";
[currentAlert showInViewController:self];
}
else
@ -1382,6 +1383,7 @@
}];
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomParticipantsVCKickAlert";
[currentAlert showInViewController:self];
}
}
@ -1511,6 +1513,7 @@
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomParticipantsVCInviteAlert";
[currentAlert showInViewController:self];
}

9
Vector/ViewController/RoomSettingsViewController.m
View file

@ -569,6 +569,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCSaveChangesAlert";
[currentAlert showInViewController:self];
}
@ -604,6 +605,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCCopyRoomIdAlert";
currentAlert.sourceView = roomIdLabel;
[currentAlert showInViewController:self];
}
@ -722,6 +724,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCOnSelectedAliasAlert";
currentAlert.sourceView = roomAliasLabel;
[currentAlert showInViewController:self];
}
@ -1024,6 +1027,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCSaveChangesFailedAlert";
[currentAlert showInViewController:self];
}
@ -2729,6 +2733,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCChangeHistoryVisibilityAlert";
[currentAlert showInViewController:self];
}
@ -2810,6 +2815,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCRemoveCanonicalAliasAlert";
[currentAlert showInViewController:self];
}
@ -2903,6 +2909,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCLeaveAlert";
[currentAlert showInViewController:self];
}
@ -2993,6 +3000,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCEnableEncryptionAlert";
[currentAlert showInViewController:self];
}
else
@ -3182,6 +3190,7 @@ NSString *const kRoomSettingsAdvancedE2eEnabledCellViewIdentifier = @"kRoomSetti
}
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomSettingsVCAddAliasAlert";
[currentAlert showInViewController:self];
return NO;

4
Vector/ViewController/RoomViewController.m
View file

@ -2049,6 +2049,7 @@
// Do not display empty action sheet
if (currentAlert.cancelButtonIndex)
{
currentAlert.mxkAccessibilityIdentifier = @"RoomVCEventMenuAlert";
currentAlert.sourceView = roomBubbleTableViewCell;
[currentAlert showInViewController:self];
}
@ -2273,6 +2274,7 @@
strongSelf->currentAlert = nil;
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomVCCallAlert";
[currentAlert showInViewController:self];
}
// In case of conference call, check that the user has enough power level
@ -2290,6 +2292,7 @@
strongSelf->currentAlert = nil;
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomVCCallAlert";
[currentAlert showInViewController:self];
}
else
@ -3064,6 +3067,7 @@
}];
currentAlert.mxkAccessibilityIdentifier = @"RoomVCUnsentMessagesMenuAlert";
currentAlert.sourceView = roomActivitiesView;
[currentAlert showInViewController:self];

10
Vector/ViewController/SettingsViewController.m
View file

@ -535,6 +535,7 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}];
currentAlert.mxkAccessibilityIdentifier = @"SettingsVCEmailValidationAlert";
[currentAlert showInViewController:self];
}
@ -1534,6 +1535,7 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}];
currentAlert.mxkAccessibilityIdentifier = @"SettingsVCUnignoreAlert";
[currentAlert showInViewController:self];
}
}
@ -1646,6 +1648,7 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}
}];
currentAlert.mxkAccessibilityIdentifier = @"SettingsVCSignoutAlert";
[currentAlert showInViewController:self];
}
@ -1671,6 +1674,7 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}];
currentAlert.mxkAccessibilityIdentifier = @"SettingsVCPushNotificationsAlert";
[currentAlert showInViewController:self];
// Keep off the switch
@ -1781,6 +1785,7 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}];
currentAlert.mxkAccessibilityIdentifier = @"SettingsVCEnableEncryptionAlert";
[currentAlert showInViewController:self];
}
else
@ -2079,6 +2084,7 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}];
currentAlert.mxkAccessibilityIdentifier = @"SettingsVCSaveChangesFailedAlert";
[currentAlert showInViewController:rootViewController];
}
}
@ -2103,6 +2109,8 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}
}];
currentAlert.mxkAccessibilityIdentifier = @"SettingsVCAddEmailAlert";
[currentAlert showInViewController:self];
return;
@ -2321,6 +2329,7 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}];
strongSelf->currentAlert.mxkAccessibilityIdentifier = @"SettingsVCOnPasswordUpdatedAlert";
[strongSelf->currentAlert showInViewController:strongSelf];
}
else
@ -2366,6 +2375,7 @@ typedef void (^blockSettingsViewController_onReadyToDestroy)();
}];
strongSelf->currentAlert.mxkAccessibilityIdentifier = @"SettingsVCPasswordChangeFailedAlert";
[strongSelf->currentAlert showInViewController:rootViewController];
}
}