Matrix/element-ios
Matrix/element-ios
1
0
Fork 0
mirror of https://github.com/vector-im/element-ios.git synced 2024-09-29 07:42:40 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #6936 from vector-im/alfogrillo/improve_link_tappability

Browse source 
Improve external links interaction UX (PSG-819)
This commit is contained in:
Alfonso Grillo 2022-10-20 11:11:45 +02:00 committed by GitHub
commit 57ea73a5d7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 18 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Riot/Modules/Room/RoomViewController.m
View file

@ -4593,6 +4593,9 @@ static CGSize kThreadListBarButtonItemImageSize;
// Do nothing for dummy links
shouldDoAction = NO;
break;
case RoomMessageURLTypeHttp:
shouldDoAction = YES;
break;
default:
{
MXEvent *tappedEvent = userInfo[kMXKRoomBubbleCellEventKey];
@ -4618,6 +4621,9 @@ static CGSize kThreadListBarButtonItemImageSize;
break;
case UITextItemInteractionPresentActions:
{
if (roomMessageURLType == RoomMessageURLTypeHttp) {
shouldDoAction = YES;
} else {
// Retrieve the tapped event
MXEvent *tappedEvent = userInfo[kMXKRoomBubbleCellEventKey];
@ -4629,6 +4635,7 @@ static CGSize kThreadListBarButtonItemImageSize;
shouldDoAction = NO;
}
}
break;
case UITextItemInteractionPreview:
// Force touch on link, let MXKRoomBubbleTableViewCell UITextView use default peek and pop behavior.

1
Riot/Modules/Room/TimelineCells/Common/MXKRoomBubbleTableViewCell.m
View file

@ -237,6 +237,7 @@ static BOOL _disableLongPressGestureOnEvent;
[tapGesture setDelegate:self];
[self.messageTextView addGestureRecognizer:tapGesture];
self.messageTextView.userInteractionEnabled = YES;
self.messageTextView.clipsToBounds = NO;
// Recognise and make tappable phone numbers, address, etc.
self.messageTextView.dataDetectorTypes = UIDataDetectorTypeAll;

1
changelog.d/pr-6936.change Normal file
View file

@ -0,0 +1 @@
Improves external links interaction UX.