mirror of
https://github.com/vector-im/element-ios.git
synced 2024-09-28 23:32:41 +00:00
Fix review remarks.
This commit is contained in:
parent
8242af6c06
commit
6ba5587bd0
4 changed files with 8 additions and 3 deletions
|
@ -17,6 +17,8 @@
|
|||
import Foundation
|
||||
import Intents
|
||||
|
||||
/// The AppCoordinator is responsible of screen navigation and data injection at root application level. It decides if authentication or home screen should be shown and inject data needed for these flows, it changes the navigation stack on deep link, displays global warning.
|
||||
/// This class should avoid to contain too many data management code not related to screen navigation logic. For example `MXSession` or push notification management should be handled in dedicated classes and report only navigation changes to the AppCoordinator.
|
||||
final class AppCoordinator: NSObject, AppCoordinatorType {
|
||||
|
||||
// MARK: - Constants
|
||||
|
@ -26,7 +28,9 @@ final class AppCoordinator: NSObject, AppCoordinatorType {
|
|||
// MARK: Private
|
||||
|
||||
private let rootRouter: RootRouterType
|
||||
// swiftlint:disable weak_delegate
|
||||
private let legacyAppDelegate: LegacyAppDelegate = AppDelegate.theDelegate()
|
||||
// swiftlint:enable weak_delegate
|
||||
|
||||
private weak var splitViewCoordinator: SplitViewCoordinatorType?
|
||||
|
||||
|
@ -54,7 +58,7 @@ final class AppCoordinator: NSObject, AppCoordinatorType {
|
|||
|
||||
// MARK: - Private methods
|
||||
|
||||
private func showLogin() {
|
||||
private func showAuthentication() {
|
||||
// TODO: Implement
|
||||
}
|
||||
|
||||
|
|
|
@ -16,6 +16,6 @@
|
|||
|
||||
import Foundation
|
||||
|
||||
/// `AppCoordinatorType` is a protocol describing a Coordinator that handle application navigation flow.
|
||||
/// `AppCoordinatorType` is a protocol describing a Coordinator that handles application navigation flow.
|
||||
protocol AppCoordinatorType: Coordinator {
|
||||
}
|
||||
|
|
|
@ -60,6 +60,7 @@ final class SplitViewCoordinator: NSObject, SplitViewCoordinatorType {
|
|||
tabBarCoordinator.delegate = self
|
||||
tabBarCoordinator.splitViewMasterPresentableDelegate = self
|
||||
tabBarCoordinator.start()
|
||||
|
||||
let detailNavigationController = self.createDetailNavigationController()
|
||||
|
||||
self.splitViewController.viewControllers = [tabBarCoordinator.toPresentable(), detailNavigationController]
|
||||
|
|
|
@ -23,7 +23,7 @@ final class RootRouter: RootRouterType {
|
|||
|
||||
// `rootViewController` animation constants
|
||||
private enum RootViewControllerUpdateAnimation {
|
||||
static let duration: TimeInterval = 0.5
|
||||
static let duration: TimeInterval = 0.3
|
||||
static let options: UIView.AnimationOptions = .transitionCrossDissolve
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue